[{"id":1776360,"web_url":"http://patchwork.ozlabs.org/comment/1776360/","msgid":"<5dec9dab-4e79-8194-42e8-2917dd4e0e8d@redhat.com>","list_archive_url":null,"date":"2017-09-27T13:43:11","subject":"Re: [Qemu-devel] [PATCH v4 4/6] block: convert crypto driver to\n\tbdrv_co_preadv|pwritev","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/27/2017 07:53 AM, Daniel P. Berrange wrote:\n> Make the crypto driver implement the bdrv_co_preadv|pwritev\n> callbacks, and also use bdrv_co_preadv|pwritev for I/O\n> with the protocol driver beneath. This replaces sector based\n> I/O with byte based I/O, and allows us to stop assuming the\n> physical sector size matches the encryption sector size.\n> \n> Signed-off-by: Daniel P. Berrange \n> ---\n> block/crypto.c | 106 +++++++++++++++++++++++++++++----------------------------\n> 1 file changed, 54 insertions(+), 52 deletions(-)\n> \n\nReviewed-by: Eric Blake ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2Jx42zSlz9tY0\n\tfor ;\n\tWed, 27 Sep 2017 23:45:28 +1000 (AEST)","from localhost ([::1]:54893 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxCeU-0001ls-IF\n\tfor incoming@patchwork.ozlabs.org; Wed, 27 Sep 2017 09:45:26 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:34901)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxCcU-0000lf-Ui\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 09:43:28 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxCcT-0002rY-VH\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 09:43:22 -0400","from mx1.redhat.com ([209.132.183.28]:48376)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dxCcN-0002mK-0z; Wed, 27 Sep 2017 09:43:15 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id DE3AD7D0DA;\n\tWed, 27 Sep 2017 13:43:13 +0000 (UTC)","from [10.10.124.97] (ovpn-124-97.rdu2.redhat.com [10.10.124.97])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 68D107FB4C;\n\tWed, 27 Sep 2017 13:43:12 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com DE3AD7D0DA","To":"\"Daniel P. Berrange\" , qemu-devel@nongnu.org","References":"<20170927125340.12360-1-berrange@redhat.com>\n\t<20170927125340.12360-5-berrange@redhat.com>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"<5dec9dab-4e79-8194-42e8-2917dd4e0e8d@redhat.com>","Date":"Wed, 27 Sep 2017 08:43:11 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170927125340.12360-5-berrange@redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"fbmrEwsgXsX3MR5QFP4w0u3M3AaUEFRCW\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tWed, 27 Sep 2017 13:43:14 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v4 4/6] block: convert crypto driver to\n\tbdrv_co_preadv|pwritev","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , Stefan Hajnoczi ,\n\tqemu-block@nongnu.org, Max Reitz ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1776608,"web_url":"http://patchwork.ozlabs.org/comment/1776608/","msgid":"","list_archive_url":null,"date":"2017-09-27T20:48:52","subject":"Re: [Qemu-devel] [PATCH v4 4/6] block: convert crypto driver to\n\tbdrv_co_preadv|pwritev","submitter":{"id":36836,"url":"http://patchwork.ozlabs.org/api/people/36836/","name":"Max Reitz","email":"mreitz@redhat.com"},"content":"On 2017-09-27 14:53, Daniel P. Berrange wrote:\n> Make the crypto driver implement the bdrv_co_preadv|pwritev\n> callbacks, and also use bdrv_co_preadv|pwritev for I/O\n> with the protocol driver beneath. This replaces sector based\n> I/O with byte based I/O, and allows us to stop assuming the\n> physical sector size matches the encryption sector size.\n> \n> Signed-off-by: Daniel P. Berrange \n> ---\n> block/crypto.c | 106 +++++++++++++++++++++++++++++----------------------------\n> 1 file changed, 54 insertions(+), 52 deletions(-)\n\nReviewed-by: Max Reitz ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=mreitz@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2VLQ400Hz9s0Z\n\tfor ;\n\tThu, 28 Sep 2017 06:49:33 +1000 (AEST)","from localhost ([::1]:56294 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxJGs-00046V-QQ\n\tfor incoming@patchwork.ozlabs.org; Wed, 27 Sep 2017 16:49:30 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:33475)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxJGV-00044p-5A\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 16:49:07 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxJGU-0008QZ-Dd\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 16:49:07 -0400","from mx1.redhat.com ([209.132.183.28]:34544)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dxJGM-0008No-TD; Wed, 27 Sep 2017 16:48:59 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id E3DE020CDD3;\n\tWed, 27 Sep 2017 20:48:57 +0000 (UTC)","from dresden.str.redhat.com (unknown [10.40.205.58])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 80ED28DC28;\n\tWed, 27 Sep 2017 20:48:54 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com E3DE020CDD3","To":"\"Daniel P. Berrange\" , qemu-devel@nongnu.org","References":"<20170927125340.12360-1-berrange@redhat.com>\n\t<20170927125340.12360-5-berrange@redhat.com>","From":"Max Reitz ","Message-ID":"","Date":"Wed, 27 Sep 2017 22:48:52 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170927125340.12360-5-berrange@redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"BVbbWisUQk74l1rwJaRJ8sw3XrCFoMhQQ\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tWed, 27 Sep 2017 20:48:58 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v4 4/6] block: convert crypto driver to\n\tbdrv_co_preadv|pwritev","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , Stefan Hajnoczi ,\n\tqemu-block@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]