[{"id":1776365,"web_url":"http://patchwork.ozlabs.org/comment/1776365/","msgid":"","list_archive_url":null,"date":"2017-09-27T13:46:43","subject":"Re: [Qemu-devel] [PATCH v4 5/6] block: convert\n\tqcrypto_block_encrypt|decrypt to take bytes offset","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/27/2017 07:53 AM, Daniel P. Berrange wrote:\n> Instead of sector offset, take the bytes offset when encrypting\n> or decrypting data.\n> \n> Signed-off-by: Daniel P. Berrange \n> ---\nReviewed-by: Eric Blake ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2JzS5rfQz9tY0\n\tfor ;\n\tWed, 27 Sep 2017 23:47:32 +1000 (AEST)","from localhost ([::1]:54903 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxCgU-0003N1-Vg\n\tfor incoming@patchwork.ozlabs.org; Wed, 27 Sep 2017 09:47:31 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:35783)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxCfx-0003Gj-9R\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 09:47:01 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxCfr-0005KA-RI\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 09:46:57 -0400","from mx1.redhat.com ([209.132.183.28]:56974)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dxCfl-0005Gk-U3; Wed, 27 Sep 2017 09:46:46 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id E3F7F4A6EB;\n\tWed, 27 Sep 2017 13:46:44 +0000 (UTC)","from [10.10.124.97] (ovpn-124-97.rdu2.redhat.com [10.10.124.97])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id BFFC37DFC2;\n\tWed, 27 Sep 2017 13:46:43 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com E3F7F4A6EB","To":"\"Daniel P. Berrange\" , qemu-devel@nongnu.org","References":"<20170927125340.12360-1-berrange@redhat.com>\n\t<20170927125340.12360-6-berrange@redhat.com>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"","Date":"Wed, 27 Sep 2017 08:46:43 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170927125340.12360-6-berrange@redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"Fh3UP5TR1J4wALfpnJWWlvocTBAIlosLt\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tWed, 27 Sep 2017 13:46:45 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v4 5/6] block: convert\n\tqcrypto_block_encrypt|decrypt to take bytes offset","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , Stefan Hajnoczi ,\n\tqemu-block@nongnu.org, Max Reitz ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1776611,"web_url":"http://patchwork.ozlabs.org/comment/1776611/","msgid":"","list_archive_url":null,"date":"2017-09-27T20:50:29","subject":"Re: [Qemu-devel] [PATCH v4 5/6] block: convert\n\tqcrypto_block_encrypt|decrypt to take bytes offset","submitter":{"id":36836,"url":"http://patchwork.ozlabs.org/api/people/36836/","name":"Max Reitz","email":"mreitz@redhat.com"},"content":"On 2017-09-27 14:53, Daniel P. Berrange wrote:\n> Instead of sector offset, take the bytes offset when encrypting\n> or decrypting data.\n> \n> Signed-off-by: Daniel P. Berrange \n> ---\n> block/crypto.c | 12 ++++--------\n> block/qcow.c | 11 +++++++----\n> block/qcow2-cluster.c | 8 +++-----\n> block/qcow2.c | 4 ++--\n> crypto/block-luks.c | 12 ++++++++----\n> crypto/block-qcow.c | 12 ++++++++----\n> crypto/block.c | 20 ++++++++++++++------\n> crypto/blockpriv.h | 4 ++--\n> include/crypto/block.h | 14 ++++++++------\n> 9 files changed, 56 insertions(+), 41 deletions(-)\n\nReviewed-by: Max Reitz ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=mreitz@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2VNR6Z0pz9t6C\n\tfor ;\n\tThu, 28 Sep 2017 06:51:19 +1000 (AEST)","from localhost ([::1]:56305 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxJIc-0005Bi-1D\n\tfor incoming@patchwork.ozlabs.org; Wed, 27 Sep 2017 16:51:18 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:33917)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxJI3-00059f-0t\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 16:50:43 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxJI2-0001XA-Be\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 16:50:43 -0400","from mx1.redhat.com ([209.132.183.28]:44540)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dxJHx-0001Ve-DE; Wed, 27 Sep 2017 16:50:37 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 638CDC08F77F;\n\tWed, 27 Sep 2017 20:50:36 +0000 (UTC)","from dresden.str.redhat.com (unknown [10.40.205.58])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 4281E7F93A;\n\tWed, 27 Sep 2017 20:50:31 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 638CDC08F77F","To":"\"Daniel P. Berrange\" , qemu-devel@nongnu.org","References":"<20170927125340.12360-1-berrange@redhat.com>\n\t<20170927125340.12360-6-berrange@redhat.com>","From":"Max Reitz ","Message-ID":"","Date":"Wed, 27 Sep 2017 22:50:29 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170927125340.12360-6-berrange@redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"4o0c59EP1sxnCbNpiS1s8LOcM45i0lcIe\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tWed, 27 Sep 2017 20:50:36 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v4 5/6] block: convert\n\tqcrypto_block_encrypt|decrypt to take bytes offset","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , Stefan Hajnoczi ,\n\tqemu-block@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]