[{"id":1776431,"web_url":"http://patchwork.ozlabs.org/comment/1776431/","msgid":"","list_archive_url":null,"date":"2017-09-27T15:36:11","subject":"Re: [PATCH v3 1/1] ip_tunnel: add mpls over gre encapsulation","submitter":{"id":23500,"url":"http://patchwork.ozlabs.org/api/people/23500/","name":"Roopa Prabhu","email":"roopa@cumulusnetworks.com"},"content":"On Wed, Sep 27, 2017 at 2:37 AM, Amine Kherbouche\n wrote:\n> This commit introduces the MPLSoGRE support (RFC 4023), using ip tunnel\n> API.\n>\n> Encap:\n> - Add a new iptunnel type mpls.\n> - Share tx path: gre type mpls loaded from skb->protocol.\n>\n> Decap:\n> - pull gre hdr and call mpls_forward().\n>\n> Signed-off-by: Amine Kherbouche \n> ---\n> include/linux/mpls.h | 2 ++\n> include/uapi/linux/if_tunnel.h | 1 +\n> net/ipv4/ip_gre.c | 11 +++++++++\n> net/ipv6/ip6_gre.c | 11 +++++++++\n> net/mpls/af_mpls.c | 52 ++++++++++++++++++++++++++++++++++++++++++\n> 5 files changed, 77 insertions(+)\n>\n> diff --git a/include/linux/mpls.h b/include/linux/mpls.h\n> index 384fb22..57203c1 100644\n> --- a/include/linux/mpls.h\n> +++ b/include/linux/mpls.h\n> @@ -8,4 +8,6 @@\n> #define MPLS_TC_MASK (MPLS_LS_TC_MASK >> MPLS_LS_TC_SHIFT)\n> #define MPLS_LABEL_MASK (MPLS_LS_LABEL_MASK >> MPLS_LS_LABEL_SHIFT)\n>\n> +int mpls_gre_rcv(struct sk_buff *skb, int gre_hdr_len);\n> +\n> #endif /* _LINUX_MPLS_H */\n> diff --git a/include/uapi/linux/if_tunnel.h b/include/uapi/linux/if_tunnel.h\n> index 2e52088..a2f48c0 100644\n> --- a/include/uapi/linux/if_tunnel.h\n> +++ b/include/uapi/linux/if_tunnel.h\n> @@ -84,6 +84,7 @@ enum tunnel_encap_types {\n> TUNNEL_ENCAP_NONE,\n> TUNNEL_ENCAP_FOU,\n> TUNNEL_ENCAP_GUE,\n> + TUNNEL_ENCAP_MPLS,\n> };\n>\n> #define TUNNEL_ENCAP_FLAG_CSUM (1<<0)\n> diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c\n> index 9cee986..0a898f4 100644\n> --- a/net/ipv4/ip_gre.c\n> +++ b/net/ipv4/ip_gre.c\n> @@ -32,6 +32,9 @@\n> #include \n> #include \n> #include \n> +#if IS_ENABLED(CONFIG_MPLS)\n> +#include \n> +#endif\n>\n> #include \n> #include \n> @@ -412,6 +415,14 @@ static int gre_rcv(struct sk_buff *skb)\n> return 0;\n> }\n>\n> + if (unlikely(tpi.proto == htons(ETH_P_MPLS_UC))) {\n> +#if IS_ENABLED(CONFIG_MPLS)\n> + return mpls_gre_rcv(skb, hdr_len);\n> +#else\n> + goto drop;\n> +#endif\n> + }\n> +\n\nAmine, one small nit here.., if you define mpls_gre_rcv in gre header\n(like you had initially), you could do the below...\n\n#if IS_ENABLED(CONFIG_MPLS)\nmpls_gre_rcv()\n{\n /* real func */\n}\n#else\nmpls_gre_rcv()\n{\n kfree_skb(skb)\n return NET_RX_DROP\n}\n#endif\n\nand the check in gre_rcv() reduces to\n\nif (unlikely(tpi.proto == htons(ETH_P_MPLS_UC)))\n return mpls_gre_rcv(skb, hdr_len);\n\nWhich looks much cleaner.\n\nOther than that, looks great. pls add my Acked-by: Roopa Prabhu\n to your next version.\n\nthanks!","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=cumulusnetworks.com\n\theader.i=@cumulusnetworks.com header.b=\"I5XSnOHu\"; \n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2MP62431z9tXC\n\tfor ;\n\tThu, 28 Sep 2017 01:36:26 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752931AbdI0PgO (ORCPT );\n\tWed, 27 Sep 2017 11:36:14 -0400","from mail-ua0-f170.google.com ([209.85.217.170]:45236 \"EHLO\n\tmail-ua0-f170.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752455AbdI0PgM (ORCPT\n\t); Wed, 27 Sep 2017 11:36:12 -0400","by mail-ua0-f170.google.com with SMTP id c27so8739904uah.2\n\tfor ; Wed, 27 Sep 2017 08:36:12 -0700 (PDT)","by 10.176.73.112 with HTTP; Wed, 27 Sep 2017 08:36:11 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=cumulusnetworks.com; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=VbRqaYf8Aky1yYMhHPAPrTroMtaZUOtz1peONQtuBMQ=;\n\tb=I5XSnOHux72O5BmU4rgf9EiHsTyl2e9+ZW9wITfq6ZW/ubs9vvWYUAwI6jpYO8Lvqn\n\tU3N/82jNdRapOq9mDzI9FSxP2Jn027JZBQfGb3PEIbO3q01+K7oRD0DJzTvToQh+Hw4P\n\t8MLGGHSw2mcQeHZWzIszF6Y5tO/E8TJbhUTEw=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=VbRqaYf8Aky1yYMhHPAPrTroMtaZUOtz1peONQtuBMQ=;\n\tb=DoEubolBBpn1K6lvyN3yXyvnf0NgfdDvT5SSdKsbTlQ9D0QuglTGNjbu61fj4bh6kn\n\tNEZz7zTrxmNRdeaHuoQ6NT2AHZmNHp3xGHEmf8qK92keRPeJm9nkDPzldQbfc6h8w43J\n\tT3emM5U45hqLwKWYEYtl8q7M56JgWfDoEMvzRKVUaCIU4su7Sbb8IZCiug6t1b/tQQDS\n\t4nR1pjyVwFC2wOAouwljYxUzKwn4BHeDy9mFIoiqu1/q8RnpYY55BIgbj1YqZ9II9YbY\n\txtbyt7+sY+I/RNkfLB/vvjOPYLyAPqd+6x6v5zr0qH9rROG4z7Y4y/3bBGozlUrtepzM\n\tCn2Q==","X-Gm-Message-State":"AHPjjUg5Y48ciXkXik7iSJAHL98tpVYhKaBwNePlww9RD2o93soVXKGX\n\tKfC1UBKFM4beOf+Jpuc8UPC5hoHGV6j03hS7K37+/e/K","X-Google-Smtp-Source":"AOwi7QAQnT+W/rtRqiDD9DxEWtRI6JBbd4ZlYAQZHe3LPWIGu3k+8szNzu0HhwhrCRgcP4ZeGlEb/DOgoW5+Q3GKWPE=","X-Received":"by 10.176.64.162 with SMTP id i31mr1099860uad.60.1506526571614; \n\tWed, 27 Sep 2017 08:36:11 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<198fd7591bc1daae4727ee8b950e116b59f2d4c3.1506504229.git.amine.kherbouche@6wind.com>","References":"\n\t<198fd7591bc1daae4727ee8b950e116b59f2d4c3.1506504229.git.amine.kherbouche@6wind.com>","From":"Roopa Prabhu ","Date":"Wed, 27 Sep 2017 08:36:11 -0700","Message-ID":"","Subject":"Re: [PATCH v3 1/1] ip_tunnel: add mpls over gre encapsulation","To":"Amine Kherbouche ","Cc":"\"netdev@vger.kernel.org\" , xeb@mail.ru,\n\tDavid Lamparter ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1776454,"web_url":"http://patchwork.ozlabs.org/comment/1776454/","msgid":"<1ce61dd3-293b-c26b-e173-3bdae4ba46a7@6wind.com>","list_archive_url":null,"date":"2017-09-27T16:08:24","subject":"Re: [PATCH v3 1/1] ip_tunnel: add mpls over gre encapsulation","submitter":{"id":72147,"url":"http://patchwork.ozlabs.org/api/people/72147/","name":"Amine Kherbouche","email":"amine.kherbouche@6wind.com"},"content":"On 09/27/2017 05:36 PM, Roopa Prabhu wrote:\n> Amine, one small nit here.., if you define mpls_gre_rcv in gre header\n> (like you had initially), you could do the below...\n>\n> #if IS_ENABLED(CONFIG_MPLS)\n> mpls_gre_rcv()\n> {\n> /* real func */\n> }\n> #else\n> mpls_gre_rcv()\n> {\n> kfree_skb(skb)\n> return NET_RX_DROP\n> }\n> #endif\n>\n> and the check in gre_rcv() reduces to\n>\n> if (unlikely(tpi.proto == htons(ETH_P_MPLS_UC)))\n> return mpls_gre_rcv(skb, hdr_len);\n>\n> Which looks much cleaner.\n\nIf I do that, do I have to add back the patch that export mpls_forward() \nor just merge it with this one ?","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=6wind-com.20150623.gappssmtp.com\n\theader.i=@6wind-com.20150623.gappssmtp.com\n\theader.b=\"coQkAgaJ\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2N6p64dhz9tXy\n\tfor ;\n\tThu, 28 Sep 2017 02:09:06 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750978AbdI0QJC (ORCPT );\n\tWed, 27 Sep 2017 12:09:02 -0400","from mail-wm0-f44.google.com ([74.125.82.44]:47627 \"EHLO\n\tmail-wm0-f44.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750752AbdI0QIg (ORCPT\n\t); Wed, 27 Sep 2017 12:08:36 -0400","by mail-wm0-f44.google.com with SMTP id r136so20191790wmf.2\n\tfor ; Wed, 27 Sep 2017 09:08:35 -0700 (PDT)","from [10.16.0.135] (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\ti136sm132110wmd.23.2017.09.27.09.08.34\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 27 Sep 2017 09:08:34 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=subject:to:references:cc:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=5CXhjGTYc/cCG2txZnxSCrfWcpwR42e937ing9OmPmo=;\n\tb=coQkAgaJ/c/Pca+koH5xwzRlgQiWGWAMSMg/zSwON6soFv9Fe7jXYuvGN/ElUKiiGV\n\tLAFJsiWJG9JkejOkKkG4bWOZ5SGhKBevSY7YZL1TPeHioyw2eKHAaiW0lxTgUiir7g66\n\t2QnZpuJ1j0GD/yXGZqcePGJJQF6nBWBANX4A0ApPA3uSTkN/IA/xw9EODmUg+YXg9qQr\n\tah5khc0u5C7Qw3poKzifYcU4pOA1Wp0BwfS6LyBCIAImDI4E5CprzH5eLlNwppmx6r8/\n\tilNwCxT6Y8v5wqivJA0xQfGpMzTARTWFNnPIt9ISlQiwYpD7ukrm5S6tFd21VAsq9a4S\n\tc9ZQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:cc:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=5CXhjGTYc/cCG2txZnxSCrfWcpwR42e937ing9OmPmo=;\n\tb=YEflgPpofjzgCTaUBqCrWRV/Wt2vKHcXTg2Ye32Zp4WBxWyQ9YTsy+RF7A5K0/59CQ\n\tU7lrJ+rz5CFa4cbkecK9IVjsRVrbWfHMo2oYjDA8lgQhvaSo6tLV0wUULX8As4aZATBK\n\tZaIKcJaVko74KwOWQbFYi0Y4ysFmA53/nJiWo/q72bBFuvZ0MG5OnZiUTOXaCYoUUpuJ\n\tO5nuaPa9pbpsyM4gWPQhWOpyi1WmoJreTW9ITUIc3CHmRmrMPGMKBHDv2NJMhveSsRCl\n\t0NSOvLfqCSaRyiCRr7OHK3TLqOzZscy6VfYtS8aWuhRF4OaRcyPTs512mytnPxcJRCF8\n\tMCSQ==","X-Gm-Message-State":"AHPjjUgle5J0PtWydMwiDjcMmSLf5JVunfFH5tz9QEXV30awiXz7xbS0\n\tw5uVwTqpK2/PS5iMd1BdNCyBrg==","X-Google-Smtp-Source":"AOwi7QAlmNgotAU2/KwesQVHIbxFlR8St/m4Df6E+VlvRo3WmVv4NFBnIPCxhKNta9FDsUZ+eNb2Qw==","X-Received":"by 10.28.74.211 with SMTP id n80mr833242wmi.94.1506528514872;\n\tWed, 27 Sep 2017 09:08:34 -0700 (PDT)","Subject":"Re: [PATCH v3 1/1] ip_tunnel: add mpls over gre encapsulation","To":"Roopa Prabhu ","References":"\n\t<198fd7591bc1daae4727ee8b950e116b59f2d4c3.1506504229.git.amine.kherbouche@6wind.com>\n\t","Cc":"\"netdev@vger.kernel.org\" , xeb@mail.ru,\n\tDavid Lamparter ","From":"Amine Kherbouche ","Message-ID":"<1ce61dd3-293b-c26b-e173-3bdae4ba46a7@6wind.com>","Date":"Wed, 27 Sep 2017 18:08:24 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.1.1","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1776461,"web_url":"http://patchwork.ozlabs.org/comment/1776461/","msgid":"","list_archive_url":null,"date":"2017-09-27T16:20:07","subject":"Re: [PATCH v3 1/1] ip_tunnel: add mpls over gre encapsulation","submitter":{"id":23500,"url":"http://patchwork.ozlabs.org/api/people/23500/","name":"Roopa Prabhu","email":"roopa@cumulusnetworks.com"},"content":"On Wed, Sep 27, 2017 at 9:08 AM, Amine Kherbouche\n wrote:\n>\n>\n> On 09/27/2017 05:36 PM, Roopa Prabhu wrote:\n>>\n>> Amine, one small nit here.., if you define mpls_gre_rcv in gre header\n>> (like you had initially), you could do the below...\n>>\n>> #if IS_ENABLED(CONFIG_MPLS)\n>> mpls_gre_rcv()\n>> {\n>> /* real func */\n>> }\n>> #else\n>> mpls_gre_rcv()\n>> {\n>> kfree_skb(skb)\n>> return NET_RX_DROP\n>> }\n>> #endif\n>>\n>> and the check in gre_rcv() reduces to\n>>\n>> if (unlikely(tpi.proto == htons(ETH_P_MPLS_UC)))\n>> return mpls_gre_rcv(skb, hdr_len);\n>>\n>> Which looks much cleaner.\n>\n>\n> If I do that, do I have to add back the patch that export mpls_forward() or\n> just merge it with this one ?\n\nI think its better to bring the patch back in.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=cumulusnetworks.com\n\theader.i=@cumulusnetworks.com header.b=\"Xo6EBfeW\"; \n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2NMb6YDPz9tXw\n\tfor ;\n\tThu, 28 Sep 2017 02:20:11 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751979AbdI0QUJ (ORCPT );\n\tWed, 27 Sep 2017 12:20:09 -0400","from mail-vk0-f47.google.com ([209.85.213.47]:48778 \"EHLO\n\tmail-vk0-f47.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751879AbdI0QUI (ORCPT\n\t); Wed, 27 Sep 2017 12:20:08 -0400","by mail-vk0-f47.google.com with SMTP id g69so7353021vke.5\n\tfor ; Wed, 27 Sep 2017 09:20:08 -0700 (PDT)","by 10.176.73.112 with HTTP; Wed, 27 Sep 2017 09:20:07 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=cumulusnetworks.com; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=rmBatsUdopfMnU/Vly4/m80Wt5K/cCEzwe38sh7N4Ks=;\n\tb=Xo6EBfeW5FSQUp7pY8piF5KVzu1sVJ4Pyud6F9DrCuh/nbGGtX2G4o+zbHHTne9oVO\n\tDWnET2yYiiUVmvzhDZj8dH7AaZ7sioXA8W0Co4V0NTH3N87aRbEG6ot65fGfQlwdOwz6\n\t6F3LT/YFpjACMDUE6Kg+cqBZmAZtrtoHzUyo4=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=rmBatsUdopfMnU/Vly4/m80Wt5K/cCEzwe38sh7N4Ks=;\n\tb=MqvGI5feTF7kVg34wEX0XUapp234Y7mu4AisC6kWo8/ZbVbxAyCf7KToxuadczvwl5\n\tv5TddMH1StZl8ofvm+m2K/YaAYVZ6pUVHdmGBKwdtTrbERd16oywRMOqerINQ3UNBJFx\n\tR7IGl4Lrn4EYFtAd/eGSG9UlBolpArsX3c7V11/XvUgOtn4T665PSY+06Mn7uDUDHlrd\n\tzm7e6s4TBfSY1xCFyXMA8qrTXGncUYfmhrPS2P2qsw6MIgJ89xTi4IJcDjqERhA4Zi9e\n\tqaDS2SZQm0X1cCo53g9wLmQk3xPsxFtKY7xYIfokN+iGMuJueZLWjKFaTTSyeyHflU2m\n\tif0Q==","X-Gm-Message-State":"AHPjjUjvekM+3E9kdB3ycEF1NJLrOBHlsPnUnJkB1d6/4h1nrIBjF/jx\n\tNEODwpqTzrEi5nTH/+v7L7XNmQlSmNxAR4rXvHfa0g==","X-Google-Smtp-Source":"AOwi7QBFaZJLzYKDPU5yZJBPQm7zAFndm4xqpS60OwvLkA3KCwJAasy+CYBe0pCoqhgd/2e8RBaQb4l2bUz71YKt1uY=","X-Received":"by 10.31.228.199 with SMTP id b190mr1015715vkh.180.1506529207591;\n\tWed, 27 Sep 2017 09:20:07 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1ce61dd3-293b-c26b-e173-3bdae4ba46a7@6wind.com>","References":"\n\t<198fd7591bc1daae4727ee8b950e116b59f2d4c3.1506504229.git.amine.kherbouche@6wind.com>\n\t\n\t<1ce61dd3-293b-c26b-e173-3bdae4ba46a7@6wind.com>","From":"Roopa Prabhu ","Date":"Wed, 27 Sep 2017 09:20:07 -0700","Message-ID":"","Subject":"Re: [PATCH v3 1/1] ip_tunnel: add mpls over gre encapsulation","To":"Amine Kherbouche ","Cc":"\"netdev@vger.kernel.org\" , xeb@mail.ru,\n\tDavid Lamparter ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1776467,"web_url":"http://patchwork.ozlabs.org/comment/1776467/","msgid":"<51d2d913-8e3b-0157-7d81-609f2c73008a@6wind.com>","list_archive_url":null,"date":"2017-09-27T16:24:32","subject":"Re: [PATCH v3 1/1] ip_tunnel: add mpls over gre encapsulation","submitter":{"id":72147,"url":"http://patchwork.ozlabs.org/api/people/72147/","name":"Amine Kherbouche","email":"amine.kherbouche@6wind.com"},"content":"On 09/27/2017 06:20 PM, Roopa Prabhu wrote:\n> I think its better to bring the patch back in.\n\nSounds good, ok","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=6wind-com.20150623.gappssmtp.com\n\theader.i=@6wind-com.20150623.gappssmtp.com\n\theader.b=\"f0GJy7Gr\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2NSt5VZqz9t2l\n\tfor ;\n\tThu, 28 Sep 2017 02:24:46 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751847AbdI0QYo (ORCPT );\n\tWed, 27 Sep 2017 12:24:44 -0400","from mail-wm0-f43.google.com ([74.125.82.43]:48406 \"EHLO\n\tmail-wm0-f43.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751580AbdI0QYn (ORCPT\n\t); Wed, 27 Sep 2017 12:24:43 -0400","by mail-wm0-f43.google.com with SMTP id m127so20328200wmm.3\n\tfor ; Wed, 27 Sep 2017 09:24:42 -0700 (PDT)","from [10.16.0.135] (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\tb30sm7895012ede.1.2017.09.27.09.24.41\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 27 Sep 2017 09:24:41 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=subject:to:references:cc:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=Oz2tNQpPSyijXWy9taEKQ7eEGf274h75yLsjnepXmgo=;\n\tb=f0GJy7GrlSW7mmXqc9C9pZhM+fSW9x6W8YSroHIjMDi85R4hJVBAb9qpRlcyzfAMgF\n\tVcifaSQapjvNJPLk9oqf0MRvOIKUVSDNTZcbgeLgqDnQFiVDh8ssMHcjaHTEHFnHs6Nu\n\tsp3pjeXqQkd/ab4ZB5Zx7KETBqsnFZ0zNpZjC10aFLUyiokcJpbakF/gSxBBPwq9KLny\n\tMEKkMddd0y1aElvGFarT3TibsVbjGlGXnajeODl1hx4IjNpcv1n68kEDIJLV141dt/sS\n\tQZsuuflsjUVSfv945oe0yj/i95fOlOGVwWqjCjSL0CnNHofukL1li73RjcNgDRjIcKdk\n\tVhbg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:cc:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=Oz2tNQpPSyijXWy9taEKQ7eEGf274h75yLsjnepXmgo=;\n\tb=QPioiPHoqer7gFqay5I/GcLdSpYt9YkAs0tYYP/GmynuoiycJok4QU8kZimMOVUnQY\n\tVhjLAnX+/pw1WAVOlSS92O3CcDKFvd03GJywem8qVQt9huSHPZQA1pgJrRuEkAbSxxFy\n\tu3qjquFwYtbjGajP0PWSuKn8vtJOTXJdZTqct70aI73/OTAHPb0fkcnlOcdlEjga8H3y\n\txJsfzXaySpFm6BWt9raRIlSrfsAZv2w9ICjyvSGmiZgPHC3/QebPQIAjwNsHR5QkztHO\n\ta+4H5MiWCoJoGx976EOuH1E/v1+Ad9DBnXmYQntSdBfG63rHDWdVOXhEYaZAypL0Q8nO\n\tfhUg==","X-Gm-Message-State":"AHPjjUhYYHEZ5d295hjjdRfhw7UjqnTss8mSn9oD8rxW6j4fSWhCkCvE\n\t9elduGFOOnvBu2xNya0SlPYexQ==","X-Google-Smtp-Source":"AOwi7QDQwOSy2+JjHPiQxXhx00Qd/kDzxiLHGQHDws6hYM77RkRZeF26rY4HwJys87TkZQ7/gn8t/w==","X-Received":"by 10.80.143.98 with SMTP id 89mr2469195edy.273.1506529482201;\n\tWed, 27 Sep 2017 09:24:42 -0700 (PDT)","Subject":"Re: [PATCH v3 1/1] ip_tunnel: add mpls over gre encapsulation","To":"Roopa Prabhu ","References":"\n\t<198fd7591bc1daae4727ee8b950e116b59f2d4c3.1506504229.git.amine.kherbouche@6wind.com>\n\t\n\t<1ce61dd3-293b-c26b-e173-3bdae4ba46a7@6wind.com>\n\t","Cc":"\"netdev@vger.kernel.org\" , xeb@mail.ru,\n\tDavid Lamparter ","From":"Amine Kherbouche ","Message-ID":"<51d2d913-8e3b-0157-7d81-609f2c73008a@6wind.com>","Date":"Wed, 27 Sep 2017 18:24:32 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.1.1","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]