[{"id":1776400,"web_url":"http://patchwork.ozlabs.org/comment/1776400/","msgid":"<2cb46b48-6736-e514-11ca-4119d9d768c3@cumulusnetworks.com>","list_archive_url":null,"date":"2017-09-27T14:38:28","subject":"Re: [patch net-next v3 06/12] net: mroute: Check if rule is a\n\tdefault rule","submitter":{"id":66448,"url":"http://patchwork.ozlabs.org/api/people/66448/","name":"Nikolay Aleksandrov","email":"nikolay@cumulusnetworks.com"},"content":"On 27/09/17 09:23, Jiri Pirko wrote:\n> From: Yotam Gigi \n> \n> When the ipmr starts, it adds one default FIB rule that matches all packets\n> and sends them to the DEFAULT (multicast) FIB table. A more complex rule\n> can be added by user to specify that for a specific interface, a packet\n> should be look up at either an arbitrary table or according to the l3mdev\n> of the interface.\n> \n> For drivers willing to offload the ipmr logic into a hardware but don't\n> want to offload all the FIB rules functionality, provide a function that\n> can indicate whether the FIB rule is the default multicast rule, thus only\n> one routing table is needed.\n> \n> This way, a driver can register to the FIB notification chain, get\n> notifications about FIB rules added and trigger some kind of an internal\n> abort mechanism when a non default rule is added by the user.\n> \n> Signed-off-by: Yotam Gigi \n> Reviewed-by: Ido Schimmel \n> Signed-off-by: Jiri Pirko \n> ---\n> v2->v3:\n> - Use the already existing ifdef CONFIG_IP_MROUTE_MULTIPLE_TABLES\n> v1->v2:\n> - Update the lastuse MFC entry field too, in addition to packets an bytes.\n> ---\n> include/linux/mroute.h | 7 +++++++\n> net/ipv4/ipmr.c | 12 ++++++++++++\n> 2 files changed, 19 insertions(+)\n> \n\nReviewed-by: Nikolay Aleksandrov ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=cumulusnetworks.com\n\theader.i=@cumulusnetworks.com header.b=\"P0RiACJg\"; \n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2L6L5cLdz9t3x\n\tfor ;\n\tThu, 28 Sep 2017 00:38:34 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752005AbdI0Oic (ORCPT );\n\tWed, 27 Sep 2017 10:38:32 -0400","from mail-wr0-f175.google.com ([209.85.128.175]:55504 \"EHLO\n\tmail-wr0-f175.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751664AbdI0Oib (ORCPT\n\t); Wed, 27 Sep 2017 10:38:31 -0400","by mail-wr0-f175.google.com with SMTP id l39so16882718wrl.12\n\tfor ; Wed, 27 Sep 2017 07:38:30 -0700 (PDT)","from [192.168.0.108] ([93.152.214.109])\n\tby smtp.gmail.com with ESMTPSA id\n\ty99sm27369271wmh.1.2017.09.27.07.38.28\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 27 Sep 2017 07:38:29 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=cumulusnetworks.com; s=google;\n\th=subject:to:references:cc:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=sBYv/4hegRoA4v0qKSWnogIDpmmqHsHGhUXANOoSnpM=;\n\tb=P0RiACJgPUXmQqRkQr5arndT5ZjbgMpY40PUFMJa0xqytvqR9s/S6ykQU6z1xT5qRC\n\t/9xkzvX0EwEf7scRCz9bM9oOgcNkKuL3U29PCJ5F1zGmAgeKGrxdGbhc/FcflHhjTMrm\n\tI1M49Pc5e8OvRHpkar1HUs7JLbM6oV36qYhbU=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:cc:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=sBYv/4hegRoA4v0qKSWnogIDpmmqHsHGhUXANOoSnpM=;\n\tb=f9ENyQK6tsH8pmxkkuAA6kKtjpIhRlftefRzyKsCNqFv6K5uW10d8UM27hXzDSRStB\n\tRdH35jucjUWT0S6J6TwBZZSXVgnqfDlRm5Pw+Bledwoj2lYCxTO8OwJdTLncwUebL8Zj\n\tl5dUQ/pF8e2OPdI3OCtF143fddHYGEHV4NkZVfEFjZ705SFH7OkORvniGUKfvMqesW5+\n\tARkccFJ1+qUiZPPEgFTrKQP/z9ZDoiT1J+WHX+5o/LlPXK29rlFzWRx0y+MK95EAOibg\n\tHy8gmOcmSffjuR8uVu1j2/7EUgGNg387cj80l6701XTgWvLpscLYW4laBR3u0URNvLEP\n\tdHJg==","X-Gm-Message-State":"AHPjjUhD4KaGuYz8t6FpXIPb0ei0P/Scmg5PM16i82k8PNGwQkWjTWfd\n\tZxSnJibKbREtB0wwoeFIT7tZcg==","X-Google-Smtp-Source":"AOwi7QBQvE+1Yuax0z5ym0GWsAGY5SHw0fOTI7a/gE1W6BWKJx9kwULkm3GH/I50fXXSoOtxjxdaMA==","X-Received":"by 10.223.166.138 with SMTP id t10mr1801855wrc.64.1506523110151; \n\tWed, 27 Sep 2017 07:38:30 -0700 (PDT)","Subject":"Re: [patch net-next v3 06/12] net: mroute: Check if rule is a\n\tdefault rule","To":"Jiri Pirko , netdev@vger.kernel.org","References":"<20170927062322.5476-1-jiri@resnulli.us>\n\t<20170927062322.5476-7-jiri@resnulli.us>","Cc":"davem@davemloft.net, yotamg@mellanox.com, idosch@mellanox.com,\n\tmlxsw@mellanox.com, andrew@lunn.ch, linyunsheng@huawei.com","From":"Nikolay Aleksandrov ","Message-ID":"<2cb46b48-6736-e514-11ca-4119d9d768c3@cumulusnetworks.com>","Date":"Wed, 27 Sep 2017 17:38:28 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tIcedove/45.6.0","MIME-Version":"1.0","In-Reply-To":"<20170927062322.5476-7-jiri@resnulli.us>","Content-Type":"text/plain; charset=windows-1252","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]