[{"id":1776354,"web_url":"http://patchwork.ozlabs.org/comment/1776354/","msgid":"","list_archive_url":null,"date":"2017-09-27T13:42:05","subject":"Re: [PATCH v7 1/2] dt-bindings: gpio: uniphier: add UniPhier GPIO\n\tbinding","submitter":{"id":7055,"url":"http://patchwork.ozlabs.org/api/people/7055/","name":"Linus Walleij","email":"linus.walleij@linaro.org"},"content":"On Wed, Sep 27, 2017 at 4:45 AM, Masahiro Yamada\n wrote:\n\n> This GPIO controller is used on UniPhier SoC family.\n>\n> The vendor specific property \"socionext,interrupt-ranges\" is for\n> specifying interrupt mapping to the parent interrupt controller\n> because the mapping is not contiguous. It works like \"ranges\",\n> but transforms \"interrupts\" instead of \"reg\".\n>\n> Signed-off-by: Masahiro Yamada \n> Acked-by: Rob Herring \n\nI don't think Rob has seen the new interrupt range thing?\n(It's not a big deal. Things like these are a bit fuzzy.)\n\n> + socionext,interrupt-ranges = <0 48 16>, <16 154 5>, <21 217 3>;\n\nIf it is as you say, that other SoCs are doing the same, we should\nthink about creating a generic property for this. Like\nhierarchy-interrupt-ranges or so.\n\nI kind of liked the old patch where it was just \"interrupts\" and\nthen you looked it up from the irq subsystem. (tglx even ACKed\nthe patch).\n\nBut I want the DT people to say something here.\n\nYours,\nLinus Walleij\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-gpio\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"Wq43eW77\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2JsF5tFLz9sRm\n\tfor ;\n\tWed, 27 Sep 2017 23:42:09 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753129AbdI0NmI (ORCPT );\n\tWed, 27 Sep 2017 09:42:08 -0400","from mail-it0-f47.google.com ([209.85.214.47]:53860 \"EHLO\n\tmail-it0-f47.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753127AbdI0NmH (ORCPT\n\t); Wed, 27 Sep 2017 09:42:07 -0400","by mail-it0-f47.google.com with SMTP id 85so6599588ith.2\n\tfor ;\n\tWed, 27 Sep 2017 06:42:07 -0700 (PDT)","by 10.79.208.237 with HTTP; Wed, 27 Sep 2017 06:42:05 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=qzTSV2Z/pVlfGJbapjmFbZ77hSpY+BaVzQZ+uQQDtF0=;\n\tb=Wq43eW77bdPHLfyYqp6Pl3WXR1ckUMI/9mcbg6b37tz/UH0+9VXYeJefPC3UNdc5Y1\n\tPl3KTRc+gHbqN9Z+rLdKpAo85FJlWy/kqOaIRxLytBNgzqneFW3A7rkXzLcKdlmjSb37\n\t0CNT1tbP5ySsxSzliBYgs7lNOq+b/oaa1Oxyc=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=qzTSV2Z/pVlfGJbapjmFbZ77hSpY+BaVzQZ+uQQDtF0=;\n\tb=NFDciV3r0Zrvc3U+F/KOGqnMQC0TXGfFnI+eU2qe7blLLkD9qMcP7kDsraS2B5OvhZ\n\t/VxlRCMWkHrg/6cXfMlII6wcZh9DCK1JGx9QALRHGOQTMpfgCPxKf1FIlvxdC3hzrgAt\n\tAx0z1/HrP3nq7bc1pWk9c+WyXYGtkKxHElz4/Juv+EFNd4HEMLmauWqvyx609/OuUlb0\n\tJSCO19YlYZPZinzn3rn7o9wW9Z/qZh2+aMKfOJ1rkWLamqOVIitI02R0U1j/vHkrmLI7\n\tQsx5UuAOMva+GlTErdcFGsaqLqaOatrbU36qsNvLn2eMAS6IkSU6kDHVfOfJtJGG/RA9\n\tchOg==","X-Gm-Message-State":"AHPjjUjShN+6VfkIbipy9Lfy2F1/QEo4WZ10yA9uPoVAdRqhp7DUGDZm\n\tGoBc5TKCF9rYC6JYlDfeF9ZtiRJ9RHukvid6JBAISA==","X-Google-Smtp-Source":"AOwi7QCbo0HJWmm/izGk5dWX52HlMLqBYRRhdZ4lj7UDfPzNMa6znkj/Gijwu0TI8XyYDraZNwxU1RzNdUoc04DYltk=","X-Received":"by 10.36.76.208 with SMTP id a199mr645618itb.84.1506519726679;\n\tWed, 27 Sep 2017 06:42:06 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1506480343-9597-2-git-send-email-yamada.masahiro@socionext.com>","References":"<1506480343-9597-1-git-send-email-yamada.masahiro@socionext.com>\n\t<1506480343-9597-2-git-send-email-yamada.masahiro@socionext.com>","From":"Linus Walleij ","Date":"Wed, 27 Sep 2017 15:42:05 +0200","Message-ID":"","Subject":"Re: [PATCH v7 1/2] dt-bindings: gpio: uniphier: add UniPhier GPIO\n\tbinding","To":"Masahiro Yamada ,\n\tRob Herring ","Cc":"\"linux-gpio@vger.kernel.org\" ,\n\t\"devicetree@vger.kernel.org\" ,\n\tMasami Hiramatsu ,\n\tJassi Brar ,\n\t\"linux-kernel@vger.kernel.org\" ,\n\tRob Herring , Mark Rutland ,\n\t\"linux-arm-kernel@lists.infradead.org\" \n\t","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}},{"id":1776402,"web_url":"http://patchwork.ozlabs.org/comment/1776402/","msgid":"","list_archive_url":null,"date":"2017-09-27T14:42:53","subject":"Re: [PATCH v7 1/2] dt-bindings: gpio: uniphier: add UniPhier GPIO\n\tbinding","submitter":{"id":65882,"url":"http://patchwork.ozlabs.org/api/people/65882/","name":"Masahiro Yamada","email":"yamada.masahiro@socionext.com"},"content":"Hi Linus,\n\n\n2017-09-27 22:42 GMT+09:00 Linus Walleij :\n> On Wed, Sep 27, 2017 at 4:45 AM, Masahiro Yamada\n> wrote:\n>\n>> This GPIO controller is used on UniPhier SoC family.\n>>\n>> The vendor specific property \"socionext,interrupt-ranges\" is for\n>> specifying interrupt mapping to the parent interrupt controller\n>> because the mapping is not contiguous. It works like \"ranges\",\n>> but transforms \"interrupts\" instead of \"reg\".\n>>\n>> Signed-off-by: Masahiro Yamada \n>> Acked-by: Rob Herring \n>\n> I don't think Rob has seen the new interrupt range thing?\n> (It's not a big deal. Things like these are a bit fuzzy.)\n\n\nThis judge is difficult.\n\nRob gave Ack to v3.\n\nI added one more property to v4, so I removed Rob's Ack\nbecause it contained what Rob had not seen.\n\nhttp://patchwork.ozlabs.org/patch/810981/\n\nBut, he was annoyed by my carefulness.\nThis time, I am keeping his Ack, but it would be appreciated\nif he cares to review this once again.\n\n\n\n>> + socionext,interrupt-ranges = <0 48 16>, <16 154 5>, <21 217 3>;\n>\n> If it is as you say, that other SoCs are doing the same, we should\n> think about creating a generic property for this. Like\n> hierarchy-interrupt-ranges or so.\n\n\nOf course, I thought of this.\nWhen we add a generic property, we need very careful review.\n\n\nIf we want something generic, phandle of parent irqchip is necessary.\n\n\n interrupt-ranges = ,\n ,\n ...\n\n\nThe format is very similar to gpio-ranges.\n\nThe phandle is necessary because it may have two or more interrupt parents.\nThis is why we introduced \"interrupts\" property at first,\nbut later we ended up with adding \"interrupts-extended\".\n\n\nUnfortunately, this does not fit with the current design of irqdomain\nbecause current irqdomain can only one parent.\n\nIn my opinion, the hierarchy irq domain was badly designed.\nThis is why it is so painful to write drivers.\n\n\n\n\n> I kind of liked the old patch where it was just \"interrupts\" and\n> then you looked it up from the irq subsystem. (tglx even ACKed\n> the patch).\n>\n> But I want the DT people to say something here.\n\n\nI think \"interrupts\" is for interrupt consumers.\n\nWe need something different for inter-irqchip connection.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=nifty.com header.i=@nifty.com\n\theader.b=\"Q/7WZhzq\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2LDQ5RnJz9tXy\n\tfor ;\n\tThu, 28 Sep 2017 00:43:50 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752074AbdI0Ont (ORCPT );\n\tWed, 27 Sep 2017 10:43:49 -0400","from conssluserg-02.nifty.com ([210.131.2.81]:40773 \"EHLO\n\tconssluserg-02.nifty.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751548AbdI0Onr (ORCPT\n\t); Wed, 27 Sep 2017 10:43:47 -0400","from mail-yw0-f173.google.com (mail-yw0-f173.google.com\n\t[209.85.161.173]) (authenticated)\n\tby conssluserg-02.nifty.com with ESMTP id v8REhYPX009235;\n\tWed, 27 Sep 2017 23:43:34 +0900","by mail-yw0-f173.google.com with SMTP id u11so9461749ywh.7;\n\tWed, 27 Sep 2017 07:43:34 -0700 (PDT)","by 10.37.170.198 with HTTP; Wed, 27 Sep 2017 07:42:53 -0700 (PDT)"],"DKIM-Filter":"OpenDKIM Filter v2.10.3 conssluserg-02.nifty.com v8REhYPX009235","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com;\n\ts=dec2015msa; t=1506523415;\n\tbh=ekbAGCBcga0ywmgd2PEolykGKzEMLeBkwnpzuhgf2Fw=;\n\th=In-Reply-To:References:From:Date:Subject:To:Cc:From;\n\tb=Q/7WZhzqgam5Xb80xZ1NU6wo5JhQigaZS+Tcj5gZlkdr3b4rG+HcFx8j+gIEf1ldh\n\tq0+Nbg4+cZJuJ/0zfOGc+BV/z4f06McsnmdFqQA+2K7Sx6ST+sRuHltWf57LasuVkW\n\t8k+evPoPBuu5OesmUyfRMZMcQ6tSOLi3ZOKndA8LvFWy5ZyAoG86/u/bEPWI8CW5EO\n\tC0b90QdTV9DRxbEF04omEf0JWJ+4KYIoVNZOfTUn3jfn3ZYUoSvhvxscMc6ptWXIA4\n\tlsm46eKmUSp/l/LsIvrCvf6Uw+wEwjf+QTH/5NXlb0r0RBKmdsXWihnHpFFDvf+1FL\n\tJz+bJs65AtYew==","X-Nifty-SrcIP":"[209.85.161.173]","X-Gm-Message-State":"AHPjjUgO6Zs+pb/byPlfCE/BMcZWAkpDoDPP6/C1Ku60vhRJt+v1j4Tg\n\tJRzh6uXa+/qMc+Afp2HLMK4ba53JpWEfdABQPI0=","X-Google-Smtp-Source":"AOwi7QDCJQeW3u80aXI2ETOXjG/yUbQ6QvMx2mBRkurIoiDMqFqDxKzxom2FQFAugQC5UU/UFgszz89XksWKtSbBqos=","X-Received":"by 10.129.93.86 with SMTP id r83mr1043845ywb.182.1506523413609; \n\tWed, 27 Sep 2017 07:43:33 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<1506480343-9597-1-git-send-email-yamada.masahiro@socionext.com>\n\t<1506480343-9597-2-git-send-email-yamada.masahiro@socionext.com>\n\t","From":"Masahiro Yamada ","Date":"Wed, 27 Sep 2017 23:42:53 +0900","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [PATCH v7 1/2] dt-bindings: gpio: uniphier: add UniPhier GPIO\n\tbinding","To":"Linus Walleij ","Cc":"Rob Herring ,\n\t\"linux-gpio@vger.kernel.org\" ,\n\t\"devicetree@vger.kernel.org\" ,\n\tMasami Hiramatsu ,\n\tJassi Brar ,\n\t\"linux-kernel@vger.kernel.org\" ,\n\tRob Herring , Mark Rutland ,\n\t\"linux-arm-kernel@lists.infradead.org\" \n\t","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}},{"id":1782254,"web_url":"http://patchwork.ozlabs.org/comment/1782254/","msgid":"","list_archive_url":null,"date":"2017-10-08T13:42:22","subject":"Re: [PATCH v7 1/2] dt-bindings: gpio: uniphier: add UniPhier GPIO\n\tbinding","submitter":{"id":65882,"url":"http://patchwork.ozlabs.org/api/people/65882/","name":"Masahiro Yamada","email":"yamada.masahiro@socionext.com"},"content":"Hi Linus,\n\n\n2017-09-27 22:42 GMT+09:00 Linus Walleij :\n> On Wed, Sep 27, 2017 at 4:45 AM, Masahiro Yamada\n> wrote:\n>\n>> This GPIO controller is used on UniPhier SoC family.\n>>\n>> The vendor specific property \"socionext,interrupt-ranges\" is for\n>> specifying interrupt mapping to the parent interrupt controller\n>> because the mapping is not contiguous. It works like \"ranges\",\n>> but transforms \"interrupts\" instead of \"reg\".\n>>\n>> Signed-off-by: Masahiro Yamada \n>> Acked-by: Rob Herring \n>\n> I don't think Rob has seen the new interrupt range thing?\n> (It's not a big deal. Things like these are a bit fuzzy.)\n>\n>> + socionext,interrupt-ranges = <0 48 16>, <16 154 5>, <21 217 3>;\n>\n> If it is as you say, that other SoCs are doing the same, we should\n> think about creating a generic property for this. Like\n> hierarchy-interrupt-ranges or so.\n>\n> I kind of liked the old patch where it was just \"interrupts\" and\n> then you looked it up from the irq subsystem. (tglx even ACKed\n> the patch).\n>\n> But I want the DT people to say something here.\n>\n> Yours,\n> Linus Walleij\n\n\nI explained the technical background of this approach,\nbut I have not had any comment.\n(DT people are silent, too)\n\nIs this driver applicable?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=nifty.com header.i=@nifty.com\n\theader.b=\"M0A3cFKx\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y94MN4HCyz9t3q\n\tfor ;\n\tMon, 9 Oct 2017 00:43:12 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751684AbdJHNnL (ORCPT );\n\tSun, 8 Oct 2017 09:43:11 -0400","from conssluserg-01.nifty.com ([210.131.2.80]:30790 \"EHLO\n\tconssluserg-01.nifty.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751027AbdJHNnK (ORCPT\n\t); Sun, 8 Oct 2017 09:43:10 -0400","from mail-qt0-f181.google.com (mail-qt0-f181.google.com\n\t[209.85.216.181]) (authenticated)\n\tby conssluserg-01.nifty.com with ESMTP id v98Dh33u000785;\n\tSun, 8 Oct 2017 22:43:04 +0900","by mail-qt0-f181.google.com with SMTP id z50so33879044qtj.4;\n\tSun, 08 Oct 2017 06:43:04 -0700 (PDT)","by 10.37.75.1 with HTTP; Sun, 8 Oct 2017 06:42:22 -0700 (PDT)"],"DKIM-Filter":"OpenDKIM Filter v2.10.3 conssluserg-01.nifty.com v98Dh33u000785","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com;\n\ts=dec2015msa; t=1507470184;\n\tbh=tKTUqmz1HAdyRdqlZrVve9CUH/NYGiX7lfpuU7OcEzg=;\n\th=In-Reply-To:References:From:Date:Subject:To:Cc:From;\n\tb=M0A3cFKxiSKMAmyVPhIDh8M3R042B+D9a1rxkwgDKAmL47a3kh/3j+XpWFIWSx6Tr\n\trMN985hHICr2EYehKVV/fGvTCDkapBZWR9cRe/QB3OToS90fZNrGPxqtS3axvPTvAi\n\tYcfR9g09vE86j/LZlyX4qIN/uZ0/oMM2H8irmCXG12wn7Jgsnf8fXYzxQ9sWiHKeZO\n\tGn8VpDvu66sZzkEGSYjwssSRz+w95ylvjT43QnNBtKLHJNPqZ2pWys6lZN8ULAB8Sk\n\tRpRd+Ood01JoD2Lw6q/ipAxe0sDa2ORikSZs8+Sv+ST7T+bSk1Tjuxgvv3a7gXJ5Vj\n\t/UpweHID+SZng==","X-Nifty-SrcIP":"[209.85.216.181]","X-Gm-Message-State":"AMCzsaXJFnAgwaUN6ULcwEufLbOHgs1bKw0iziXa/3hhOEkWjR6bqDGj\n\t7Y6WrO4fYOGTCjQyWCLL12w+YY3Xd9QXSTNlMPA=","X-Google-Smtp-Source":"AOwi7QB1FNhqM5Ru5t/j9E79UqsThV2oS3cvuHix7NFBCMMwn9oaT3pcYRYwdHdUDIyYPLMcViFbMvGE0pVWMTUsiyI=","X-Received":"by 10.37.173.156 with SMTP id z28mr6132373ybi.139.1507470182936; \n\tSun, 08 Oct 2017 06:43:02 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<1506480343-9597-1-git-send-email-yamada.masahiro@socionext.com>\n\t<1506480343-9597-2-git-send-email-yamada.masahiro@socionext.com>\n\t","From":"Masahiro Yamada ","Date":"Sun, 8 Oct 2017 22:42:22 +0900","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [PATCH v7 1/2] dt-bindings: gpio: uniphier: add UniPhier GPIO\n\tbinding","To":"Linus Walleij ","Cc":"Rob Herring ,\n\t\"linux-gpio@vger.kernel.org\" ,\n\t\"devicetree@vger.kernel.org\" ,\n\tMasami Hiramatsu ,\n\tJassi Brar ,\n\t\"linux-kernel@vger.kernel.org\" ,\n\tRob Herring , Mark Rutland ,\n\t\"linux-arm-kernel@lists.infradead.org\" \n\t","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}}]