[{"id":1776524,"web_url":"http://patchwork.ozlabs.org/comment/1776524/","msgid":"<8737786lua.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>","list_archive_url":null,"date":"2017-09-27T18:24:45","subject":"Re: [PATCH net-next 6/6] net: dsa: mv88e6xxx: Flood broadcast\n\tframes in hardware","submitter":{"id":15889,"url":"http://patchwork.ozlabs.org/api/people/15889/","name":"Vivien Didelot","email":"vivien.didelot@savoirfairelinux.com"},"content":"Hi Andrew,\n\nAndrew Lunn writes:\n\n> +static int mv88e6xxx_port_add_broadcast(struct mv88e6xxx_chip *chip, int port,\n> +\t\t\t\t\tu16 vid)\n> +{\n> +\tconst char broadcast[6] = { 0xff, 0xff, 0xff, 0xff, 0xff, 0xff };\n> +\n> +\treturn mv88e6xxx_port_db_load_purge(\n> +\t\tchip, port, broadcast, vid,\n> +\t\tMV88E6XXX_G1_ATU_DATA_STATE_MC_STATIC);\n\nPlease don't do this. This is not a valid coding style and has already\nshown to be a bad example for other DSA drivers copying mv88e6xxx.\n\nSimply declare u8 state = MV88E6XXX_G1_ATU_DATA_STATE_MC_STATIC above...\n\n> +}\n> +\n> +static int mv88e6xxx_broadcast_setup(struct mv88e6xxx_chip *chip, u16 vid)\n> +{\n> +\tint port;\n> +\tint err;\n> +\n> +\tfor (port = 0; port < mv88e6xxx_num_ports(chip); ++port) {\n> +\t\terr = mv88e6xxx_port_add_broadcast(chip, port, vid);\n> +\t\tif (err)\n> +\t\t\treturn err;\n> +\t}\n> +\n> +\treturn 0;\n> +}\n> +\n> static int _mv88e6xxx_port_vlan_add(struct mv88e6xxx_chip *chip, int port,\n> \t\t\t\t u16 vid, u8 member)\n> {\n> @@ -1247,7 +1271,11 @@ static int _mv88e6xxx_port_vlan_add(struct mv88e6xxx_chip *chip, int port,\n> \n> \tvlan.member[port] = member;\n> \n> -\treturn mv88e6xxx_vtu_loadpurge(chip, &vlan);\n> +\terr = mv88e6xxx_vtu_loadpurge(chip, &vlan);\n> +\tif (err)\n> +\t\treturn err;\n> +\n> +\treturn mv88e6xxx_broadcast_setup(chip, vid);\n> }\n> \n> static void mv88e6xxx_port_vlan_add(struct dsa_switch *ds, int port,\n> @@ -2025,6 +2053,10 @@ static int mv88e6xxx_setup(struct dsa_switch *ds)\n> \tif (err)\n> \t\tgoto unlock;\n> \n> +\terr = mv88e6xxx_broadcast_setup(chip, 0);\n> +\tif (err)\n> +\t\tgoto unlock;\n> +\n> \terr = mv88e6xxx_pot_setup(chip);\n> \tif (err)\n> \t\tgoto unlock;\n\n\nAdding the broadcast address to an Ethernet switch's FDB is pretty\ngeneric and mv88e6xxx mustn't be the only driver doing this.\n\nThey do not have to care about the broadcast address, this is just a\nstandard MDB entry for them. This must be moved up to the DSA layer.\n\nAdding the broadcast address in dsa_port_vlan_add and dsa_port_enable\nlike this should be enough: http://ix.io/AmS\n\n\nThanks,\n\n Vivien","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2RCd1dfTz9tXQ\n\tfor ;\n\tThu, 28 Sep 2017 04:28:29 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752034AbdI0S20 (ORCPT );\n\tWed, 27 Sep 2017 14:28:26 -0400","from mail.savoirfairelinux.com ([208.88.110.44]:39610 \"EHLO\n\tmail.savoirfairelinux.com\" rhost-flags-OK-OK-OK-OK) by\n\tvger.kernel.org with ESMTP id S1751692AbdI0S2Z (ORCPT\n\t); Wed, 27 Sep 2017 14:28:25 -0400","from localhost (localhost [127.0.0.1])\n\tby mail.savoirfairelinux.com (Postfix) with ESMTP id 0A6379C1B4B;\n\tWed, 27 Sep 2017 14:28:25 -0400 (EDT)","from mail.savoirfairelinux.com ([127.0.0.1])\n\tby localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavisd-new,\n\tport 10032)\n\twith ESMTP id tVc4u9O6hfxD; Wed, 27 Sep 2017 14:28:23 -0400 (EDT)","from localhost (localhost [127.0.0.1])\n\tby mail.savoirfairelinux.com (Postfix) with ESMTP id B14F29C2844;\n\tWed, 27 Sep 2017 14:28:23 -0400 (EDT)","from mail.savoirfairelinux.com ([127.0.0.1])\n\tby localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavisd-new,\n\tport 10026)\n\twith ESMTP id GamNub1zrNtW; Wed, 27 Sep 2017 14:28:23 -0400 (EDT)","from localhost (modemcable249.105-163-184.mc.videotron.ca\n\t[184.163.105.249])\n\tby mail.savoirfairelinux.com (Postfix) with ESMTPSA id 79A4C9C1B4B;\n\tWed, 27 Sep 2017 14:28:23 -0400 (EDT)"],"X-Virus-Scanned":"amavisd-new at mail.savoirfairelinux.com","From":"Vivien Didelot ","To":"Andrew Lunn , David Miller ","Cc":"netdev , Andrew Lunn ","Subject":"Re: [PATCH net-next 6/6] net: dsa: mv88e6xxx: Flood broadcast\n\tframes in hardware","In-Reply-To":"<1506464764-12699-7-git-send-email-andrew@lunn.ch>","References":"<1506464764-12699-1-git-send-email-andrew@lunn.ch>\n\t<1506464764-12699-7-git-send-email-andrew@lunn.ch>","Date":"Wed, 27 Sep 2017 14:24:45 -0400","Message-ID":"<8737786lua.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>","MIME-Version":"1.0","Content-Type":"text/plain","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1776529,"web_url":"http://patchwork.ozlabs.org/comment/1776529/","msgid":"<20170927183650.GC12394@lunn.ch>","list_archive_url":null,"date":"2017-09-27T18:36:50","subject":"Re: [PATCH net-next 6/6] net: dsa: mv88e6xxx: Flood broadcast frames\n\tin hardware","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"> Adding the broadcast address to an Ethernet switch's FDB is pretty\n> generic and mv88e6xxx mustn't be the only driver doing this.\n\nActually, it is. All the others seem to do this in hardware without\nneeding an FDB. Since mv88e6xxx is the only one requiring it, it has\nto be done in the mv88e6xxx driver.\n\n Andrew","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2RPP2d5nz9t30\n\tfor ;\n\tThu, 28 Sep 2017 04:36:57 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751973AbdI0Sgy (ORCPT );\n\tWed, 27 Sep 2017 14:36:54 -0400","from vps0.lunn.ch ([185.16.172.187]:58433 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751590AbdI0Sgx (ORCPT );\n\tWed, 27 Sep 2017 14:36:53 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dxHCU-0004NM-0z; Wed, 27 Sep 2017 20:36:50 +0200"],"Date":"Wed, 27 Sep 2017 20:36:50 +0200","From":"Andrew Lunn ","To":"Vivien Didelot ","Cc":"David Miller , netdev ","Subject":"Re: [PATCH net-next 6/6] net: dsa: mv88e6xxx: Flood broadcast frames\n\tin hardware","Message-ID":"<20170927183650.GC12394@lunn.ch>","References":"<1506464764-12699-1-git-send-email-andrew@lunn.ch>\n\t<1506464764-12699-7-git-send-email-andrew@lunn.ch>\n\t<8737786lua.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<8737786lua.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1776530,"web_url":"http://patchwork.ozlabs.org/comment/1776530/","msgid":"<9733da02-0b69-33f0-de8a-63bc5cae6bb4@gmail.com>","list_archive_url":null,"date":"2017-09-27T18:37:54","subject":"Re: [PATCH net-next 6/6] net: dsa: mv88e6xxx: Flood broadcast frames\n\tin hardware","submitter":{"id":2800,"url":"http://patchwork.ozlabs.org/api/people/2800/","name":"Florian Fainelli","email":"f.fainelli@gmail.com"},"content":"On 09/27/2017 11:24 AM, Vivien Didelot wrote:\n> Hi Andrew,\n> \n> Andrew Lunn writes:\n> \n>> +static int mv88e6xxx_port_add_broadcast(struct mv88e6xxx_chip *chip, int port,\n>> +\t\t\t\t\tu16 vid)\n>> +{\n>> +\tconst char broadcast[6] = { 0xff, 0xff, 0xff, 0xff, 0xff, 0xff };\n>> +\n>> +\treturn mv88e6xxx_port_db_load_purge(\n>> +\t\tchip, port, broadcast, vid,\n>> +\t\tMV88E6XXX_G1_ATU_DATA_STATE_MC_STATIC);\n> \n> Please don't do this. This is not a valid coding style and has already\n> shown to be a bad example for other DSA drivers copying mv88e6xxx.\n> \n> Simply declare u8 state = MV88E6XXX_G1_ATU_DATA_STATE_MC_STATIC above...\n> \n>> +}\n>> +\n>> +static int mv88e6xxx_broadcast_setup(struct mv88e6xxx_chip *chip, u16 vid)\n>> +{\n>> +\tint port;\n>> +\tint err;\n>> +\n>> +\tfor (port = 0; port < mv88e6xxx_num_ports(chip); ++port) {\n>> +\t\terr = mv88e6xxx_port_add_broadcast(chip, port, vid);\n>> +\t\tif (err)\n>> +\t\t\treturn err;\n>> +\t}\n>> +\n>> +\treturn 0;\n>> +}\n>> +\n>> static int _mv88e6xxx_port_vlan_add(struct mv88e6xxx_chip *chip, int port,\n>> \t\t\t\t u16 vid, u8 member)\n>> {\n>> @@ -1247,7 +1271,11 @@ static int _mv88e6xxx_port_vlan_add(struct mv88e6xxx_chip *chip, int port,\n>> \n>> \tvlan.member[port] = member;\n>> \n>> -\treturn mv88e6xxx_vtu_loadpurge(chip, &vlan);\n>> +\terr = mv88e6xxx_vtu_loadpurge(chip, &vlan);\n>> +\tif (err)\n>> +\t\treturn err;\n>> +\n>> +\treturn mv88e6xxx_broadcast_setup(chip, vid);\n>> }\n>> \n>> static void mv88e6xxx_port_vlan_add(struct dsa_switch *ds, int port,\n>> @@ -2025,6 +2053,10 @@ static int mv88e6xxx_setup(struct dsa_switch *ds)\n>> \tif (err)\n>> \t\tgoto unlock;\n>> \n>> +\terr = mv88e6xxx_broadcast_setup(chip, 0);\n>> +\tif (err)\n>> +\t\tgoto unlock;\n>> +\n>> \terr = mv88e6xxx_pot_setup(chip);\n>> \tif (err)\n>> \t\tgoto unlock;\n> \n> \n> Adding the broadcast address to an Ethernet switch's FDB is pretty\n> generic and mv88e6xxx mustn't be the only driver doing this.\n\nI have not had time to test Andrew's IGMP patch set on bcm_sf2/b53, but\nwhile I agree that adding a broadcast address using a FDB entry is\ngeneric in premise, we don't know yet whether other switch drivers need\nthat or not, so until we do, it seems like Andrew's approach is\nappropriate here by keeping this local to mv88e6xxx.\n\n> \n> They do not have to care about the broadcast address, this is just a\n> standard MDB entry for them. This must be moved up to the DSA layer.\n> \n> Adding the broadcast address in dsa_port_vlan_add and dsa_port_enable\n> like this should be enough: http://ix.io/AmS\n> \n\nWhat if I don't have CONFIG_BRIDGE_VLAN_FILTERING enabled, what happens\nin that case, would not this result in not programming the broadcast\naddress?","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"QYArmICd\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2RQg3Krpz9t30\n\tfor ;\n\tThu, 28 Sep 2017 04:38:03 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751590AbdI0SiA (ORCPT );\n\tWed, 27 Sep 2017 14:38:00 -0400","from mail-wr0-f196.google.com ([209.85.128.196]:38504 \"EHLO\n\tmail-wr0-f196.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750786AbdI0Sh7 (ORCPT\n\t); Wed, 27 Sep 2017 14:37:59 -0400","by mail-wr0-f196.google.com with SMTP id p37so5999323wrb.5\n\tfor ; Wed, 27 Sep 2017 11:37:59 -0700 (PDT)","from [10.112.156.244] ([192.19.255.250])\n\tby smtp.googlemail.com with ESMTPSA id\n\tj65sm18767589wmj.3.2017.09.27.11.37.56\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 27 Sep 2017 11:37:57 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=7xw1Hoi9gBq+zMpXlwHhY6g0oXNBQ1ySMtBYrc+MoRM=;\n\tb=QYArmICdQ/rCDu0+NKMZWHDnxc98V9uET8mmA+thnVzE2oB8HfEXrtXG7wnajGzdpB\n\tW8N9Oc6qoLs/B5XXJhCltn/IbBw7+NYkw9Zp9YWq+Upi5cHIamqJpbcyLg3SZP+WZLDf\n\t/ADu0fp7yU5iwGNLe/0TyKtTR2Sb14KfXODaCnC0+sYIfAoEj2ThTl2ChaJjLQ78kZzp\n\tB5NAgGgDNLZ4CVGxCW5xdZNdC8/UdQXmE3Wj/iLCZCZN0RGuPMzPllT26TaL9KFHUSXE\n\tKgP5A8bvXo5uVd7S82vr2R2VBJLo7AdLWGLGUCXHEFA/5C/7t3HNk83GJrO7JQEAWE0i\n\t2pog==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=7xw1Hoi9gBq+zMpXlwHhY6g0oXNBQ1ySMtBYrc+MoRM=;\n\tb=IlEeZo/XSIBDKn6yWK/0sjhcdn0yZH0hCM5ijw2u9kBZdho9ne5OlyeddA027PJjCF\n\tP65Q4CDxHPot8n2NdpEEEq8E3UbhlnS6VE0rtGiCgDAjVeeRkv/wccZ6RzOgkNqZhUSX\n\ttgsvoe7eecE1XKoV8RnX4aEySvDfgmfskEfn+1c7rf/Qv0IZT49vGEkdvHUYmGmY6MXo\n\tcCXlt0xGV5BImM11EQ3uDOA02cqH1qJlyRsl7irjy7F/TUNh/h6EHJxB+5kql6zfMWrg\n\tUxwFb0JpmFxz0Vnnoy7Yn4umYg0j9Vg7mFs8ieosr9odG/rP4dScEk0LkJ5/rYxWp8f8\n\tOzcQ==","X-Gm-Message-State":"AHPjjUi2QzrhSE4Gwap7cnCNeG6/UVHz4vADgbBfCUZGJPcaNNvNoGBh\n\taBRHPSPcPt7ovvVStVAsiHXrkTe2","X-Google-Smtp-Source":"AOwi7QAMkYom/SWiO1+EAo1NSoylfbpUqWGVa2onfDefFU18lhmXe2nNnwVp6A1GZCh+A4H2oazk0g==","X-Received":"by 10.223.170.202 with SMTP id i10mr2524772wrc.232.1506537478134;\n\tWed, 27 Sep 2017 11:37:58 -0700 (PDT)","Subject":"Re: [PATCH net-next 6/6] net: dsa: mv88e6xxx: Flood broadcast frames\n\tin hardware","To":"Vivien Didelot ,\n\tAndrew Lunn , David Miller ","Cc":"netdev ","References":"<1506464764-12699-1-git-send-email-andrew@lunn.ch>\n\t<1506464764-12699-7-git-send-email-andrew@lunn.ch>\n\t<8737786lua.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>","From":"Florian Fainelli ","Message-ID":"<9733da02-0b69-33f0-de8a-63bc5cae6bb4@gmail.com>","Date":"Wed, 27 Sep 2017 11:37:54 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<8737786lua.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1776534,"web_url":"http://patchwork.ozlabs.org/comment/1776534/","msgid":"<20170927184636.GD12394@lunn.ch>","list_archive_url":null,"date":"2017-09-27T18:46:36","subject":"Re: [PATCH net-next 6/6] net: dsa: mv88e6xxx: Flood broadcast frames\n\tin hardware","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"> What if I don't have CONFIG_BRIDGE_VLAN_FILTERING enabled, what happens\n> in that case, would not this result in not programming the broadcast\n> address?\n\nHi Florian\n\nIt took me a while to make this work with CONFIG_BRIDGE_VLAN_FILTERING\nenabled. Any change to enable hardware flooding needs careful testing\nfor lots of different configurations. This is another reason i don't\nwant to do it at the DSA level, until we have a good understanding\nwhat it means in each individual driver.\n\n Andrew","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2Rcj1Kqjz9tXQ\n\tfor ;\n\tThu, 28 Sep 2017 04:46:45 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752050AbdI0Sql (ORCPT );\n\tWed, 27 Sep 2017 14:46:41 -0400","from vps0.lunn.ch ([185.16.172.187]:58454 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751073AbdI0Sqk (ORCPT );\n\tWed, 27 Sep 2017 14:46:40 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dxHLw-0004Vd-RC; Wed, 27 Sep 2017 20:46:36 +0200"],"Date":"Wed, 27 Sep 2017 20:46:36 +0200","From":"Andrew Lunn ","To":"Florian Fainelli ","Cc":"Vivien Didelot ,\n\tDavid Miller , netdev ","Subject":"Re: [PATCH net-next 6/6] net: dsa: mv88e6xxx: Flood broadcast frames\n\tin hardware","Message-ID":"<20170927184636.GD12394@lunn.ch>","References":"<1506464764-12699-1-git-send-email-andrew@lunn.ch>\n\t<1506464764-12699-7-git-send-email-andrew@lunn.ch>\n\t<8737786lua.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>\n\t<9733da02-0b69-33f0-de8a-63bc5cae6bb4@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<9733da02-0b69-33f0-de8a-63bc5cae6bb4@gmail.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1776544,"web_url":"http://patchwork.ozlabs.org/comment/1776544/","msgid":"<871smsotlm.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>","list_archive_url":null,"date":"2017-09-27T18:59:49","subject":"Re: [PATCH net-next 6/6] net: dsa: mv88e6xxx: Flood broadcast\n\tframes in hardware","submitter":{"id":15889,"url":"http://patchwork.ozlabs.org/api/people/15889/","name":"Vivien Didelot","email":"vivien.didelot@savoirfairelinux.com"},"content":"Hi Andrew,\n\nAndrew Lunn writes:\n\n>> Adding the broadcast address to an Ethernet switch's FDB is pretty\n>> generic and mv88e6xxx mustn't be the only driver doing this.\n>\n> Actually, it is. All the others seem to do this in hardware without\n> needing an FDB. Since mv88e6xxx is the only one requiring it, it has\n> to be done in the mv88e6xxx driver.\n\nAdding the broadcast address from the DSA layer wouldn't hurt and make\nthings pretty obvious. This would also avoid drivers to get\nunnecessarily complex. A .port_vlan_add implementation must remain\nsimple and mustn't do more than adding a VLAN entry.\n\nDon't forget that we want the DSA drivers to be dump and have the core\nlogic of Ethernet switch handling resides in DSA core itself.\n\nIf some switch chips can flood broadcast without an FDB entry, good for\nthem, they can skip it. We will have the same issue for special L2\nMulticast destination addresses, some switches have special bits to\nconsider them as management, some others don't and require to load the\nATU with them.\n\nRegarding Marvell, what value do you have for the global FloodBC bit\n(Global 2, offset 0x05)?\n\n\nThanks,\n\n Vivien","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2S056SJDz9t43\n\tfor ;\n\tThu, 28 Sep 2017 05:03:33 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750914AbdI0TD3 (ORCPT );\n\tWed, 27 Sep 2017 15:03:29 -0400","from mail.savoirfairelinux.com ([208.88.110.44]:41728 \"EHLO\n\tmail.savoirfairelinux.com\" rhost-flags-OK-OK-OK-OK) by\n\tvger.kernel.org with ESMTP id S1750739AbdI0TD3 (ORCPT\n\t); Wed, 27 Sep 2017 15:03:29 -0400","from localhost (localhost [127.0.0.1])\n\tby mail.savoirfairelinux.com (Postfix) with ESMTP id A87609C277D;\n\tWed, 27 Sep 2017 15:03:28 -0400 (EDT)","from mail.savoirfairelinux.com ([127.0.0.1])\n\tby localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavisd-new,\n\tport 10032)\n\twith ESMTP id 7STwbLb_QWJV; Wed, 27 Sep 2017 15:03:28 -0400 (EDT)","from localhost (localhost [127.0.0.1])\n\tby mail.savoirfairelinux.com (Postfix) with ESMTP id 08B849C2844;\n\tWed, 27 Sep 2017 15:03:28 -0400 (EDT)","from mail.savoirfairelinux.com ([127.0.0.1])\n\tby localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavisd-new,\n\tport 10026)\n\twith ESMTP id mYUojp6ugHDH; Wed, 27 Sep 2017 15:03:27 -0400 (EDT)","from localhost (modemcable249.105-163-184.mc.videotron.ca\n\t[184.163.105.249])\n\tby mail.savoirfairelinux.com (Postfix) with ESMTPSA id CC3209C277D;\n\tWed, 27 Sep 2017 15:03:27 -0400 (EDT)"],"X-Virus-Scanned":"amavisd-new at mail.savoirfairelinux.com","From":"Vivien Didelot ","To":"Andrew Lunn ","Cc":"David Miller , netdev ","Subject":"Re: [PATCH net-next 6/6] net: dsa: mv88e6xxx: Flood broadcast\n\tframes in hardware","In-Reply-To":"<20170927183650.GC12394@lunn.ch>","References":"<1506464764-12699-1-git-send-email-andrew@lunn.ch>\n\t<1506464764-12699-7-git-send-email-andrew@lunn.ch>\n\t<8737786lua.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>\n\t<20170927183650.GC12394@lunn.ch>","Date":"Wed, 27 Sep 2017 14:59:49 -0400","Message-ID":"<871smsotlm.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>","MIME-Version":"1.0","Content-Type":"text/plain","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1776563,"web_url":"http://patchwork.ozlabs.org/comment/1776563/","msgid":"<8760c4t0df.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>","list_archive_url":null,"date":"2017-09-27T19:19:56","subject":"Re: [PATCH net-next 6/6] net: dsa: mv88e6xxx: Flood broadcast\n\tframes in hardware","submitter":{"id":15889,"url":"http://patchwork.ozlabs.org/api/people/15889/","name":"Vivien Didelot","email":"vivien.didelot@savoirfairelinux.com"},"content":"Hi Andrew, Florian,\n\nAndrew Lunn writes:\n\n> It took me a while to make this work with CONFIG_BRIDGE_VLAN_FILTERING\n> enabled. Any change to enable hardware flooding needs careful testing\n> for lots of different configurations. This is another reason i don't\n> want to do it at the DSA level, until we have a good understanding\n> what it means in each individual driver.\n\nThen if we are worried about how broadcast flooding is handled on\ndifferent switches, we can provide a new .flood_broadcast(ds, vid)\nswitch operation for the drivers to implement.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2SRL19Ndz9t49\n\tfor ;\n\tThu, 28 Sep 2017 05:23:42 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751580AbdI0TXi (ORCPT );\n\tWed, 27 Sep 2017 15:23:38 -0400","from mail.savoirfairelinux.com ([208.88.110.44]:43230 \"EHLO\n\tmail.savoirfairelinux.com\" rhost-flags-OK-OK-OK-OK) by\n\tvger.kernel.org with ESMTP id S1751088AbdI0TXi (ORCPT\n\t); Wed, 27 Sep 2017 15:23:38 -0400","from localhost (localhost [127.0.0.1])\n\tby mail.savoirfairelinux.com (Postfix) with ESMTP id 5A2CB9C23FE;\n\tWed, 27 Sep 2017 15:23:37 -0400 (EDT)","from mail.savoirfairelinux.com ([127.0.0.1])\n\tby localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavisd-new,\n\tport 10032)\n\twith ESMTP id 6W1sh91untQf; Wed, 27 Sep 2017 15:23:34 -0400 (EDT)","from localhost (localhost [127.0.0.1])\n\tby mail.savoirfairelinux.com (Postfix) with ESMTP id C63E39C218B;\n\tWed, 27 Sep 2017 15:23:34 -0400 (EDT)","from mail.savoirfairelinux.com ([127.0.0.1])\n\tby localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavisd-new,\n\tport 10026)\n\twith ESMTP id zvx-wNUtS9Lk; Wed, 27 Sep 2017 15:23:34 -0400 (EDT)","from localhost (modemcable249.105-163-184.mc.videotron.ca\n\t[184.163.105.249])\n\tby mail.savoirfairelinux.com (Postfix) with ESMTPSA id 95A1A9C2840;\n\tWed, 27 Sep 2017 15:23:34 -0400 (EDT)"],"X-Virus-Scanned":"amavisd-new at mail.savoirfairelinux.com","From":"Vivien Didelot ","To":"Andrew Lunn , Florian Fainelli ","Cc":"David Miller , netdev ","Subject":"Re: [PATCH net-next 6/6] net: dsa: mv88e6xxx: Flood broadcast\n\tframes in hardware","In-Reply-To":"<20170927184636.GD12394@lunn.ch>","References":"<1506464764-12699-1-git-send-email-andrew@lunn.ch>\n\t<1506464764-12699-7-git-send-email-andrew@lunn.ch>\n\t<8737786lua.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>\n\t<9733da02-0b69-33f0-de8a-63bc5cae6bb4@gmail.com>\n\t<20170927184636.GD12394@lunn.ch>","Date":"Wed, 27 Sep 2017 15:19:56 -0400","Message-ID":"<8760c4t0df.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>","MIME-Version":"1.0","Content-Type":"text/plain","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1776565,"web_url":"http://patchwork.ozlabs.org/comment/1776565/","msgid":"<465be6d8-67d0-d176-1252-abb222bf0528@gmail.com>","list_archive_url":null,"date":"2017-09-27T19:33:29","subject":"Re: [PATCH net-next 6/6] net: dsa: mv88e6xxx: Flood broadcast frames\n\tin hardware","submitter":{"id":2800,"url":"http://patchwork.ozlabs.org/api/people/2800/","name":"Florian Fainelli","email":"f.fainelli@gmail.com"},"content":"On 09/27/2017 12:19 PM, Vivien Didelot wrote:\n> Hi Andrew, Florian,\n> \n> Andrew Lunn writes:\n> \n>> It took me a while to make this work with CONFIG_BRIDGE_VLAN_FILTERING\n>> enabled. Any change to enable hardware flooding needs careful testing\n>> for lots of different configurations. This is another reason i don't\n>> want to do it at the DSA level, until we have a good understanding\n>> what it means in each individual driver.\n> \n> Then if we are worried about how broadcast flooding is handled on\n> different switches, we can provide a new .flood_broadcast(ds, vid)\n> switch operation for the drivers to implement.\n\nWe don't really have a good visibility on the number of switches\nrequiring special configuration for broadcast addresses nor how this\nwould have to happen so it would be a tad difficult to define an\nappropriate API with a single user.\n\nIn general, single user \"generic\" facilities tend to be biased towards\ntheir particular problem space (c.f: devlink) so a generic interface to\ncall into HW specific details does not usually sell well...","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"XLyMVsc9\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2Sfp1ftFz9t49\n\tfor ;\n\tThu, 28 Sep 2017 05:33:38 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751276AbdI0Tdg (ORCPT );\n\tWed, 27 Sep 2017 15:33:36 -0400","from mail-qk0-f174.google.com ([209.85.220.174]:53114 \"EHLO\n\tmail-qk0-f174.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750739AbdI0Tdf (ORCPT\n\t); Wed, 27 Sep 2017 15:33:35 -0400","by mail-qk0-f174.google.com with SMTP id o77so14396974qke.9\n\tfor ; Wed, 27 Sep 2017 12:33:34 -0700 (PDT)","from [10.112.156.244] ([192.19.255.250])\n\tby smtp.googlemail.com with ESMTPSA id\n\tk46sm9209292qta.64.2017.09.27.12.33.31\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 27 Sep 2017 12:33:32 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=DnLxHiuhRo05DgXxDBNXZCm8PvQ44IvWsHjiDzj2EQk=;\n\tb=XLyMVsc9WrtQfk+Rq/HQE+1j3514k35MQ8kkDLGwM/3weQLI7pOPO1hgcMwwI+E+Jx\n\tmuWExL26TFwMBtYRCHWJpOSnkPHDuQAci2D+Yo5YHPp/pseYGA3VBpk0si4wg5cltkJg\n\tAyOG96ro+Nu6cEt01RjGOqjHV8kcXYUHfvRneWTHDel+Hvaew6JfJWB3MQQxImZ21ZC6\n\tvOIg9XqJa4JLaUglKwoN9UhmElt53SPy5/OIV0FPYp7eIgek713vzg4zBqGj5612wYv0\n\tv1w7PhdyQk3ErhPnVvYIzAEAZEvJztB52FkfExSTRyVE8UacHpPTS9KgdjYmzverZKwb\n\tUfNw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=DnLxHiuhRo05DgXxDBNXZCm8PvQ44IvWsHjiDzj2EQk=;\n\tb=cLGOBmU1nzpAXhVoo0foI8HDMiZv/oNiHBOyiZyyZM+z4Mmp18Xn9tB5mNxxRwoEFh\n\tUZstNaDqUjZVJ5pWQM/eUcQP8eZ72BVYODYbEZkyHubT5emIQPDBpvQVQl1u7VJ7txvp\n\tlaGHUAg8hOXxhTJtTtfzilUAzGYRBkMQ7kRLvOvC/NdNNGIr6KOMr1hqHHtAqxn8Vs+F\n\txTWF3wiqMgg+uz66uNLq2N45MkqxlsbpsVFi2d03Y0kpDxz1D0wk01gIHI4VWPz9J8pD\n\tHDGmlsjRC8OyMaV/A6YNLXLSIrOsJ7KYOSi6wkWgocCWbhevPjP29rjQUiC72Jnh8EaQ\n\t2Bmg==","X-Gm-Message-State":"AMCzsaWeT0S28aZtWkis409z8JHrU7Yek++7SNsBbh9rkfwDgYKe9tPN\n\t/rLbbNnebT/RJnbVW930PEuUsWlZ","X-Google-Smtp-Source":"AOwi7QDixHIFV15QTri1PmYYJKp3hnRcF2fy97uCMoBhaBEQpOwg7Jr+OaEflVqKU+9vv+c/T/J+zQ==","X-Received":"by 10.55.165.81 with SMTP id o78mr3889082qke.313.1506540813879; \n\tWed, 27 Sep 2017 12:33:33 -0700 (PDT)","Subject":"Re: [PATCH net-next 6/6] net: dsa: mv88e6xxx: Flood broadcast frames\n\tin hardware","To":"Vivien Didelot ,\n\tAndrew Lunn ","Cc":"David Miller , netdev ","References":"<1506464764-12699-1-git-send-email-andrew@lunn.ch>\n\t<1506464764-12699-7-git-send-email-andrew@lunn.ch>\n\t<8737786lua.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>\n\t<9733da02-0b69-33f0-de8a-63bc5cae6bb4@gmail.com>\n\t<20170927184636.GD12394@lunn.ch>\n\t<8760c4t0df.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>","From":"Florian Fainelli ","Message-ID":"<465be6d8-67d0-d176-1252-abb222bf0528@gmail.com>","Date":"Wed, 27 Sep 2017 12:33:29 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<8760c4t0df.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1776590,"web_url":"http://patchwork.ozlabs.org/comment/1776590/","msgid":"<20170927201810.GH12394@lunn.ch>","list_archive_url":null,"date":"2017-09-27T20:18:10","subject":"Re: [PATCH net-next 6/6] net: dsa: mv88e6xxx: Flood broadcast frames\n\tin hardware","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"On Wed, Sep 27, 2017 at 12:33:29PM -0700, Florian Fainelli wrote:\n> On 09/27/2017 12:19 PM, Vivien Didelot wrote:\n> > Hi Andrew, Florian,\n> > \n> > Andrew Lunn writes:\n> > \n> >> It took me a while to make this work with CONFIG_BRIDGE_VLAN_FILTERING\n> >> enabled. Any change to enable hardware flooding needs careful testing\n> >> for lots of different configurations. This is another reason i don't\n> >> want to do it at the DSA level, until we have a good understanding\n> >> what it means in each individual driver.\n> > \n> > Then if we are worried about how broadcast flooding is handled on\n> > different switches, we can provide a new .flood_broadcast(ds, vid)\n> > switch operation for the drivers to implement.\n> \n> We don't really have a good visibility on the number of switches\n> requiring special configuration for broadcast addresses nor how this\n> would have to happen so it would be a tad difficult to define an\n> appropriate API with a single user.\n\nYes, i agree with this. We should wait before adding a generic\nsolution. I want to wait until a few drivers do whatever is needed for\nhardware broadcast. We can then see what is common, and what is\ndifferent, find an API to suit and do some refactoring.\n\n\t Andrew","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2TfL0V1pz9t66\n\tfor ;\n\tThu, 28 Sep 2017 06:18:18 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751988AbdI0USP (ORCPT );\n\tWed, 27 Sep 2017 16:18:15 -0400","from vps0.lunn.ch ([185.16.172.187]:58563 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751938AbdI0USO (ORCPT );\n\tWed, 27 Sep 2017 16:18:14 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dxImY-0005H2-IY; Wed, 27 Sep 2017 22:18:10 +0200"],"Date":"Wed, 27 Sep 2017 22:18:10 +0200","From":"Andrew Lunn ","To":"Florian Fainelli ","Cc":"Vivien Didelot ,\n\tDavid Miller , netdev ","Subject":"Re: [PATCH net-next 6/6] net: dsa: mv88e6xxx: Flood broadcast frames\n\tin hardware","Message-ID":"<20170927201810.GH12394@lunn.ch>","References":"<1506464764-12699-1-git-send-email-andrew@lunn.ch>\n\t<1506464764-12699-7-git-send-email-andrew@lunn.ch>\n\t<8737786lua.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>\n\t<9733da02-0b69-33f0-de8a-63bc5cae6bb4@gmail.com>\n\t<20170927184636.GD12394@lunn.ch>\n\t<8760c4t0df.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>\n\t<465be6d8-67d0-d176-1252-abb222bf0528@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<465be6d8-67d0-d176-1252-abb222bf0528@gmail.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]