[{"id":1775888,"web_url":"http://patchwork.ozlabs.org/comment/1775888/","msgid":"<20170926214900.GJ3325@lunn.ch>","list_archive_url":null,"date":"2017-09-26T21:49:00","subject":"Re: [PATCH net-next 1/5] net: dsa: return -ENODEV is there is no\n\tslave PHY","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"On Tue, Sep 26, 2017 at 05:15:31PM -0400, Vivien Didelot wrote:\n> Instead of returning -EOPNOTSUPP when a slave device has no PHY,\n> directly return -ENODEV as ethtool and phylib do.\n> \n> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>\n\nReviewed-by: Andrew Lunn <andrew@lunn.ch>\n\n    Andrew","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1vjq6gJqz9t16\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 27 Sep 2017 07:49:19 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1032359AbdIZVtF (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 26 Sep 2017 17:49:05 -0400","from vps0.lunn.ch ([185.16.172.187]:56913 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1032282AbdIZVtE (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tTue, 26 Sep 2017 17:49:04 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from <andrew@lunn.ch>)\n\tid 1dwxiu-0002nE-Iu; Tue, 26 Sep 2017 23:49:00 +0200"],"Date":"Tue, 26 Sep 2017 23:49:00 +0200","From":"Andrew Lunn <andrew@lunn.ch>","To":"Vivien Didelot <vivien.didelot@savoirfairelinux.com>","Cc":"netdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tkernel@savoirfairelinux.com, \"David S. Miller\" <davem@davemloft.net>,\n\tFlorian Fainelli <f.fainelli@gmail.com>","Subject":"Re: [PATCH net-next 1/5] net: dsa: return -ENODEV is there is no\n\tslave PHY","Message-ID":"<20170926214900.GJ3325@lunn.ch>","References":"<20170926211535.21273-1-vivien.didelot@savoirfairelinux.com>\n\t<20170926211535.21273-2-vivien.didelot@savoirfairelinux.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170926211535.21273-2-vivien.didelot@savoirfairelinux.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1775896,"web_url":"http://patchwork.ozlabs.org/comment/1775896/","msgid":"<9c30119d-89b0-468f-926a-e831823a01a6@gmail.com>","list_archive_url":null,"date":"2017-09-26T21:59:48","subject":"Re: [PATCH net-next 1/5] net: dsa: return -ENODEV is there is no\n\tslave PHY","submitter":{"id":2800,"url":"http://patchwork.ozlabs.org/api/people/2800/","name":"Florian Fainelli","email":"f.fainelli@gmail.com"},"content":"On 09/26/2017 02:15 PM, Vivien Didelot wrote:\n> Instead of returning -EOPNOTSUPP when a slave device has no PHY,\n> directly return -ENODEV as ethtool and phylib do.\n> \n> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>\n\nReviewed-by: Florian Fainelli <f.fainelli@gmail.com>\n--\nFlorian","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"IWedhI32\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1vyG4jgTz9t4X\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 27 Sep 2017 08:00:06 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1032488AbdIZV74 (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 26 Sep 2017 17:59:56 -0400","from mail-qt0-f195.google.com ([209.85.216.195]:38182 \"EHLO\n\tmail-qt0-f195.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1031089AbdIZV7x (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Tue, 26 Sep 2017 17:59:53 -0400","by mail-qt0-f195.google.com with SMTP id o3so7903089qte.5;\n\tTue, 26 Sep 2017 14:59:53 -0700 (PDT)","from [10.112.156.244] ([192.19.255.250])\n\tby smtp.googlemail.com with ESMTPSA id\n\tu32sm6032500qte.25.2017.09.26.14.59.50\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 26 Sep 2017 14:59:51 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=T/9FrxlrJDVmp4ZsAGANdIyMcFkewKdcq/QRXWRXD2k=;\n\tb=IWedhI327WFJe6vSK2/iWU18UlViZLN78uACdzWotEUZnj7Qto0tKVLwPL8gKVTuTN\n\tuoBY+EycpezBBBM1TLI7dVihH48Eyqn3ZuQvWoyKcgOtDa8k2nodQQGH+4I1eGkoNFd0\n\t5JXc/WBhbjX6/WhP8/llD0Eh1RL9ahLu1tcehzmiM0e1i/na7r7Ja4AhsqdtxWdKperQ\n\txgr0bApm9o5Ef5woAOa8ZE4SBaoS+H38WCks/jhRYjPF2bIxDUAdEYOZiEG7UdD8fDxs\n\t6eHNVJ+mXusMZwf43cvMh33z4P329J4PevEMAkAK82zAEsvto9FNGh73NSLXllcmXhEX\n\tvi7Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=T/9FrxlrJDVmp4ZsAGANdIyMcFkewKdcq/QRXWRXD2k=;\n\tb=nb8W5ox4GLhCC8ATVV+v6LKETPzNYnHpRpzd9Q7EWJQvuf0I0C6XjZEzA8Dx4vjJMK\n\tFwOy5vM+6ThwzQH8VkL6EbSA85zeQOVKJbDsLROB8tmbhUIe8VuwTLKeg3snKQV7baNp\n\tJaYXD22I5ouGYsEax+whr5inrMY5oq7wuuvnvuHiZlFWQ46c3JK3YGQboEocNLE6f5BH\n\tZk5AFV2CcNfiwZDge46vDIZvg6msYi7w6m/m1vl2ojA8fYongeFGWUdfK0BQz51yXXy5\n\t8ooqfgxAi32HvCZwxAE+PNDca4T6p8KicKrjEow7BBjmqrN6V6pGoA6NdoXcPziaJbyb\n\tp4zA==","X-Gm-Message-State":"AHPjjUhbQQ7PakUuwiinF+q4dXdBvwfZLhVDw9NkGA6hbA7FoiUSxd/y\n\tsZ5Ca3Fq+zvzHo/RtFNfNqjbnCDT","X-Google-Smtp-Source":"AOwi7QCgdAnB6/dbjuUbG6FN6JrpdAhFCY8O9Sp4atf5OKveVH/IFh8xoQU9SY30/n9x95cDXGtZew==","X-Received":"by 10.200.40.142 with SMTP id i14mr18247438qti.326.1506463193074;\n\tTue, 26 Sep 2017 14:59:53 -0700 (PDT)","Subject":"Re: [PATCH net-next 1/5] net: dsa: return -ENODEV is there is no\n\tslave PHY","To":"Vivien Didelot <vivien.didelot@savoirfairelinux.com>,\n\tnetdev@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com,\n\t\"David S. Miller\" <davem@davemloft.net>, Andrew Lunn <andrew@lunn.ch>","References":"<20170926211535.21273-1-vivien.didelot@savoirfairelinux.com>\n\t<20170926211535.21273-2-vivien.didelot@savoirfairelinux.com>","From":"Florian Fainelli <f.fainelli@gmail.com>","Message-ID":"<9c30119d-89b0-468f-926a-e831823a01a6@gmail.com>","Date":"Tue, 26 Sep 2017 14:59:48 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170926211535.21273-2-vivien.didelot@savoirfairelinux.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}}]