[{"id":1775890,"web_url":"http://patchwork.ozlabs.org/comment/1775890/","msgid":"<20170926215614.GK3325@lunn.ch>","list_archive_url":null,"date":"2017-09-26T21:56:14","subject":"Re: [PATCH net-next 2/5] net: dsa: use slave device phydev","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"On Tue, Sep 26, 2017 at 05:15:32PM -0400, Vivien Didelot wrote:\n> There is no need to store a phy_device in dsa_slave_priv since\n> net_device already provides one. Simply s/p->phy/dev->phydev/.\n> \n> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>\n\nReviewed-by: Andrew Lunn <andrew@lunn.ch>\n\n    Andrew","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1vt34W38z9t4Z\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 27 Sep 2017 07:56:27 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754624AbdIZV4R (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 26 Sep 2017 17:56:17 -0400","from vps0.lunn.ch ([185.16.172.187]:56925 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751697AbdIZV4Q (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tTue, 26 Sep 2017 17:56:16 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from <andrew@lunn.ch>)\n\tid 1dwxpu-0002qo-66; Tue, 26 Sep 2017 23:56:14 +0200"],"Date":"Tue, 26 Sep 2017 23:56:14 +0200","From":"Andrew Lunn <andrew@lunn.ch>","To":"Vivien Didelot <vivien.didelot@savoirfairelinux.com>","Cc":"netdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tkernel@savoirfairelinux.com, \"David S. Miller\" <davem@davemloft.net>,\n\tFlorian Fainelli <f.fainelli@gmail.com>","Subject":"Re: [PATCH net-next 2/5] net: dsa: use slave device phydev","Message-ID":"<20170926215614.GK3325@lunn.ch>","References":"<20170926211535.21273-1-vivien.didelot@savoirfairelinux.com>\n\t<20170926211535.21273-3-vivien.didelot@savoirfairelinux.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170926211535.21273-3-vivien.didelot@savoirfairelinux.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1775955,"web_url":"http://patchwork.ozlabs.org/comment/1775955/","msgid":"<292b4fbf-36c6-e63b-58dc-942ca71cc704@gmail.com>","list_archive_url":null,"date":"2017-09-26T23:54:09","subject":"Re: [PATCH net-next 2/5] net: dsa: use slave device phydev","submitter":{"id":2800,"url":"http://patchwork.ozlabs.org/api/people/2800/","name":"Florian Fainelli","email":"f.fainelli@gmail.com"},"content":"On 09/26/2017 02:15 PM, Vivien Didelot wrote:\n> There is no need to store a phy_device in dsa_slave_priv since\n> net_device already provides one. Simply s/p->phy/dev->phydev/.\n> \n> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>\n\nReviewed-by: Florian Fainelli <f.fainelli@gmail.com>","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"bqVS1Ac8\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1yVC5w0Hz9t4X\n\tfor <patchwork-incoming@ozlabs.org>;\n\tWed, 27 Sep 2017 09:54:27 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1032729AbdIZXyR (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 26 Sep 2017 19:54:17 -0400","from mail-wr0-f196.google.com ([209.85.128.196]:36010 \"EHLO\n\tmail-wr0-f196.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1032726AbdIZXyP (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Tue, 26 Sep 2017 19:54:15 -0400","by mail-wr0-f196.google.com with SMTP id k10so150451wrk.3;\n\tTue, 26 Sep 2017 16:54:15 -0700 (PDT)","from [10.112.156.244] ([192.19.255.250])\n\tby smtp.googlemail.com with ESMTPSA id\n\ta195sm2208943wme.34.2017.09.26.16.54.11\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 26 Sep 2017 16:54:13 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=i7efgKv+kjsgjuvtoxbGIoGLJreMGNF19oXp445j+xA=;\n\tb=bqVS1Ac8HapnQiTz47/TQUdXEbaUfBW8oB0+tpSCT8qhLdrWANzf5k7hERl/LXwPLD\n\tXQY+/8+5WeObWQCrYgZJQT/+sNtInt/Rs6VmYDs6YAcqRSe4pnfPE/ZpXQ6S3fT+RMwC\n\tGlGeC/MfrO6AAoDc9Dbmk7uL+lq65payEut7LVwzicTxBff2WuOQVFi+i2++eYVZacHa\n\t7rq1mPJ1MePMOqhsOyvqfEjf2lLJ7gz0Fun4sECpsOip+Gbnkws95KKwdelH/7Bwq18z\n\tMn2eeQts2FWg10DC9l0rO2KyMGpQoFcrJ8TOzWU7aP9sAXR5LCw83RtzBTkTBoQHhp6D\n\tOVyg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=i7efgKv+kjsgjuvtoxbGIoGLJreMGNF19oXp445j+xA=;\n\tb=l1A6EClh86xCG8nI6RTc9mn+q/wiLsilFVf+wsRmEX78OB1PoLAcjPhpR4IU6t0z0O\n\t+VA5HHhgkqVAoM3s9yBC0RhEonUoP4Mz8w6HuXAMa9GQYtp5bzQBhC4jUvO9B6+YsCS8\n\tx4TWxDNmiK5BCyD9kx2EMk8nYOXJXg7pLF+zinB9YvJe+WPQSFBV4jnTugnXLkJ82miL\n\t+tIaWk2CRstgtf1N5qD4lywT8Ac2xIZANzr+i8ErrYDwjcfnSSUMAaYs1AuGk6RTUeV9\n\tL0rMaTmmeGB16QRvO9C1p5c23FwexZuCOJj/wMgConGEGJeZgnrA1+3dG38KDgh9Zpi6\n\t0H3g==","X-Gm-Message-State":"AHPjjUgZyiO4+NBbR+3czxmEucjOz2XOa0AkE8gE5s4oupk/5UmK0LO8\n\t0+KlyCgj6L16HbKW8RMZLo+Zo8k4","X-Google-Smtp-Source":"AOwi7QA+NvMsv13s9BtXAsiO3gfZXw+mC5MZRrpxCFoVTQg5FupQhWQ3BHcJ/9XS8tYOxBT+r7jkDg==","X-Received":"by 10.223.142.199 with SMTP id\n\tq65mr12062662wrb.110.1506470054141; \n\tTue, 26 Sep 2017 16:54:14 -0700 (PDT)","Subject":"Re: [PATCH net-next 2/5] net: dsa: use slave device phydev","To":"Vivien Didelot <vivien.didelot@savoirfairelinux.com>,\n\tnetdev@vger.kernel.org","Cc":"linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com,\n\t\"David S. Miller\" <davem@davemloft.net>, Andrew Lunn <andrew@lunn.ch>","References":"<20170926211535.21273-1-vivien.didelot@savoirfairelinux.com>\n\t<20170926211535.21273-3-vivien.didelot@savoirfairelinux.com>","From":"Florian Fainelli <f.fainelli@gmail.com>","Message-ID":"<292b4fbf-36c6-e63b-58dc-942ca71cc704@gmail.com>","Date":"Tue, 26 Sep 2017 16:54:09 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170926211535.21273-3-vivien.didelot@savoirfairelinux.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}}]