[{"id":1776298,"web_url":"http://patchwork.ozlabs.org/comment/1776298/","msgid":"<0257126a-f2a5-8029-f5e7-dbab0bc025ff@redhat.com>","list_archive_url":null,"date":"2017-09-27T12:20:40","subject":"Re: [Qemu-devel] [PATCH v1 2/6] s390x/tcg: add MMU for real\n\taddresses","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":"> +/**\n> + * Translate a real address into a physical (absolute) address.\n> + * @param raddr  the real address\n> + * @param rw     0 = read, 1 = write, 2 = code fetch\n> + * @param addr  the translated address is stored to this pointer\n----------------->^\nConny, if you want you can also insert one additional space here :)\n\n> + * @param flags  the PAGE_READ/WRITE/EXEC flags are stored to this pointer\n> + * @return       0 if the translation was successful, < 0 if a fault occurred\n> + */\n> +int mmu_translate_real(CPUS390XState *env, target_ulong raddr, int rw,\n> +                       target_ulong *addr, int *flags)\n> +{\n> +    /* TODO: low address protection once we flush the tlb on cr changes */\n> +    *flags = PAGE_READ | PAGE_WRITE;\n> +    *addr = mmu_real2abs(env, raddr);\n> +\n> +    /* TODO: storage key handling */\n> +    return 0;\n> +}\n>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2H3x4pb2z9tXT\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 27 Sep 2017 22:21:17 +1000 (AEST)","from localhost ([::1]:54581 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dxBL1-0001ta-Pl\n\tfor incoming@patchwork.ozlabs.org; Wed, 27 Sep 2017 08:21:15 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:40180)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <david@redhat.com>) id 1dxBKZ-0001sm-45\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 08:20:48 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <david@redhat.com>) id 1dxBKW-0003WA-M2\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 08:20:47 -0400","from mx1.redhat.com ([209.132.183.28]:46562)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <david@redhat.com>) id 1dxBKW-0003Vr-FE\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 08:20:44 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 5A931CD256;\n\tWed, 27 Sep 2017 12:20:43 +0000 (UTC)","from [10.36.118.1] (unknown [10.36.118.1])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id B21727C14C;\n\tWed, 27 Sep 2017 12:20:41 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 5A931CD256","To":"qemu-devel@nongnu.org","References":"<20170926183318.12995-1-david@redhat.com>\n\t<20170926183318.12995-3-david@redhat.com>","From":"David Hildenbrand <david@redhat.com>","Organization":"Red Hat GmbH","Message-ID":"<0257126a-f2a5-8029-f5e7-dbab0bc025ff@redhat.com>","Date":"Wed, 27 Sep 2017 14:20:40 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170926183318.12995-3-david@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tWed, 27 Sep 2017 12:20:43 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1 2/6] s390x/tcg: add MMU for real\n\taddresses","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Christian Borntraeger <borntraeger@de.ibm.com>, thuth@redhat.com,\n\tcohuck@redhat.com, Alexander Graf <agraf@suse.de>,\n\tRichard Henderson <rth@twiddle.net>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}}]