[{"id":1775703,"web_url":"http://patchwork.ozlabs.org/comment/1775703/","msgid":"<1ff22007-d4d9-791d-b204-f9490ac0cf00@de.ibm.com>","list_archive_url":null,"date":"2017-09-26T17:07:25","subject":"Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for\n\t<=2.10","submitter":{"id":590,"url":"http://patchwork.ozlabs.org/api/people/590/","name":"Christian Borntraeger","email":"borntraeger@de.ibm.com"},"content":"On 09/26/2017 06:20 PM, Cornelia Huck wrote:\n> d32bd032d8 (\"s390x/ccw: create s390 phb conditionally\") made\n> creating the s390 phb dependant on the zpci facility. This broke\n> migration from pre-cpu model machines which was fixed with\n> 8ad9087c4a (\"s390x/ccw: create s390 phb for compat reasons as well\").\n> However, that is not enough: Migration from 2.10 with -cpu z13\n> breaks as well.\n> \n> Let's create a phb for all pre-2.11 compat machines to fix this.\n> We leave the zpci facility off to avoid a guest-visible change\n> with cpu models on.\n> \n> Reported-by: Christian Borntraeger \n> Fixes: d32bd032d8 (\"s390x/ccw: create s390 phb conditionally\")\n> Signed-off-by: Cornelia Huck \n\nTested-by: Christian Borntraeger \n\nseems to work fine. \n> ---\n> hw/s390x/s390-virtio-ccw.c | 8 +++++++-\n> include/hw/s390x/s390-virtio-ccw.h | 1 +\n> 2 files changed, 8 insertions(+), 1 deletion(-)\n> \n> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c\n> index 1bcb7000ab..981f1c4336 100644\n> --- a/hw/s390x/s390-virtio-ccw.c\n> +++ b/hw/s390x/s390-virtio-ccw.c\n> @@ -247,6 +247,8 @@ static void s390_create_virtio_net(BusState *bus, const char *name)\n> }\n> }\n> \n> +static S390CcwMachineClass *get_machine_class(void);\n> +\n> static void ccw_init(MachineState *machine)\n> {\n> int ret;\n> @@ -266,7 +268,7 @@ static void ccw_init(MachineState *machine)\n> machine->initrd_filename, \"s390-ccw.img\",\n> \"s390-netboot.img\", true);\n> \n> - if (s390_has_feat(S390_FEAT_ZPCI)) {\n> + if (s390_has_feat(S390_FEAT_ZPCI) || get_machine_class()->phb_compat) {\n> DeviceState *dev = qdev_create(NULL, TYPE_S390_PCI_HOST_BRIDGE);\n> object_property_add_child(qdev_get_machine(),\n> TYPE_S390_PCI_HOST_BRIDGE,\n> @@ -407,6 +409,7 @@ static void ccw_machine_class_init(ObjectClass *oc, void *data)\n> s390mc->cpu_model_allowed = true;\n> s390mc->css_migration_enabled = true;\n> s390mc->gs_allowed = true;\n> + s390mc->phb_compat = false;\n> mc->init = ccw_init;\n> mc->reset = s390_machine_reset;\n> mc->hot_add_cpu = s390_hot_add_cpu;\n> @@ -716,6 +719,9 @@ static void ccw_machine_2_10_instance_options(MachineState *machine)\n> \n> static void ccw_machine_2_10_class_options(MachineClass *mc)\n> {\n> + S390CcwMachineClass *s390mc = S390_MACHINE_CLASS(mc);\n> +\n> + s390mc->phb_compat = pci_available;\n> ccw_machine_2_11_class_options(mc);\n> SET_MACHINE_COMPAT(mc, CCW_COMPAT_2_10);\n> }\n> diff --git a/include/hw/s390x/s390-virtio-ccw.h b/include/hw/s390x/s390-virtio-ccw.h\n> index a9a90c2022..fb717afe92 100644\n> --- a/include/hw/s390x/s390-virtio-ccw.h\n> +++ b/include/hw/s390x/s390-virtio-ccw.h\n> @@ -41,6 +41,7 @@ typedef struct S390CcwMachineClass {\n> bool cpu_model_allowed;\n> bool css_migration_enabled;\n> bool gs_allowed;\n> + bool phb_compat;\n> } S390CcwMachineClass;\n> \n> /* runtime-instrumentation allowed by the machine */\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1nTK0XLnz9t16\n\tfor ;\n\tWed, 27 Sep 2017 03:08:05 +1000 (AEST)","from localhost ([::1]:50374 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwtL1-0000js-7M\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 13:08:03 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:50513)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwtKf-0000jY-OV\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 13:07:42 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwtKa-0000B6-OB\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 13:07:41 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1]:54870)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dwtKa-0000AT-Es\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 13:07:36 -0400","from pps.filterd (m0098399.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8QH6Wb7143848\n\tfor ; Tue, 26 Sep 2017 13:07:32 -0400","from e06smtp14.uk.ibm.com (e06smtp14.uk.ibm.com [195.75.94.110])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d7qgrpy04-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Tue, 26 Sep 2017 13:07:31 -0400","from localhost\n\tby e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tTue, 26 Sep 2017 18:07:28 +0100","from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197)\n\tby e06smtp14.uk.ibm.com (192.168.101.144) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tTue, 26 Sep 2017 18:07:26 +0100","from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com\n\t[9.149.105.58])\n\tby b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8QH7PhC21364812; Tue, 26 Sep 2017 17:07:25 GMT","from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 000DE4C044;\n\tTue, 26 Sep 2017 18:03:41 +0100 (BST)","from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 925124C040;\n\tTue, 26 Sep 2017 18:03:41 +0100 (BST)","from oc7330422307.ibm.com (unknown [9.145.67.135])\n\tby d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tTue, 26 Sep 2017 18:03:41 +0100 (BST)"],"To":"Cornelia Huck , qemu-devel@nongnu.org","References":"<20170926162058.30772-1-cohuck@redhat.com>\n\t<20170926162058.30772-2-cohuck@redhat.com>","From":"Christian Borntraeger ","Date":"Tue, 26 Sep 2017 19:07:25 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.0","MIME-Version":"1.0","In-Reply-To":"<20170926162058.30772-2-cohuck@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","x-cbid":"17092617-0016-0000-0000-000004F050A1","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092617-0017-0000-0000-0000282A9E71","Message-Id":"<1ff22007-d4d9-791d-b204-f9490ac0cf00@de.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-26_06:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709260241","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.156.1","Subject":"Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for\n\t<=2.10","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pasic@linux.vnet.ibm.com, zyimin@linux.vnet.ibm.com, david@redhat.com,\n\tdgilbert@redhat.com, agraf@suse.de, jjherne@linux.vnet.ibm.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1775775,"web_url":"http://patchwork.ozlabs.org/comment/1775775/","msgid":"<338c8565-691e-a8bc-d8a6-3637ce13701d@redhat.com>","list_archive_url":null,"date":"2017-09-26T18:40:25","subject":"Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for\n\t<=2.10","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":"On 26.09.2017 18:20, Cornelia Huck wrote:\n> d32bd032d8 (\"s390x/ccw: create s390 phb conditionally\") made\n> creating the s390 phb dependant on the zpci facility. This broke\n> migration from pre-cpu model machines which was fixed with\n> 8ad9087c4a (\"s390x/ccw: create s390 phb for compat reasons as well\").\n> However, that is not enough: Migration from 2.10 with -cpu z13\n> breaks as well.\n> \n> Let's create a phb for all pre-2.11 compat machines to fix this.\n> We leave the zpci facility off to avoid a guest-visible change\n> with cpu models on.\n> \n> Reported-by: Christian Borntraeger \n> Fixes: d32bd032d8 (\"s390x/ccw: create s390 phb conditionally\")\n> Signed-off-by: Cornelia Huck \n> ---\n> hw/s390x/s390-virtio-ccw.c | 8 +++++++-\n> include/hw/s390x/s390-virtio-ccw.h | 1 +\n> 2 files changed, 8 insertions(+), 1 deletion(-)\n> \n> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c\n> index 1bcb7000ab..981f1c4336 100644\n> --- a/hw/s390x/s390-virtio-ccw.c\n> +++ b/hw/s390x/s390-virtio-ccw.c\n> @@ -247,6 +247,8 @@ static void s390_create_virtio_net(BusState *bus, const char *name)\n> }\n> }\n> \n> +static S390CcwMachineClass *get_machine_class(void);\n> +\n> static void ccw_init(MachineState *machine)\n> {\n> int ret;\n> @@ -266,7 +268,7 @@ static void ccw_init(MachineState *machine)\n> machine->initrd_filename, \"s390-ccw.img\",\n> \"s390-netboot.img\", true);\n> \n> - if (s390_has_feat(S390_FEAT_ZPCI)) {\n> + if (s390_has_feat(S390_FEAT_ZPCI) || get_machine_class()->phb_compat) {\n> DeviceState *dev = qdev_create(NULL, TYPE_S390_PCI_HOST_BRIDGE);\n> object_property_add_child(qdev_get_machine(),\n> TYPE_S390_PCI_HOST_BRIDGE,\n> @@ -407,6 +409,7 @@ static void ccw_machine_class_init(ObjectClass *oc, void *data)\n> s390mc->cpu_model_allowed = true;\n> s390mc->css_migration_enabled = true;\n> s390mc->gs_allowed = true;\n> + s390mc->phb_compat = false;\n> mc->init = ccw_init;\n> mc->reset = s390_machine_reset;\n> mc->hot_add_cpu = s390_hot_add_cpu;\n> @@ -716,6 +719,9 @@ static void ccw_machine_2_10_instance_options(MachineState *machine)\n> \n> static void ccw_machine_2_10_class_options(MachineClass *mc)\n> {\n> + S390CcwMachineClass *s390mc = S390_MACHINE_CLASS(mc);\n> +\n> + s390mc->phb_compat = pci_available;\n> ccw_machine_2_11_class_options(mc);\n> SET_MACHINE_COMPAT(mc, CCW_COMPAT_2_10);\n> }\n> diff --git a/include/hw/s390x/s390-virtio-ccw.h b/include/hw/s390x/s390-virtio-ccw.h\n> index a9a90c2022..fb717afe92 100644\n> --- a/include/hw/s390x/s390-virtio-ccw.h\n> +++ b/include/hw/s390x/s390-virtio-ccw.h\n> @@ -41,6 +41,7 @@ typedef struct S390CcwMachineClass {\n> bool cpu_model_allowed;\n> bool css_migration_enabled;\n> bool gs_allowed;\n> + bool phb_compat;\n> } S390CcwMachineClass;\n> \n> /* runtime-instrumentation allowed by the machine */\n> \n\nI'd really really really (did I mention really?) favor something like a\ndummy device, because we could easily handle the !CONFIG_PCI case then.\n\nAll these compat options and conditions will kill us someday... we're\nalready patching around that whole stuff way too much.\n\nIf we ever unconditionally created a device, we should keep doing so.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1qXs3WvHz9t3m\n\tfor ;\n\tWed, 27 Sep 2017 04:41:17 +1000 (AEST)","from localhost ([::1]:50708 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwunD-00019U-Ja\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 14:41:15 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:47678)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwumX-00011J-6C\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 14:40:34 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwumU-0006Pe-2v\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 14:40:33 -0400","from mx1.redhat.com ([209.132.183.28]:37270)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dwumT-0006PU-Qi\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 14:40:30 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id B904AC058EAE;\n\tTue, 26 Sep 2017 18:40:28 +0000 (UTC)","from [10.36.117.152] (ovpn-117-152.ams2.redhat.com [10.36.117.152])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id A221966D26;\n\tTue, 26 Sep 2017 18:40:26 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com B904AC058EAE","To":"Cornelia Huck , qemu-devel@nongnu.org","References":"<20170926162058.30772-1-cohuck@redhat.com>\n\t<20170926162058.30772-2-cohuck@redhat.com>","From":"David Hildenbrand ","Organization":"Red Hat GmbH","Message-ID":"<338c8565-691e-a8bc-d8a6-3637ce13701d@redhat.com>","Date":"Tue, 26 Sep 2017 20:40:25 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170926162058.30772-2-cohuck@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tTue, 26 Sep 2017 18:40:28 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for\n\t<=2.10","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pasic@linux.vnet.ibm.com, zyimin@linux.vnet.ibm.com, agraf@suse.de,\n\tdgilbert@redhat.com, borntraeger@de.ibm.com, jjherne@linux.vnet.ibm.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1776194,"web_url":"http://patchwork.ozlabs.org/comment/1776194/","msgid":"<20170927114717.72bd69f8.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-27T09:47:17","subject":"Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for\n\t<=2.10","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Tue, 26 Sep 2017 20:40:25 +0200\nDavid Hildenbrand wrote:\n\n> On 26.09.2017 18:20, Cornelia Huck wrote:\n> > d32bd032d8 (\"s390x/ccw: create s390 phb conditionally\") made\n> > creating the s390 phb dependant on the zpci facility. This broke\n> > migration from pre-cpu model machines which was fixed with\n> > 8ad9087c4a (\"s390x/ccw: create s390 phb for compat reasons as well\").\n> > However, that is not enough: Migration from 2.10 with -cpu z13\n> > breaks as well.\n> > \n> > Let's create a phb for all pre-2.11 compat machines to fix this.\n> > We leave the zpci facility off to avoid a guest-visible change\n> > with cpu models on.\n> > \n> > Reported-by: Christian Borntraeger \n> > Fixes: d32bd032d8 (\"s390x/ccw: create s390 phb conditionally\")\n> > Signed-off-by: Cornelia Huck \n> > ---\n> > hw/s390x/s390-virtio-ccw.c | 8 +++++++-\n> > include/hw/s390x/s390-virtio-ccw.h | 1 +\n> > 2 files changed, 8 insertions(+), 1 deletion(-)\n> > \n> > diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c\n> > index 1bcb7000ab..981f1c4336 100644\n> > --- a/hw/s390x/s390-virtio-ccw.c\n> > +++ b/hw/s390x/s390-virtio-ccw.c\n> > @@ -247,6 +247,8 @@ static void s390_create_virtio_net(BusState *bus, const char *name)\n> > }\n> > }\n> > \n> > +static S390CcwMachineClass *get_machine_class(void);\n> > +\n> > static void ccw_init(MachineState *machine)\n> > {\n> > int ret;\n> > @@ -266,7 +268,7 @@ static void ccw_init(MachineState *machine)\n> > machine->initrd_filename, \"s390-ccw.img\",\n> > \"s390-netboot.img\", true);\n> > \n> > - if (s390_has_feat(S390_FEAT_ZPCI)) {\n> > + if (s390_has_feat(S390_FEAT_ZPCI) || get_machine_class()->phb_compat) {\n> > DeviceState *dev = qdev_create(NULL, TYPE_S390_PCI_HOST_BRIDGE);\n> > object_property_add_child(qdev_get_machine(),\n> > TYPE_S390_PCI_HOST_BRIDGE,\n> > @@ -407,6 +409,7 @@ static void ccw_machine_class_init(ObjectClass *oc, void *data)\n> > s390mc->cpu_model_allowed = true;\n> > s390mc->css_migration_enabled = true;\n> > s390mc->gs_allowed = true;\n> > + s390mc->phb_compat = false;\n> > mc->init = ccw_init;\n> > mc->reset = s390_machine_reset;\n> > mc->hot_add_cpu = s390_hot_add_cpu;\n> > @@ -716,6 +719,9 @@ static void ccw_machine_2_10_instance_options(MachineState *machine)\n> > \n> > static void ccw_machine_2_10_class_options(MachineClass *mc)\n> > {\n> > + S390CcwMachineClass *s390mc = S390_MACHINE_CLASS(mc);\n> > +\n> > + s390mc->phb_compat = pci_available;\n> > ccw_machine_2_11_class_options(mc);\n> > SET_MACHINE_COMPAT(mc, CCW_COMPAT_2_10);\n> > }\n> > diff --git a/include/hw/s390x/s390-virtio-ccw.h b/include/hw/s390x/s390-virtio-ccw.h\n> > index a9a90c2022..fb717afe92 100644\n> > --- a/include/hw/s390x/s390-virtio-ccw.h\n> > +++ b/include/hw/s390x/s390-virtio-ccw.h\n> > @@ -41,6 +41,7 @@ typedef struct S390CcwMachineClass {\n> > bool cpu_model_allowed;\n> > bool css_migration_enabled;\n> > bool gs_allowed;\n> > + bool phb_compat;\n> > } S390CcwMachineClass;\n> > \n> > /* runtime-instrumentation allowed by the machine */\n> > \n> \n> I'd really really really (did I mention really?) favor something like a\n> dummy device, because we could easily handle the !CONFIG_PCI case then.\n> \n> All these compat options and conditions will kill us someday... we're\n> already patching around that whole stuff way too much.\n> \n> If we ever unconditionally created a device, we should keep doing so.\n\nYes, that whole thing is horrible, especially interaction with compat\nmachines.\n\nDo you have an idea on how to create such a dummy device (without\nhaving to effectively copy a lot of configured-out code)?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2Cg520FRz9sBd\n\tfor ;\n\tWed, 27 Sep 2017 19:48:01 +1000 (AEST)","from localhost ([::1]:53719 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dx8wg-0003tI-Dw\n\tfor incoming@patchwork.ozlabs.org; Wed, 27 Sep 2017 05:47:58 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:60576)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dx8wB-0003t0-DK\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 05:47:28 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dx8w8-0003Tf-9g\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 05:47:27 -0400","from mx1.redhat.com ([209.132.183.28]:51966)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dx8w8-0003TF-0S\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 05:47:24 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C08306146A;\n\tWed, 27 Sep 2017 09:47:22 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 3A9BD7EA4C;\n\tWed, 27 Sep 2017 09:47:19 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com C08306146A","Date":"Wed, 27 Sep 2017 11:47:17 +0200","From":"Cornelia Huck ","To":"David Hildenbrand ","Message-ID":"<20170927114717.72bd69f8.cohuck@redhat.com>","In-Reply-To":"<338c8565-691e-a8bc-d8a6-3637ce13701d@redhat.com>","References":"<20170926162058.30772-1-cohuck@redhat.com>\n\t<20170926162058.30772-2-cohuck@redhat.com>\n\t<338c8565-691e-a8bc-d8a6-3637ce13701d@redhat.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tWed, 27 Sep 2017 09:47:22 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for\n\t<=2.10","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pasic@linux.vnet.ibm.com, zyimin@linux.vnet.ibm.com,\n\tqemu-devel@nongnu.org, agraf@suse.de, borntraeger@de.ibm.com,\n\tjjherne@linux.vnet.ibm.com, dgilbert@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1776216,"web_url":"http://patchwork.ozlabs.org/comment/1776216/","msgid":"","list_archive_url":null,"date":"2017-09-27T10:25:00","subject":"Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for\n\t<=2.10","submitter":{"id":66807,"url":"http://patchwork.ozlabs.org/api/people/66807/","name":"Yi Min Zhao","email":"zyimin@linux.vnet.ibm.com"},"content":"在 2017/9/27 下午5:47, Cornelia Huck 写道:\n> On Tue, 26 Sep 2017 20:40:25 +0200\n> David Hildenbrand wrote:\n>\n>> On 26.09.2017 18:20, Cornelia Huck wrote:\n>>> d32bd032d8 (\"s390x/ccw: create s390 phb conditionally\") made\n>>> creating the s390 phb dependant on the zpci facility. This broke\n>>> migration from pre-cpu model machines which was fixed with\n>>> 8ad9087c4a (\"s390x/ccw: create s390 phb for compat reasons as well\").\n>>> However, that is not enough: Migration from 2.10 with -cpu z13\n>>> breaks as well.\n>>>\n>>> Let's create a phb for all pre-2.11 compat machines to fix this.\n>>> We leave the zpci facility off to avoid a guest-visible change\n>>> with cpu models on.\n>>>\n>>> Reported-by: Christian Borntraeger \n>>> Fixes: d32bd032d8 (\"s390x/ccw: create s390 phb conditionally\")\n>>> Signed-off-by: Cornelia Huck \n>>> ---\n>>> hw/s390x/s390-virtio-ccw.c | 8 +++++++-\n>>> include/hw/s390x/s390-virtio-ccw.h | 1 +\n>>> 2 files changed, 8 insertions(+), 1 deletion(-)\n>>>\n>>> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c\n>>> index 1bcb7000ab..981f1c4336 100644\n>>> --- a/hw/s390x/s390-virtio-ccw.c\n>>> +++ b/hw/s390x/s390-virtio-ccw.c\n>>> @@ -247,6 +247,8 @@ static void s390_create_virtio_net(BusState *bus, const char *name)\n>>> }\n>>> }\n>>> \n>>> +static S390CcwMachineClass *get_machine_class(void);\n>>> +\n>>> static void ccw_init(MachineState *machine)\n>>> {\n>>> int ret;\n>>> @@ -266,7 +268,7 @@ static void ccw_init(MachineState *machine)\n>>> machine->initrd_filename, \"s390-ccw.img\",\n>>> \"s390-netboot.img\", true);\n>>> \n>>> - if (s390_has_feat(S390_FEAT_ZPCI)) {\n>>> + if (s390_has_feat(S390_FEAT_ZPCI) || get_machine_class()->phb_compat) {\n>>> DeviceState *dev = qdev_create(NULL, TYPE_S390_PCI_HOST_BRIDGE);\n>>> object_property_add_child(qdev_get_machine(),\n>>> TYPE_S390_PCI_HOST_BRIDGE,\n>>> @@ -407,6 +409,7 @@ static void ccw_machine_class_init(ObjectClass *oc, void *data)\n>>> s390mc->cpu_model_allowed = true;\n>>> s390mc->css_migration_enabled = true;\n>>> s390mc->gs_allowed = true;\n>>> + s390mc->phb_compat = false;\n>>> mc->init = ccw_init;\n>>> mc->reset = s390_machine_reset;\n>>> mc->hot_add_cpu = s390_hot_add_cpu;\n>>> @@ -716,6 +719,9 @@ static void ccw_machine_2_10_instance_options(MachineState *machine)\n>>> \n>>> static void ccw_machine_2_10_class_options(MachineClass *mc)\n>>> {\n>>> + S390CcwMachineClass *s390mc = S390_MACHINE_CLASS(mc);\n>>> +\n>>> + s390mc->phb_compat = pci_available;\n>>> ccw_machine_2_11_class_options(mc);\n>>> SET_MACHINE_COMPAT(mc, CCW_COMPAT_2_10);\n>>> }\n>>> diff --git a/include/hw/s390x/s390-virtio-ccw.h b/include/hw/s390x/s390-virtio-ccw.h\n>>> index a9a90c2022..fb717afe92 100644\n>>> --- a/include/hw/s390x/s390-virtio-ccw.h\n>>> +++ b/include/hw/s390x/s390-virtio-ccw.h\n>>> @@ -41,6 +41,7 @@ typedef struct S390CcwMachineClass {\n>>> bool cpu_model_allowed;\n>>> bool css_migration_enabled;\n>>> bool gs_allowed;\n>>> + bool phb_compat;\n>>> } S390CcwMachineClass;\n>>> \n>>> /* runtime-instrumentation allowed by the machine */\n>>> \n>> I'd really really really (did I mention really?) favor something like a\n>> dummy device, because we could easily handle the !CONFIG_PCI case then.\n>>\n>> All these compat options and conditions will kill us someday... we're\n>> already patching around that whole stuff way too much.\n>>\n>> If we ever unconditionally created a device, we should keep doing so.\n> Yes, that whole thing is horrible, especially interaction with compat\n> machines.\n>\n> Do you have an idea on how to create such a dummy device (without\n> having to effectively copy a lot of configured-out code)?\n>\n>\nHow about in s390_pcihost_hot_plug() we check s390_has_feat(zpci)?\nIf no zpci feature, we avoid plugging any pci device.\nThen we could always create phb.\nI think pcibus's vmstate is only data to migrate.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2DVZ05SXz9tXQ\n\tfor ;\n\tWed, 27 Sep 2017 20:25:42 +1000 (AEST)","from localhost ([::1]:53889 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dx9XA-0003Z5-2f\n\tfor incoming@patchwork.ozlabs.org; Wed, 27 Sep 2017 06:25:40 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41329)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dx9Wl-0003Ym-EZ\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 06:25:16 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dx9Wi-0004RB-7M\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 06:25:15 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1]:33108)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dx9Wh-0004Q5-V1\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 06:25:12 -0400","from pps.filterd (m0098410.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8RAO1ZQ115919\n\tfor ; Wed, 27 Sep 2017 06:25:07 -0400","from e33.co.us.ibm.com (e33.co.us.ibm.com [32.97.110.151])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d87p18e6e-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Wed, 27 Sep 2017 06:25:06 -0400","from localhost\n\tby e33.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tWed, 27 Sep 2017 04:25:06 -0600","from b03cxnp08026.gho.boulder.ibm.com (9.17.130.18)\n\tby e33.co.us.ibm.com (192.168.1.133) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tWed, 27 Sep 2017 04:25:04 -0600","from b03ledav006.gho.boulder.ibm.com\n\t(b03ledav006.gho.boulder.ibm.com [9.17.130.237])\n\tby b03cxnp08026.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8RAP3A361800660; Wed, 27 Sep 2017 03:25:03 -0700","from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id A5B3FC6042;\n\tWed, 27 Sep 2017 04:25:03 -0600 (MDT)","from zyimindembp.cn.ibm.com (unknown [9.115.193.51])\n\tby b03ledav006.gho.boulder.ibm.com (Postfix) with ESMTP id D5E5CC603C;\n\tWed, 27 Sep 2017 04:25:01 -0600 (MDT)"],"To":"Cornelia Huck , David Hildenbrand ","References":"<20170926162058.30772-1-cohuck@redhat.com>\n\t<20170926162058.30772-2-cohuck@redhat.com>\n\t<338c8565-691e-a8bc-d8a6-3637ce13701d@redhat.com>\n\t<20170927114717.72bd69f8.cohuck@redhat.com>","From":"Yi Min Zhao ","Date":"Wed, 27 Sep 2017 18:25:00 +0800","User-Agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)\n\tGecko/20100101 Thunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170927114717.72bd69f8.cohuck@redhat.com>","Content-Type":"text/plain; charset=gbk; format=flowed","X-TM-AS-GCONF":"00","x-cbid":"17092710-0008-0000-0000-000008A15052","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007800; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000231; SDB=6.00923055; UDB=6.00464006;\n\tIPR=6.00703197; \n\tBA=6.00005608; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017290;\n\tXFM=3.00000015; UTC=2017-09-27 10:25:05","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092710-0009-0000-0000-0000442339D6","Message-Id":"","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-27_02:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709270146","Content-Transfer-Encoding":"quoted-printable","X-MIME-Autoconverted":"from 8bit to quoted-printable by\n\tmx0a-001b2d01.pphosted.com id v8RAO1ZQ115919","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.156.1","Subject":"Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for\n\t<=2.10","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"agraf@suse.de, pasic@linux.vnet.ibm.com, dgilbert@redhat.com,\n\tqemu-devel@nongnu.org, borntraeger@de.ibm.com, jjherne@linux.vnet.ibm.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1776246,"web_url":"http://patchwork.ozlabs.org/comment/1776246/","msgid":"<20170927125606.65dc514d.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-27T10:56:06","subject":"Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for\n\t<=2.10","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Wed, 27 Sep 2017 18:25:00 +0800\nYi Min Zhao wrote:\n\n> 在 2017/9/27 下午5:47, Cornelia Huck 写道:\n> > On Tue, 26 Sep 2017 20:40:25 +0200\n> > David Hildenbrand wrote:\n\n> >> I'd really really really (did I mention really?) favor something like a\n> >> dummy device, because we could easily handle the !CONFIG_PCI case then.\n> >>\n> >> All these compat options and conditions will kill us someday... we're\n> >> already patching around that whole stuff way too much.\n> >>\n> >> If we ever unconditionally created a device, we should keep doing so. \n> > Yes, that whole thing is horrible, especially interaction with compat\n> > machines.\n> >\n> > Do you have an idea on how to create such a dummy device (without\n> > having to effectively copy a lot of configured-out code)?\n> >\n> > \n> How about in s390_pcihost_hot_plug() we check s390_has_feat(zpci)?\n> If no zpci feature, we avoid plugging any pci device.\n> Then we could always create phb.\n> I think pcibus's vmstate is only data to migrate.\n\nThat's still problematic if CONFIG_PCI is off. I currently don't have a\nbetter idea than either disallowing compat machines on builds without\npci, or using a dummy device...","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2FBK5tVhz9tXf\n\tfor ;\n\tWed, 27 Sep 2017 20:56:41 +1000 (AEST)","from localhost ([::1]:53986 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxA19-0002eV-W4\n\tfor incoming@patchwork.ozlabs.org; Wed, 27 Sep 2017 06:56:40 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:48991)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxA0o-0002eQ-It\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 06:56:19 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxA0k-0001K3-Je\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 06:56:18 -0400","from mx1.redhat.com ([209.132.183.28]:36064)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dxA0k-0001Jm-DR\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 06:56:14 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 4A1397E447;\n\tWed, 27 Sep 2017 10:56:13 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 3087A7EF7E;\n\tWed, 27 Sep 2017 10:56:09 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 4A1397E447","Date":"Wed, 27 Sep 2017 12:56:06 +0200","From":"Cornelia Huck ","To":"Yi Min Zhao ","Message-ID":"<20170927125606.65dc514d.cohuck@redhat.com>","In-Reply-To":"","References":"<20170926162058.30772-1-cohuck@redhat.com>\n\t<20170926162058.30772-2-cohuck@redhat.com>\n\t<338c8565-691e-a8bc-d8a6-3637ce13701d@redhat.com>\n\t<20170927114717.72bd69f8.cohuck@redhat.com>\n\t","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"quoted-printable","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tWed, 27 Sep 2017 10:56:13 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for\n\t<=2.10","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pasic@linux.vnet.ibm.com, David Hildenbrand ,\n\tagraf@suse.de, qemu-devel@nongnu.org, borntraeger@de.ibm.com,\n\tjjherne@linux.vnet.ibm.com, dgilbert@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1776248,"web_url":"http://patchwork.ozlabs.org/comment/1776248/","msgid":"<14df9ad6-f0e9-cd51-04dd-4fe994808433@de.ibm.com>","list_archive_url":null,"date":"2017-09-27T10:59:35","subject":"Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for\n\t<=2.10","submitter":{"id":590,"url":"http://patchwork.ozlabs.org/api/people/590/","name":"Christian Borntraeger","email":"borntraeger@de.ibm.com"},"content":"On 09/27/2017 12:56 PM, Cornelia Huck wrote:\n> On Wed, 27 Sep 2017 18:25:00 +0800\n> Yi Min Zhao wrote:\n> \n>> 在 2017/9/27 下午5:47, Cornelia Huck 写道:\n>>> On Tue, 26 Sep 2017 20:40:25 +0200\n>>> David Hildenbrand wrote:\n> \n>>>> I'd really really really (did I mention really?) favor something like a\n>>>> dummy device, because we could easily handle the !CONFIG_PCI case then.\n>>>>\n>>>> All these compat options and conditions will kill us someday... we're\n>>>> already patching around that whole stuff way too much.\n>>>>\n>>>> If we ever unconditionally created a device, we should keep doing so. \n>>> Yes, that whole thing is horrible, especially interaction with compat\n>>> machines.\n>>>\n>>> Do you have an idea on how to create such a dummy device (without\n>>> having to effectively copy a lot of configured-out code)?\n>>>\n>>> \n>> How about in s390_pcihost_hot_plug() we check s390_has_feat(zpci)?\n>> If no zpci feature, we avoid plugging any pci device.\n>> Then we could always create phb.\n>> I think pcibus's vmstate is only data to migrate.\n> \n> That's still problematic if CONFIG_PCI is off. I currently don't have a\n> better idea than either disallowing compat machines on builds without\n> pci, or using a dummy device...\n\nFor this particular case your initial patch might be less problematic than\na dummy device, because the code that does the migration is NOT contained\nin s390 specific code but in common PCI code instead. We would need to keep\nthe dummy device always in a way that it will work with the common PCI\ncode.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2FGP6wYxz9tXp\n\tfor ;\n\tWed, 27 Sep 2017 21:00:13 +1000 (AEST)","from localhost ([::1]:53993 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxA4a-0003Yk-4o\n\tfor incoming@patchwork.ozlabs.org; Wed, 27 Sep 2017 07:00:12 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:49512)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxA4D-0003Yb-Vq\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 06:59:51 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxA4A-0003Cv-0m\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 06:59:50 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1]:50076)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dxA49-0003Az-Nw\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 06:59:45 -0400","from pps.filterd (m0098409.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8RAwtYP045361\n\tfor ; Wed, 27 Sep 2017 06:59:40 -0400","from e06smtp14.uk.ibm.com (e06smtp14.uk.ibm.com [195.75.94.110])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d83qrn1hm-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Wed, 27 Sep 2017 06:59:40 -0400","from localhost\n\tby e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tWed, 27 Sep 2017 11:59:38 +0100","from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197)\n\tby e06smtp14.uk.ibm.com (192.168.101.144) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tWed, 27 Sep 2017 11:59:36 +0100","from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com\n\t[9.149.105.62])\n\tby b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8RAxZ9P22085838; Wed, 27 Sep 2017 10:59:35 GMT","from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 58731AE053;\n\tWed, 27 Sep 2017 11:54:17 +0100 (BST)","from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 173ECAE045;\n\tWed, 27 Sep 2017 11:54:17 +0100 (BST)","from oc7330422307.ibm.com (unknown [9.152.224.56])\n\tby d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tWed, 27 Sep 2017 11:54:17 +0100 (BST)"],"To":"Cornelia Huck ,\n\tYi Min Zhao ","References":"<20170926162058.30772-1-cohuck@redhat.com>\n\t<20170926162058.30772-2-cohuck@redhat.com>\n\t<338c8565-691e-a8bc-d8a6-3637ce13701d@redhat.com>\n\t<20170927114717.72bd69f8.cohuck@redhat.com>\n\t\n\t<20170927125606.65dc514d.cohuck@redhat.com>","From":"Christian Borntraeger ","Date":"Wed, 27 Sep 2017 12:59:35 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.0","MIME-Version":"1.0","In-Reply-To":"<20170927125606.65dc514d.cohuck@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-TM-AS-GCONF":"00","x-cbid":"17092710-0016-0000-0000-000004F08D0B","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092710-0017-0000-0000-0000282ADD0D","Message-Id":"<14df9ad6-f0e9-cd51-04dd-4fe994808433@de.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-27_03:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709270155","Content-Transfer-Encoding":"quoted-printable","X-MIME-Autoconverted":"from 8bit to quoted-printable by\n\tmx0a-001b2d01.pphosted.com id v8RAwtYP045361","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.156.1","Subject":"Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for\n\t<=2.10","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pasic@linux.vnet.ibm.com, David Hildenbrand ,\n\tqemu-devel@nongnu.org, agraf@suse.de, dgilbert@redhat.com,\n\tjjherne@linux.vnet.ibm.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1776299,"web_url":"http://patchwork.ozlabs.org/comment/1776299/","msgid":"<4681e677-9e5a-4c1c-8e22-dc5c51b7286d@redhat.com>","list_archive_url":null,"date":"2017-09-27T12:21:45","subject":"Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for\n\t<=2.10","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":"On 27.09.2017 12:59, Christian Borntraeger wrote:\n> \n> \n> On 09/27/2017 12:56 PM, Cornelia Huck wrote:\n>> On Wed, 27 Sep 2017 18:25:00 +0800\n>> Yi Min Zhao wrote:\n>>\n>>> 在 2017/9/27 下午5:47, Cornelia Huck 写道:\n>>>> On Tue, 26 Sep 2017 20:40:25 +0200\n>>>> David Hildenbrand wrote:\n>>\n>>>>> I'd really really really (did I mention really?) favor something like a\n>>>>> dummy device, because we could easily handle the !CONFIG_PCI case then.\n>>>>>\n>>>>> All these compat options and conditions will kill us someday... we're\n>>>>> already patching around that whole stuff way too much.\n>>>>>\n>>>>> If we ever unconditionally created a device, we should keep doing so. \n>>>> Yes, that whole thing is horrible, especially interaction with compat\n>>>> machines.\n>>>>\n>>>> Do you have an idea on how to create such a dummy device (without\n>>>> having to effectively copy a lot of configured-out code)?\n>>>>\n>>>> \n>>> How about in s390_pcihost_hot_plug() we check s390_has_feat(zpci)?\n>>> If no zpci feature, we avoid plugging any pci device.\n>>> Then we could always create phb.\n>>> I think pcibus's vmstate is only data to migrate.\n>>\n>> That's still problematic if CONFIG_PCI is off. I currently don't have a\n>> better idea than either disallowing compat machines on builds without\n>> pci, or using a dummy device...\n> \n> For this particular case your initial patch might be less problematic than\n> a dummy device, because the code that does the migration is NOT contained\n> in s390 specific code but in common PCI code instead. We would need to keep\n> the dummy device always in a way that it will work with the common PCI\n> code.\n> \n\nInteresting, so how is migration then handled for e.g. x86 or other\narchitectures that can work without CONFIG_PCI? I assume their migration\nshould also break?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2H5V5wtmz9tXT\n\tfor ;\n\tWed, 27 Sep 2017 22:22:38 +1000 (AEST)","from localhost ([::1]:54587 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxBMK-0002gd-Qe\n\tfor incoming@patchwork.ozlabs.org; Wed, 27 Sep 2017 08:22:36 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:40494)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxBLf-0002eR-5I\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 08:21:56 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxBLZ-0003v6-8x\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 08:21:55 -0400","from mx1.redhat.com ([209.132.183.28]:41098)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dxBLZ-0003uj-2g\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 08:21:49 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 18A25C058EA2;\n\tWed, 27 Sep 2017 12:21:48 +0000 (UTC)","from [10.36.118.1] (unknown [10.36.118.1])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 3B7377F56E;\n\tWed, 27 Sep 2017 12:21:46 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 18A25C058EA2","To":"Christian Borntraeger ,\n\tCornelia Huck ,\n\tYi Min Zhao ","References":"<20170926162058.30772-1-cohuck@redhat.com>\n\t<20170926162058.30772-2-cohuck@redhat.com>\n\t<338c8565-691e-a8bc-d8a6-3637ce13701d@redhat.com>\n\t<20170927114717.72bd69f8.cohuck@redhat.com>\n\t\n\t<20170927125606.65dc514d.cohuck@redhat.com>\n\t<14df9ad6-f0e9-cd51-04dd-4fe994808433@de.ibm.com>","From":"David Hildenbrand ","Organization":"Red Hat GmbH","Message-ID":"<4681e677-9e5a-4c1c-8e22-dc5c51b7286d@redhat.com>","Date":"Wed, 27 Sep 2017 14:21:45 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<14df9ad6-f0e9-cd51-04dd-4fe994808433@de.ibm.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tWed, 27 Sep 2017 12:21:48 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for\n\t<=2.10","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pasic@linux.vnet.ibm.com, dgilbert@redhat.com, qemu-devel@nongnu.org,\n\tjjherne@linux.vnet.ibm.com, agraf@suse.de","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1776300,"web_url":"http://patchwork.ozlabs.org/comment/1776300/","msgid":"<090b28f2-de30-20ff-8458-2eb8184fcaeb@de.ibm.com>","list_archive_url":null,"date":"2017-09-27T12:26:50","subject":"Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for\n\t<=2.10","submitter":{"id":590,"url":"http://patchwork.ozlabs.org/api/people/590/","name":"Christian Borntraeger","email":"borntraeger@de.ibm.com"},"content":"On 09/27/2017 02:21 PM, David Hildenbrand wrote:\n> On 27.09.2017 12:59, Christian Borntraeger wrote:\n>>\n>>\n>> On 09/27/2017 12:56 PM, Cornelia Huck wrote:\n>>> On Wed, 27 Sep 2017 18:25:00 +0800\n>>> Yi Min Zhao wrote:\n>>>\n>>>> 在 2017/9/27 下午5:47, Cornelia Huck 写道:\n>>>>> On Tue, 26 Sep 2017 20:40:25 +0200\n>>>>> David Hildenbrand wrote:\n>>>\n>>>>>> I'd really really really (did I mention really?) favor something like a\n>>>>>> dummy device, because we could easily handle the !CONFIG_PCI case then.\n>>>>>>\n>>>>>> All these compat options and conditions will kill us someday... we're\n>>>>>> already patching around that whole stuff way too much.\n>>>>>>\n>>>>>> If we ever unconditionally created a device, we should keep doing so. \n>>>>> Yes, that whole thing is horrible, especially interaction with compat\n>>>>> machines.\n>>>>>\n>>>>> Do you have an idea on how to create such a dummy device (without\n>>>>> having to effectively copy a lot of configured-out code)?\n>>>>>\n>>>>> \n>>>> How about in s390_pcihost_hot_plug() we check s390_has_feat(zpci)?\n>>>> If no zpci feature, we avoid plugging any pci device.\n>>>> Then we could always create phb.\n>>>> I think pcibus's vmstate is only data to migrate.\n>>>\n>>> That's still problematic if CONFIG_PCI is off. I currently don't have a\n>>> better idea than either disallowing compat machines on builds without\n>>> pci, or using a dummy device...\n>>\n>> For this particular case your initial patch might be less problematic than\n>> a dummy device, because the code that does the migration is NOT contained\n>> in s390 specific code but in common PCI code instead. We would need to keep\n>> the dummy device always in a way that it will work with the common PCI\n>> code.\n>>\n> \n> Interesting, so how is migration then handled for e.g. x86 or other\n> architectures that can work without CONFIG_PCI? I assume their migration\n> should also break?\n\nIf you migrate from a QEMU with CONFIG_PCI to a QEMU without CONFIG_PCI \nI assume it will break. But maybe there is really some clever way to\ndo the right thing. \n\nPS: Is really anybody disabling CONFIG_PCI and why?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2HCD5gg6z9tXT\n\tfor ;\n\tWed, 27 Sep 2017 22:27:34 +1000 (AEST)","from localhost ([::1]:54603 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxBR6-0004g5-9C\n\tfor incoming@patchwork.ozlabs.org; Wed, 27 Sep 2017 08:27:32 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41822)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxBQh-0004fy-SW\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 08:27:15 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxBQc-00065O-4D\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 08:27:07 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1]:58824)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dxBQb-00065C-QS\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 08:27:02 -0400","from pps.filterd (m0098399.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8RCOTCX048226\n\tfor ; Wed, 27 Sep 2017 08:26:57 -0400","from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d8bcaaeff-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Wed, 27 Sep 2017 08:26:56 -0400","from localhost\n\tby e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tWed, 27 Sep 2017 13:26:54 +0100","from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198)\n\tby e06smtp12.uk.ibm.com (192.168.101.142) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tWed, 27 Sep 2017 13:26:51 +0100","from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com\n\t[9.149.105.58])\n\tby b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8RCQpF218415800; Wed, 27 Sep 2017 12:26:51 GMT","from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 701954C044;\n\tWed, 27 Sep 2017 13:23:06 +0100 (BST)","from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 2E6964C04E;\n\tWed, 27 Sep 2017 13:23:06 +0100 (BST)","from oc7330422307.ibm.com (unknown [9.152.224.56])\n\tby d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tWed, 27 Sep 2017 13:23:06 +0100 (BST)"],"To":"David Hildenbrand , Cornelia Huck , \n\tYi Min Zhao ","References":"<20170926162058.30772-1-cohuck@redhat.com>\n\t<20170926162058.30772-2-cohuck@redhat.com>\n\t<338c8565-691e-a8bc-d8a6-3637ce13701d@redhat.com>\n\t<20170927114717.72bd69f8.cohuck@redhat.com>\n\t\n\t<20170927125606.65dc514d.cohuck@redhat.com>\n\t<14df9ad6-f0e9-cd51-04dd-4fe994808433@de.ibm.com>\n\t<4681e677-9e5a-4c1c-8e22-dc5c51b7286d@redhat.com>","From":"Christian Borntraeger ","Date":"Wed, 27 Sep 2017 14:26:50 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.0","MIME-Version":"1.0","In-Reply-To":"<4681e677-9e5a-4c1c-8e22-dc5c51b7286d@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-TM-AS-GCONF":"00","x-cbid":"17092712-0008-0000-0000-0000049A9051","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092712-0009-0000-0000-00001E2BDE7B","Message-Id":"<090b28f2-de30-20ff-8458-2eb8184fcaeb@de.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-27_03:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709270174","Content-Transfer-Encoding":"quoted-printable","X-MIME-Autoconverted":"from 8bit to quoted-printable by\n\tmx0a-001b2d01.pphosted.com id v8RCOTCX048226","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.156.1","Subject":"Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for\n\t<=2.10","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pasic@linux.vnet.ibm.com, dgilbert@redhat.com, qemu-devel@nongnu.org,\n\tjjherne@linux.vnet.ibm.com, agraf@suse.de","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1776393,"web_url":"http://patchwork.ozlabs.org/comment/1776393/","msgid":"<20170927142837.GB2108@work-vm>","list_archive_url":null,"date":"2017-09-27T14:28:38","subject":"Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for\n\t<=2.10","submitter":{"id":48102,"url":"http://patchwork.ozlabs.org/api/people/48102/","name":"Dr. David Alan Gilbert","email":"dgilbert@redhat.com"},"content":"* David Hildenbrand (david@redhat.com) wrote:\n> On 27.09.2017 12:59, Christian Borntraeger wrote:\n> > \n> > \n> > On 09/27/2017 12:56 PM, Cornelia Huck wrote:\n> >> On Wed, 27 Sep 2017 18:25:00 +0800\n> >> Yi Min Zhao wrote:\n> >>\n> >>> 在 2017/9/27 下午5:47, Cornelia Huck 写道:\n> >>>> On Tue, 26 Sep 2017 20:40:25 +0200\n> >>>> David Hildenbrand wrote:\n> >>\n> >>>>> I'd really really really (did I mention really?) favor something like a\n> >>>>> dummy device, because we could easily handle the !CONFIG_PCI case then.\n> >>>>>\n> >>>>> All these compat options and conditions will kill us someday... we're\n> >>>>> already patching around that whole stuff way too much.\n> >>>>>\n> >>>>> If we ever unconditionally created a device, we should keep doing so. \n> >>>> Yes, that whole thing is horrible, especially interaction with compat\n> >>>> machines.\n> >>>>\n> >>>> Do you have an idea on how to create such a dummy device (without\n> >>>> having to effectively copy a lot of configured-out code)?\n> >>>>\n> >>>> \n> >>> How about in s390_pcihost_hot_plug() we check s390_has_feat(zpci)?\n> >>> If no zpci feature, we avoid plugging any pci device.\n> >>> Then we could always create phb.\n> >>> I think pcibus's vmstate is only data to migrate.\n> >>\n> >> That's still problematic if CONFIG_PCI is off. I currently don't have a\n> >> better idea than either disallowing compat machines on builds without\n> >> pci, or using a dummy device...\n> > \n> > For this particular case your initial patch might be less problematic than\n> > a dummy device, because the code that does the migration is NOT contained\n> > in s390 specific code but in common PCI code instead. We would need to keep\n> > the dummy device always in a way that it will work with the common PCI\n> > code.\n> > \n> \n> Interesting, so how is migration then handled for e.g. x86 or other\n> architectures that can work without CONFIG_PCI? I assume their migration\n> should also break?\n\nIt's tied to machine-type; the x86 i440fx and q35 machine types have\nPCI; you can't disable PCI while still having those machine types.\n(I don't know if you can disable PCI at all on x86)\n\nDave\n\n> -- \n> \n> Thanks,\n> \n> David\n--\nDr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=dgilbert@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2Kw11jSCz9t3x\n\tfor ;\n\tThu, 28 Sep 2017 00:29:31 +1000 (AEST)","from localhost ([::1]:55076 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxDL5-000391-MO\n\tfor incoming@patchwork.ozlabs.org; Wed, 27 Sep 2017 10:29:27 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:49691)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxDKc-000351-Mk\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 10:29:04 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxDKW-00032f-Oi\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 10:28:58 -0400","from mx1.redhat.com ([209.132.183.28]:16703)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dxDKW-000325-FW\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 10:28:52 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 52C35A34C7;\n\tWed, 27 Sep 2017 14:28:51 +0000 (UTC)","from work-vm (ovpn-116-234.ams2.redhat.com [10.36.116.234])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 665A388D99;\n\tWed, 27 Sep 2017 14:28:42 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 52C35A34C7","Date":"Wed, 27 Sep 2017 15:28:38 +0100","From":"\"Dr. David Alan Gilbert\" ","To":"David Hildenbrand ","Message-ID":"<20170927142837.GB2108@work-vm>","References":"<20170926162058.30772-1-cohuck@redhat.com>\n\t<20170926162058.30772-2-cohuck@redhat.com>\n\t<338c8565-691e-a8bc-d8a6-3637ce13701d@redhat.com>\n\t<20170927114717.72bd69f8.cohuck@redhat.com>\n\t\n\t<20170927125606.65dc514d.cohuck@redhat.com>\n\t<14df9ad6-f0e9-cd51-04dd-4fe994808433@de.ibm.com>\n\t<4681e677-9e5a-4c1c-8e22-dc5c51b7286d@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<4681e677-9e5a-4c1c-8e22-dc5c51b7286d@redhat.com>","User-Agent":"Mutt/1.9.0 (2017-09-02)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tWed, 27 Sep 2017 14:28:51 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for\n\t<=2.10","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pasic@linux.vnet.ibm.com, Yi Min Zhao ,\n\tCornelia Huck , qemu-devel@nongnu.org,\n\tagraf@suse.de, Christian Borntraeger ,\n\tjjherne@linux.vnet.ibm.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1776406,"web_url":"http://patchwork.ozlabs.org/comment/1776406/","msgid":"<20170927164644.42205e6f.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-27T14:46:44","subject":"Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for\n\t<=2.10","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Wed, 27 Sep 2017 15:28:38 +0100\n\"Dr. David Alan Gilbert\" wrote:\n\n> * David Hildenbrand (david@redhat.com) wrote:\n> > On 27.09.2017 12:59, Christian Borntraeger wrote: \n> > > \n> > > \n> > > On 09/27/2017 12:56 PM, Cornelia Huck wrote: \n> > >> On Wed, 27 Sep 2017 18:25:00 +0800\n> > >> Yi Min Zhao wrote:\n> > >> \n> > >>> 在 2017/9/27 下午5:47, Cornelia Huck 写道: \n> > >>>> On Tue, 26 Sep 2017 20:40:25 +0200\n> > >>>> David Hildenbrand wrote: \n> > >> \n> > >>>>> I'd really really really (did I mention really?) favor something like a\n> > >>>>> dummy device, because we could easily handle the !CONFIG_PCI case then.\n> > >>>>>\n> > >>>>> All these compat options and conditions will kill us someday... we're\n> > >>>>> already patching around that whole stuff way too much.\n> > >>>>>\n> > >>>>> If we ever unconditionally created a device, we should keep doing so. \n> > >>>> Yes, that whole thing is horrible, especially interaction with compat\n> > >>>> machines.\n> > >>>>\n> > >>>> Do you have an idea on how to create such a dummy device (without\n> > >>>> having to effectively copy a lot of configured-out code)?\n> > >>>>\n> > >>>> \n> > >>> How about in s390_pcihost_hot_plug() we check s390_has_feat(zpci)?\n> > >>> If no zpci feature, we avoid plugging any pci device.\n> > >>> Then we could always create phb.\n> > >>> I think pcibus's vmstate is only data to migrate. \n> > >>\n> > >> That's still problematic if CONFIG_PCI is off. I currently don't have a\n> > >> better idea than either disallowing compat machines on builds without\n> > >> pci, or using a dummy device... \n> > > \n> > > For this particular case your initial patch might be less problematic than\n> > > a dummy device, because the code that does the migration is NOT contained\n> > > in s390 specific code but in common PCI code instead. We would need to keep\n> > > the dummy device always in a way that it will work with the common PCI\n> > > code.\n> > > \n> > \n> > Interesting, so how is migration then handled for e.g. x86 or other\n> > architectures that can work without CONFIG_PCI? I assume their migration\n> > should also break? \n> \n> It's tied to machine-type; the x86 i440fx and q35 machine types have\n> PCI; you can't disable PCI while still having those machine types.\n> (I don't know if you can disable PCI at all on x86)\n\nUgh, that sounds like we need two machine types on s390x as well\n(s390x-ccw-virtio and s390x-ccw-virtio-nopci or so), built\nconditionally. That whole zpci detanglement is looking worse and\nworse :(","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2LJq4wKvz9tXs\n\tfor ;\n\tThu, 28 Sep 2017 00:47:37 +1000 (AEST)","from localhost ([::1]:55122 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxDcc-0005uA-2f\n\tfor incoming@patchwork.ozlabs.org; Wed, 27 Sep 2017 10:47:34 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:54485)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxDc3-0005sb-5E\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 10:47:00 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxDbz-0003vL-6P\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 10:46:59 -0400","from mx1.redhat.com ([209.132.183.28]:33518)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dxDby-0003vA-Th\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 10:46:55 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C8530883BF;\n\tWed, 27 Sep 2017 14:46:53 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 89E2A8923D;\n\tWed, 27 Sep 2017 14:46:46 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com C8530883BF","Date":"Wed, 27 Sep 2017 16:46:44 +0200","From":"Cornelia Huck ","To":"\"Dr. David Alan Gilbert\" ","Message-ID":"<20170927164644.42205e6f.cohuck@redhat.com>","In-Reply-To":"<20170927142837.GB2108@work-vm>","References":"<20170926162058.30772-1-cohuck@redhat.com>\n\t<20170926162058.30772-2-cohuck@redhat.com>\n\t<338c8565-691e-a8bc-d8a6-3637ce13701d@redhat.com>\n\t<20170927114717.72bd69f8.cohuck@redhat.com>\n\t\n\t<20170927125606.65dc514d.cohuck@redhat.com>\n\t<14df9ad6-f0e9-cd51-04dd-4fe994808433@de.ibm.com>\n\t<4681e677-9e5a-4c1c-8e22-dc5c51b7286d@redhat.com>\n\t<20170927142837.GB2108@work-vm>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"quoted-printable","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tWed, 27 Sep 2017 14:46:54 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for\n\t<=2.10","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pasic@linux.vnet.ibm.com, Yi Min Zhao ,\n\tDavid Hildenbrand , agraf@suse.de,\n\tqemu-devel@nongnu.org, Christian Borntraeger ,\n\tjjherne@linux.vnet.ibm.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1776407,"web_url":"http://patchwork.ozlabs.org/comment/1776407/","msgid":"<20170927144927.GC2108@work-vm>","list_archive_url":null,"date":"2017-09-27T14:49:27","subject":"Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for\n\t<=2.10","submitter":{"id":48102,"url":"http://patchwork.ozlabs.org/api/people/48102/","name":"Dr. David Alan Gilbert","email":"dgilbert@redhat.com"},"content":"* Cornelia Huck (cohuck@redhat.com) wrote:\n> On Wed, 27 Sep 2017 15:28:38 +0100\n> \"Dr. David Alan Gilbert\" wrote:\n> \n> > * David Hildenbrand (david@redhat.com) wrote:\n> > > On 27.09.2017 12:59, Christian Borntraeger wrote: \n> > > > \n> > > > \n> > > > On 09/27/2017 12:56 PM, Cornelia Huck wrote: \n> > > >> On Wed, 27 Sep 2017 18:25:00 +0800\n> > > >> Yi Min Zhao wrote:\n> > > >> \n> > > >>> 在 2017/9/27 下午5:47, Cornelia Huck 写道: \n> > > >>>> On Tue, 26 Sep 2017 20:40:25 +0200\n> > > >>>> David Hildenbrand wrote: \n> > > >> \n> > > >>>>> I'd really really really (did I mention really?) favor something like a\n> > > >>>>> dummy device, because we could easily handle the !CONFIG_PCI case then.\n> > > >>>>>\n> > > >>>>> All these compat options and conditions will kill us someday... we're\n> > > >>>>> already patching around that whole stuff way too much.\n> > > >>>>>\n> > > >>>>> If we ever unconditionally created a device, we should keep doing so. \n> > > >>>> Yes, that whole thing is horrible, especially interaction with compat\n> > > >>>> machines.\n> > > >>>>\n> > > >>>> Do you have an idea on how to create such a dummy device (without\n> > > >>>> having to effectively copy a lot of configured-out code)?\n> > > >>>>\n> > > >>>> \n> > > >>> How about in s390_pcihost_hot_plug() we check s390_has_feat(zpci)?\n> > > >>> If no zpci feature, we avoid plugging any pci device.\n> > > >>> Then we could always create phb.\n> > > >>> I think pcibus's vmstate is only data to migrate. \n> > > >>\n> > > >> That's still problematic if CONFIG_PCI is off. I currently don't have a\n> > > >> better idea than either disallowing compat machines on builds without\n> > > >> pci, or using a dummy device... \n> > > > \n> > > > For this particular case your initial patch might be less problematic than\n> > > > a dummy device, because the code that does the migration is NOT contained\n> > > > in s390 specific code but in common PCI code instead. We would need to keep\n> > > > the dummy device always in a way that it will work with the common PCI\n> > > > code.\n> > > > \n> > > \n> > > Interesting, so how is migration then handled for e.g. x86 or other\n> > > architectures that can work without CONFIG_PCI? I assume their migration\n> > > should also break? \n> > \n> > It's tied to machine-type; the x86 i440fx and q35 machine types have\n> > PCI; you can't disable PCI while still having those machine types.\n> > (I don't know if you can disable PCI at all on x86)\n> \n> Ugh, that sounds like we need two machine types on s390x as well\n> (s390x-ccw-virtio and s390x-ccw-virtio-nopci or so), built\n> conditionally. That whole zpci detanglement is looking worse and\n> worse :(\n\nWell fundamentally the migration expects to migrate something into\nthe same shaped hole on the destination; if you've got a lump of PCI\nconfig on the source there's got to be somewhere for it to fit on the\ndestination.\nNow, if PCI is actually pretty rare; then you might be able to make\nthe host-pci bridge a normal device and not include it in any\nmachine type; that way those who want PCI can just instantiate\nthe host-pci bridge, and those who don't want it just stick with\nthe base machine type.\n\nDave\n--\nDr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=dgilbert@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2LMl69Vnz9tXs\n\tfor ;\n\tThu, 28 Sep 2017 00:50:11 +1000 (AEST)","from localhost ([::1]:55129 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxDf7-00074Y-Lb\n\tfor incoming@patchwork.ozlabs.org; Wed, 27 Sep 2017 10:50:09 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:55214)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxDec-0006zX-OH\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 10:49:44 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxDeZ-0005bS-I2\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 10:49:38 -0400","from mx1.redhat.com ([209.132.183.28]:43780)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dxDeZ-0005b6-8V\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 10:49:35 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 18BF9C058EAE;\n\tWed, 27 Sep 2017 14:49:34 +0000 (UTC)","from work-vm (ovpn-116-234.ams2.redhat.com [10.36.116.234])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 482ADBAE94;\n\tWed, 27 Sep 2017 14:49:29 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 18BF9C058EAE","Date":"Wed, 27 Sep 2017 15:49:27 +0100","From":"\"Dr. David Alan Gilbert\" ","To":"Cornelia Huck ","Message-ID":"<20170927144927.GC2108@work-vm>","References":"<20170926162058.30772-1-cohuck@redhat.com>\n\t<20170926162058.30772-2-cohuck@redhat.com>\n\t<338c8565-691e-a8bc-d8a6-3637ce13701d@redhat.com>\n\t<20170927114717.72bd69f8.cohuck@redhat.com>\n\t\n\t<20170927125606.65dc514d.cohuck@redhat.com>\n\t<14df9ad6-f0e9-cd51-04dd-4fe994808433@de.ibm.com>\n\t<4681e677-9e5a-4c1c-8e22-dc5c51b7286d@redhat.com>\n\t<20170927142837.GB2108@work-vm>\n\t<20170927164644.42205e6f.cohuck@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20170927164644.42205e6f.cohuck@redhat.com>","User-Agent":"Mutt/1.9.0 (2017-09-02)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tWed, 27 Sep 2017 14:49:34 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for\n\t<=2.10","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pasic@linux.vnet.ibm.com, Yi Min Zhao ,\n\tDavid Hildenbrand , agraf@suse.de,\n\tqemu-devel@nongnu.org, Christian Borntraeger ,\n\tjjherne@linux.vnet.ibm.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1776414,"web_url":"http://patchwork.ozlabs.org/comment/1776414/","msgid":"<20170927170346.68ca0cd8.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-27T15:03:46","subject":"Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for\n\t<=2.10","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Wed, 27 Sep 2017 15:49:27 +0100\n\"Dr. David Alan Gilbert\" wrote:\n\n> * Cornelia Huck (cohuck@redhat.com) wrote:\n> > On Wed, 27 Sep 2017 15:28:38 +0100\n> > \"Dr. David Alan Gilbert\" wrote:\n> > \n> > > * David Hildenbrand (david@redhat.com) wrote: \n> > > > On 27.09.2017 12:59, Christian Borntraeger wrote: \n> > > > > \n> > > > > \n> > > > > On 09/27/2017 12:56 PM, Cornelia Huck wrote: \n> > > > >> On Wed, 27 Sep 2017 18:25:00 +0800\n> > > > >> Yi Min Zhao wrote:\n> > > > >> \n> > > > >>> 在 2017/9/27 下午5:47, Cornelia Huck 写道: \n> > > > >>>> On Tue, 26 Sep 2017 20:40:25 +0200\n> > > > >>>> David Hildenbrand wrote: \n> > > > >> \n> > > > >>>>> I'd really really really (did I mention really?) favor something like a\n> > > > >>>>> dummy device, because we could easily handle the !CONFIG_PCI case then.\n> > > > >>>>>\n> > > > >>>>> All these compat options and conditions will kill us someday... we're\n> > > > >>>>> already patching around that whole stuff way too much.\n> > > > >>>>>\n> > > > >>>>> If we ever unconditionally created a device, we should keep doing so. \n> > > > >>>> Yes, that whole thing is horrible, especially interaction with compat\n> > > > >>>> machines.\n> > > > >>>>\n> > > > >>>> Do you have an idea on how to create such a dummy device (without\n> > > > >>>> having to effectively copy a lot of configured-out code)?\n> > > > >>>>\n> > > > >>>> \n> > > > >>> How about in s390_pcihost_hot_plug() we check s390_has_feat(zpci)?\n> > > > >>> If no zpci feature, we avoid plugging any pci device.\n> > > > >>> Then we could always create phb.\n> > > > >>> I think pcibus's vmstate is only data to migrate. \n> > > > >>\n> > > > >> That's still problematic if CONFIG_PCI is off. I currently don't have a\n> > > > >> better idea than either disallowing compat machines on builds without\n> > > > >> pci, or using a dummy device... \n> > > > > \n> > > > > For this particular case your initial patch might be less problematic than\n> > > > > a dummy device, because the code that does the migration is NOT contained\n> > > > > in s390 specific code but in common PCI code instead. We would need to keep\n> > > > > the dummy device always in a way that it will work with the common PCI\n> > > > > code.\n> > > > > \n> > > > \n> > > > Interesting, so how is migration then handled for e.g. x86 or other\n> > > > architectures that can work without CONFIG_PCI? I assume their migration\n> > > > should also break? \n> > > \n> > > It's tied to machine-type; the x86 i440fx and q35 machine types have\n> > > PCI; you can't disable PCI while still having those machine types.\n> > > (I don't know if you can disable PCI at all on x86) \n> > \n> > Ugh, that sounds like we need two machine types on s390x as well\n> > (s390x-ccw-virtio and s390x-ccw-virtio-nopci or so), built\n> > conditionally. That whole zpci detanglement is looking worse and\n> > worse :( \n> \n> Well fundamentally the migration expects to migrate something into\n> the same shaped hole on the destination; if you've got a lump of PCI\n> config on the source there's got to be somewhere for it to fit on the\n> destination.\n> Now, if PCI is actually pretty rare; then you might be able to make\n> the host-pci bridge a normal device and not include it in any\n> machine type; that way those who want PCI can just instantiate\n> the host-pci bridge, and those who don't want it just stick with\n> the base machine type.\n\nI fear that ship has already sailed; the s390-ccw-virtio machine type\nhas been instantiating a phb for quite some time, which means we have\nto drag this on in the compat machines...","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2Lhg2Z4fz9tXy\n\tfor ;\n\tThu, 28 Sep 2017 01:04:36 +1000 (AEST)","from localhost ([::1]:55178 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxDsw-00051h-Bj\n\tfor incoming@patchwork.ozlabs.org; Wed, 27 Sep 2017 11:04:26 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:58587)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxDsU-00051W-UG\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 11:04:02 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxDsQ-00056u-Oy\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 11:03:58 -0400","from mx1.redhat.com ([209.132.183.28]:37912)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dxDsQ-00056P-Fi\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 11:03:54 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 77DE13B725;\n\tWed, 27 Sep 2017 15:03:53 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 8DF1BE816E;\n\tWed, 27 Sep 2017 15:03:48 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 77DE13B725","Date":"Wed, 27 Sep 2017 17:03:46 +0200","From":"Cornelia Huck ","To":"\"Dr. David Alan Gilbert\" ","Message-ID":"<20170927170346.68ca0cd8.cohuck@redhat.com>","In-Reply-To":"<20170927144927.GC2108@work-vm>","References":"<20170926162058.30772-1-cohuck@redhat.com>\n\t<20170926162058.30772-2-cohuck@redhat.com>\n\t<338c8565-691e-a8bc-d8a6-3637ce13701d@redhat.com>\n\t<20170927114717.72bd69f8.cohuck@redhat.com>\n\t\n\t<20170927125606.65dc514d.cohuck@redhat.com>\n\t<14df9ad6-f0e9-cd51-04dd-4fe994808433@de.ibm.com>\n\t<4681e677-9e5a-4c1c-8e22-dc5c51b7286d@redhat.com>\n\t<20170927142837.GB2108@work-vm>\n\t<20170927164644.42205e6f.cohuck@redhat.com>\n\t<20170927144927.GC2108@work-vm>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"quoted-printable","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tWed, 27 Sep 2017 15:03:53 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for\n\t<=2.10","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pasic@linux.vnet.ibm.com, Yi Min Zhao ,\n\tDavid Hildenbrand , agraf@suse.de,\n\tqemu-devel@nongnu.org, Christian Borntraeger ,\n\tjjherne@linux.vnet.ibm.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1776947,"web_url":"http://patchwork.ozlabs.org/comment/1776947/","msgid":"<9c8c2596-c4cf-41ad-7228-0ed598cf65cd@de.ibm.com>","list_archive_url":null,"date":"2017-09-28T10:34:29","subject":"Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for\n\t<=2.10","submitter":{"id":590,"url":"http://patchwork.ozlabs.org/api/people/590/","name":"Christian Borntraeger","email":"borntraeger@de.ibm.com"},"content":"On 09/27/2017 05:03 PM, Cornelia Huck wrote:\n> On Wed, 27 Sep 2017 15:49:27 +0100\n> \"Dr. David Alan Gilbert\" wrote:\n> \n>> * Cornelia Huck (cohuck@redhat.com) wrote:\n>>> On Wed, 27 Sep 2017 15:28:38 +0100\n>>> \"Dr. David Alan Gilbert\" wrote:\n>>> \n>>>> * David Hildenbrand (david@redhat.com) wrote: \n>>>>> On 27.09.2017 12:59, Christian Borntraeger wrote: \n>>>>>>\n>>>>>>\n>>>>>> On 09/27/2017 12:56 PM, Cornelia Huck wrote: \n>>>>>>> On Wed, 27 Sep 2017 18:25:00 +0800\n>>>>>>> Yi Min Zhao wrote:\n>>>>>>> \n>>>>>>>> 在 2017/9/27 下午5:47, Cornelia Huck 写道: \n>>>>>>>>> On Tue, 26 Sep 2017 20:40:25 +0200\n>>>>>>>>> David Hildenbrand wrote: \n>>>>>>> \n>>>>>>>>>> I'd really really really (did I mention really?) favor something like a\n>>>>>>>>>> dummy device, because we could easily handle the !CONFIG_PCI case then.\n>>>>>>>>>>\n>>>>>>>>>> All these compat options and conditions will kill us someday... we're\n>>>>>>>>>> already patching around that whole stuff way too much.\n>>>>>>>>>>\n>>>>>>>>>> If we ever unconditionally created a device, we should keep doing so. \n>>>>>>>>> Yes, that whole thing is horrible, especially interaction with compat\n>>>>>>>>> machines.\n>>>>>>>>>\n>>>>>>>>> Do you have an idea on how to create such a dummy device (without\n>>>>>>>>> having to effectively copy a lot of configured-out code)?\n>>>>>>>>>\n>>>>>>>>> \n>>>>>>>> How about in s390_pcihost_hot_plug() we check s390_has_feat(zpci)?\n>>>>>>>> If no zpci feature, we avoid plugging any pci device.\n>>>>>>>> Then we could always create phb.\n>>>>>>>> I think pcibus's vmstate is only data to migrate. \n>>>>>>>\n>>>>>>> That's still problematic if CONFIG_PCI is off. I currently don't have a\n>>>>>>> better idea than either disallowing compat machines on builds without\n>>>>>>> pci, or using a dummy device... \n>>>>>>\n>>>>>> For this particular case your initial patch might be less problematic than\n>>>>>> a dummy device, because the code that does the migration is NOT contained\n>>>>>> in s390 specific code but in common PCI code instead. We would need to keep\n>>>>>> the dummy device always in a way that it will work with the common PCI\n>>>>>> code.\n>>>>>> \n>>>>>\n>>>>> Interesting, so how is migration then handled for e.g. x86 or other\n>>>>> architectures that can work without CONFIG_PCI? I assume their migration\n>>>>> should also break? \n>>>>\n>>>> It's tied to machine-type; the x86 i440fx and q35 machine types have\n>>>> PCI; you can't disable PCI while still having those machine types.\n>>>> (I don't know if you can disable PCI at all on x86) \n>>>\n>>> Ugh, that sounds like we need two machine types on s390x as well\n>>> (s390x-ccw-virtio and s390x-ccw-virtio-nopci or so), built\n>>> conditionally. That whole zpci detanglement is looking worse and\n>>> worse :( \n>>\n>> Well fundamentally the migration expects to migrate something into\n>> the same shaped hole on the destination; if you've got a lump of PCI\n>> config on the source there's got to be somewhere for it to fit on the\n>> destination.\n>> Now, if PCI is actually pretty rare; then you might be able to make\n>> the host-pci bridge a normal device and not include it in any\n>> machine type; that way those who want PCI can just instantiate\n>> the host-pci bridge, and those who don't want it just stick with\n>> the base machine type.\n> \n> I fear that ship has already sailed; the s390-ccw-virtio machine type\n> has been instantiating a phb for quite some time, which means we have\n> to drag this on in the compat machines...\n\nIn the end that means that you should revert\n\ncommit d32bd032d8fde41281aae34c16a4aa97e9acfeac\nAuthor: Cornelia Huck \nAuthorDate: Thu Jul 6 17:21:52 2017 +0200\nCommit: Cornelia Huck \nCommitDate: Wed Aug 30 18:23:25 2017 +0200\n\n s390x/ccw: create s390 phb conditionally\n\nto keep s390-ccw-virtio clean proper.\n\nIf you want to have PCI disabled, you can do you in a machine like \ns390-rhelx.y.z or whatever.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2rgB6gVnz9tXj\n\tfor ;\n\tThu, 28 Sep 2017 20:35:18 +1000 (AEST)","from localhost ([::1]:58341 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxWA1-0002SU-25\n\tfor incoming@patchwork.ozlabs.org; Thu, 28 Sep 2017 06:35:17 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:47444)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxW9b-0002S2-Fp\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 06:34:52 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxW9S-0005ua-8q\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 06:34:47 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1]:59588)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dxW9S-0005u7-0f\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 06:34:42 -0400","from pps.filterd (m0098404.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8SAY7Q2000625\n\tfor ; Thu, 28 Sep 2017 06:34:37 -0400","from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d8s38u552-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Thu, 28 Sep 2017 06:34:36 -0400","from localhost\n\tby e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tThu, 28 Sep 2017 11:34:34 +0100","from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196)\n\tby e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tThu, 28 Sep 2017 11:34:30 +0100","from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com\n\t[9.149.105.61])\n\tby b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8SAYUQX23330826; Thu, 28 Sep 2017 10:34:30 GMT","from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 6C0A811C050;\n\tThu, 28 Sep 2017 11:30:21 +0100 (BST)","from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 2B69411C04A;\n\tThu, 28 Sep 2017 11:30:21 +0100 (BST)","from oc7330422307.ibm.com (unknown [9.152.224.141])\n\tby d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tThu, 28 Sep 2017 11:30:21 +0100 (BST)"],"To":"Cornelia Huck ,\n\t\"Dr. David Alan Gilbert\" ","References":"<20170926162058.30772-1-cohuck@redhat.com>\n\t<20170926162058.30772-2-cohuck@redhat.com>\n\t<338c8565-691e-a8bc-d8a6-3637ce13701d@redhat.com>\n\t<20170927114717.72bd69f8.cohuck@redhat.com>\n\t\n\t<20170927125606.65dc514d.cohuck@redhat.com>\n\t<14df9ad6-f0e9-cd51-04dd-4fe994808433@de.ibm.com>\n\t<4681e677-9e5a-4c1c-8e22-dc5c51b7286d@redhat.com>\n\t<20170927142837.GB2108@work-vm>\n\t<20170927164644.42205e6f.cohuck@redhat.com>\n\t<20170927144927.GC2108@work-vm>\n\t<20170927170346.68ca0cd8.cohuck@redhat.com>","From":"Christian Borntraeger ","Date":"Thu, 28 Sep 2017 12:34:29 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.0","MIME-Version":"1.0","In-Reply-To":"<20170927170346.68ca0cd8.cohuck@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-TM-AS-GCONF":"00","x-cbid":"17092810-0040-0000-0000-000003FDE24C","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092810-0041-0000-0000-0000209F3373","Message-Id":"<9c8c2596-c4cf-41ad-7228-0ed598cf65cd@de.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-28_04:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709280158","Content-Transfer-Encoding":"quoted-printable","X-MIME-Autoconverted":"from 8bit to quoted-printable by\n\tmx0a-001b2d01.pphosted.com id v8SAY7Q2000625","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.156.1","Subject":"Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for\n\t<=2.10","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pasic@linux.vnet.ibm.com, Yi Min Zhao ,\n\tDavid Hildenbrand , agraf@suse.de,\n\tqemu-devel@nongnu.org, jjherne@linux.vnet.ibm.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1776953,"web_url":"http://patchwork.ozlabs.org/comment/1776953/","msgid":"","list_archive_url":null,"date":"2017-09-28T10:41:54","subject":"Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for\n\t<=2.10","submitter":{"id":590,"url":"http://patchwork.ozlabs.org/api/people/590/","name":"Christian Borntraeger","email":"borntraeger@de.ibm.com"},"content":"On 09/28/2017 12:34 PM, Christian Borntraeger wrote:\n> \n> \n> On 09/27/2017 05:03 PM, Cornelia Huck wrote:\n>> On Wed, 27 Sep 2017 15:49:27 +0100\n>> \"Dr. David Alan Gilbert\" wrote:\n>>\n>>> * Cornelia Huck (cohuck@redhat.com) wrote:\n>>>> On Wed, 27 Sep 2017 15:28:38 +0100\n>>>> \"Dr. David Alan Gilbert\" wrote:\n>>>> \n>>>>> * David Hildenbrand (david@redhat.com) wrote: \n>>>>>> On 27.09.2017 12:59, Christian Borntraeger wrote: \n>>>>>>>\n>>>>>>>\n>>>>>>> On 09/27/2017 12:56 PM, Cornelia Huck wrote: \n>>>>>>>> On Wed, 27 Sep 2017 18:25:00 +0800\n>>>>>>>> Yi Min Zhao wrote:\n>>>>>>>> \n>>>>>>>>> 在 2017/9/27 下午5:47, Cornelia Huck 写道: \n>>>>>>>>>> On Tue, 26 Sep 2017 20:40:25 +0200\n>>>>>>>>>> David Hildenbrand wrote: \n>>>>>>>> \n>>>>>>>>>>> I'd really really really (did I mention really?) favor something like a\n>>>>>>>>>>> dummy device, because we could easily handle the !CONFIG_PCI case then.\n>>>>>>>>>>>\n>>>>>>>>>>> All these compat options and conditions will kill us someday... we're\n>>>>>>>>>>> already patching around that whole stuff way too much.\n>>>>>>>>>>>\n>>>>>>>>>>> If we ever unconditionally created a device, we should keep doing so. \n>>>>>>>>>> Yes, that whole thing is horrible, especially interaction with compat\n>>>>>>>>>> machines.\n>>>>>>>>>>\n>>>>>>>>>> Do you have an idea on how to create such a dummy device (without\n>>>>>>>>>> having to effectively copy a lot of configured-out code)?\n>>>>>>>>>>\n>>>>>>>>>> \n>>>>>>>>> How about in s390_pcihost_hot_plug() we check s390_has_feat(zpci)?\n>>>>>>>>> If no zpci feature, we avoid plugging any pci device.\n>>>>>>>>> Then we could always create phb.\n>>>>>>>>> I think pcibus's vmstate is only data to migrate. \n>>>>>>>>\n>>>>>>>> That's still problematic if CONFIG_PCI is off. I currently don't have a\n>>>>>>>> better idea than either disallowing compat machines on builds without\n>>>>>>>> pci, or using a dummy device... \n>>>>>>>\n>>>>>>> For this particular case your initial patch might be less problematic than\n>>>>>>> a dummy device, because the code that does the migration is NOT contained\n>>>>>>> in s390 specific code but in common PCI code instead. We would need to keep\n>>>>>>> the dummy device always in a way that it will work with the common PCI\n>>>>>>> code.\n>>>>>>> \n>>>>>>\n>>>>>> Interesting, so how is migration then handled for e.g. x86 or other\n>>>>>> architectures that can work without CONFIG_PCI? I assume their migration\n>>>>>> should also break? \n>>>>>\n>>>>> It's tied to machine-type; the x86 i440fx and q35 machine types have\n>>>>> PCI; you can't disable PCI while still having those machine types.\n>>>>> (I don't know if you can disable PCI at all on x86) \n>>>>\n>>>> Ugh, that sounds like we need two machine types on s390x as well\n>>>> (s390x-ccw-virtio and s390x-ccw-virtio-nopci or so), built\n>>>> conditionally. That whole zpci detanglement is looking worse and\n>>>> worse :( \n>>>\n>>> Well fundamentally the migration expects to migrate something into\n>>> the same shaped hole on the destination; if you've got a lump of PCI\n>>> config on the source there's got to be somewhere for it to fit on the\n>>> destination.\n>>> Now, if PCI is actually pretty rare; then you might be able to make\n>>> the host-pci bridge a normal device and not include it in any\n>>> machine type; that way those who want PCI can just instantiate\n>>> the host-pci bridge, and those who don't want it just stick with\n>>> the base machine type.\n>>\n>> I fear that ship has already sailed; the s390-ccw-virtio machine type\n>> has been instantiating a phb for quite some time, which means we have\n>> to drag this on in the compat machines...\n> \n> In the end that means that you should revert\n> \n> commit d32bd032d8fde41281aae34c16a4aa97e9acfeac\n> Author: Cornelia Huck \n> AuthorDate: Thu Jul 6 17:21:52 2017 +0200\n> Commit: Cornelia Huck \n> CommitDate: Wed Aug 30 18:23:25 2017 +0200\n> \n> s390x/ccw: create s390 phb conditionally\n> \n> to keep s390-ccw-virtio clean proper.\n> \n> If you want to have PCI disabled, you can do you in a machine like \ntoo quick ^that^\t\t\t\t\t \n> s390-rhelx.y.z or whatever. \n\nI think we really must revert this commit.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2rsT3mFYz9t38\n\tfor ;\n\tThu, 28 Sep 2017 20:44:13 +1000 (AEST)","from localhost ([::1]:58396 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxWId-00086q-HW\n\tfor incoming@patchwork.ozlabs.org; Thu, 28 Sep 2017 06:44:11 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:51802)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxWGb-0006vq-82\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 06:42:06 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxWGX-0001ZJ-AY\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 06:42:05 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5]:41534\n\thelo=mx0a-001b2d01.pphosted.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dxWGX-0001Z7-4M\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 06:42:01 -0400","from pps.filterd (m0098413.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8SAcpPB060923\n\tfor ; Thu, 28 Sep 2017 06:42:00 -0400","from e06smtp14.uk.ibm.com (e06smtp14.uk.ibm.com [195.75.94.110])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2d8sda2r24-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Thu, 28 Sep 2017 06:42:00 -0400","from localhost\n\tby e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tThu, 28 Sep 2017 11:41:58 +0100","from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198)\n\tby e06smtp14.uk.ibm.com (192.168.101.144) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tThu, 28 Sep 2017 11:41:55 +0100","from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com\n\t[9.149.105.62])\n\tby b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8SAftVV20906030; Thu, 28 Sep 2017 10:41:55 GMT","from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 0BAE3AE045;\n\tThu, 28 Sep 2017 11:36:35 +0100 (BST)","from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id C2859AE051;\n\tThu, 28 Sep 2017 11:36:34 +0100 (BST)","from oc7330422307.ibm.com (unknown [9.152.224.141])\n\tby d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tThu, 28 Sep 2017 11:36:34 +0100 (BST)"],"From":"Christian Borntraeger ","To":"Cornelia Huck ,\n\t\"Dr. David Alan Gilbert\" ","References":"<20170926162058.30772-1-cohuck@redhat.com>\n\t<20170926162058.30772-2-cohuck@redhat.com>\n\t<338c8565-691e-a8bc-d8a6-3637ce13701d@redhat.com>\n\t<20170927114717.72bd69f8.cohuck@redhat.com>\n\t\n\t<20170927125606.65dc514d.cohuck@redhat.com>\n\t<14df9ad6-f0e9-cd51-04dd-4fe994808433@de.ibm.com>\n\t<4681e677-9e5a-4c1c-8e22-dc5c51b7286d@redhat.com>\n\t<20170927142837.GB2108@work-vm>\n\t<20170927164644.42205e6f.cohuck@redhat.com>\n\t<20170927144927.GC2108@work-vm>\n\t<20170927170346.68ca0cd8.cohuck@redhat.com>\n\t<9c8c2596-c4cf-41ad-7228-0ed598cf65cd@de.ibm.com>","Date":"Thu, 28 Sep 2017 12:41:54 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.0","MIME-Version":"1.0","In-Reply-To":"<9c8c2596-c4cf-41ad-7228-0ed598cf65cd@de.ibm.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-TM-AS-GCONF":"00","x-cbid":"17092810-0016-0000-0000-000004F0E785","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092810-0017-0000-0000-0000282B3B4F","Message-Id":"","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-28_04:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709280159","Content-Transfer-Encoding":"quoted-printable","X-MIME-Autoconverted":"from 8bit to quoted-printable by\n\tmx0b-001b2d01.pphosted.com id v8SAcpPB060923","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.158.5","Subject":"Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for\n\t<=2.10","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pasic@linux.vnet.ibm.com, Yi Min Zhao ,\n\tDavid Hildenbrand , agraf@suse.de,\n\tqemu-devel@nongnu.org, jjherne@linux.vnet.ibm.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1776985,"web_url":"http://patchwork.ozlabs.org/comment/1776985/","msgid":"<20170928140704.0cc18986.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-28T12:07:04","subject":"Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for\n\t<=2.10","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Thu, 28 Sep 2017 12:41:54 +0200\nChristian Borntraeger wrote:\n\n> On 09/28/2017 12:34 PM, Christian Borntraeger wrote:\n> > \n> > \n> > On 09/27/2017 05:03 PM, Cornelia Huck wrote: \n> >> On Wed, 27 Sep 2017 15:49:27 +0100\n> >> \"Dr. David Alan Gilbert\" wrote:\n> >> \n> >>> * Cornelia Huck (cohuck@redhat.com) wrote: \n> >>>> On Wed, 27 Sep 2017 15:28:38 +0100\n> >>>> \"Dr. David Alan Gilbert\" wrote:\n> >>>> \n> >>>>> * David Hildenbrand (david@redhat.com) wrote: \n> >>>>>> On 27.09.2017 12:59, Christian Borntraeger wrote: \n> >>>>>>>\n> >>>>>>>\n> >>>>>>> On 09/27/2017 12:56 PM, Cornelia Huck wrote: \n> >>>>>>>> On Wed, 27 Sep 2017 18:25:00 +0800\n> >>>>>>>> Yi Min Zhao wrote:\n> >>>>>>>> \n> >>>>>>>>> 在 2017/9/27 下午5:47, Cornelia Huck 写道: \n> >>>>>>>>>> On Tue, 26 Sep 2017 20:40:25 +0200\n> >>>>>>>>>> David Hildenbrand wrote: \n> >>>>>>>> \n> >>>>>>>>>>> I'd really really really (did I mention really?) favor something like a\n> >>>>>>>>>>> dummy device, because we could easily handle the !CONFIG_PCI case then.\n> >>>>>>>>>>>\n> >>>>>>>>>>> All these compat options and conditions will kill us someday... we're\n> >>>>>>>>>>> already patching around that whole stuff way too much.\n> >>>>>>>>>>>\n> >>>>>>>>>>> If we ever unconditionally created a device, we should keep doing so. \n> >>>>>>>>>> Yes, that whole thing is horrible, especially interaction with compat\n> >>>>>>>>>> machines.\n> >>>>>>>>>>\n> >>>>>>>>>> Do you have an idea on how to create such a dummy device (without\n> >>>>>>>>>> having to effectively copy a lot of configured-out code)?\n> >>>>>>>>>>\n> >>>>>>>>>> \n> >>>>>>>>> How about in s390_pcihost_hot_plug() we check s390_has_feat(zpci)?\n> >>>>>>>>> If no zpci feature, we avoid plugging any pci device.\n> >>>>>>>>> Then we could always create phb.\n> >>>>>>>>> I think pcibus's vmstate is only data to migrate. \n> >>>>>>>>\n> >>>>>>>> That's still problematic if CONFIG_PCI is off. I currently don't have a\n> >>>>>>>> better idea than either disallowing compat machines on builds without\n> >>>>>>>> pci, or using a dummy device... \n> >>>>>>>\n> >>>>>>> For this particular case your initial patch might be less problematic than\n> >>>>>>> a dummy device, because the code that does the migration is NOT contained\n> >>>>>>> in s390 specific code but in common PCI code instead. We would need to keep\n> >>>>>>> the dummy device always in a way that it will work with the common PCI\n> >>>>>>> code.\n> >>>>>>> \n> >>>>>>\n> >>>>>> Interesting, so how is migration then handled for e.g. x86 or other\n> >>>>>> architectures that can work without CONFIG_PCI? I assume their migration\n> >>>>>> should also break? \n> >>>>>\n> >>>>> It's tied to machine-type; the x86 i440fx and q35 machine types have\n> >>>>> PCI; you can't disable PCI while still having those machine types.\n> >>>>> (I don't know if you can disable PCI at all on x86) \n> >>>>\n> >>>> Ugh, that sounds like we need two machine types on s390x as well\n> >>>> (s390x-ccw-virtio and s390x-ccw-virtio-nopci or so), built\n> >>>> conditionally. That whole zpci detanglement is looking worse and\n> >>>> worse :( \n> >>>\n> >>> Well fundamentally the migration expects to migrate something into\n> >>> the same shaped hole on the destination; if you've got a lump of PCI\n> >>> config on the source there's got to be somewhere for it to fit on the\n> >>> destination.\n> >>> Now, if PCI is actually pretty rare; then you might be able to make\n> >>> the host-pci bridge a normal device and not include it in any\n> >>> machine type; that way those who want PCI can just instantiate\n> >>> the host-pci bridge, and those who don't want it just stick with\n> >>> the base machine type. \n> >>\n> >> I fear that ship has already sailed; the s390-ccw-virtio machine type\n> >> has been instantiating a phb for quite some time, which means we have\n> >> to drag this on in the compat machines... \n> > \n> > In the end that means that you should revert\n> > \n> > commit d32bd032d8fde41281aae34c16a4aa97e9acfeac\n> > Author: Cornelia Huck \n> > AuthorDate: Thu Jul 6 17:21:52 2017 +0200\n> > Commit: Cornelia Huck \n> > CommitDate: Wed Aug 30 18:23:25 2017 +0200\n> > \n> > s390x/ccw: create s390 phb conditionally\n> > \n> > to keep s390-ccw-virtio clean proper.\n> > \n> > If you want to have PCI disabled, you can do you in a machine like \n> too quick ^that^\t\t\t\t\t \n> > s390-rhelx.y.z or whatever. \n> \n> I think we really must revert this commit. \n> \n\nA set of non-pci machines looks more attractive to me. I currently have\nthe following (not yet tested):\n\nFrom 5dd282bd6e12dca0ca8252019a4c4c58e729b2c5 Mon Sep 17 00:00:00 2001\nFrom: Cornelia Huck \nDate: Thu, 28 Sep 2017 14:00:48 +0200\nSubject: [PATCH] s390x: set of -nopci machines for non-pci builds\n\nSigned-off-by: Cornelia Huck \n---\n hw/s390x/s390-virtio-ccw.c | 22 +++++++++++++++++-----\n 1 file changed, 17 insertions(+), 5 deletions(-)\n\ndiff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c\nindex 1bcb7000ab..e032857b6e 100644\n--- a/hw/s390x/s390-virtio-ccw.c\n+++ b/hw/s390x/s390-virtio-ccw.c\n@@ -266,7 +266,7 @@ static void ccw_init(MachineState *machine)\n machine->initrd_filename, \"s390-ccw.img\",\n \"s390-netboot.img\", true);\n \n- if (s390_has_feat(S390_FEAT_ZPCI)) {\n+ if (pci_available) {\n DeviceState *dev = qdev_create(NULL, TYPE_S390_PCI_HOST_BRIDGE);\n object_property_add_child(qdev_get_machine(),\n TYPE_S390_PCI_HOST_BRIDGE,\n@@ -596,9 +596,11 @@ bool css_migration_enabled(void)\n { \\\n MachineClass *mc = MACHINE_CLASS(oc); \\\n ccw_machine_##suffix##_class_options(mc); \\\n- mc->desc = \"VirtIO-ccw based S390 machine v\" verstr; \\\n+ mc->desc = pci_available ? \"VirtIO-ccw based S390 machine v\" verstr : \\\n+ \"VirtIO-ccw based S390 machine (no PCI) v\" verstr; \\\n if (latest) { \\\n- mc->alias = \"s390-ccw-virtio\"; \\\n+ mc->alias = pci_available ? \"s390-ccw-virtio\" : \\\n+ \"s390-ccw-virtio-nopci\"; \\\n mc->is_default = 1; \\\n } \\\n } \\\n@@ -609,14 +611,24 @@ bool css_migration_enabled(void)\n ccw_machine_##suffix##_instance_options(machine); \\\n } \\\n static const TypeInfo ccw_machine_##suffix##_info = { \\\n- .name = MACHINE_TYPE_NAME(\"s390-ccw-virtio-\" verstr), \\\n+ .name = MACHINE_TYPE_NAME(\"s390-virtio-ccw-\" verstr), \\\n+ .parent = TYPE_S390_CCW_MACHINE, \\\n+ .class_init = ccw_machine_##suffix##_class_init, \\\n+ .instance_init = ccw_machine_##suffix##_instance_init, \\\n+ }; \\\n+ static const TypeInfo ccw_machine_nopci_##suffix##_info = { \\\n+ .name = MACHINE_TYPE_NAME(\"s390-virtio-ccw-nopci-\" verstr), \\\n .parent = TYPE_S390_CCW_MACHINE, \\\n .class_init = ccw_machine_##suffix##_class_init, \\\n .instance_init = ccw_machine_##suffix##_instance_init, \\\n }; \\\n static void ccw_machine_register_##suffix(void) \\\n { \\\n- type_register_static(&ccw_machine_##suffix##_info); \\\n+ if (pci_available) { \\\n+ type_register_static(&ccw_machine_##suffix##_info); \\\n+ } else { \\\n+ type_register_static(&ccw_machine_nopci_##suffix##_info); \\\n+ } \\\n } \\\n type_init(ccw_machine_register_##suffix)","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2tpQ6ndJz9tX5\n\tfor ;\n\tThu, 28 Sep 2017 22:11:42 +1000 (AEST)","from localhost ([::1]:58980 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxXfI-00043r-VV\n\tfor incoming@patchwork.ozlabs.org; Thu, 28 Sep 2017 08:11:41 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:44699)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxXb3-0000lQ-Jv\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 08:07:19 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxXax-00080o-Br\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 08:07:17 -0400","from mx1.redhat.com ([209.132.183.28]:63047)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dxXax-00080K-44\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 08:07:11 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 3C3FB18686A;\n\tThu, 28 Sep 2017 12:07:10 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id E62888F898;\n\tThu, 28 Sep 2017 12:07:06 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 3C3FB18686A","Date":"Thu, 28 Sep 2017 14:07:04 +0200","From":"Cornelia Huck ","To":"Christian Borntraeger ","Message-ID":"<20170928140704.0cc18986.cohuck@redhat.com>","In-Reply-To":"","References":"<20170926162058.30772-1-cohuck@redhat.com>\n\t<20170926162058.30772-2-cohuck@redhat.com>\n\t<338c8565-691e-a8bc-d8a6-3637ce13701d@redhat.com>\n\t<20170927114717.72bd69f8.cohuck@redhat.com>\n\t\n\t<20170927125606.65dc514d.cohuck@redhat.com>\n\t<14df9ad6-f0e9-cd51-04dd-4fe994808433@de.ibm.com>\n\t<4681e677-9e5a-4c1c-8e22-dc5c51b7286d@redhat.com>\n\t<20170927142837.GB2108@work-vm>\n\t<20170927164644.42205e6f.cohuck@redhat.com>\n\t<20170927144927.GC2108@work-vm>\n\t<20170927170346.68ca0cd8.cohuck@redhat.com>\n\t<9c8c2596-c4cf-41ad-7228-0ed598cf65cd@de.ibm.com>\n\t","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"quoted-printable","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tThu, 28 Sep 2017 12:07:10 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for\n\t<=2.10","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pasic@linux.vnet.ibm.com, Yi Min Zhao ,\n\tDavid Hildenbrand , qemu-devel@nongnu.org,\n\tagraf@suse.de, jjherne@linux.vnet.ibm.com,\n\t\"Dr. David Alan Gilbert\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1776992,"web_url":"http://patchwork.ozlabs.org/comment/1776992/","msgid":"","list_archive_url":null,"date":"2017-09-28T12:17:54","subject":"Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for\n\t<=2.10","submitter":{"id":590,"url":"http://patchwork.ozlabs.org/api/people/590/","name":"Christian Borntraeger","email":"borntraeger@de.ibm.com"},"content":"On 09/28/2017 02:07 PM, Cornelia Huck wrote:\n> On Thu, 28 Sep 2017 12:41:54 +0200\n> Christian Borntraeger wrote:\n> \n>> On 09/28/2017 12:34 PM, Christian Borntraeger wrote:\n>>>\n>>>\n>>> On 09/27/2017 05:03 PM, Cornelia Huck wrote: \n>>>> On Wed, 27 Sep 2017 15:49:27 +0100\n>>>> \"Dr. David Alan Gilbert\" wrote:\n>>>> \n>>>>> * Cornelia Huck (cohuck@redhat.com) wrote: \n>>>>>> On Wed, 27 Sep 2017 15:28:38 +0100\n>>>>>> \"Dr. David Alan Gilbert\" wrote:\n>>>>>> \n>>>>>>> * David Hildenbrand (david@redhat.com) wrote: \n>>>>>>>> On 27.09.2017 12:59, Christian Borntraeger wrote: \n>>>>>>>>>\n>>>>>>>>>\n>>>>>>>>> On 09/27/2017 12:56 PM, Cornelia Huck wrote: \n>>>>>>>>>> On Wed, 27 Sep 2017 18:25:00 +0800\n>>>>>>>>>> Yi Min Zhao wrote:\n>>>>>>>>>> \n>>>>>>>>>>> 在 2017/9/27 下午5:47, Cornelia Huck 写道: \n>>>>>>>>>>>> On Tue, 26 Sep 2017 20:40:25 +0200\n>>>>>>>>>>>> David Hildenbrand wrote: \n>>>>>>>>>> \n>>>>>>>>>>>>> I'd really really really (did I mention really?) favor something like a\n>>>>>>>>>>>>> dummy device, because we could easily handle the !CONFIG_PCI case then.\n>>>>>>>>>>>>>\n>>>>>>>>>>>>> All these compat options and conditions will kill us someday... we're\n>>>>>>>>>>>>> already patching around that whole stuff way too much.\n>>>>>>>>>>>>>\n>>>>>>>>>>>>> If we ever unconditionally created a device, we should keep doing so. \n>>>>>>>>>>>> Yes, that whole thing is horrible, especially interaction with compat\n>>>>>>>>>>>> machines.\n>>>>>>>>>>>>\n>>>>>>>>>>>> Do you have an idea on how to create such a dummy device (without\n>>>>>>>>>>>> having to effectively copy a lot of configured-out code)?\n>>>>>>>>>>>>\n>>>>>>>>>>>> \n>>>>>>>>>>> How about in s390_pcihost_hot_plug() we check s390_has_feat(zpci)?\n>>>>>>>>>>> If no zpci feature, we avoid plugging any pci device.\n>>>>>>>>>>> Then we could always create phb.\n>>>>>>>>>>> I think pcibus's vmstate is only data to migrate. \n>>>>>>>>>>\n>>>>>>>>>> That's still problematic if CONFIG_PCI is off. I currently don't have a\n>>>>>>>>>> better idea than either disallowing compat machines on builds without\n>>>>>>>>>> pci, or using a dummy device... \n>>>>>>>>>\n>>>>>>>>> For this particular case your initial patch might be less problematic than\n>>>>>>>>> a dummy device, because the code that does the migration is NOT contained\n>>>>>>>>> in s390 specific code but in common PCI code instead. We would need to keep\n>>>>>>>>> the dummy device always in a way that it will work with the common PCI\n>>>>>>>>> code.\n>>>>>>>>> \n>>>>>>>>\n>>>>>>>> Interesting, so how is migration then handled for e.g. x86 or other\n>>>>>>>> architectures that can work without CONFIG_PCI? I assume their migration\n>>>>>>>> should also break? \n>>>>>>>\n>>>>>>> It's tied to machine-type; the x86 i440fx and q35 machine types have\n>>>>>>> PCI; you can't disable PCI while still having those machine types.\n>>>>>>> (I don't know if you can disable PCI at all on x86) \n>>>>>>\n>>>>>> Ugh, that sounds like we need two machine types on s390x as well\n>>>>>> (s390x-ccw-virtio and s390x-ccw-virtio-nopci or so), built\n>>>>>> conditionally. That whole zpci detanglement is looking worse and\n>>>>>> worse :( \n>>>>>\n>>>>> Well fundamentally the migration expects to migrate something into\n>>>>> the same shaped hole on the destination; if you've got a lump of PCI\n>>>>> config on the source there's got to be somewhere for it to fit on the\n>>>>> destination.\n>>>>> Now, if PCI is actually pretty rare; then you might be able to make\n>>>>> the host-pci bridge a normal device and not include it in any\n>>>>> machine type; that way those who want PCI can just instantiate\n>>>>> the host-pci bridge, and those who don't want it just stick with\n>>>>> the base machine type. \n>>>>\n>>>> I fear that ship has already sailed; the s390-ccw-virtio machine type\n>>>> has been instantiating a phb for quite some time, which means we have\n>>>> to drag this on in the compat machines... \n>>>\n>>> In the end that means that you should revert\n>>>\n>>> commit d32bd032d8fde41281aae34c16a4aa97e9acfeac\n>>> Author: Cornelia Huck \n>>> AuthorDate: Thu Jul 6 17:21:52 2017 +0200\n>>> Commit: Cornelia Huck \n>>> CommitDate: Wed Aug 30 18:23:25 2017 +0200\n>>>\n>>> s390x/ccw: create s390 phb conditionally\n>>>\n>>> to keep s390-ccw-virtio clean proper.\n>>>\n>>> If you want to have PCI disabled, you can do you in a machine like \n>> too quick ^that^\t\t\t\t\t \n>>> s390-rhelx.y.z or whatever. \n>>\n>> I think we really must revert this commit. \n>>\n> \n> A set of non-pci machines looks more attractive to me. I currently have\n> the following (not yet tested):\n\n\nI see no point if PCI disable machines. There is no non-PCI x86 machine\nbesides the isapc. But this has no version whatsoever so it certainly\nis not made for being migrated.\nAs far as I can see and we would make things much more complex.\n\nnon-PCI will trigger other issues. e.g. zpci and aen is part of the z14 cpu model\nsince 2.10. Really this is not helping, its making things worse. \n\nIf you really want to avoid PCI for whatever redhat is doing, can't you just hide\nit in a rhel specific machine (which you seem to have anyway for x86 and power)?\n\nSo unless you convince me otherwise consider nopci machine for the upstream\nmachines NACKed by me.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2tyM35nRz9tX5\n\tfor ;\n\tThu, 28 Sep 2017 22:18:34 +1000 (AEST)","from localhost ([::1]:59005 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxXlv-0007bG-JQ\n\tfor incoming@patchwork.ozlabs.org; Thu, 28 Sep 2017 08:18:31 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:47514)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxXlZ-0007bB-Fa\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 08:18:10 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxXlT-00041l-0I\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 08:18:09 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5]:40592\n\thelo=mx0a-001b2d01.pphosted.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dxXlS-00041U-QS\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 08:18:02 -0400","from pps.filterd (m0098413.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8SCEClm067059\n\tfor ; Thu, 28 Sep 2017 08:17:59 -0400","from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2d8yp14k5s-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Thu, 28 Sep 2017 08:17:58 -0400","from localhost\n\tby e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tThu, 28 Sep 2017 13:17:57 +0100","from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195)\n\tby e06smtp12.uk.ibm.com (192.168.101.142) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tThu, 28 Sep 2017 13:17:55 +0100","from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com\n\t[9.149.105.62])\n\tby b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8SCHtku21561530; Thu, 28 Sep 2017 12:17:55 GMT","from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id CB0B5AE055;\n\tThu, 28 Sep 2017 13:12:34 +0100 (BST)","from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 8DB35AE045;\n\tThu, 28 Sep 2017 13:12:34 +0100 (BST)","from oc7330422307.ibm.com (unknown [9.152.224.141])\n\tby d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tThu, 28 Sep 2017 13:12:34 +0100 (BST)"],"To":"Cornelia Huck ","References":"<20170926162058.30772-1-cohuck@redhat.com>\n\t<20170926162058.30772-2-cohuck@redhat.com>\n\t<338c8565-691e-a8bc-d8a6-3637ce13701d@redhat.com>\n\t<20170927114717.72bd69f8.cohuck@redhat.com>\n\t\n\t<20170927125606.65dc514d.cohuck@redhat.com>\n\t<14df9ad6-f0e9-cd51-04dd-4fe994808433@de.ibm.com>\n\t<4681e677-9e5a-4c1c-8e22-dc5c51b7286d@redhat.com>\n\t<20170927142837.GB2108@work-vm>\n\t<20170927164644.42205e6f.cohuck@redhat.com>\n\t<20170927144927.GC2108@work-vm>\n\t<20170927170346.68ca0cd8.cohuck@redhat.com>\n\t<9c8c2596-c4cf-41ad-7228-0ed598cf65cd@de.ibm.com>\n\t\n\t<20170928140704.0cc18986.cohuck@redhat.com>","From":"Christian Borntraeger ","Date":"Thu, 28 Sep 2017 14:17:54 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.0","MIME-Version":"1.0","In-Reply-To":"<20170928140704.0cc18986.cohuck@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-TM-AS-GCONF":"00","x-cbid":"17092812-0008-0000-0000-0000049AEBC4","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092812-0009-0000-0000-00001E2C3D9A","Message-Id":"","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-28_04:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709280183","Content-Transfer-Encoding":"quoted-printable","X-MIME-Autoconverted":"from 8bit to quoted-printable by\n\tmx0b-001b2d01.pphosted.com id v8SCEClm067059","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.158.5","Subject":"Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for\n\t<=2.10","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pasic@linux.vnet.ibm.com, Yi Min Zhao ,\n\tDavid Hildenbrand , qemu-devel@nongnu.org,\n\tagraf@suse.de, jjherne@linux.vnet.ibm.com,\n\t\"Dr. David Alan Gilbert\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1776999,"web_url":"http://patchwork.ozlabs.org/comment/1776999/","msgid":"<20170928142745.2ab4da2a.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-28T12:27:45","subject":"Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for\n\t<=2.10","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Thu, 28 Sep 2017 14:17:54 +0200\nChristian Borntraeger wrote:\n\n> I see no point if PCI disable machines. There is no non-PCI x86 machine\n> besides the isapc. But this has no version whatsoever so it certainly\n> is not made for being migrated.\n> As far as I can see and we would make things much more complex.\n> \n> non-PCI will trigger other issues. e.g. zpci and aen is part of the z14 cpu model\n> since 2.10. Really this is not helping, its making things worse. \n\nWhat about creating the phb depending upon pci_available? Has no impact\nfor normal builds unless you muck around manually...\n\n> If you really want to avoid PCI for whatever redhat is doing, can't you just hide\n> it in a rhel specific machine (which you seem to have anyway for x86 and power)?\n\n...but makes it easier to disable it correctly, if wanted.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2vDv5rmdz9s3w\n\tfor ;\n\tThu, 28 Sep 2017 22:31:11 +1000 (AEST)","from localhost ([::1]:59058 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxXy9-0003Bc-UU\n\tfor incoming@patchwork.ozlabs.org; Thu, 28 Sep 2017 08:31:09 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:49553)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxXv5-0001Nn-22\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 08:28:02 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxXuz-0008Cy-HO\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 08:27:59 -0400","from mx1.redhat.com ([209.132.183.28]:56382)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dxXuz-0008Cl-BE\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 08:27:53 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id ED6B8D69BF;\n\tThu, 28 Sep 2017 12:27:51 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 3469E86E7B;\n\tThu, 28 Sep 2017 12:27:48 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com ED6B8D69BF","Date":"Thu, 28 Sep 2017 14:27:45 +0200","From":"Cornelia Huck ","To":"Christian Borntraeger ","Message-ID":"<20170928142745.2ab4da2a.cohuck@redhat.com>","In-Reply-To":"","References":"<20170926162058.30772-1-cohuck@redhat.com>\n\t<20170926162058.30772-2-cohuck@redhat.com>\n\t<338c8565-691e-a8bc-d8a6-3637ce13701d@redhat.com>\n\t<20170927114717.72bd69f8.cohuck@redhat.com>\n\t\n\t<20170927125606.65dc514d.cohuck@redhat.com>\n\t<14df9ad6-f0e9-cd51-04dd-4fe994808433@de.ibm.com>\n\t<4681e677-9e5a-4c1c-8e22-dc5c51b7286d@redhat.com>\n\t<20170927142837.GB2108@work-vm>\n\t<20170927164644.42205e6f.cohuck@redhat.com>\n\t<20170927144927.GC2108@work-vm>\n\t<20170927170346.68ca0cd8.cohuck@redhat.com>\n\t<9c8c2596-c4cf-41ad-7228-0ed598cf65cd@de.ibm.com>\n\t\n\t<20170928140704.0cc18986.cohuck@redhat.com>\n\t","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tThu, 28 Sep 2017 12:27:52 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for\n\t<=2.10","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pasic@linux.vnet.ibm.com, Yi Min Zhao ,\n\tDavid Hildenbrand , qemu-devel@nongnu.org,\n\tagraf@suse.de, jjherne@linux.vnet.ibm.com,\n\t\"Dr. David Alan Gilbert\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1777000,"web_url":"http://patchwork.ozlabs.org/comment/1777000/","msgid":"<06985cad-8fc0-8eb5-8cd1-6baabd5a217b@redhat.com>","list_archive_url":null,"date":"2017-09-28T12:33:44","subject":"Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for\n\t<=2.10","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":">> In the end that means that you should revert\n>>\n>> commit d32bd032d8fde41281aae34c16a4aa97e9acfeac\n>> Author: Cornelia Huck \n>> AuthorDate: Thu Jul 6 17:21:52 2017 +0200\n>> Commit: Cornelia Huck \n>> CommitDate: Wed Aug 30 18:23:25 2017 +0200\n>>\n>> s390x/ccw: create s390 phb conditionally\n>>\n>> to keep s390-ccw-virtio clean proper.\n>>\n>> If you want to have PCI disabled, you can do you in a machine like \n> too quick ^that^\t\t\t\t\t \n>> s390-rhelx.y.z or whatever. \n> \n> I think we really must revert this commit. \n> \n\nI tend to agree.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2vJT4Fw6z9s3w\n\tfor ;\n\tThu, 28 Sep 2017 22:34:17 +1000 (AEST)","from localhost ([::1]:59093 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxY19-000448-KH\n\tfor incoming@patchwork.ozlabs.org; Thu, 28 Sep 2017 08:34:15 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:51164)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxY0n-00043m-4T\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 08:33:57 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxY0j-0001jf-8Q\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 08:33:53 -0400","from mx1.redhat.com ([209.132.183.28]:45250)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dxY0j-0001jH-2d\n\tfor qemu-devel@nongnu.org; Thu, 28 Sep 2017 08:33:49 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id E34BF191F92;\n\tThu, 28 Sep 2017 12:33:47 +0000 (UTC)","from [10.36.117.191] (ovpn-117-191.ams2.redhat.com [10.36.117.191])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 08AEE7F464;\n\tThu, 28 Sep 2017 12:33:45 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com E34BF191F92","To":"Christian Borntraeger ,\n\tCornelia Huck ,\n\t\"Dr. David Alan Gilbert\" ","References":"<20170926162058.30772-1-cohuck@redhat.com>\n\t<20170926162058.30772-2-cohuck@redhat.com>\n\t<338c8565-691e-a8bc-d8a6-3637ce13701d@redhat.com>\n\t<20170927114717.72bd69f8.cohuck@redhat.com>\n\t\n\t<20170927125606.65dc514d.cohuck@redhat.com>\n\t<14df9ad6-f0e9-cd51-04dd-4fe994808433@de.ibm.com>\n\t<4681e677-9e5a-4c1c-8e22-dc5c51b7286d@redhat.com>\n\t<20170927142837.GB2108@work-vm>\n\t<20170927164644.42205e6f.cohuck@redhat.com>\n\t<20170927144927.GC2108@work-vm>\n\t<20170927170346.68ca0cd8.cohuck@redhat.com>\n\t<9c8c2596-c4cf-41ad-7228-0ed598cf65cd@de.ibm.com>\n\t","From":"David Hildenbrand ","Organization":"Red Hat GmbH","Message-ID":"<06985cad-8fc0-8eb5-8cd1-6baabd5a217b@redhat.com>","Date":"Thu, 28 Sep 2017 14:33:44 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tThu, 28 Sep 2017 12:33:48 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 1/1] s390x: create a compat s390 phb for\n\t<=2.10","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pasic@linux.vnet.ibm.com, Yi Min Zhao ,\n\tqemu-devel@nongnu.org, jjherne@linux.vnet.ibm.com, agraf@suse.de","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]