[{"id":1775928,"web_url":"http://patchwork.ozlabs.org/comment/1775928/","msgid":"<20170926223414.hdyveon53ev5dqi2@ast-mbp>","list_archive_url":null,"date":"2017-09-26T22:34:16","subject":"Re: [PATCH v2 net-next 2/2] bpf/verifier: improve disassembly of\n\tBPF_NEG instructions","submitter":{"id":42586,"url":"http://patchwork.ozlabs.org/api/people/42586/","name":"Alexei Starovoitov","email":"alexei.starovoitov@gmail.com"},"content":"On Tue, Sep 26, 2017 at 04:35:29PM +0100, Edward Cree wrote:\n> BPF_NEG takes only one operand, unlike the bulk of BPF_ALU[64] which are\n> compound-assignments. So give it its own format in print_bpf_insn().\n> \n> Signed-off-by: Edward Cree \n\nAcked-by: Alexei Starovoitov \n\nthank you for the cleanup.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"YWGRn7Gf\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1wjr0HNqz9s7F\n\tfor ;\n\tWed, 27 Sep 2017 08:34:24 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1032609AbdIZWeV (ORCPT );\n\tTue, 26 Sep 2017 18:34:21 -0400","from mail-pg0-f54.google.com ([74.125.83.54]:49744 \"EHLO\n\tmail-pg0-f54.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1032596AbdIZWeT (ORCPT\n\t); Tue, 26 Sep 2017 18:34:19 -0400","by mail-pg0-f54.google.com with SMTP id m30so6682448pgn.6\n\tfor ; Tue, 26 Sep 2017 15:34:18 -0700 (PDT)","from ast-mbp ([2620:10d:c090:180::1:6adc])\n\tby smtp.gmail.com with ESMTPSA id\n\te24sm2721834pfk.54.2017.09.26.15.34.16\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 26 Sep 2017 15:34:17 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=szaJfQyuHUTe5hCXQ6ltda5u4erIO6QlLN3OaQG7FNM=;\n\tb=YWGRn7GfLRbSc3WvKIYjpqh/0iUa8/9Xbs3cXYUfxWpouP6DBvV7JnZLfxNP3X0usl\n\tSQ+6nf+eK3JfkwLN0rD9J7jx/Mq2H+9V4IPaXmmJ1UzUSApTt4ZjT09VDVHloFqdZVEZ\n\tgUMxQ1zRhXdl7d1GGjhC3zHk9jZr0WpEXGmfW3flXIN15Q37XLmSxQ/q1GKvzVtDVr8N\n\t1YzLDdZN6i6oncMyGOWXOBvPneToO3H2b6lF/l+RNE8SG99tXvwgLhGIteT3P1SndYo6\n\t3w1+MTrqVKO3XafrzCwZd33ABFfYRDIO4o5fuSmOG88lF+sp+zqRmSA+24vQPkUszeEq\n\t38Gw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=szaJfQyuHUTe5hCXQ6ltda5u4erIO6QlLN3OaQG7FNM=;\n\tb=cjHrIT5EOVESuZsNyaJsTvW+SXSVe+mBYXwIQEivxBNTSPgnadzFSM2lFrgBJFUrq0\n\tsqlDpjVXy4jwRU96ti6fEZ0IBbAgrVl5U6oEGxVDU2WUaxXZ53ndIAtEXTKU0HGJI175\n\tw+SPtVhk3Elt3t8HQKzJ2sds2YQy0AhHKJ08f5y6qRJxT5S2DUM9ARbdDWAnUtbvYiPI\n\tW+28xj/mYwmMEtMdytT6mQIg9lEUr4bVIJWmpsqI1VDFlK40K5FLRcMnQatXiBHdBKUm\n\teroOhyrvAcqaSC3BfwqPd1Vx2Fwvo8Hb7QFzZUXh9Ti21CguPd2DR8uLHjSfMkXYNrZR\n\tgVTA==","X-Gm-Message-State":"AHPjjUjAOuVsTE1Qg+590NlNXEdD9tXPmN8okhn7iye74qpe4wDlOTPK\n\t1qS818aUwIzlH1sqtZMfyg4=","X-Google-Smtp-Source":"AOwi7QDfoDE/iaTmhMhsoXdPu0B/V9kPFIFLp5pPp2a7KvZ4vudodiGzLx7MT2P7nMCp8E2Si1HzpQ==","X-Received":"by 10.99.113.93 with SMTP id b29mr12620385pgn.422.1506465258433; \n\tTue, 26 Sep 2017 15:34:18 -0700 (PDT)","Date":"Tue, 26 Sep 2017 15:34:16 -0700","From":"Alexei Starovoitov ","To":"Edward Cree ","Cc":"davem@davemloft.net, netdev@vger.kernel.org, daniel@iogearbox.net,\n\tys114321@gmail.com","Subject":"Re: [PATCH v2 net-next 2/2] bpf/verifier: improve disassembly of\n\tBPF_NEG instructions","Message-ID":"<20170926223414.hdyveon53ev5dqi2@ast-mbp>","References":"<52270348-67f1-4e7a-cd2f-9d611ae94064@solarflare.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"NeoMutt/20170421 (1.8.2)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1775941,"web_url":"http://patchwork.ozlabs.org/comment/1775941/","msgid":"<59CADA6C.1000300@iogearbox.net>","list_archive_url":null,"date":"2017-09-26T22:53:32","subject":"Re: [PATCH v2 net-next 2/2] bpf/verifier: improve disassembly of\n\tBPF_NEG instructions","submitter":{"id":65705,"url":"http://patchwork.ozlabs.org/api/people/65705/","name":"Daniel Borkmann","email":"daniel@iogearbox.net"},"content":"On 09/26/2017 05:35 PM, Edward Cree wrote:\n> BPF_NEG takes only one operand, unlike the bulk of BPF_ALU[64] which are\n> compound-assignments. So give it its own format in print_bpf_insn().\n>\n> Signed-off-by: Edward Cree \n\nAcked-by: Daniel Borkmann ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1x830Cvjz9t30\n\tfor ;\n\tWed, 27 Sep 2017 08:53:39 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1031376AbdIZWxh (ORCPT );\n\tTue, 26 Sep 2017 18:53:37 -0400","from www62.your-server.de ([213.133.104.62]:41489 \"EHLO\n\twww62.your-server.de\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S969634AbdIZWxf (ORCPT\n\t); Tue, 26 Sep 2017 18:53:35 -0400","from [85.7.161.218] (helo=localhost.localdomain)\n\tby www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-SHA:256)\n\t(Exim 4.85_2) (envelope-from )\n\tid 1dwyjN-0002F6-AH; Wed, 27 Sep 2017 00:53:33 +0200"],"Message-ID":"<59CADA6C.1000300@iogearbox.net>","Date":"Wed, 27 Sep 2017 00:53:32 +0200","From":"Daniel Borkmann ","User-Agent":"Mozilla/5.0 (X11; Linux x86_64;\n\trv:31.0) Gecko/20100101 Thunderbird/31.7.0","MIME-Version":"1.0","To":"Edward Cree , davem@davemloft.net","CC":"netdev@vger.kernel.org, alexei.starovoitov@gmail.com, ys114321@gmail.com","Subject":"Re: [PATCH v2 net-next 2/2] bpf/verifier: improve disassembly of\n\tBPF_NEG instructions","References":"<52270348-67f1-4e7a-cd2f-9d611ae94064@solarflare.com>\n\t","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","X-Authenticated-Sender":"daniel@iogearbox.net","X-Virus-Scanned":"Clear (ClamAV 0.99.2/23876/Tue Sep 26 22:41:53 2017)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]