[{"id":1775926,"web_url":"http://patchwork.ozlabs.org/comment/1775926/","msgid":"<20170926223344.3ey6w2qrejrqzqpv@ast-mbp>","list_archive_url":null,"date":"2017-09-26T22:33:46","subject":"Re: [PATCH v2 net-next 1/2] bpf/verifier: improve disassembly of\n\tBPF_END instructions","submitter":{"id":42586,"url":"http://patchwork.ozlabs.org/api/people/42586/","name":"Alexei Starovoitov","email":"alexei.starovoitov@gmail.com"},"content":"On Tue, Sep 26, 2017 at 04:35:13PM +0100, Edward Cree wrote:\n> print_bpf_insn() was treating all BPF_ALU[64] the same, but BPF_END has a\n> different structure: it has a size in insn->imm (even if it's BPF_X) and\n> uses the BPF_SRC (X or K) to indicate which endianness to use. So it\n> needs different code to print it.\n> \n> Signed-off-by: Edward Cree \n\nwell, it's an improvement over what we have today, so\nAcked-by: Alexei Starovoitov ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"AFPsbZL1\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1wjF3c5xz9t3B\n\tfor ;\n\tWed, 27 Sep 2017 08:33:53 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1031252AbdIZWdu (ORCPT );\n\tTue, 26 Sep 2017 18:33:50 -0400","from mail-pf0-f194.google.com ([209.85.192.194]:37845 \"EHLO\n\tmail-pf0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1031134AbdIZWdt (ORCPT\n\t); Tue, 26 Sep 2017 18:33:49 -0400","by mail-pf0-f194.google.com with SMTP id e69so5536011pfg.4\n\tfor ; Tue, 26 Sep 2017 15:33:48 -0700 (PDT)","from ast-mbp ([2620:10d:c090:180::1:6adc])\n\tby smtp.gmail.com with ESMTPSA id\n\th186sm16717676pge.72.2017.09.26.15.33.46\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 26 Sep 2017 15:33:47 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=C9zBWToj5aWfmxhYy9lN/t+uTEH3R2p67C9I7l+LIzo=;\n\tb=AFPsbZL1YHJY0xVNnmessBZHQPe82YxSOPIT+1gKyYmlI3WwgGlfzjgAUdVvPp9rsk\n\tPKIN0uBwT4kZ5jCu8vG90gbKDqSk7FgXT10VoBDlm6/Dq1Brn3mmCSFwxlHH+zuZxfi+\n\tcxgvNvEtLSfi5hh1Rd6ihVWlTvr+SXQXpsy7RUqEr7o4Z2NS8+jk0BCvUkrKpE4pP92N\n\tsMG4NLV1IyLnQTthtGnpokl9k0UNOgjZFfz1he78Dg7rPaMJev9b8rt6EA+d6ObWqg27\n\t50cDDoEcXNUKzw5X1K4K9M2d0s1XUagrmSZvUKDvnwMu+zF88gthZvLiJ+ipOaHIKLLZ\n\tQKKw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=C9zBWToj5aWfmxhYy9lN/t+uTEH3R2p67C9I7l+LIzo=;\n\tb=Iuo9N4t59qFOE6Ma7gWdn+EGRZf0LDjae57cFaUjgGwpWJhkfgJaNP6l5pblrCacY2\n\tW1tIx+gcMpOJs/yYk7zk+/tK9z8tARWRDG6AKrQoE4xeg3J6HbXgwyXra/efmpDIiGHj\n\tAs9fMLGXqES5cUls/1wE4ledJf5iQMcFZx22ggn4iywyfvi7V3zRoN4lOS9kUcuA9Pog\n\tF3L/XWcK2B5/WiteU00YDGYLnF0LsvoIKK5tnVmvKUvA0SeIInKb5O9YVRQR2KYcvOPj\n\t90FQbZaQP90Fl5M+4UyX0TnPQQFgS0lXyH2FYmMOuoPWV/vccGzUnGJCVGbKRFogu8fq\n\teQdg==","X-Gm-Message-State":"AHPjjUhWecR9khnJTfYzIb475JPmqzIjfGzG9mbAwZnM971UBwuny7HU\n\t5i/tN1VS/fmu0aKkl+bVExo=","X-Google-Smtp-Source":"AOwi7QDQZ34afcLeF9a3fqDk+lzKsfCGzy+55PXIie4NSgBUpln2Czo9bBizusscYsEVGVSvMxAvBQ==","X-Received":"by 10.84.133.66 with SMTP id 60mr12116798plf.386.1506465228525; \n\tTue, 26 Sep 2017 15:33:48 -0700 (PDT)","Date":"Tue, 26 Sep 2017 15:33:46 -0700","From":"Alexei Starovoitov ","To":"Edward Cree ","Cc":"davem@davemloft.net, netdev@vger.kernel.org, daniel@iogearbox.net,\n\tys114321@gmail.com","Subject":"Re: [PATCH v2 net-next 1/2] bpf/verifier: improve disassembly of\n\tBPF_END instructions","Message-ID":"<20170926223344.3ey6w2qrejrqzqpv@ast-mbp>","References":"<52270348-67f1-4e7a-cd2f-9d611ae94064@solarflare.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"NeoMutt/20170421 (1.8.2)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1775940,"web_url":"http://patchwork.ozlabs.org/comment/1775940/","msgid":"<59CADA5A.1040307@iogearbox.net>","list_archive_url":null,"date":"2017-09-26T22:53:14","subject":"Re: [PATCH v2 net-next 1/2] bpf/verifier: improve disassembly of\n\tBPF_END instructions","submitter":{"id":65705,"url":"http://patchwork.ozlabs.org/api/people/65705/","name":"Daniel Borkmann","email":"daniel@iogearbox.net"},"content":"On 09/26/2017 05:35 PM, Edward Cree wrote:\n> print_bpf_insn() was treating all BPF_ALU[64] the same, but BPF_END has a\n> different structure: it has a size in insn->imm (even if it's BPF_X) and\n> uses the BPF_SRC (X or K) to indicate which endianness to use. So it\n> needs different code to print it.\n>\n> Signed-off-by: Edward Cree \n\nAcked-by: Daniel Borkmann ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1x7j4xJhz9t30\n\tfor ;\n\tWed, 27 Sep 2017 08:53:21 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1031337AbdIZWxT (ORCPT );\n\tTue, 26 Sep 2017 18:53:19 -0400","from www62.your-server.de ([213.133.104.62]:41457 \"EHLO\n\twww62.your-server.de\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S965051AbdIZWxS (ORCPT\n\t); Tue, 26 Sep 2017 18:53:18 -0400","from [85.7.161.218] (helo=localhost.localdomain)\n\tby www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-SHA:256)\n\t(Exim 4.85_2) (envelope-from )\n\tid 1dwyj4-00028x-Od; Wed, 27 Sep 2017 00:53:14 +0200"],"Message-ID":"<59CADA5A.1040307@iogearbox.net>","Date":"Wed, 27 Sep 2017 00:53:14 +0200","From":"Daniel Borkmann ","User-Agent":"Mozilla/5.0 (X11; Linux x86_64;\n\trv:31.0) Gecko/20100101 Thunderbird/31.7.0","MIME-Version":"1.0","To":"Edward Cree , davem@davemloft.net","CC":"netdev@vger.kernel.org, alexei.starovoitov@gmail.com, ys114321@gmail.com","Subject":"Re: [PATCH v2 net-next 1/2] bpf/verifier: improve disassembly of\n\tBPF_END instructions","References":"<52270348-67f1-4e7a-cd2f-9d611ae94064@solarflare.com>\n\t","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","X-Authenticated-Sender":"daniel@iogearbox.net","X-Virus-Scanned":"Clear (ClamAV 0.99.2/23876/Tue Sep 26 22:41:53 2017)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]