[{"id":1776535,"web_url":"http://patchwork.ozlabs.org/comment/1776535/","msgid":"<8d35b8d7-bb0a-97f4-2e64-29e2d9304c3f@canonical.com>","list_archive_url":null,"date":"2017-09-27T18:46:54","subject":"ACK: [SRU][Zesty][PATCH 1/1] md: MD_CLOSING needs to be cleared\n\tafter called md_set_readonly or do_md_stop","submitter":{"id":2898,"url":"http://patchwork.ozlabs.org/api/people/2898/","name":"Stefan Bader","email":"stefan.bader@canonical.com"},"content":"On 26.09.2017 11:19, Joseph Salisbury wrote:\n> From: NeilBrown \n> \n> BugLink: http://bugs.launchpad.net/bugs/1706243\n> \n> if called md_set_readonly and set MD_CLOSING bit, the mddev cannot\n> be opened any more due to the MD_CLOING bit wasn't cleared. Thus it\n> needs to be cleared in md_ioctl after any call to md_set_readonly()\n> or do_md_stop().\n> \n> Signed-off-by: NeilBrown \n> Fixes: af8d8e6f0315 (\"md: changes for MD_STILL_CLOSED flag\")\n> Cc: stable@vger.kernel.org (v4.9+)\n> Signed-off-by: Zhilong Liu \n> Signed-off-by: Shaohua Li \n> (cherry picked from commit 065e519e71b2c1f41936cce75b46b5ab34adb588)\n> Signed-off-by: Joseph Salisbury \nAcked-by: Stefan Bader \n\n> ---\n> drivers/md/md.c | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/drivers/md/md.c b/drivers/md/md.c\n> index 01175da..643920c 100644\n> --- a/drivers/md/md.c\n> +++ b/drivers/md/md.c\n> @@ -6787,6 +6787,7 @@ static int md_ioctl(struct block_device *bdev, fmode_t mode,\n> \tvoid __user *argp = (void __user *)arg;\n> \tstruct mddev *mddev = NULL;\n> \tint ro;\n> +\tbool did_set_md_closing = false;\n> \n> \tif (!md_ioctl_valid(cmd))\n> \t\treturn -ENOTTY;\n> @@ -6876,7 +6877,9 @@ static int md_ioctl(struct block_device *bdev, fmode_t mode,\n> \t\t\terr = -EBUSY;\n> \t\t\tgoto out;\n> \t\t}\n> +\t\tWARN_ON_ONCE(test_bit(MD_CLOSING, &mddev->flags));\n> \t\tset_bit(MD_CLOSING, &mddev->flags);\n> +\t\tdid_set_md_closing = true;\n> \t\tmutex_unlock(&mddev->open_mutex);\n> \t\tsync_blockdev(bdev);\n> \t}\n> @@ -7069,6 +7072,8 @@ static int md_ioctl(struct block_device *bdev, fmode_t mode,\n> \t\tmddev->hold_active = 0;\n> \tmddev_unlock(mddev);\n> out:\n> +\tif(did_set_md_closing)\n> +\t\tclear_bit(MD_CLOSING, &mddev->flags);\n> \treturn err;\n> }\n> #ifdef CONFIG_COMPAT\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=kernel-team-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2Rd273Ghz9tXQ;\n\tThu, 28 Sep 2017 04:47:02 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dxHMH-0005kK-Tf; Wed, 27 Sep 2017 18:46:57 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dxHMF-0005j9-Lz\n\tfor kernel-team@lists.ubuntu.com; Wed, 27 Sep 2017 18:46:55 +0000","from rrcs-69-193-151-51.nyc.biz.rr.com ([69.193.151.51]\n\thelo=[10.155.52.21]) by youngberry.canonical.com with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1dxHMF-0000OO-CM\n\tfor kernel-team@lists.ubuntu.com; Wed, 27 Sep 2017 18:46:55 +0000"],"Subject":"ACK: [SRU][Zesty][PATCH 1/1] md: MD_CLOSING needs to be cleared\n\tafter called md_set_readonly or do_md_stop","To":"kernel-team@lists.ubuntu.com","References":"\n\t","From":"Stefan Bader ","Message-ID":"<8d35b8d7-bb0a-97f4-2e64-29e2d9304c3f@canonical.com>","Date":"Wed, 27 Sep 2017 14:46:54 -0400","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============1800897337528277723==\"","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" "}},{"id":1779587,"web_url":"http://patchwork.ozlabs.org/comment/1779587/","msgid":"<06675909-8e05-0992-0d15-174a0f66d782@canonical.com>","list_archive_url":null,"date":"2017-10-04T09:53:46","subject":"ACK: [SRU][Zesty][PATCH 1/1] md: MD_CLOSING needs to be cleared\n\tafter called md_set_readonly or do_md_stop","submitter":{"id":2900,"url":"http://patchwork.ozlabs.org/api/people/2900/","name":"Colin Ian King","email":"colin.king@canonical.com"},"content":"On 26/09/17 16:19, Joseph Salisbury wrote:\n> From: NeilBrown \n> \n> BugLink: http://bugs.launchpad.net/bugs/1706243\n> \n> if called md_set_readonly and set MD_CLOSING bit, the mddev cannot\n> be opened any more due to the MD_CLOING bit wasn't cleared. Thus it\n> needs to be cleared in md_ioctl after any call to md_set_readonly()\n> or do_md_stop().\n> \n> Signed-off-by: NeilBrown \n> Fixes: af8d8e6f0315 (\"md: changes for MD_STILL_CLOSED flag\")\n> Cc: stable@vger.kernel.org (v4.9+)\n> Signed-off-by: Zhilong Liu \n> Signed-off-by: Shaohua Li \n> (cherry picked from commit 065e519e71b2c1f41936cce75b46b5ab34adb588)\n> Signed-off-by: Joseph Salisbury \n> ---\n> drivers/md/md.c | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/drivers/md/md.c b/drivers/md/md.c\n> index 01175da..643920c 100644\n> --- a/drivers/md/md.c\n> +++ b/drivers/md/md.c\n> @@ -6787,6 +6787,7 @@ static int md_ioctl(struct block_device *bdev, fmode_t mode,\n> \tvoid __user *argp = (void __user *)arg;\n> \tstruct mddev *mddev = NULL;\n> \tint ro;\n> +\tbool did_set_md_closing = false;\n> \n> \tif (!md_ioctl_valid(cmd))\n> \t\treturn -ENOTTY;\n> @@ -6876,7 +6877,9 @@ static int md_ioctl(struct block_device *bdev, fmode_t mode,\n> \t\t\terr = -EBUSY;\n> \t\t\tgoto out;\n> \t\t}\n> +\t\tWARN_ON_ONCE(test_bit(MD_CLOSING, &mddev->flags));\n> \t\tset_bit(MD_CLOSING, &mddev->flags);\n> +\t\tdid_set_md_closing = true;\n> \t\tmutex_unlock(&mddev->open_mutex);\n> \t\tsync_blockdev(bdev);\n> \t}\n> @@ -7069,6 +7072,8 @@ static int md_ioctl(struct block_device *bdev, fmode_t mode,\n> \t\tmddev->hold_active = 0;\n> \tmddev_unlock(mddev);\n> out:\n> +\tif(did_set_md_closing)\n> +\t\tclear_bit(MD_CLOSING, &mddev->flags);\n> \treturn err;\n> }\n> #ifdef CONFIG_COMPAT\n> \n\nPositive test results. Looks good.\n\nAcked-by: Colin Ian King ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=kernel-team-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3y6WSc6zTRz9t2W;\n\tWed, 4 Oct 2017 20:53:52 +1100 (AEDT)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dzgNB-0002ap-9u; Wed, 04 Oct 2017 09:53:49 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dzgN9-0002aL-OA\n\tfor kernel-team@lists.ubuntu.com; Wed, 04 Oct 2017 09:53:47 +0000","from 1.general.cking.uk.vpn ([10.172.193.212])\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1dzgN9-0001DD-DA; Wed, 04 Oct 2017 09:53:47 +0000"],"Subject":"ACK: [SRU][Zesty][PATCH 1/1] md: MD_CLOSING needs to be cleared\n\tafter called md_set_readonly or do_md_stop","To":"kernel-team@lists.ubuntu.com","References":"\n\t","From":"Colin Ian King ","Message-ID":"<06675909-8e05-0992-0d15-174a0f66d782@canonical.com>","Date":"Wed, 4 Oct 2017 10:53:46 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" "}}]