[{"id":1778482,"web_url":"http://patchwork.ozlabs.org/comment/1778482/","msgid":"<20171002173340.GB2116@perard.uk.xensource.com>","list_archive_url":null,"date":"2017-10-02T17:33:40","subject":"Re: [Qemu-devel] [PATCH 2/3 v4] xenfb: Use Input Handlers directly","submitter":{"id":4759,"url":"http://patchwork.ozlabs.org/api/people/4759/","name":"Anthony PERARD","email":"anthony.perard@citrix.com"},"content":"On Tue, Sep 26, 2017 at 02:43:38PM +0000, Owen Smith wrote:\n> Avoid the unneccessary calls through the input-legacy.c file by\n> using the qemu_input_handler_*() calls directly. This did require\n> reworking the event and sync handlers to use the reverse mapping\n> from qcode to linux using qemu_input_qcode_to_linux().\n> Removes the scancode2linux mapping, and supporting documention.\n> \n> Signed-off-by: Owen Smith \n\nThere is a call to trace_xenfb_key_event() that have been added\nupstream, just before the call to xenfb_send_key(), that should probably\nbe added to this patch, otherwise, the patch does not apply. With that\nfix, you can add my:\nAcked-by: Anthony PERARD \n\nThanks,","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@gnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y5Tnf0ptcz9t5R\n\tfor ;\n\tTue, 3 Oct 2017 04:35:02 +1100 (AEDT)","from localhost ([::1]:53536 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dz4cO-0002Bg-7L\n\tfor incoming@patchwork.ozlabs.org; Mon, 02 Oct 2017 13:35:00 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:36392)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1dz4bq-00025o-Ok\n\tfor qemu-devel@nongnu.org; Mon, 02 Oct 2017 13:34:27 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1dz4bn-0005as-Kw\n\tfor qemu-devel@nongnu.org; Mon, 02 Oct 2017 13:34:26 -0400","from smtp.citrix.com ([66.165.176.89]:38757)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71)\n\t(envelope-from )\n\tid 1dz4bn-0005Zk-El\n\tfor qemu-devel@nongnu.org; Mon, 02 Oct 2017 13:34:23 -0400"],"X-IronPort-AV":"E=Sophos;i=\"5.42,470,1500940800\"; d=\"scan'208\";a=\"442201734\"","Date":"Mon, 2 Oct 2017 18:33:40 +0100","From":"Anthony PERARD ","To":"Owen Smith ","Message-ID":"<20171002173340.GB2116@perard.uk.xensource.com>","References":"<1506437019-17946-1-git-send-email-owen.smith@citrix.com>\n\t<1506437019-17946-3-git-send-email-owen.smith@citrix.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Disposition":"inline","In-Reply-To":"<1506437019-17946-3-git-send-email-owen.smith@citrix.com>","User-Agent":"Mutt/1.9.1 (2017-09-22)","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"66.165.176.89","Subject":"Re: [Qemu-devel] [PATCH 2/3 v4] xenfb: Use Input Handlers directly","X-BeenThere":"qemu-devel@gnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"xen-devel@lists.xenproject.org, sstabellini@kernel.org, kraxel@redhat.com,\n\tqemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@gnu.org","Sender":"\"Qemu-devel\"\n\t"}}]