[{"id":1778462,"web_url":"http://patchwork.ozlabs.org/comment/1778462/","msgid":"<20171002170132.GA2116@perard.uk.xensource.com>","list_archive_url":null,"date":"2017-10-02T17:01:33","subject":"Re: [Qemu-devel] [PATCH 3/3 v4] xenfb: Add\n\t[feature|request]-raw-pointer","submitter":{"id":4759,"url":"http://patchwork.ozlabs.org/api/people/4759/","name":"Anthony PERARD","email":"anthony.perard@citrix.com"},"content":"On Tue, Sep 26, 2017 at 02:43:39PM +0000, Owen Smith wrote:\n> Writes \"feature-raw-pointer\" during init to indicate the backend\n> can pass raw unscaled values for absolute axes to the frontend.\n> Frontends set \"request-raw-pointer\" to indicate the backend should\n> not attempt to scale absolute values to console size.\n> \"request-raw-pointer\" is only valid if \"request-abs-pointer\" is\n> also set. Raw unscaled pointer values are in the range [0, 0x7fff]\n> \n> Signed-off-by: Owen Smith \n\nHi Owen,\n\nWhy did you remove the following from the commit description?\n> \"feature-raw-pointer\" and \"request-raw-pointer\" added to Xen\n> header in commit 7868654ff7fe5e4a2eeae2b277644fa884a5031e\n\nI think that with it, you could have kept stefano's reviewed-by tag.\n\nThanks,","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@gnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y5T3m2wpfz9t1t\n\tfor ;\n\tTue, 3 Oct 2017 04:02:10 +1100 (AEDT)","from localhost ([::1]:53436 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dz46U-0001g8-Bt\n\tfor incoming@patchwork.ozlabs.org; Mon, 02 Oct 2017 13:02:02 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:52069)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1dz468-0001eP-K6\n\tfor qemu-devel@nongnu.org; Mon, 02 Oct 2017 13:01:41 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1dz463-0003GJ-UY\n\tfor qemu-devel@nongnu.org; Mon, 02 Oct 2017 13:01:40 -0400","from smtp.citrix.com ([66.165.176.89]:45214)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71)\n\t(envelope-from )\n\tid 1dz463-0003Fb-Ol\n\tfor qemu-devel@nongnu.org; Mon, 02 Oct 2017 13:01:35 -0400"],"X-IronPort-AV":"E=Sophos;i=\"5.42,470,1500940800\"; d=\"scan'208\";a=\"442195361\"","Date":"Mon, 2 Oct 2017 18:01:33 +0100","From":"Anthony PERARD ","To":"Owen Smith ","Message-ID":"<20171002170132.GA2116@perard.uk.xensource.com>","References":"<1506437019-17946-1-git-send-email-owen.smith@citrix.com>\n\t<1506437019-17946-4-git-send-email-owen.smith@citrix.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Disposition":"inline","In-Reply-To":"<1506437019-17946-4-git-send-email-owen.smith@citrix.com>","User-Agent":"Mutt/1.9.1 (2017-09-22)","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"66.165.176.89","Subject":"Re: [Qemu-devel] [PATCH 3/3 v4] xenfb: Add\n\t[feature|request]-raw-pointer","X-BeenThere":"qemu-devel@gnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"xen-devel@lists.xenproject.org, sstabellini@kernel.org, kraxel@redhat.com,\n\tqemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@gnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1784215,"web_url":"http://patchwork.ozlabs.org/comment/1784215/","msgid":"","list_archive_url":null,"date":"2017-10-10T23:52:48","subject":"Re: [Qemu-devel] [PATCH 3/3 v4] xenfb: Add\n\t[feature|request]-raw-pointer","submitter":{"id":68602,"url":"http://patchwork.ozlabs.org/api/people/68602/","name":"Stefano Stabellini","email":"sstabellini@kernel.org"},"content":"On Mon, 2 Oct 2017, Anthony PERARD wrote:\n> On Tue, Sep 26, 2017 at 02:43:39PM +0000, Owen Smith wrote:\n> > Writes \"feature-raw-pointer\" during init to indicate the backend\n> > can pass raw unscaled values for absolute axes to the frontend.\n> > Frontends set \"request-raw-pointer\" to indicate the backend should\n> > not attempt to scale absolute values to console size.\n> > \"request-raw-pointer\" is only valid if \"request-abs-pointer\" is\n> > also set. Raw unscaled pointer values are in the range [0, 0x7fff]\n> > \n> > Signed-off-by: Owen Smith \n> \n> Hi Owen,\n> \n> Why did you remove the following from the commit description?\n> > \"feature-raw-pointer\" and \"request-raw-pointer\" added to Xen\n> > header in commit 7868654ff7fe5e4a2eeae2b277644fa884a5031e\n> \n> I think that with it, you could have kept stefano's reviewed-by tag.\n\nHi Anthony,\n\nHave you tested this series with a few of different guests? Do you\nconsider it safe to merge? If so, we can send it upstream (either via\nxen or via ui as Gerd kindly offered).","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=sstabellini@kernel.org"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yBYpS1XwDz9t42\n\tfor ;\n\tWed, 11 Oct 2017 10:53:18 +1100 (AEDT)","from localhost ([::1]:37860 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e24Kp-0001Wp-FJ\n\tfor incoming@patchwork.ozlabs.org; Tue, 10 Oct 2017 19:53:15 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:43909)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e24KW-0001Wj-Jk\n\tfor qemu-devel@nongnu.org; Tue, 10 Oct 2017 19:52:57 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e24KT-0007H6-VT\n\tfor qemu-devel@nongnu.org; Tue, 10 Oct 2017 19:52:56 -0400","from mail.kernel.org ([198.145.29.99]:38300)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1e24KT-0007Gf-P4\n\tfor qemu-devel@nongnu.org; Tue, 10 Oct 2017 19:52:53 -0400","from [10.149.184.130]\n\t(162-198-228-33.lightspeed.wlfrct.sbcglobal.net [162.198.228.33])\n\t(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id 2A38A218BC;\n\tTue, 10 Oct 2017 23:52:51 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org 2A38A218BC","Date":"Tue, 10 Oct 2017 16:52:48 -0700 (PDT)","From":"Stefano Stabellini ","X-X-Sender":"sstabellini@sstabellini-ThinkPad-X260","To":"Anthony PERARD ","In-Reply-To":"<20171002170132.GA2116@perard.uk.xensource.com>","Message-ID":"","References":"<1506437019-17946-1-git-send-email-owen.smith@citrix.com>\n\t<1506437019-17946-4-git-send-email-owen.smith@citrix.com>\n\t<20171002170132.GA2116@perard.uk.xensource.com>","User-Agent":"Alpine 2.10 (DEB 1266 2009-07-14)","MIME-Version":"1.0","Content-Type":"TEXT/PLAIN; charset=US-ASCII","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"198.145.29.99","Subject":"Re: [Qemu-devel] [PATCH 3/3 v4] xenfb: Add\n\t[feature|request]-raw-pointer","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, xen-devel@lists.xenproject.org,\n\tsstabellini@kernel.org, Owen Smith ,\n\tkraxel@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1784752,"web_url":"http://patchwork.ozlabs.org/comment/1784752/","msgid":"<20171011154718.GQ1771@perard.uk.xensource.com>","list_archive_url":null,"date":"2017-10-11T15:47:18","subject":"Re: [Qemu-devel] [PATCH 3/3 v4] xenfb: Add\n\t[feature|request]-raw-pointer","submitter":{"id":4759,"url":"http://patchwork.ozlabs.org/api/people/4759/","name":"Anthony PERARD","email":"anthony.perard@citrix.com"},"content":"On Tue, Oct 10, 2017 at 04:52:48PM -0700, Stefano Stabellini wrote:\n> On Mon, 2 Oct 2017, Anthony PERARD wrote:\n> > On Tue, Sep 26, 2017 at 02:43:39PM +0000, Owen Smith wrote:\n> > > Writes \"feature-raw-pointer\" during init to indicate the backend\n> > > can pass raw unscaled values for absolute axes to the frontend.\n> > > Frontends set \"request-raw-pointer\" to indicate the backend should\n> > > not attempt to scale absolute values to console size.\n> > > \"request-raw-pointer\" is only valid if \"request-abs-pointer\" is\n> > > also set. Raw unscaled pointer values are in the range [0, 0x7fff]\n> > > \n> > > Signed-off-by: Owen Smith \n> > \n> > Hi Owen,\n> > \n> > Why did you remove the following from the commit description?\n> > > \"feature-raw-pointer\" and \"request-raw-pointer\" added to Xen\n> > > header in commit 7868654ff7fe5e4a2eeae2b277644fa884a5031e\n> > \n> > I think that with it, you could have kept stefano's reviewed-by tag.\n> \n> Hi Anthony,\n> \n> Have you tested this series with a few of different guests? Do you\n> consider it safe to merge? If so, we can send it upstream (either via\n> xen or via ui as Gerd kindly offered). \n\nYes, I think it's fine.\n\nThe only observation I have is that on a Linux guest, when I have\nusbdevice=tablet, with this series the pv mouse seems to become the\nprimary way of gueting mouse events (without, the tablet is primary).\nSo, on my VNC client instead of having both mouse in the guest and on my\ndesktop being at the same place, there is like a zoom of the mouse (the\nzoom centered on the top-left corner). (That's better than relative\nmouse event that we can get with the emulation.)","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yBz003P3Mz9s7F\n\tfor ;\n\tThu, 12 Oct 2017 02:47:58 +1100 (AEDT)","from localhost ([::1]:41506 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e2JEf-00060a-WD\n\tfor incoming@patchwork.ozlabs.org; Wed, 11 Oct 2017 11:47:54 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41710)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1e2JEJ-00060T-E3\n\tfor qemu-devel@nongnu.org; Wed, 11 Oct 2017 11:47:32 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1e2JEE-0001N1-KR\n\tfor qemu-devel@nongnu.org; Wed, 11 Oct 2017 11:47:30 -0400","from smtp02.citrix.com ([66.165.176.63]:34173)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71)\n\t(envelope-from )\n\tid 1e2JEE-0001MC-Cy\n\tfor qemu-devel@nongnu.org; Wed, 11 Oct 2017 11:47:26 -0400"],"X-IronPort-AV":"E=Sophos;i=\"5.43,361,1503360000\"; d=\"scan'208\";a=\"453429581\"","Date":"Wed, 11 Oct 2017 16:47:18 +0100","From":"Anthony PERARD ","To":"Stefano Stabellini ","Message-ID":"<20171011154718.GQ1771@perard.uk.xensource.com>","References":"<1506437019-17946-1-git-send-email-owen.smith@citrix.com>\n\t<1506437019-17946-4-git-send-email-owen.smith@citrix.com>\n\t<20171002170132.GA2116@perard.uk.xensource.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.9.1 (2017-09-22)","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"66.165.176.63","Subject":"Re: [Qemu-devel] [PATCH 3/3 v4] xenfb: Add\n\t[feature|request]-raw-pointer","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, xen-devel@lists.xenproject.org,\n\tOwen Smith , kraxel@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1784929,"web_url":"http://patchwork.ozlabs.org/comment/1784929/","msgid":"","list_archive_url":null,"date":"2017-10-11T20:19:25","subject":"Re: [Qemu-devel] [PATCH 3/3 v4] xenfb: Add\n\t[feature|request]-raw-pointer","submitter":{"id":68602,"url":"http://patchwork.ozlabs.org/api/people/68602/","name":"Stefano Stabellini","email":"sstabellini@kernel.org"},"content":"On Wed, 11 Oct 2017, Anthony PERARD wrote:\n> On Tue, Oct 10, 2017 at 04:52:48PM -0700, Stefano Stabellini wrote:\n> > On Mon, 2 Oct 2017, Anthony PERARD wrote:\n> > > On Tue, Sep 26, 2017 at 02:43:39PM +0000, Owen Smith wrote:\n> > > > Writes \"feature-raw-pointer\" during init to indicate the backend\n> > > > can pass raw unscaled values for absolute axes to the frontend.\n> > > > Frontends set \"request-raw-pointer\" to indicate the backend should\n> > > > not attempt to scale absolute values to console size.\n> > > > \"request-raw-pointer\" is only valid if \"request-abs-pointer\" is\n> > > > also set. Raw unscaled pointer values are in the range [0, 0x7fff]\n> > > > \n> > > > Signed-off-by: Owen Smith \n> > > \n> > > Hi Owen,\n> > > \n> > > Why did you remove the following from the commit description?\n> > > > \"feature-raw-pointer\" and \"request-raw-pointer\" added to Xen\n> > > > header in commit 7868654ff7fe5e4a2eeae2b277644fa884a5031e\n> > > \n> > > I think that with it, you could have kept stefano's reviewed-by tag.\n> > \n> > Hi Anthony,\n> > \n> > Have you tested this series with a few of different guests? Do you\n> > consider it safe to merge? If so, we can send it upstream (either via\n> > xen or via ui as Gerd kindly offered). \n> \n> Yes, I think it's fine.\n> \n> The only observation I have is that on a Linux guest, when I have\n> usbdevice=tablet, with this series the pv mouse seems to become the\n> primary way of gueting mouse events (without, the tablet is primary).\n> So, on my VNC client instead of having both mouse in the guest and on my\n> desktop being at the same place, there is like a zoom of the mouse (the\n> zoom centered on the top-left corner). (That's better than relative\n> mouse event that we can get with the emulation.)\n\nThanks for testing. I am not completely sure about what should be the\nright behavior when both usbdevice=tablet and pvmouse are present.\nTypically, PV devices take precedence over emulated devices, so maybe\nit is OK that PV mouse is the primary device in this case.\n\nBut we would need to document this behavioral change in the commit\ndescriptions.\n\nThe other question is whether the \"zoom of the mouse\" you are seeing is\nnormal or whether we can \"fix\" it somehow. I guess it has always been\nthe case for PV mouse? It is not something new, is it?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=sstabellini@kernel.org"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yC5284C6Hz9sBd\n\tfor ;\n\tThu, 12 Oct 2017 07:20:12 +1100 (AEDT)","from localhost ([::1]:42540 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e2NU7-0006MT-Fj\n\tfor incoming@patchwork.ozlabs.org; Wed, 11 Oct 2017 16:20:07 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:58360)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e2NTX-0006M9-PM\n\tfor qemu-devel@nongnu.org; Wed, 11 Oct 2017 16:19:32 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e2NTT-0002Lp-P3\n\tfor qemu-devel@nongnu.org; Wed, 11 Oct 2017 16:19:31 -0400","from mail.kernel.org ([198.145.29.99]:34100)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1e2NTT-0002Kn-Iq\n\tfor qemu-devel@nongnu.org; Wed, 11 Oct 2017 16:19:27 -0400","from [10.149.184.130]\n\t(162-198-228-33.lightspeed.wlfrct.sbcglobal.net [162.198.228.33])\n\t(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id 0CB8D204EE;\n\tWed, 11 Oct 2017 20:19:26 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org 0CB8D204EE","Date":"Wed, 11 Oct 2017 13:19:25 -0700 (PDT)","From":"Stefano Stabellini ","X-X-Sender":"sstabellini@sstabellini-ThinkPad-X260","To":"Anthony PERARD ","In-Reply-To":"<20171011154718.GQ1771@perard.uk.xensource.com>","Message-ID":"","References":"<1506437019-17946-1-git-send-email-owen.smith@citrix.com>\n\t<1506437019-17946-4-git-send-email-owen.smith@citrix.com>\n\t<20171002170132.GA2116@perard.uk.xensource.com>\n\t\n\t<20171011154718.GQ1771@perard.uk.xensource.com>","User-Agent":"Alpine 2.10 (DEB 1266 2009-07-14)","MIME-Version":"1.0","Content-Type":"TEXT/PLAIN; charset=US-ASCII","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"198.145.29.99","Subject":"Re: [Qemu-devel] [PATCH 3/3 v4] xenfb: Add\n\t[feature|request]-raw-pointer","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, xen-devel@lists.xenproject.org,\n\tStefano Stabellini ,\n\tOwen Smith , kraxel@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1785192,"web_url":"http://patchwork.ozlabs.org/comment/1785192/","msgid":"","list_archive_url":null,"date":"2017-10-12T07:58:50","subject":"Re: [Qemu-devel] [Xen-devel] [PATCH 3/3 v4] xenfb:\n\tAdd\t[feature|request]-raw-pointer","submitter":{"id":11456,"url":"http://patchwork.ozlabs.org/api/people/11456/","name":"Paul Durrant","email":"Paul.Durrant@citrix.com"},"content":"> -----Original Message-----\r\n> From: Xen-devel [mailto:xen-devel-bounces@lists.xen.org] On Behalf Of\r\n> Stefano Stabellini\r\n> Sent: 11 October 2017 21:19\r\n> To: Anthony Perard \r\n> Cc: qemu-devel@nongnu.org; xen-devel@lists.xenproject.org; Stefano\r\n> Stabellini ; Owen Smith ;\r\n> kraxel@redhat.com\r\n> Subject: Re: [Xen-devel] [PATCH 3/3 v4] xenfb: Add [feature|request]-raw-\r\n> pointer\r\n> \r\n> On Wed, 11 Oct 2017, Anthony PERARD wrote:\r\n> > On Tue, Oct 10, 2017 at 04:52:48PM -0700, Stefano Stabellini wrote:\r\n> > > On Mon, 2 Oct 2017, Anthony PERARD wrote:\r\n> > > > On Tue, Sep 26, 2017 at 02:43:39PM +0000, Owen Smith wrote:\r\n> > > > > Writes \"feature-raw-pointer\" during init to indicate the backend\r\n> > > > > can pass raw unscaled values for absolute axes to the frontend.\r\n> > > > > Frontends set \"request-raw-pointer\" to indicate the backend should\r\n> > > > > not attempt to scale absolute values to console size.\r\n> > > > > \"request-raw-pointer\" is only valid if \"request-abs-pointer\" is\r\n> > > > > also set. Raw unscaled pointer values are in the range [0, 0x7fff]\r\n> > > > >\r\n> > > > > Signed-off-by: Owen Smith \r\n> > > >\r\n> > > > Hi Owen,\r\n> > > >\r\n> > > > Why did you remove the following from the commit description?\r\n> > > > > \"feature-raw-pointer\" and \"request-raw-pointer\" added to Xen\r\n> > > > > header in commit 7868654ff7fe5e4a2eeae2b277644fa884a5031e\r\n> > > >\r\n> > > > I think that with it, you could have kept stefano's reviewed-by tag.\r\n> > >\r\n> > > Hi Anthony,\r\n> > >\r\n> > > Have you tested this series with a few of different guests? Do you\r\n> > > consider it safe to merge? If so, we can send it upstream (either via\r\n> > > xen or via ui as Gerd kindly offered).\r\n> >\r\n> > Yes, I think it's fine.\r\n> >\r\n> > The only observation I have is that on a Linux guest, when I have\r\n> > usbdevice=tablet, with this series the pv mouse seems to become the\r\n> > primary way of gueting mouse events (without, the tablet is primary).\r\n> > So, on my VNC client instead of having both mouse in the guest and on my\r\n> > desktop being at the same place, there is like a zoom of the mouse (the\r\n> > zoom centered on the top-left corner). (That's better than relative\r\n> > mouse event that we can get with the emulation.)\r\n> \r\n> Thanks for testing. I am not completely sure about what should be the\r\n> right behavior when both usbdevice=tablet and pvmouse are present.\r\n> Typically, PV devices take precedence over emulated devices, so maybe\r\n> it is OK that PV mouse is the primary device in this case.\r\n> \r\n> But we would need to document this behavioral change in the commit\r\n> descriptions.\r\n> \r\n\r\nIt's probably OS specific though. I guess the behaviour changed because the OS favours absolute pointing devices over relative ones and how it has two absolute ones to choose from. How it reconciles those, who knows?\r\n\r\n Paul\r\n\r\n> The other question is whether the \"zoom of the mouse\" you are seeing is\r\n> normal or whether we can \"fix\" it somehow. I guess it has always been\r\n> the case for PV mouse? It is not something new, is it?\r\n> \r\n> _______________________________________________\r\n> Xen-devel mailing list\r\n> Xen-devel@lists.xen.org\r\n> https://lists.xen.org/xen-devel","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yCNZx6J1xz9t2W\n\tfor ;\n\tThu, 12 Oct 2017 19:01:09 +1100 (AEDT)","from localhost ([::1]:44206 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e2YQQ-0002Qx-LD\n\tfor incoming@patchwork.ozlabs.org; Thu, 12 Oct 2017 04:01:02 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:46332)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1e2YPi-0002H8-LQ\n\tfor qemu-devel@nongnu.org; Thu, 12 Oct 2017 04:00:23 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1e2YPa-0005K5-Ev\n\tfor qemu-devel@nongnu.org; Thu, 12 Oct 2017 04:00:18 -0400","from smtp.citrix.com.au ([103.14.252.240]:59569)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71)\n\t(envelope-from )\n\tid 1e2YPZ-0005Ev-QC\n\tfor qemu-devel@nongnu.org; Thu, 12 Oct 2017 04:00:10 -0400"],"X-IronPort-AV":"E=Sophos;i=\"5.43,365,1503360000\"; d=\"scan'208\";a=\"106288831\"","From":"Paul Durrant ","To":"'Stefano Stabellini' , Anthony Perard\n\t","Thread-Topic":"[Xen-devel] [PATCH 3/3 v4] xenfb: Add\n\t[feature|request]-raw-pointer","Thread-Index":"AQHTQiPXOFgaS/jba0SfFBW7oOT0uKLeqqAAgABMB4CAAORGEA==","Date":"Thu, 12 Oct 2017 07:58:50 +0000","Message-ID":"","References":"<1506437019-17946-1-git-send-email-owen.smith@citrix.com>\n\t<1506437019-17946-4-git-send-email-owen.smith@citrix.com>\n\t<20171002170132.GA2116@perard.uk.xensource.com>\n\t\n\t<20171011154718.GQ1771@perard.uk.xensource.com>\n\t","In-Reply-To":"","Accept-Language":"en-GB, en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-ms-exchange-transport-fromentityheader":"Hosted","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","MIME-Version":"1.0","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"103.14.252.240","Subject":"Re: [Qemu-devel] [Xen-devel] [PATCH 3/3 v4] xenfb:\n\tAdd\t[feature|request]-raw-pointer","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"\"xen-devel@lists.xenproject.org\" ,\n\t\"kraxel@redhat.com\" ,\n\t\"qemu-devel@nongnu.org\" ,\n\tOwen Smith ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1785238,"web_url":"http://patchwork.ozlabs.org/comment/1785238/","msgid":"<1507800365.26812.11.camel@redhat.com>","list_archive_url":null,"date":"2017-10-12T09:26:05","subject":"Re: [Qemu-devel] [Xen-devel] [PATCH 3/3 v4] xenfb: Add\n\t[feature|request]-raw-pointer","submitter":{"id":589,"url":"http://patchwork.ozlabs.org/api/people/589/","name":"Gerd Hoffmann","email":"kraxel@redhat.com"},"content":"Hi,\n\n> It's probably OS specific though. I guess the behaviour changed\n> because the OS favours absolute pointing devices over relative ones\n> and how it has two absolute ones to choose from. How it reconciles\n> those, who knows?\n\nTypically hid emulation calls qemu_input_handler_activate() when the\nguest initializes the device, which moves the device to the top of the\npriority list.\n\nVisible effect on a typical guest with ps/2 mouse and usb-tablet is\nthat qemu switches from relative mode (mouse) to absolute mode (tablet)\n when the guest loads the usb hid driver.\n\nI suspect pvmouse is doing the same thing. So it may simply depend on\nguest driver load order whenever pvmouse or usb-tablet is used.\n\nSimplest fix is probably to only attach the device you plan to use to\nthe guest. If you can't turn off pvmouse for xen guests then you might\nwant drop the qemu_input_handler_activate() call, so it behaves simliar\nto the ps/2 mouse (is used in case no other pointer device is present).\n\nHTH,\n Gerd","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=kraxel@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yCQTg5Tcrz9t2m\n\tfor ;\n\tThu, 12 Oct 2017 20:26:47 +1100 (AEDT)","from localhost ([::1]:44419 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e2ZlN-0008Vz-SP\n\tfor incoming@patchwork.ozlabs.org; Thu, 12 Oct 2017 05:26:45 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:51374)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e2Zkr-0008UL-PP\n\tfor qemu-devel@nongnu.org; Thu, 12 Oct 2017 05:26:14 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e2Zko-0003uJ-1M\n\tfor qemu-devel@nongnu.org; Thu, 12 Oct 2017 05:26:13 -0400","from mx1.redhat.com ([209.132.183.28]:37072)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1e2Zkn-0003sZ-Qv\n\tfor qemu-devel@nongnu.org; Thu, 12 Oct 2017 05:26:09 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 421BA2C971C;\n\tThu, 12 Oct 2017 09:26:07 +0000 (UTC)","from sirius.home.kraxel.org (ovpn-116-239.ams2.redhat.com\n\t[10.36.116.239])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id E14DF5C663;\n\tThu, 12 Oct 2017 09:26:06 +0000 (UTC)","from localhost (localhost [IPv6:::1])\n\tby sirius.home.kraxel.org (Postfix) with ESMTP id C0C1920488;\n\tThu, 12 Oct 2017 11:26:05 +0200 (CEST)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 421BA2C971C","Message-ID":"<1507800365.26812.11.camel@redhat.com>","From":"Gerd Hoffmann ","To":"Paul Durrant , 'Stefano Stabellini'\n\t, Anthony Perard ","Date":"Thu, 12 Oct 2017 11:26:05 +0200","In-Reply-To":"","References":"<1506437019-17946-1-git-send-email-owen.smith@citrix.com>\n\t<1506437019-17946-4-git-send-email-owen.smith@citrix.com>\n\t<20171002170132.GA2116@perard.uk.xensource.com>\n\t\n\t<20171011154718.GQ1771@perard.uk.xensource.com>\n\t\n\t","Content-Type":"text/plain; charset=\"UTF-8\"","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tThu, 12 Oct 2017 09:26:07 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [Xen-devel] [PATCH 3/3 v4] xenfb: Add\n\t[feature|request]-raw-pointer","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"\"xen-devel@lists.xenproject.org\" ,\n\t\"qemu-devel@nongnu.org\" ,\n\tOwen Smith ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1785253,"web_url":"http://patchwork.ozlabs.org/comment/1785253/","msgid":"<0941888f3e184161a54e9c4509a1faab@AMSPEX02CL03.citrite.net>","list_archive_url":null,"date":"2017-10-12T09:39:16","subject":"Re: [Qemu-devel] [Xen-devel] [PATCH 3/3 v4] xenfb: Add\n\t[feature|request]-raw-pointer","submitter":{"id":11456,"url":"http://patchwork.ozlabs.org/api/people/11456/","name":"Paul Durrant","email":"Paul.Durrant@citrix.com"},"content":"> -----Original Message-----\r\n> From: Gerd Hoffmann [mailto:kraxel@redhat.com]\r\n> Sent: 12 October 2017 10:26\r\n> To: Paul Durrant ; 'Stefano Stabellini'\r\n> ; Anthony Perard \r\n> Cc: qemu-devel@nongnu.org; xen-devel@lists.xenproject.org; Owen Smith\r\n> \r\n> Subject: Re: [Xen-devel] [PATCH 3/3 v4] xenfb: Add [feature|request]-raw-\r\n> pointer\r\n> \r\n> Hi,\r\n> \r\n> > It's probably OS specific though. I guess the behaviour changed\r\n> > because the OS favours absolute pointing devices over relative ones\r\n> > and how it has two absolute ones to choose from. How it reconciles\r\n> > those, who knows?\r\n> \r\n> Typically hid emulation calls qemu_input_handler_activate() when the\r\n> guest initializes the device, which moves the device to the top of the\r\n> priority list.\r\n> \r\n> Visible effect on a typical guest with ps/2 mouse and usb-tablet is\r\n> that qemu switches from relative mode (mouse) to absolute mode (tablet)\r\n> when the guest loads the usb hid driver.\r\n> \r\n> I suspect pvmouse is doing the same thing. So it may simply depend on\r\n> guest driver load order whenever pvmouse or usb-tablet is used.\r\n> \r\n> Simplest fix is probably to only attach the device you plan to use to\r\n> the guest. If you can't turn off pvmouse for xen guests then you might\r\n> want drop the qemu_input_handler_activate() call, so it behaves simliar\r\n> to the ps/2 mouse (is used in case no other pointer device is present).\r\n\r\nAvoiding the activate call sounds reasonable and should avoid the behavioural change.\r\n\r\nCheers,\r\n\r\n Paul\r\n\r\n> \r\n> HTH,\r\n> Gerd","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yCQmm28Qbz9t2l\n\tfor ;\n\tThu, 12 Oct 2017 20:39:51 +1100 (AEDT)","from localhost ([::1]:44479 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e2Zy1-0006Hr-2Z\n\tfor incoming@patchwork.ozlabs.org; Thu, 12 Oct 2017 05:39:49 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:57854)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1e2Zxi-0006Hj-9F\n\tfor qemu-devel@nongnu.org; Thu, 12 Oct 2017 05:39:31 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1e2Zxf-0005MM-6q\n\tfor qemu-devel@nongnu.org; Thu, 12 Oct 2017 05:39:30 -0400","from smtp.citrix.com.au ([103.14.252.240]:24204)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71)\n\t(envelope-from )\n\tid 1e2Zxe-0005Jy-IL\n\tfor qemu-devel@nongnu.org; Thu, 12 Oct 2017 05:39:27 -0400"],"X-IronPort-AV":"E=Sophos;i=\"5.43,365,1503360000\"; d=\"scan'208\";a=\"106291320\"","From":"Paul Durrant ","To":"'Gerd Hoffmann' , 'Stefano Stabellini'\n\t, Anthony Perard ","Thread-Topic":"[Xen-devel] [PATCH 3/3 v4] xenfb: Add\n\t[feature|request]-raw-pointer","Thread-Index":"AQHTQzwk1vjhMegnuU+gwnfNR5R6N6Lf9Dyg","Date":"Thu, 12 Oct 2017 09:39:16 +0000","Message-ID":"<0941888f3e184161a54e9c4509a1faab@AMSPEX02CL03.citrite.net>","References":"<1506437019-17946-1-git-send-email-owen.smith@citrix.com>\n\t<1506437019-17946-4-git-send-email-owen.smith@citrix.com>\n\t<20171002170132.GA2116@perard.uk.xensource.com>\n\t\n\t<20171011154718.GQ1771@perard.uk.xensource.com>\n\t\n\t\n\t<1507800365.26812.11.camel@redhat.com>","In-Reply-To":"<1507800365.26812.11.camel@redhat.com>","Accept-Language":"en-GB, en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-ms-exchange-transport-fromentityheader":"Hosted","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","MIME-Version":"1.0","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"103.14.252.240","Subject":"Re: [Qemu-devel] [Xen-devel] [PATCH 3/3 v4] xenfb: Add\n\t[feature|request]-raw-pointer","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"\"xen-devel@lists.xenproject.org\" ,\n\t\"qemu-devel@nongnu.org\" ,\n\tOwen Smith ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1785305,"web_url":"http://patchwork.ozlabs.org/comment/1785305/","msgid":"<20171012103832.GT1771@perard.uk.xensource.com>","list_archive_url":null,"date":"2017-10-12T10:38:32","subject":"Re: [Qemu-devel] [PATCH 3/3 v4] xenfb: Add\n\t[feature|request]-raw-pointer","submitter":{"id":4759,"url":"http://patchwork.ozlabs.org/api/people/4759/","name":"Anthony PERARD","email":"anthony.perard@citrix.com"},"content":"On Wed, Oct 11, 2017 at 01:19:25PM -0700, Stefano Stabellini wrote:\n> On Wed, 11 Oct 2017, Anthony PERARD wrote:\n> > The only observation I have is that on a Linux guest, when I have\n> > usbdevice=tablet, with this series the pv mouse seems to become the\n> > primary way of gueting mouse events (without, the tablet is primary).\n> > So, on my VNC client instead of having both mouse in the guest and on my\n> > desktop being at the same place, there is like a zoom of the mouse (the\n> > zoom centered on the top-left corner). (That's better than relative\n> > mouse event that we can get with the emulation.)\n> \n> Thanks for testing. I am not completely sure about what should be the\n> right behavior when both usbdevice=tablet and pvmouse are present.\n> Typically, PV devices take precedence over emulated devices, so maybe\n> it is OK that PV mouse is the primary device in this case.\n> \n> But we would need to document this behavioral change in the commit\n> descriptions.\n\nMaybe something like \"WARNING: pvmouse is fixed and now works!\" :)\n\nI think the change come from the fact that without the second patch, the\npv mouse doesn't work (or at least, I did not manage to make it work).\n\n> The other question is whether the \"zoom of the mouse\" you are seeing is\n> normal or whether we can \"fix\" it somehow. I guess it has always been\n> the case for PV mouse? It is not something new, is it?\n\nYes, I think it always as been the case for PV mouse. I pretty sure I've\nseen this behavior long time ago.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yCS4y1vBhz9t2l\n\tfor ;\n\tThu, 12 Oct 2017 21:38:58 +1100 (AEDT)","from localhost ([::1]:44717 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e2atE-00079T-Dr\n\tfor incoming@patchwork.ozlabs.org; Thu, 12 Oct 2017 06:38:56 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:54960)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1e2asw-00079C-DN\n\tfor qemu-devel@nongnu.org; Thu, 12 Oct 2017 06:38:39 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1e2ast-0000jw-99\n\tfor qemu-devel@nongnu.org; Thu, 12 Oct 2017 06:38:38 -0400","from smtp.citrix.com ([66.165.176.89]:41636)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71)\n\t(envelope-from )\n\tid 1e2ast-0000gs-2Y\n\tfor qemu-devel@nongnu.org; Thu, 12 Oct 2017 06:38:35 -0400"],"X-IronPort-AV":"E=Sophos;i=\"5.43,365,1503360000\"; d=\"scan'208\";a=\"445646278\"","Date":"Thu, 12 Oct 2017 11:38:32 +0100","From":"Anthony PERARD ","To":"Stefano Stabellini ","Message-ID":"<20171012103832.GT1771@perard.uk.xensource.com>","References":"<1506437019-17946-1-git-send-email-owen.smith@citrix.com>\n\t<1506437019-17946-4-git-send-email-owen.smith@citrix.com>\n\t<20171002170132.GA2116@perard.uk.xensource.com>\n\t\n\t<20171011154718.GQ1771@perard.uk.xensource.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.9.1 (2017-09-22)","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"66.165.176.89","Subject":"Re: [Qemu-devel] [PATCH 3/3 v4] xenfb: Add\n\t[feature|request]-raw-pointer","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, xen-devel@lists.xenproject.org,\n\tOwen Smith , kraxel@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1785687,"web_url":"http://patchwork.ozlabs.org/comment/1785687/","msgid":"","list_archive_url":null,"date":"2017-10-12T17:27:01","subject":"Re: [Qemu-devel] [Xen-devel] [PATCH 3/3 v4] xenfb: Add\n\t[feature|request]-raw-pointer","submitter":{"id":68602,"url":"http://patchwork.ozlabs.org/api/people/68602/","name":"Stefano Stabellini","email":"sstabellini@kernel.org"},"content":"On Thu, 12 Oct 2017, Paul Durrant wrote:\n> > -----Original Message-----\n> > From: Gerd Hoffmann [mailto:kraxel@redhat.com]\n> > Sent: 12 October 2017 10:26\n> > To: Paul Durrant ; 'Stefano Stabellini'\n> > ; Anthony Perard \n> > Cc: qemu-devel@nongnu.org; xen-devel@lists.xenproject.org; Owen Smith\n> > \n> > Subject: Re: [Xen-devel] [PATCH 3/3 v4] xenfb: Add [feature|request]-raw-\n> > pointer\n> > \n> > Hi,\n> > \n> > > It's probably OS specific though. I guess the behaviour changed\n> > > because the OS favours absolute pointing devices over relative ones\n> > > and how it has two absolute ones to choose from. How it reconciles\n> > > those, who knows?\n> > \n> > Typically hid emulation calls qemu_input_handler_activate() when the\n> > guest initializes the device, which moves the device to the top of the\n> > priority list.\n> > \n> > Visible effect on a typical guest with ps/2 mouse and usb-tablet is\n> > that qemu switches from relative mode (mouse) to absolute mode (tablet)\n> > when the guest loads the usb hid driver.\n> > \n> > I suspect pvmouse is doing the same thing. So it may simply depend on\n> > guest driver load order whenever pvmouse or usb-tablet is used.\n> > \n> > Simplest fix is probably to only attach the device you plan to use to\n> > the guest. If you can't turn off pvmouse for xen guests then you might\n> > want drop the qemu_input_handler_activate() call, so it behaves simliar\n> > to the ps/2 mouse (is used in case no other pointer device is present).\n> \n> Avoiding the activate call sounds reasonable and should avoid the behavioural change.\n\n+1\n\nOwen, are you up for resubmitting the series with this small change?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=sstabellini@kernel.org"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yCd8d09wvz9t2r\n\tfor ;\n\tFri, 13 Oct 2017 04:27:43 +1100 (AEDT)","from localhost ([::1]:46620 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e2hGn-0006WF-Eb\n\tfor incoming@patchwork.ozlabs.org; Thu, 12 Oct 2017 13:27:41 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:40822)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e2hGT-0006Vz-A8\n\tfor qemu-devel@nongnu.org; Thu, 12 Oct 2017 13:27:22 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e2hGP-0007hL-8F\n\tfor qemu-devel@nongnu.org; Thu, 12 Oct 2017 13:27:21 -0400","from mail.kernel.org ([198.145.29.99]:55522)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1e2hGP-0007gn-1L\n\tfor qemu-devel@nongnu.org; Thu, 12 Oct 2017 13:27:17 -0400","from [10.0.0.56] (c-24-130-70-9.hsd1.ca.comcast.net [24.130.70.9])\n\t(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id 3D33621874;\n\tThu, 12 Oct 2017 17:27:14 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org 3D33621874","Date":"Thu, 12 Oct 2017 10:27:01 -0700 (PDT)","From":"Stefano Stabellini ","X-X-Sender":"sstabellini@sstabellini-ThinkPad-X260","To":"Paul Durrant ","In-Reply-To":"<0941888f3e184161a54e9c4509a1faab@AMSPEX02CL03.citrite.net>","Message-ID":"","References":"<1506437019-17946-1-git-send-email-owen.smith@citrix.com>\n\t<1506437019-17946-4-git-send-email-owen.smith@citrix.com>\n\t<20171002170132.GA2116@perard.uk.xensource.com>\n\t\n\t<20171011154718.GQ1771@perard.uk.xensource.com>\n\t\n\t\n\t<1507800365.26812.11.camel@redhat.com>\n\t<0941888f3e184161a54e9c4509a1faab@AMSPEX02CL03.citrite.net>","User-Agent":"Alpine 2.10 (DEB 1266 2009-07-14)","MIME-Version":"1.0","Content-Type":"TEXT/PLAIN; charset=US-ASCII","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"198.145.29.99","Subject":"Re: [Qemu-devel] [Xen-devel] [PATCH 3/3 v4] xenfb: Add\n\t[feature|request]-raw-pointer","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"'Stefano Stabellini' ,\n\tOwen Smith ,\n\t\"qemu-devel@nongnu.org\" ,\n\t'Gerd Hoffmann' ,\n\tAnthony Perard ,\n\t\"xen-devel@lists.xenproject.org\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1790255,"web_url":"http://patchwork.ozlabs.org/comment/1790255/","msgid":"<5136b1e64d2c412aab5f5a5264a599e2@AMSPEX02CL02.citrite.net>","list_archive_url":null,"date":"2017-10-19T09:00:27","subject":"Re: [Qemu-devel] [Xen-devel] [PATCH 3/3 v4] xenfb: Add\n\t[feature|request]-raw-pointer","submitter":{"id":64781,"url":"http://patchwork.ozlabs.org/api/people/64781/","name":"Owen Smith","email":"owen.smith@citrix.com"},"content":"> -----Original Message-----\n> From: Stefano Stabellini [mailto:sstabellini@kernel.org]\n> Sent: 12 October 2017 18:27\n> To: Paul Durrant \n> Cc: 'Gerd Hoffmann' ; 'Stefano Stabellini'\n> ; Anthony Perard ;\n> qemu-devel@nongnu.org; xen-devel@lists.xenproject.org; Owen Smith\n> \n> Subject: RE: [Xen-devel] [PATCH 3/3 v4] xenfb: Add [feature|request]-raw-\n> pointer\n> \n> On Thu, 12 Oct 2017, Paul Durrant wrote:\n> > > -----Original Message-----\n> > > From: Gerd Hoffmann [mailto:kraxel@redhat.com]\n> > > Sent: 12 October 2017 10:26\n> > > To: Paul Durrant ; 'Stefano Stabellini'\n> > > ; Anthony Perard \n> > > Cc: qemu-devel@nongnu.org; xen-devel@lists.xenproject.org; Owen\n> > > Smith \n> > > Subject: Re: [Xen-devel] [PATCH 3/3 v4] xenfb: Add\n> > > [feature|request]-raw- pointer\n> > >\n> > > Hi,\n> > >\n> > > > It's probably OS specific though. I guess the behaviour changed\n> > > > because the OS favours absolute pointing devices over relative\n> > > > ones and how it has two absolute ones to choose from. How it\n> > > > reconciles those, who knows?\n> > >\n> > > Typically hid emulation calls qemu_input_handler_activate() when the\n> > > guest initializes the device, which moves the device to the top of\n> > > the priority list.\n> > >\n> > > Visible effect on a typical guest with ps/2 mouse and usb-tablet is\n> > > that qemu switches from relative mode (mouse) to absolute mode\n> > > (tablet) when the guest loads the usb hid driver.\n> > >\n> > > I suspect pvmouse is doing the same thing. So it may simply depend\n> > > on guest driver load order whenever pvmouse or usb-tablet is used.\n> > >\n> > > Simplest fix is probably to only attach the device you plan to use\n> > > to the guest. If you can't turn off pvmouse for xen guests then you\n> > > might want drop the qemu_input_handler_activate() call, so it\n> > > behaves simliar to the ps/2 mouse (is used in case no other pointer\n> device is present).\n> >\n> > Avoiding the activate call sounds reasonable and should avoid the\n> behavioural change.\n> \n> +1\n> \n> Owen, are you up for resubmitting the series with this small change?\n\nHaving just rebuilt my xen / linux host, and checked qemu, it looks like the keycodemapdb patches have gone in, so I'll rebase and re-submit this series\n\nOwen","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yHjb7614Pz9t2S\n\tfor ;\n\tThu, 19 Oct 2017 20:01:23 +1100 (AEDT)","from localhost ([::1]:48229 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e56he-0004YC-0I\n\tfor incoming@patchwork.ozlabs.org; Thu, 19 Oct 2017 05:01:22 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:54958)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1e56h3-0004Nj-Ry\n\tfor qemu-devel@nongnu.org; Thu, 19 Oct 2017 05:00:49 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1e56gu-00082h-0e\n\tfor qemu-devel@nongnu.org; Thu, 19 Oct 2017 05:00:45 -0400","from smtp.citrix.com.au ([103.14.252.240]:35995)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71)\n\t(envelope-from )\n\tid 1e56gt-0007wt-Cr\n\tfor qemu-devel@nongnu.org; Thu, 19 Oct 2017 05:00:35 -0400"],"X-IronPort-AV":"E=Sophos;i=\"5.43,400,1503360000\"; d=\"scan'208\";a=\"106395039\"","From":"Owen Smith ","To":"Stefano Stabellini , Paul Durrant\n\t","Thread-Topic":"[Xen-devel] [PATCH 3/3 v4] xenfb: Add\n\t[feature|request]-raw-pointer","Thread-Index":"AQHTQzwkjg/R8UJqyU6ybJ/q1oM7h6Lf0/EAgACCsICACpPVIA==","Date":"Thu, 19 Oct 2017 09:00:27 +0000","Message-ID":"<5136b1e64d2c412aab5f5a5264a599e2@AMSPEX02CL02.citrite.net>","References":"<1506437019-17946-1-git-send-email-owen.smith@citrix.com>\n\t<1506437019-17946-4-git-send-email-owen.smith@citrix.com>\n\t<20171002170132.GA2116@perard.uk.xensource.com>\n\t\n\t<20171011154718.GQ1771@perard.uk.xensource.com>\n\t\n\t\n\t<1507800365.26812.11.camel@redhat.com>\n\t<0941888f3e184161a54e9c4509a1faab@AMSPEX02CL03.citrite.net>\n\t","In-Reply-To":"","Accept-Language":"en-GB, en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-ms-exchange-transport-fromentityheader":"Hosted","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"103.14.252.240","Subject":"Re: [Qemu-devel] [Xen-devel] [PATCH 3/3 v4] xenfb: Add\n\t[feature|request]-raw-pointer","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Anthony Perard ,\n\t\"xen-devel@lists.xenproject.org\" ,\n\t'Gerd Hoffmann' ,\n\t\"qemu-devel@nongnu.org\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]