[{"id":1775520,"web_url":"http://patchwork.ozlabs.org/comment/1775520/","msgid":"<6f4a490e-96bc-58b5-c561-4491f175e2e4@redhat.com>","list_archive_url":null,"date":"2017-09-26T13:43:42","subject":"Re: [Qemu-devel] [PATCH v2 1/2] s390x/ais: enable ais when\n\tmigration is available","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":"> +    /* try enable the AIS facility */\n> +    test_attr.group = KVM_DEV_FLIC_AISM_ALL;\n> +    if (!ioctl(flic_state->fd, KVM_HAS_DEVICE_ATTR, test_attr)) {\n> +            kvm_vm_enable_cap(kvm_state, KVM_CAP_S390_AIS, 0);\n> +    }\n> +\n>      return;\n>  fail:\n>      error_propagate(errp, errp_local);\n> @@ -578,7 +584,7 @@ static void kvm_s390_flic_reset(DeviceState *dev)\n>  \n>      flic_disable_wait_pfault(flic);\n>  \n> -    if (fs->ais_supported) {\n> +    if (s390_has_feat(S390_FEAT_ADAPTER_INT_SUPPRESSION)) {\n\nI don't remember if a reset is trigger on realization. Most probably\nnot, but it could be.\n\nWould it hurt if the following code would not get called if the flic\nhasn't been used yet? (possible reset before cpu model has been\ninitialized) - are kvm_s390_modify_ais_mode() calls required before ais\ncan be used for the first time?\n\nIf so, we could add a manual reset after the cpu model has been initialized.\n\n>          for (isc = 0; isc <= MAX_ISC; isc++) {\n>              rc = kvm_s390_modify_ais_mode(fs, isc, SIC_IRQ_MODE_ALL);\n>              if (rc) {\n> diff --git a/hw/s390x/css.c b/hw/s390x/css.c\n> index 75d4f30..1d4bb73 100644\n> --- a/hw/s390x/css.c\n> +++ b/hw/s390x/css.c\n> @@ -1,7 +1,7 @@\n>  /*\n>   * Channel subsystem base support.\n>   *\n> - * Copyright 2012 IBM Corp.\n> + * Copyright IBM Corp. 2012, 2017\n>   * Author(s): Cornelia Huck <cornelia.huck@de.ibm.com>\n>   *\n>   * This work is licensed under the terms of the GNU GPL, version 2 or (at\n> @@ -672,7 +672,7 @@ void css_adapter_interrupt(CssIoAdapterType type, uint8_t isc)\n>      }\n>  \n>      trace_css_adapter_interrupt(isc);\n> -    if (fs->ais_supported) {\n> +    if (s390_has_feat(S390_FEAT_ADAPTER_INT_SUPPRESSION)) {\n>          if (fsc->inject_airq(fs, type, isc, adapter->flags)) {\n>              error_report(\"Failed to inject airq with AIS supported\");\n>              exit(1);\n> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c\n> index fafbc6d..98c82c2 100644\n> --- a/hw/s390x/s390-virtio-ccw.c\n\nLooks much better to me now.","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1hyV3HRnz9s7M\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 26 Sep 2017 23:44:34 +1000 (AEST)","from localhost ([::1]:47626 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dwqA4-0002rM-Cx\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 09:44:32 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:51278)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <david@redhat.com>) id 1dwq9N-0002m8-2n\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 09:43:54 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <david@redhat.com>) id 1dwq9J-0003sp-UO\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 09:43:49 -0400","from mx1.redhat.com ([209.132.183.28]:52708)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <david@redhat.com>) id 1dwq9J-0003sU-NG\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 09:43:45 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id ABE9EC058EAA;\n\tTue, 26 Sep 2017 13:43:44 +0000 (UTC)","from [10.36.117.152] (ovpn-117-152.ams2.redhat.com [10.36.117.152])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 00EB46941A;\n\tTue, 26 Sep 2017 13:43:42 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com ABE9EC058EAA","To":"Christian Borntraeger <borntraeger@de.ibm.com>,\n\tCornelia Huck <cohuck@redhat.com>","References":"<20170926133624.155394-1-borntraeger@de.ibm.com>\n\t<20170926133624.155394-2-borntraeger@de.ibm.com>","From":"David Hildenbrand <david@redhat.com>","Organization":"Red Hat GmbH","Message-ID":"<6f4a490e-96bc-58b5-c561-4491f175e2e4@redhat.com>","Date":"Tue, 26 Sep 2017 15:43:42 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170926133624.155394-2-borntraeger@de.ibm.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tTue, 26 Sep 2017 13:43:44 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 1/2] s390x/ais: enable ais when\n\tmigration is available","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Halil Pasic <pasic@linux.vnet.ibm.com>,\n\tYi Min Zhao <zyimin@linux.vnet.ibm.com>,\n\tqemu-devel <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>,\n\t\"Jason J . Herne\" <jjherne@linux.vnet.ibm.com>,\n\tRichard Henderson <rth@twiddle.net>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1775553,"web_url":"http://patchwork.ozlabs.org/comment/1775553/","msgid":"<debb11b6-3eba-b2fe-961f-52df7b1c5926@de.ibm.com>","list_archive_url":null,"date":"2017-09-26T14:06:51","subject":"Re: [Qemu-devel] [PATCH v2 1/2] s390x/ais: enable ais when\n\tmigration is available","submitter":{"id":590,"url":"http://patchwork.ozlabs.org/api/people/590/","name":"Christian Borntraeger","email":"borntraeger@de.ibm.com"},"content":"On 09/26/2017 03:43 PM, David Hildenbrand wrote:\n> \n>> +    /* try enable the AIS facility */\n>> +    test_attr.group = KVM_DEV_FLIC_AISM_ALL;\n>> +    if (!ioctl(flic_state->fd, KVM_HAS_DEVICE_ATTR, test_attr)) {\n>> +            kvm_vm_enable_cap(kvm_state, KVM_CAP_S390_AIS, 0);\n>> +    }\n>> +\n>>      return;\n>>  fail:\n>>      error_propagate(errp, errp_local);\n>> @@ -578,7 +584,7 @@ static void kvm_s390_flic_reset(DeviceState *dev)\n>>  \n>>      flic_disable_wait_pfault(flic);\n>>  \n>> -    if (fs->ais_supported) {\n>> +    if (s390_has_feat(S390_FEAT_ADAPTER_INT_SUPPRESSION)) {\n> \n> I don't remember if a reset is trigger on realization. Most probably\n> not, but it could be.\n> \n> Would it hurt if the following code would not get called if the flic\n> hasn't been used yet? (possible reset before cpu model has been\n> initialized) - are kvm_s390_modify_ais_mode() calls required before ais\n> can be used for the first time?\n\nHmm, simm/nimm should default to zero in the kernel I guess. So I think it would\nnot hurt. Yi Min, correct?\n\n\nAnyway it seems that reset is NOT called during realize, the first\ncall is\n\n                #0  0x00000000010e5178 kvm_s390_flic_reset (qemu-system-s390x)\n                #1  0x000000000124bbc4 device_reset (qemu-system-s390x)\n                #2  0x0000000001248cd0 qdev_reset_one (qemu-system-s390x)\n                #3  0x0000000001249ea4 qdev_walk_children (qemu-system-s390x)\n                #4  0x000000000124fd3a qbus_walk_children (qemu-system-s390x)\n                #5  0x0000000001248e6c qbus_reset_all (qemu-system-s390x)\n                #6  0x0000000001248eae qbus_reset_all_fn (qemu-system-s390x)\n                #7  0x0000000001250a60 qemu_devices_reset (qemu-system-s390x)\n                #8  0x0000000001143c80 s390_machine_reset (qemu-system-s390x)\n                #9  0x00000000011c5b72 qemu_system_reset (qemu-system-s390x)\n                #10 0x00000000011ceb8e main (qemu-system-s390x)\n                #11 0x000003ff947a289a __libc_start_main (libc.so.6)\n                #12 0x0000000001017646 _start (qemu-system-s390x)","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1jT426R7z9sRV\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 27 Sep 2017 00:07:32 +1000 (AEST)","from localhost ([::1]:47712 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dwqWI-0006Ez-JP\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 10:07:30 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:57501)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <borntraeger@de.ibm.com>) id 1dwqVw-0006Ds-3h\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 10:07:12 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <borntraeger@de.ibm.com>) id 1dwqVr-0006sg-Qb\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 10:07:08 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1]:58296)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <borntraeger@de.ibm.com>)\n\tid 1dwqVr-0006sT-HZ\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 10:07:03 -0400","from pps.filterd (m0098396.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8QE5d6U103357\n\tfor <qemu-devel@nongnu.org>; Tue, 26 Sep 2017 10:06:58 -0400","from e06smtp12.uk.ibm.com (e06smtp12.uk.ibm.com [195.75.94.108])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d7pd71nsj-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <qemu-devel@nongnu.org>; Tue, 26 Sep 2017 10:06:57 -0400","from localhost\n\tby e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <qemu-devel@nongnu.org> from <borntraeger@de.ibm.com>;\n\tTue, 26 Sep 2017 15:06:55 +0100","from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196)\n\tby e06smtp12.uk.ibm.com (192.168.101.142) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tTue, 26 Sep 2017 15:06:52 +0100","from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com\n\t[9.149.105.59])\n\tby b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8QE6qcu21757994; Tue, 26 Sep 2017 14:06:52 GMT","from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 61FB4A4040;\n\tTue, 26 Sep 2017 15:02:45 +0100 (BST)","from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 24370A404D;\n\tTue, 26 Sep 2017 15:02:45 +0100 (BST)","from oc7330422307.ibm.com (unknown [9.152.224.56])\n\tby d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tTue, 26 Sep 2017 15:02:45 +0100 (BST)"],"To":"David Hildenbrand <david@redhat.com>, Cornelia Huck <cohuck@redhat.com>","References":"<20170926133624.155394-1-borntraeger@de.ibm.com>\n\t<20170926133624.155394-2-borntraeger@de.ibm.com>\n\t<6f4a490e-96bc-58b5-c561-4491f175e2e4@redhat.com>","From":"Christian Borntraeger <borntraeger@de.ibm.com>","Date":"Tue, 26 Sep 2017 16:06:51 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.0","MIME-Version":"1.0","In-Reply-To":"<6f4a490e-96bc-58b5-c561-4491f175e2e4@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","x-cbid":"17092614-0008-0000-0000-0000049A3B08","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092614-0009-0000-0000-00001E2B85D7","Message-Id":"<debb11b6-3eba-b2fe-961f-52df7b1c5926@de.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-26_05:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709260204","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.156.1","Subject":"Re: [Qemu-devel] [PATCH v2 1/2] s390x/ais: enable ais when\n\tmigration is available","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Halil Pasic <pasic@linux.vnet.ibm.com>,\n\tYi Min Zhao <zyimin@linux.vnet.ibm.com>,\n\tqemu-devel <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>,\n\t\"Jason J . Herne\" <jjherne@linux.vnet.ibm.com>,\n\tRichard Henderson <rth@twiddle.net>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1775557,"web_url":"http://patchwork.ozlabs.org/comment/1775557/","msgid":"<5a6075ac-cbf7-cd2b-bdfa-e3f19cbf2a5b@redhat.com>","list_archive_url":null,"date":"2017-09-26T14:08:05","subject":"Re: [Qemu-devel] [PATCH v2 1/2] s390x/ais: enable ais when\n\tmigration is available","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":"On 26.09.2017 16:06, Christian Borntraeger wrote:\n> \n> \n> On 09/26/2017 03:43 PM, David Hildenbrand wrote:\n>>\n>>> +    /* try enable the AIS facility */\n>>> +    test_attr.group = KVM_DEV_FLIC_AISM_ALL;\n>>> +    if (!ioctl(flic_state->fd, KVM_HAS_DEVICE_ATTR, test_attr)) {\n>>> +            kvm_vm_enable_cap(kvm_state, KVM_CAP_S390_AIS, 0);\n>>> +    }\n>>> +\n>>>      return;\n>>>  fail:\n>>>      error_propagate(errp, errp_local);\n>>> @@ -578,7 +584,7 @@ static void kvm_s390_flic_reset(DeviceState *dev)\n>>>  \n>>>      flic_disable_wait_pfault(flic);\n>>>  \n>>> -    if (fs->ais_supported) {\n>>> +    if (s390_has_feat(S390_FEAT_ADAPTER_INT_SUPPRESSION)) {\n>>\n>> I don't remember if a reset is trigger on realization. Most probably\n>> not, but it could be.\n>>\n>> Would it hurt if the following code would not get called if the flic\n>> hasn't been used yet? (possible reset before cpu model has been\n>> initialized) - are kvm_s390_modify_ais_mode() calls required before ais\n>> can be used for the first time?\n> \n> Hmm, simm/nimm should default to zero in the kernel I guess. So I think it would\n> not hurt. Yi Min, correct?\n> \n> \n> Anyway it seems that reset is NOT called during realize, the first\n> call is\n> \n>                 #0  0x00000000010e5178 kvm_s390_flic_reset (qemu-system-s390x)\n>                 #1  0x000000000124bbc4 device_reset (qemu-system-s390x)\n>                 #2  0x0000000001248cd0 qdev_reset_one (qemu-system-s390x)\n>                 #3  0x0000000001249ea4 qdev_walk_children (qemu-system-s390x)\n>                 #4  0x000000000124fd3a qbus_walk_children (qemu-system-s390x)\n>                 #5  0x0000000001248e6c qbus_reset_all (qemu-system-s390x)\n>                 #6  0x0000000001248eae qbus_reset_all_fn (qemu-system-s390x)\n>                 #7  0x0000000001250a60 qemu_devices_reset (qemu-system-s390x)\n>                 #8  0x0000000001143c80 s390_machine_reset (qemu-system-s390x)\n>                 #9  0x00000000011c5b72 qemu_system_reset (qemu-system-s390x)\n>                 #10 0x00000000011ceb8e main (qemu-system-s390x)\n>                 #11 0x000003ff947a289a __libc_start_main (libc.so.6)\n>                 #12 0x0000000001017646 _start (qemu-system-s390x)\n> \n> \n\nReviewed-by: David Hildenbrand <david@redhat.com>\n\nthan","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1jVW04YMz9sRV\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 27 Sep 2017 00:08:51 +1000 (AEST)","from localhost ([::1]:47718 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dwqXZ-00078R-4T\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 10:08:49 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:57827)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <david@redhat.com>) id 1dwqX0-0006yD-7F\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 10:08:20 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <david@redhat.com>) id 1dwqWw-0007G5-4F\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 10:08:14 -0400","from mx1.redhat.com ([209.132.183.28]:51346)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <david@redhat.com>) id 1dwqWv-0007Fp-R5\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 10:08:10 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id DEEA85D687;\n\tTue, 26 Sep 2017 14:08:08 +0000 (UTC)","from [10.36.117.152] (ovpn-117-152.ams2.redhat.com [10.36.117.152])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 9AC0869AE1;\n\tTue, 26 Sep 2017 14:08:06 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com DEEA85D687","To":"Christian Borntraeger <borntraeger@de.ibm.com>,\n\tCornelia Huck <cohuck@redhat.com>","References":"<20170926133624.155394-1-borntraeger@de.ibm.com>\n\t<20170926133624.155394-2-borntraeger@de.ibm.com>\n\t<6f4a490e-96bc-58b5-c561-4491f175e2e4@redhat.com>\n\t<debb11b6-3eba-b2fe-961f-52df7b1c5926@de.ibm.com>","From":"David Hildenbrand <david@redhat.com>","Organization":"Red Hat GmbH","Message-ID":"<5a6075ac-cbf7-cd2b-bdfa-e3f19cbf2a5b@redhat.com>","Date":"Tue, 26 Sep 2017 16:08:05 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<debb11b6-3eba-b2fe-961f-52df7b1c5926@de.ibm.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tTue, 26 Sep 2017 14:08:09 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 1/2] s390x/ais: enable ais when\n\tmigration is available","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Halil Pasic <pasic@linux.vnet.ibm.com>,\n\tYi Min Zhao <zyimin@linux.vnet.ibm.com>,\n\tqemu-devel <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>,\n\t\"Jason J . Herne\" <jjherne@linux.vnet.ibm.com>,\n\tRichard Henderson <rth@twiddle.net>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1776029,"web_url":"http://patchwork.ozlabs.org/comment/1776029/","msgid":"<47df0694-49b2-7acf-fab1-af6119fa5aa2@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-09-27T04:35:53","subject":"Re: [Qemu-devel] [PATCH v2 1/2] s390x/ais: enable ais when\n\tmigration is available","submitter":{"id":66807,"url":"http://patchwork.ozlabs.org/api/people/66807/","name":"Yi Min Zhao","email":"zyimin@linux.vnet.ibm.com"},"content":"在 2017/9/26 下午10:06, Christian Borntraeger 写道:\n>\n> On 09/26/2017 03:43 PM, David Hildenbrand wrote:\n>>> +    /* try enable the AIS facility */\n>>> +    test_attr.group = KVM_DEV_FLIC_AISM_ALL;\n>>> +    if (!ioctl(flic_state->fd, KVM_HAS_DEVICE_ATTR, test_attr)) {\n>>> +            kvm_vm_enable_cap(kvm_state, KVM_CAP_S390_AIS, 0);\n>>> +    }\n>>> +\n>>>       return;\n>>>   fail:\n>>>       error_propagate(errp, errp_local);\n>>> @@ -578,7 +584,7 @@ static void kvm_s390_flic_reset(DeviceState *dev)\n>>>   \n>>>       flic_disable_wait_pfault(flic);\n>>>   \n>>> -    if (fs->ais_supported) {\n>>> +    if (s390_has_feat(S390_FEAT_ADAPTER_INT_SUPPRESSION)) {\n>> I don't remember if a reset is trigger on realization. Most probably\n>> not, but it could be.\n>>\n>> Would it hurt if the following code would not get called if the flic\n>> hasn't been used yet? (possible reset before cpu model has been\n>> initialized) - are kvm_s390_modify_ais_mode() calls required before ais\n>> can be used for the first time?\n> Hmm, simm/nimm should default to zero in the kernel I guess. So I think it would\n> not hurt. Yi Min, correct?\nYes, the default mode is all interruption mode, IOW simm = 0 and nimm = 0.\n>\n>\n> Anyway it seems that reset is NOT called during realize, the first\n> call is\n>\n>                  #0  0x00000000010e5178 kvm_s390_flic_reset (qemu-system-s390x)\n>                  #1  0x000000000124bbc4 device_reset (qemu-system-s390x)\n>                  #2  0x0000000001248cd0 qdev_reset_one (qemu-system-s390x)\n>                  #3  0x0000000001249ea4 qdev_walk_children (qemu-system-s390x)\n>                  #4  0x000000000124fd3a qbus_walk_children (qemu-system-s390x)\n>                  #5  0x0000000001248e6c qbus_reset_all (qemu-system-s390x)\n>                  #6  0x0000000001248eae qbus_reset_all_fn (qemu-system-s390x)\n>                  #7  0x0000000001250a60 qemu_devices_reset (qemu-system-s390x)\n>                  #8  0x0000000001143c80 s390_machine_reset (qemu-system-s390x)\n>                  #9  0x00000000011c5b72 qemu_system_reset (qemu-system-s390x)\n>                  #10 0x00000000011ceb8e main (qemu-system-s390x)\n>                  #11 0x000003ff947a289a __libc_start_main (libc.so.6)\n>                  #12 0x0000000001017646 _start (qemu-system-s390x)\n>\n>\n>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y24lv3nfgz9t30\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 27 Sep 2017 14:36:40 +1000 (AEST)","from localhost ([::1]:52085 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dx45N-0006g8-8y\n\tfor incoming@patchwork.ozlabs.org; Wed, 27 Sep 2017 00:36:37 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42364)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <zyimin@linux.vnet.ibm.com>) id 1dx44v-0006g2-Fc\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 00:36:10 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <zyimin@linux.vnet.ibm.com>) id 1dx44s-0001Wb-CY\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 00:36:09 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1]:38278)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <zyimin@linux.vnet.ibm.com>)\n\tid 1dx44s-0001W0-2H\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 00:36:06 -0400","from pps.filterd (m0098404.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8R4XbwI101441\n\tfor <qemu-devel@nongnu.org>; Wed, 27 Sep 2017 00:36:01 -0400","from e38.co.us.ibm.com (e38.co.us.ibm.com [32.97.110.159])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d7vxe5p97-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <qemu-devel@nongnu.org>; Wed, 27 Sep 2017 00:36:01 -0400","from localhost\n\tby e38.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <qemu-devel@nongnu.org> from <zyimin@linux.vnet.ibm.com>;\n\tTue, 26 Sep 2017 22:36:00 -0600","from b03cxnp07028.gho.boulder.ibm.com (9.17.130.15)\n\tby e38.co.us.ibm.com (192.168.1.138) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tTue, 26 Sep 2017 22:35:57 -0600","from b03ledav006.gho.boulder.ibm.com\n\t(b03ledav006.gho.boulder.ibm.com [9.17.130.237])\n\tby b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8R4ZuG55570822; Tue, 26 Sep 2017 21:35:56 -0700","from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id CAC20C6037;\n\tTue, 26 Sep 2017 22:35:56 -0600 (MDT)","from zyimindembp.cn.ibm.com (unknown [9.115.193.51])\n\tby b03ledav006.gho.boulder.ibm.com (Postfix) with ESMTP id 265C3C6047;\n\tTue, 26 Sep 2017 22:35:54 -0600 (MDT)"],"To":"Christian Borntraeger <borntraeger@de.ibm.com>,\n\tDavid Hildenbrand <david@redhat.com>, Cornelia Huck <cohuck@redhat.com>","References":"<20170926133624.155394-1-borntraeger@de.ibm.com>\n\t<20170926133624.155394-2-borntraeger@de.ibm.com>\n\t<6f4a490e-96bc-58b5-c561-4491f175e2e4@redhat.com>\n\t<debb11b6-3eba-b2fe-961f-52df7b1c5926@de.ibm.com>","From":"Yi Min Zhao <zyimin@linux.vnet.ibm.com>","Date":"Wed, 27 Sep 2017 12:35:53 +0800","User-Agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)\n\tGecko/20100101 Thunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<debb11b6-3eba-b2fe-961f-52df7b1c5926@de.ibm.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","X-TM-AS-GCONF":"00","x-cbid":"17092704-0028-0000-0000-0000086A79AD","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007799; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000231; SDB=6.00922938; UDB=6.00463936;\n\tIPR=6.00703080; \n\tBA=6.00005608; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017286;\n\tXFM=3.00000015; UTC=2017-09-27 04:35:58","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092704-0029-0000-0000-000037B5FEC6","Message-Id":"<47df0694-49b2-7acf-fab1-af6119fa5aa2@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-27_01:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709270070","Content-Transfer-Encoding":"quoted-printable","X-MIME-Autoconverted":"from 8bit to quoted-printable by\n\tmx0a-001b2d01.pphosted.com id v8R4XbwI101441","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.156.1","Subject":"Re: [Qemu-devel] [PATCH v2 1/2] s390x/ais: enable ais when\n\tmigration is available","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"qemu-devel <qemu-devel@nongnu.org>,\n\tHalil Pasic <pasic@linux.vnet.ibm.com>, Alexander Graf <agraf@suse.de>,\n\t\"Jason J . Herne\" <jjherne@linux.vnet.ibm.com>,\n\tRichard Henderson <rth@twiddle.net>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1776041,"web_url":"http://patchwork.ozlabs.org/comment/1776041/","msgid":"<7134b571-41dd-97c8-85b8-fb623babb016@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-09-27T05:45:54","subject":"Re: [Qemu-devel] [PATCH v2 1/2] s390x/ais: enable ais when\n\tmigration is available","submitter":{"id":66807,"url":"http://patchwork.ozlabs.org/api/people/66807/","name":"Yi Min Zhao","email":"zyimin@linux.vnet.ibm.com"},"content":"在 2017/9/26 下午9:36, Christian Borntraeger 写道:\n> @@ -557,6 +557,12 @@ static void kvm_s390_flic_realize(DeviceState *dev, Error **errp)\n>       test_attr.group = KVM_DEV_FLIC_CLEAR_IO_IRQ;\n>       flic_state->clear_io_supported = !ioctl(flic_state->fd,\n>                                               KVM_HAS_DEVICE_ATTR, test_attr);\n> +    /* try enable the AIS facility */\n> +    test_attr.group = KVM_DEV_FLIC_AISM_ALL;\n> +    if (!ioctl(flic_state->fd, KVM_HAS_DEVICE_ATTR, test_attr)) {\n> +            kvm_vm_enable_cap(kvm_state, KVM_CAP_S390_AIS, 0);\nIs there an indention error?\nExcept this, the code LGTM.\n> +    }\n> +\n>       return;","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y26Jh40L0z9t3F\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 27 Sep 2017 15:46:43 +1000 (AEST)","from localhost ([::1]:52229 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dx5BA-00078I-Vr\n\tfor incoming@patchwork.ozlabs.org; Wed, 27 Sep 2017 01:46:41 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:54229)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <zyimin@linux.vnet.ibm.com>) id 1dx5Ag-000781-QF\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 01:46:11 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <zyimin@linux.vnet.ibm.com>) id 1dx5Ab-0003HP-Ti\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 01:46:10 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1]:47112)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <zyimin@linux.vnet.ibm.com>)\n\tid 1dx5Ab-0003Gi-Kq\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 01:46:05 -0400","from pps.filterd (m0098399.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8R5im5M035585\n\tfor <qemu-devel@nongnu.org>; Wed, 27 Sep 2017 01:46:01 -0400","from e34.co.us.ibm.com (e34.co.us.ibm.com [32.97.110.152])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d848h4qbr-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <qemu-devel@nongnu.org>; Wed, 27 Sep 2017 01:46:01 -0400","from localhost\n\tby e34.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <qemu-devel@nongnu.org> from <zyimin@linux.vnet.ibm.com>;\n\tTue, 26 Sep 2017 23:46:00 -0600","from b03cxnp07029.gho.boulder.ibm.com (9.17.130.16)\n\tby e34.co.us.ibm.com (192.168.1.134) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tTue, 26 Sep 2017 23:45:57 -0600","from b03ledav006.gho.boulder.ibm.com\n\t(b03ledav006.gho.boulder.ibm.com [9.17.130.237])\n\tby b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8R5jvgE3015042; Tue, 26 Sep 2017 22:45:57 -0700","from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 400BFC6042;\n\tTue, 26 Sep 2017 23:45:57 -0600 (MDT)","from zyimindembp.cn.ibm.com (unknown [9.115.193.51])\n\tby b03ledav006.gho.boulder.ibm.com (Postfix) with ESMTP id 922D5C6037;\n\tTue, 26 Sep 2017 23:45:55 -0600 (MDT)"],"To":"Christian Borntraeger <borntraeger@de.ibm.com>,\n\tCornelia Huck <cohuck@redhat.com>","References":"<20170926133624.155394-1-borntraeger@de.ibm.com>\n\t<20170926133624.155394-2-borntraeger@de.ibm.com>","From":"Yi Min Zhao <zyimin@linux.vnet.ibm.com>","Date":"Wed, 27 Sep 2017 13:45:54 +0800","User-Agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)\n\tGecko/20100101 Thunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170926133624.155394-2-borntraeger@de.ibm.com>","Content-Type":"text/plain; charset=gbk; format=flowed","X-TM-AS-GCONF":"00","x-cbid":"17092705-0016-0000-0000-000007930BA2","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007799; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000231; SDB=6.00922962; UDB=6.00463950;\n\tIPR=6.00703103; \n\tBA=6.00005608; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017286;\n\tXFM=3.00000015; UTC=2017-09-27 05:45:59","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092705-0017-0000-0000-00003BA17492","Message-Id":"<7134b571-41dd-97c8-85b8-fb623babb016@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-27_01:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709270086","Content-Transfer-Encoding":"quoted-printable","X-MIME-Autoconverted":"from 8bit to quoted-printable by\n\tmx0a-001b2d01.pphosted.com id v8R5im5M035585","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.156.1","Subject":"Re: [Qemu-devel] [PATCH v2 1/2] s390x/ais: enable ais when\n\tmigration is available","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Halil Pasic <pasic@linux.vnet.ibm.com>,\n\tDavid Hildenbrand <david@redhat.com>, Alexander Graf <agraf@suse.de>, \n\tqemu-devel <qemu-devel@nongnu.org>,\n\t\"Jason J . Herne\" <jjherne@linux.vnet.ibm.com>,\n\tRichard Henderson <rth@twiddle.net>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1776073,"web_url":"http://patchwork.ozlabs.org/comment/1776073/","msgid":"<5caeb93d-b436-d8c0-2706-fd3476b54ad0@de.ibm.com>","list_archive_url":null,"date":"2017-09-27T07:02:48","subject":"Re: [Qemu-devel] [PATCH v2 1/2] s390x/ais: enable ais when\n\tmigration is available","submitter":{"id":590,"url":"http://patchwork.ozlabs.org/api/people/590/","name":"Christian Borntraeger","email":"borntraeger@de.ibm.com"},"content":"On 09/27/2017 07:45 AM, Yi Min Zhao wrote:\n> \n> \n> 在 2017/9/26 下午9:36, Christian Borntraeger 写道:\n>> @@ -557,6 +557,12 @@ static void kvm_s390_flic_realize(DeviceState *dev, Error **errp)\n>>       test_attr.group = KVM_DEV_FLIC_CLEAR_IO_IRQ;\n>>       flic_state->clear_io_supported = !ioctl(flic_state->fd,\n>>                                               KVM_HAS_DEVICE_ATTR, test_attr);\n>> +    /* try enable the AIS facility */\n>> +    test_attr.group = KVM_DEV_FLIC_AISM_ALL;\n>> +    if (!ioctl(flic_state->fd, KVM_HAS_DEVICE_ATTR, test_attr)) {\n>> +            kvm_vm_enable_cap(kvm_state, KVM_CAP_S390_AIS, 0);\n\nyes, will fix.\n\n\n> Is there an indention error?\n> Except this, the code LGTM.\n>> +    }\n>> +\n>>       return;\n>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y281f0rVBz9t4Z\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 27 Sep 2017 17:03:50 +1000 (AEST)","from localhost ([::1]:52511 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dx6No-0003Ij-6E\n\tfor incoming@patchwork.ozlabs.org; Wed, 27 Sep 2017 03:03:48 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:40737)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <borntraeger@de.ibm.com>) id 1dx6N6-0003HD-KZ\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 03:03:05 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <borntraeger@de.ibm.com>) id 1dx6N0-0000pf-UL\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 03:03:04 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5]:47970\n\thelo=mx0a-001b2d01.pphosted.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <borntraeger@de.ibm.com>)\n\tid 1dx6N0-0000pN-OU\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 03:02:58 -0400","from pps.filterd (m0098413.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8R6xm0O047590\n\tfor <qemu-devel@nongnu.org>; Wed, 27 Sep 2017 03:02:55 -0400","from e06smtp14.uk.ibm.com (e06smtp14.uk.ibm.com [195.75.94.110])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2d81gkf6v7-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <qemu-devel@nongnu.org>; Wed, 27 Sep 2017 03:02:54 -0400","from localhost\n\tby e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <qemu-devel@nongnu.org> from <borntraeger@de.ibm.com>;\n\tWed, 27 Sep 2017 08:02:52 +0100","from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195)\n\tby e06smtp14.uk.ibm.com (192.168.101.144) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tWed, 27 Sep 2017 08:02:49 +0100","from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com\n\t[9.149.105.62])\n\tby b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8R72mYB31850520; Wed, 27 Sep 2017 07:02:48 GMT","from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 838B9AE055;\n\tWed, 27 Sep 2017 07:57:30 +0100 (BST)","from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 42348AE053;\n\tWed, 27 Sep 2017 07:57:30 +0100 (BST)","from oc7330422307.ibm.com (unknown [9.152.224.56])\n\tby d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tWed, 27 Sep 2017 07:57:30 +0100 (BST)"],"To":"Yi Min Zhao <zyimin@linux.vnet.ibm.com>,\n\tCornelia Huck <cohuck@redhat.com>","References":"<20170926133624.155394-1-borntraeger@de.ibm.com>\n\t<20170926133624.155394-2-borntraeger@de.ibm.com>\n\t<7134b571-41dd-97c8-85b8-fb623babb016@linux.vnet.ibm.com>","From":"Christian Borntraeger <borntraeger@de.ibm.com>","Date":"Wed, 27 Sep 2017 09:02:48 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.0","MIME-Version":"1.0","In-Reply-To":"<7134b571-41dd-97c8-85b8-fb623babb016@linux.vnet.ibm.com>","Content-Type":"text/plain; charset=gbk","Content-Language":"en-US","X-TM-AS-GCONF":"00","x-cbid":"17092707-0016-0000-0000-000004F07805","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092707-0017-0000-0000-0000282AC732","Message-Id":"<5caeb93d-b436-d8c0-2706-fd3476b54ad0@de.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-27_02:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709270105","Content-Transfer-Encoding":"quoted-printable","X-MIME-Autoconverted":"from 8bit to quoted-printable by\n\tmx0b-001b2d01.pphosted.com id v8R6xm0O047590","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.158.5","Subject":"Re: [Qemu-devel] [PATCH v2 1/2] s390x/ais: enable ais when\n\tmigration is available","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Halil Pasic <pasic@linux.vnet.ibm.com>,\n\tDavid Hildenbrand <david@redhat.com>, Alexander Graf <agraf@suse.de>, \n\tqemu-devel <qemu-devel@nongnu.org>,\n\t\"Jason J . Herne\" <jjherne@linux.vnet.ibm.com>,\n\tRichard Henderson <rth@twiddle.net>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}}]