[{"id":1775445,"web_url":"http://patchwork.ozlabs.org/comment/1775445/","msgid":"<20170926125518.kulkohinaojty2zl@flea>","list_archive_url":null,"date":"2017-09-26T12:55:18","subject":"Re: [PATCH v2 01/10] pinctrl: move gpio-axp209 to pinctrl","submitter":{"id":12916,"url":"http://patchwork.ozlabs.org/api/people/12916/","name":"Maxime Ripard","email":"maxime.ripard@free-electrons.com"},"content":"On Tue, Sep 26, 2017 at 12:17:11PM +0000, Quentin Schulz wrote:\n> To prepare the driver for the upcoming pinctrl features, move the GPIO\n> driver AXP209 from GPIO to pinctrl subsystem.\n> \n> Signed-off-by: Quentin Schulz \n\nI'm not sure we actually need to do this. Can't we just keep the\ndriver here?\n\nMaxime","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1gtN3NVTz9tXn\n\tfor ;\n\tTue, 26 Sep 2017 22:55:56 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S968948AbdIZMzc (ORCPT );\n\tTue, 26 Sep 2017 08:55:32 -0400","from mail.free-electrons.com ([62.4.15.54]:53724 \"EHLO\n\tmail.free-electrons.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S966749AbdIZMza (ORCPT\n\t); Tue, 26 Sep 2017 08:55:30 -0400","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 4F9CC208DD; Tue, 26 Sep 2017 14:55:28 +0200 (CEST)","from localhost (unknown [195.81.232.10])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 2D058208CB;\n\tTue, 26 Sep 2017 14:55:18 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Date":"Tue, 26 Sep 2017 14:55:18 +0200","From":"Maxime Ripard ","To":"Quentin Schulz ","Cc":"linus.walleij@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com,\n\twens@csie.org, linux@armlinux.org.uk, lee.jones@linaro.org,\n\tlinux-gpio@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tlinux-sunxi@googlegroups.com, thomas.petazzoni@free-electrons.com","Subject":"Re: [PATCH v2 01/10] pinctrl: move gpio-axp209 to pinctrl","Message-ID":"<20170926125518.kulkohinaojty2zl@flea>","References":"\n\t","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"q4gppu7zyiczrz4d\"","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"NeoMutt/20170914 (1.9.0)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1775449,"web_url":"http://patchwork.ozlabs.org/comment/1775449/","msgid":"","list_archive_url":null,"date":"2017-09-26T12:59:38","subject":"Re: [PATCH v2 01/10] pinctrl: move gpio-axp209 to pinctrl","submitter":{"id":69366,"url":"http://patchwork.ozlabs.org/api/people/69366/","name":"Quentin Schulz","email":"quentin.schulz@free-electrons.com"},"content":"Hi Maxime,\n\nOn 26/09/2017 14:55, Maxime Ripard wrote:\n> On Tue, Sep 26, 2017 at 12:17:11PM +0000, Quentin Schulz wrote:\n>> To prepare the driver for the upcoming pinctrl features, move the GPIO\n>> driver AXP209 from GPIO to pinctrl subsystem.\n>>\n>> Signed-off-by: Quentin Schulz \n> \n> I'm not sure we actually need to do this. Can't we just keep the\n> driver here?\n> \n\nThat's not what I understood from:\nhttps://lkml.org/lkml/2016/11/24/360 and the following answers from\nLinus on the first version.\n\nQuentin","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1gz4564rz9tXj\n\tfor ;\n\tTue, 26 Sep 2017 22:59:59 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S967099AbdIZM76 (ORCPT );\n\tTue, 26 Sep 2017 08:59:58 -0400","from mail.free-electrons.com ([62.4.15.54]:53969 \"EHLO\n\tmail.free-electrons.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S967089AbdIZM75 (ORCPT\n\t); Tue, 26 Sep 2017 08:59:57 -0400","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 2BEF720850; Tue, 26 Sep 2017 14:59:55 +0200 (CEST)","from [192.168.0.13] (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr\n\t[90.63.216.87])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id D0EB62081E;\n\tTue, 26 Sep 2017 14:59:44 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Subject":"Re: [PATCH v2 01/10] pinctrl: move gpio-axp209 to pinctrl","To":"Maxime Ripard ","Cc":"linus.walleij@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com,\n\twens@csie.org, linux@armlinux.org.uk, lee.jones@linaro.org,\n\tlinux-gpio@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tlinux-sunxi@googlegroups.com, thomas.petazzoni@free-electrons.com","References":"\n\t\n\t<20170926125518.kulkohinaojty2zl@flea>","From":"Quentin Schulz ","Message-ID":"","Date":"Tue, 26 Sep 2017 14:59:38 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170926125518.kulkohinaojty2zl@flea>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"1wRK5rxTKnVOU8HPvRh5JKvR0NS4sdKt2\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1775470,"web_url":"http://patchwork.ozlabs.org/comment/1775470/","msgid":"","list_archive_url":null,"date":"2017-09-26T13:08:54","subject":"Re: [PATCH v2 01/10] pinctrl: move gpio-axp209 to pinctrl","submitter":{"id":47154,"url":"http://patchwork.ozlabs.org/api/people/47154/","name":"Chen-Yu Tsai","email":"wens@csie.org"},"content":"On Tue, Sep 26, 2017 at 8:59 PM, Quentin Schulz\n wrote:\n> Hi Maxime,\n>\n> On 26/09/2017 14:55, Maxime Ripard wrote:\n>> On Tue, Sep 26, 2017 at 12:17:11PM +0000, Quentin Schulz wrote:\n>>> To prepare the driver for the upcoming pinctrl features, move the GPIO\n>>> driver AXP209 from GPIO to pinctrl subsystem.\n>>>\n>>> Signed-off-by: Quentin Schulz \n>>\n>> I'm not sure we actually need to do this. Can't we just keep the\n>> driver here?\n>>\n>\n> That's not what I understood from:\n> https://lkml.org/lkml/2016/11/24/360 and the following answers from\n> Linus on the first version.\n\nPlease remember to add -M to git format-patch, as Linus mentioned,\nif you resend.\n\nChenyu\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1h9w0S3Tz9tXj\n\tfor ;\n\tTue, 26 Sep 2017 23:09:24 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S969065AbdIZNJV (ORCPT );\n\tTue, 26 Sep 2017 09:09:21 -0400","from smtp.csie.ntu.edu.tw ([140.112.30.61]:60632 \"EHLO\n\tsmtp.csie.ntu.edu.tw\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S966345AbdIZNJU (ORCPT\n\t); Tue, 26 Sep 2017 09:09:20 -0400","from mail-wm0-f51.google.com (mail-wm0-f51.google.com\n\t[74.125.82.51])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits))\n\t(No client certificate requested) (Authenticated sender: b93043)\n\tby smtp.csie.ntu.edu.tw (Postfix) with ESMTPSA id 0E53B209F0;\n\tTue, 26 Sep 2017 21:09:18 +0800 (CST)","by mail-wm0-f51.google.com with SMTP id m72so7735103wmc.1;\n\tTue, 26 Sep 2017 06:09:17 -0700 (PDT)","by 10.223.196.226 with HTTP; Tue, 26 Sep 2017 06:08:54 -0700 (PDT)"],"X-Gm-Message-State":"AHPjjUjhcM28wngFiUEwQQbkmRkIOQluMOS/NVEGi0b8lyjkUp85FDyZ\n\tdbH9/1jovChGaxuMSRcrdCKb+AD1nJc32GZ/AGk=","X-Google-Smtp-Source":"AOwi7QBp7n04+9oq05qVfOi2ajavjN/69goZz6nkPGXhbw72uK6ruq99ZX5aWy1UpUvXNGm1R8X5L1VmZoFxw1wZw7o=","X-Received":"by 10.28.59.215 with SMTP id i206mr3173283wma.116.1506431355348; \n\tTue, 26 Sep 2017 06:09:15 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"\n\t\n\t<20170926125518.kulkohinaojty2zl@flea>\n\t","From":"Chen-Yu Tsai ","Date":"Tue, 26 Sep 2017 21:08:54 +0800","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [PATCH v2 01/10] pinctrl: move gpio-axp209 to pinctrl","To":"Quentin Schulz ","Cc":"Maxime Ripard ,\n\tLinus Walleij ,\n\tRob Herring , \n\tMark Rutland , Chen-Yu Tsai ,\n\tRussell King , Lee Jones ,\n\t\"linux-gpio@vger.kernel.org\" ,\n\tdevicetree ,\n\tlinux-kernel ,\n\tlinux-arm-kernel ,\n\tlinux-sunxi ,\n\tThomas Petazzoni ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1780989,"web_url":"http://patchwork.ozlabs.org/comment/1780989/","msgid":"<20171005205037.hxtoyeryiolflkda@rob-hp-laptop>","list_archive_url":null,"date":"2017-10-05T20:50:37","subject":"Re: [PATCH v2 01/10] pinctrl: move gpio-axp209 to pinctrl","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Tue, Sep 26, 2017 at 02:17:11PM +0200, Quentin Schulz wrote:\n> To prepare the driver for the upcoming pinctrl features, move the GPIO\n> driver AXP209 from GPIO to pinctrl subsystem.\n> \n> Signed-off-by: Quentin Schulz \n> ---\n> Documentation/devicetree/bindings/gpio/gpio-axp209.txt | 30 +-\n> Documentation/devicetree/bindings/pinctrl/pinctrl-axp209.txt | 30 +-\n> drivers/gpio/Kconfig | 6 +-\n> drivers/gpio/Makefile | 1 +-\n> drivers/gpio/gpio-axp209.c | 188 +-------\n> drivers/pinctrl/Kconfig | 6 +-\n> drivers/pinctrl/Makefile | 1 +-\n> drivers/pinctrl/pinctrl-axp209.c | 188 +++++++-\n> 8 files changed, 225 insertions(+), 225 deletions(-)\n> delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-axp209.txt\n> create mode 100644 Documentation/devicetree/bindings/pinctrl/pinctrl-axp209.txt\n> delete mode 100644 drivers/gpio/gpio-axp209.c\n> create mode 100644 drivers/pinctrl/pinctrl-axp209.c\n> \n> diff --git a/Documentation/devicetree/bindings/gpio/gpio-axp209.txt b/Documentation/devicetree/bindings/gpio/gpio-axp209.txt\n> deleted file mode 100644\n> index a661130..0000000\n> --- a/Documentation/devicetree/bindings/gpio/gpio-axp209.txt\n> +++ /dev/null\n> @@ -1,30 +0,0 @@\n> -AXP209 GPIO controller\n> -\n> -This driver follows the usual GPIO bindings found in\n> -Documentation/devicetree/bindings/gpio/gpio.txt\n> -\n> -Required properties:\n> -- compatible: Should be \"x-powers,axp209-gpio\"\n> -- #gpio-cells: Should be two. The first cell is the pin number and the\n> - second is the GPIO flags.\n> -- gpio-controller: Marks the device node as a GPIO controller.\n> -\n> -This node must be a subnode of the axp20x PMIC, documented in\n> -Documentation/devicetree/bindings/mfd/axp20x.txt\n> -\n> -Example:\n> -\n> -axp209: pmic@34 {\n> -\tcompatible = \"x-powers,axp209\";\n> -\treg = <0x34>;\n> -\tinterrupt-parent = <&nmi_intc>;\n> -\tinterrupts = <0 IRQ_TYPE_LEVEL_LOW>;\n> -\tinterrupt-controller;\n> -\t#interrupt-cells = <1>;\n> -\n> -\taxp_gpio: gpio {\n> -\t\tcompatible = \"x-powers,axp209-gpio\";\n> -\t\tgpio-controller;\n> -\t\t#gpio-cells = <2>;\n> -\t};\n> -};\n> diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-axp209.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-axp209.txt\n> new file mode 100644\n> index 0000000..a661130\n> --- /dev/null\n> +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-axp209.txt\n> @@ -0,0 +1,30 @@\n> +AXP209 GPIO controller\n> +\n> +This driver follows the usual GPIO bindings found in\n> +Documentation/devicetree/bindings/gpio/gpio.txt\n> +\n> +Required properties:\n> +- compatible: Should be \"x-powers,axp209-gpio\"\n> +- #gpio-cells: Should be two. The first cell is the pin number and the\n> + second is the GPIO flags.\n> +- gpio-controller: Marks the device node as a GPIO controller.\n\nMaybe there's some reason to move the driver, but the binding describes \na gpio-controller so it should remain in bindings/gpio/. Binding and \ndriver directories aren't one to one necessarily.\n\nRob\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y7Q0L2bryz9t5Y\n\tfor ;\n\tFri, 6 Oct 2017 07:50:58 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751835AbdJEUum (ORCPT\n\t);\n\tThu, 5 Oct 2017 16:50:42 -0400","from mail-oi0-f67.google.com ([209.85.218.67]:38453 \"EHLO\n\tmail-oi0-f67.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751381AbdJEUuj (ORCPT\n\t); Thu, 5 Oct 2017 16:50:39 -0400","by mail-oi0-f67.google.com with SMTP id t134so2158624oih.5;\n\tThu, 05 Oct 2017 13:50:39 -0700 (PDT)","from localhost (216-188-254-6.dyn.grandenetworks.net.\n\t[216.188.254.6]) by smtp.gmail.com with ESMTPSA id\n\td129sm6741541oia.27.2017.10.05.13.50.37\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 05 Oct 2017 13:50:37 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=Qra02DoUCvYDoWvjwJIlbnNCXMe75vgDpC2c9HHjId8=;\n\tb=XO9XqI7FoXylHOmwbBECnhuJ+OxvST2bGsF2WRJ3Cad9FYZIBaMstuFltO218dW4Nc\n\ti/XwBGonjz9gdi6G82ZXLiBatQzijrlWE+cJAir4TVyDFbu9d4iDXqYNeW6tof0JbNdG\n\t/EAyAXV02xupTlc5STwuEHoAm6+FhiuCTZZ9kmQ1DRg4FHKzVIxmIyeLyU8N1bweN5MH\n\tjBOo5yNkqqs/tQwEVL+tUZ5EcdniuH7Ge+xNsILLIPtySPCjp0IlaBC/L6qQ94y8lipk\n\tnz0aQpDMXVaBDS+C6sa7Fxf2OFaBIvhuciQNIevIk0xql+Sr69XbZFXP4k66qVmgbC+9\n\t7Ohw==","X-Gm-Message-State":"AMCzsaX6qFXYz9U9FZ4w61Fk29CoWVA4REZmQbLkaQEpE4ixWO8jCk1K\n\tRpoZvY+I6wt/Dm7/ibvEwg==","X-Google-Smtp-Source":"AOwi7QBmBWTaEkfQvf9DuEF2KT3JCjuGJTVChpQzAZryslVdvgBmOB+QnPACz+CG+dKhr3SLCLZ2Lw==","X-Received":"by 10.157.81.140 with SMTP id y12mr5199261otg.9.1507236638476;\n\tThu, 05 Oct 2017 13:50:38 -0700 (PDT)","Date":"Thu, 5 Oct 2017 15:50:37 -0500","From":"Rob Herring ","To":"Quentin Schulz ","Cc":"linus.walleij@linaro.org, mark.rutland@arm.com, wens@csie.org,\n\tlinux@armlinux.org.uk, maxime.ripard@free-electrons.com,\n\tlee.jones@linaro.org, linux-gpio@vger.kernel.org,\n\tdevicetree@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com,\n\tthomas.petazzoni@free-electrons.com","Subject":"Re: [PATCH v2 01/10] pinctrl: move gpio-axp209 to pinctrl","Message-ID":"<20171005205037.hxtoyeryiolflkda@rob-hp-laptop>","References":"\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]