[{"id":1775480,"web_url":"http://patchwork.ozlabs.org/comment/1775480/","msgid":"<20170926131445.xo2uawiovjtmyivj@flea>","list_archive_url":null,"date":"2017-09-26T13:14:45","subject":"Re: [PATCH v2 07/10] mfd: axp20x: add pinctrl cell for AXP813","submitter":{"id":12916,"url":"http://patchwork.ozlabs.org/api/people/12916/","name":"Maxime Ripard","email":"maxime.ripard@free-electrons.com"},"content":"On Tue, Sep 26, 2017 at 12:17:17PM +0000, Quentin Schulz wrote:\n> As pinctrl and GPIO driver now supports AXP813, add a cell for it.\n> \n> Signed-off-by: Quentin Schulz \n> ---\n> drivers/mfd/axp20x.c | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c\n> index 336de66..a457528 100644\n> --- a/drivers/mfd/axp20x.c\n> +++ b/drivers/mfd/axp20x.c\n> @@ -876,6 +876,9 @@ static struct mfd_cell axp813_cells[] = {\n> \t\t.name\t\t\t= \"axp221-pek\",\n> \t\t.num_resources\t\t= ARRAY_SIZE(axp803_pek_resources),\n> \t\t.resources\t\t= axp803_pek_resources,\n> +\t}, {\n> +\t\t.name\t\t\t= \"axp20x-gpio\",\n> +\t\t.of_compatible\t\t= \"x-powers,axp813-pctl\",\n\nThis was probably introduced in the previous driver, but why are you\nusing the pctl suffix? Can't we just use the GPIO one to remain\nconsistent with the previous users and the datasheet?\n\nThanks!\nMaxime","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1hJZ0lgKz9tXq\n\tfor ;\n\tTue, 26 Sep 2017 23:15:10 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S967280AbdIZNO5 (ORCPT );\n\tTue, 26 Sep 2017 09:14:57 -0400","from mail.free-electrons.com ([62.4.15.54]:54718 \"EHLO\n\tmail.free-electrons.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S967144AbdIZNO4 (ORCPT\n\t); Tue, 26 Sep 2017 09:14:56 -0400","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 94442207D6; Tue, 26 Sep 2017 15:14:54 +0200 (CEST)","from localhost (unknown [195.81.232.10])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 6FEA8207C8;\n\tTue, 26 Sep 2017 15:14:44 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Date":"Tue, 26 Sep 2017 15:14:45 +0200","From":"Maxime Ripard ","To":"Quentin Schulz ","Cc":"linus.walleij@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com,\n\twens@csie.org, linux@armlinux.org.uk, lee.jones@linaro.org,\n\tlinux-gpio@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tlinux-sunxi@googlegroups.com, thomas.petazzoni@free-electrons.com","Subject":"Re: [PATCH v2 07/10] mfd: axp20x: add pinctrl cell for AXP813","Message-ID":"<20170926131445.xo2uawiovjtmyivj@flea>","References":"\n\t<5345a2e94013f4e4f7b545cd4d84b098bd2fa349.1506428208.git-series.quentin.schulz@free-electrons.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"2cdrv6jxd25mp4ib\"","Content-Disposition":"inline","In-Reply-To":"<5345a2e94013f4e4f7b545cd4d84b098bd2fa349.1506428208.git-series.quentin.schulz@free-electrons.com>","User-Agent":"NeoMutt/20170914 (1.9.0)","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}},{"id":1777239,"web_url":"http://patchwork.ozlabs.org/comment/1777239/","msgid":"<20170928190614.v5jgejvgdlyxbxrh@dell>","list_archive_url":null,"date":"2017-09-28T19:06:14","subject":"Re: [PATCH v2 07/10] mfd: axp20x: add pinctrl cell for AXP813","submitter":{"id":12720,"url":"http://patchwork.ozlabs.org/api/people/12720/","name":"Lee Jones","email":"lee.jones@linaro.org"},"content":"On Tue, 26 Sep 2017, Maxime Ripard wrote:\n\n> On Tue, Sep 26, 2017 at 12:17:17PM +0000, Quentin Schulz wrote:\n> > As pinctrl and GPIO driver now supports AXP813, add a cell for it.\n> > \n> > Signed-off-by: Quentin Schulz \n> > ---\n> > drivers/mfd/axp20x.c | 3 +++\n> > 1 file changed, 3 insertions(+)\n> > \n> > diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c\n> > index 336de66..a457528 100644\n> > --- a/drivers/mfd/axp20x.c\n> > +++ b/drivers/mfd/axp20x.c\n> > @@ -876,6 +876,9 @@ static struct mfd_cell axp813_cells[] = {\n> > \t\t.name\t\t\t= \"axp221-pek\",\n> > \t\t.num_resources\t\t= ARRAY_SIZE(axp803_pek_resources),\n> > \t\t.resources\t\t= axp803_pek_resources,\n> > +\t}, {\n> > +\t\t.name\t\t\t= \"axp20x-gpio\",\n> > +\t\t.of_compatible\t\t= \"x-powers,axp813-pctl\",\n> \n> This was probably introduced in the previous driver, but why are you\n> using the pctl suffix? Can't we just use the GPIO one to remain\n> consistent with the previous users and the datasheet?\n\nRight. Pinctrl is a Linuxisum. GPIO sounds more appropriate.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"jIJQfhSa\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y341K2Rz6z9t6C\n\tfor ;\n\tFri, 29 Sep 2017 05:06:42 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750902AbdI1TGU (ORCPT );\n\tThu, 28 Sep 2017 15:06:20 -0400","from mail-pf0-f181.google.com ([209.85.192.181]:48812 \"EHLO\n\tmail-pf0-f181.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750943AbdI1TGT (ORCPT\n\t); Thu, 28 Sep 2017 15:06:19 -0400","by mail-pf0-f181.google.com with SMTP id n24so1310751pfk.5\n\tfor ;\n\tThu, 28 Sep 2017 12:06:19 -0700 (PDT)","from dell ([70.35.39.2]) by smtp.gmail.com with ESMTPSA id\n\tb63sm4029766pga.27.2017.09.28.12.06.16\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 28 Sep 2017 12:06:17 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=0m7pz1emTi+K8C4EeniVTz93qHIJAYv4P49Yi5zRJQ8=;\n\tb=jIJQfhSa4lrapSPR2YBZQHpEeNNp+hJnb+qWhf+9N+PiRAt2P87taKY8e4JodYLUh7\n\tJshKUNSK2DBKD0VZyLKJup6+VK9760eWm/S+WH3gC/hd4MSuKObBlzqo6bgYZL+oksU/\n\tTVCPX7owsKOjrPAR6UyUJYsRH1AiJrdzRljsI=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=0m7pz1emTi+K8C4EeniVTz93qHIJAYv4P49Yi5zRJQ8=;\n\tb=AYDdtCslxHhdt6KoCbh4cSUmW4410/SkVC9duAu6saFWyoqcXlNvnMJkdaG2F0kX3f\n\tIa6Au5TSDejWKoo7igl6bbizcI6YI/q+c+vzdD8gNAiXOPqsExWqSiW4FwdH6Q121HYt\n\tnv9yzuKHiqv55XSh3PVa92q1NA/g7yAHdrj2AgTIQcj5Ghx6iCCqA+MBhtSCuNBbRpkg\n\tpKwFP/92dpd6yVC2SVb7NPNhg4j5ixhkIC2maN853IOZYnz+0UV6PIMxl5AHwVqZrZwu\n\tRWdaal4xRyN6ahiQPakQKSrvDnEHMSvgMkWC4zrMtmYhRMYVARzJhr3WnzuhWiCHbCNw\n\tIUhg==","X-Gm-Message-State":"AHPjjUiMt/zvNhF7AqJYaMnl5vnFHmc76bvv79uro4fv+FTJjZAF3aX+\n\tMhGbnZPbbhtLuTkrHRKa3DLCSg==","X-Google-Smtp-Source":"AOwi7QDNSDpaSx4+dhUAwV7+PAqn+hoQIt9Pk3DmsaQezWvcTLcU62URHTKoPADr74KluSv9iZuhrA==","X-Received":"by 10.159.198.74 with SMTP id y10mr4781236plt.45.1506625578933; \n\tThu, 28 Sep 2017 12:06:18 -0700 (PDT)","Date":"Thu, 28 Sep 2017 20:06:14 +0100","From":"Lee Jones ","To":"Maxime Ripard ","Cc":"Quentin Schulz ,\n\tlinus.walleij@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com,\n\twens@csie.org, linux@armlinux.org.uk, linux-gpio@vger.kernel.org,\n\tdevicetree@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com,\n\tthomas.petazzoni@free-electrons.com","Subject":"Re: [PATCH v2 07/10] mfd: axp20x: add pinctrl cell for AXP813","Message-ID":"<20170928190614.v5jgejvgdlyxbxrh@dell>","References":"\n\t<5345a2e94013f4e4f7b545cd4d84b098bd2fa349.1506428208.git-series.quentin.schulz@free-electrons.com>\n\t<20170926131445.xo2uawiovjtmyivj@flea>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20170926131445.xo2uawiovjtmyivj@flea>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}}]