[{"id":1778994,"web_url":"http://patchwork.ozlabs.org/comment/1778994/","msgid":"","list_archive_url":null,"date":"2017-10-03T13:58:41","subject":"Re: [Qemu-devel] [PATCH 41/43] windbg: implemented\n\tkd_api_search_memory","submitter":{"id":68164,"url":"http://patchwork.ozlabs.org/api/people/68164/","name":"Ladi Prosek","email":"lprosek@redhat.com"},"content":"On Tue, Sep 26, 2017 at 1:07 PM, Mihail Abakumov\n wrote:\n> Signed-off-by: Mihail Abakumov \n> Signed-off-by: Pavel Dovgalyuk \n> Signed-off-by: Dmitriy Koltunov \n> ---\n> include/exec/windbgstub-utils.h | 1 +\n> windbgstub-utils.c | 30 ++++++++++++++++++++++++++++++\n> windbgstub.c | 4 ++++\n> 3 files changed, 35 insertions(+)\n>\n> diff --git a/include/exec/windbgstub-utils.h b/include/exec/windbgstub-utils.h\n> index 23cafb1a89..ba001ddb42 100755\n> --- a/include/exec/windbgstub-utils.h\n> +++ b/include/exec/windbgstub-utils.h\n> @@ -118,6 +118,7 @@ void kd_api_write_physical_memory(CPUState *cpu, PacketData *pd);\n> void kd_api_get_version(CPUState *cpu, PacketData *pd);\n> void kd_api_read_msr(CPUState *cpu, PacketData *pd);\n> void kd_api_write_msr(CPUState *cpu, PacketData *pd);\n> +void kd_api_search_memory(CPUState *cpu, PacketData *pd);\n> void kd_api_unsupported(CPUState *cpu, PacketData *pd);\n>\n> SizedBuf kd_gen_exception_sc(CPUState *cpu);\n> diff --git a/windbgstub-utils.c b/windbgstub-utils.c\n> index 26bdb1f6ea..2d3fbcc41c 100755\n> --- a/windbgstub-utils.c\n> +++ b/windbgstub-utils.c\n> @@ -1540,6 +1540,36 @@ void kd_api_write_msr(CPUState *cpu, PacketData *pd)\n> pd->m64.ReturnStatus = STATUS_SUCCESS;\n> }\n>\n> +void kd_api_search_memory(CPUState *cpu, PacketData *pd)\n> +{\n> + DBGKD_SEARCH_MEMORY *m64c = &pd->m64.u.SearchMemory;\n> + int s_len = MAX(1, ldq_p(&m64c->SearchLength));\n> + int p_len = MIN(ldl_p(&m64c->PatternLength), pd->extra_size);\n> + target_ulong addr = ldq_p(&m64c->SearchAddress);\n> +\n> + uint8_t mem[s_len - 1 + p_len];\n\ns_len could be very large, people do things like\n\n0:000> s -d 0x80000000 L?0x7fffffff \n\nYou should not allocate this buffer on the stack and preferably break\nlarge searches down to smaller ranges, i.e. don't allocate and read\n~s_len bytes all at once.\n\n> + int err = cpu_memory_rw_debug(cpu, addr, mem, sizeof(mem), 0);\n> + if (!err) {\n> + int i;\n> + pd->m64.ReturnStatus = STATUS_NO_MORE_ENTRIES;\n> + for (i = 0; i < s_len; ++i) {\n> + if (memcmp(mem + i, pd->extra, p_len) == 0) {\n> + m64c->FoundAddress = addr + i;\n> + m64c->FoundAddress = ldq_p(&m64c->FoundAddress);\n> + pd->m64.ReturnStatus = STATUS_SUCCESS;\n> + break;\n> + }\n> + }\n\nUse memmem instead?\n\n> + } else {\n> + pd->m64.ReturnStatus = STATUS_UNSUCCESSFUL;\n> + WINDBG_DEBUG(\"search_memory: No physical page mapped: \" FMT_ADDR,\n> + addr);\n> + }\n> +\n> + pd->extra_size = 0;\n> +}\n> +\n> void kd_api_unsupported(CPUState *cpu, PacketData *pd)\n> {\n> WINDBG_ERROR(\"Catched unimplemented api %s\",\n> diff --git a/windbgstub.c b/windbgstub.c\n> index 1ec4932ddc..7cff6bc514 100755\n> --- a/windbgstub.c\n> +++ b/windbgstub.c\n> @@ -205,6 +205,10 @@ static void windbg_process_manipulate_packet(ParsingContext *ctx)\n> case DbgKdClearAllInternalBreakpointsApi:\n> return;\n>\n> + case DbgKdSearchMemoryApi:\n> + kd_api_search_memory(cpu, &ctx->data);\n> + break;\n> +\n> default:\n> kd_api_unsupported(cpu, &ctx->data);\n> break;\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y60yW4csWz9sPk\n\tfor ;\n\tWed, 4 Oct 2017 00:59:17 +1100 (AEDT)","from localhost ([::1]:58699 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dzNj1-0002d3-5L\n\tfor incoming@patchwork.ozlabs.org; Tue, 03 Oct 2017 09:59:07 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:44159)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dzNig-0002cm-QS\n\tfor qemu-devel@nongnu.org; Tue, 03 Oct 2017 09:58:47 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dzNic-0003w2-QC\n\tfor qemu-devel@nongnu.org; Tue, 03 Oct 2017 09:58:46 -0400","from mail-ua0-f177.google.com ([209.85.217.177]:49818)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1dzNic-0003vk-LI\n\tfor qemu-devel@nongnu.org; Tue, 03 Oct 2017 09:58:42 -0400","by mail-ua0-f177.google.com with SMTP id 97so5237074uai.6\n\tfor ; Tue, 03 Oct 2017 06:58:42 -0700 (PDT)","by 10.103.60.26 with HTTP; Tue, 3 Oct 2017 06:58:41 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=iroaK7KhmaZ7li7RuhLPIoT1t38MSxvHJaMHZ+JpnRI=;\n\tb=LAUESez6wVKqqm5da1KjQWWwITXHdUygQi5gohnCMIXG1ufV2tPIcP5ID/QZs5EXmF\n\t5ebP8vVkV+W1DbAtdaxqdpewW/xG6Z5pMpP1mhl36byn8xd/DJFQ+PGqRxmduR2m/0F4\n\t3wAGF6bWVOJOfo7YSJTezPgIWa3332wRolDDnk9raaglDEuOZ8kSqfd+gCr4EWs9aA5s\n\tj1y4dh84DSOPLDpU5aSmS6+wdQ5TbSUJbS17uR3ST1UCD1MhYlUxseQQGcRurZWKzv0e\n\tzlm9ZzV5hhPVC8qoG0SXjIDQLyfAKbMth/ZxpJ3jWoPwjXdEDPjUa7/jDJMxZPRrcWjd\n\tFkZg==","X-Gm-Message-State":"AMCzsaVcMQ+VfOh3KNeyF42ltFzMw50QKIumFzzuHycvAN+7oGWRD6IC\n\t59h3B6rTLwL9CgnQbVQLP1OrE01BdpwD4Unnu+zxDQ==","X-Google-Smtp-Source":"AOwi7QCoRUFWRiRJrgjwQ0reGn1nq13KUjHYf+fUz6YpaeeEdywgtXCwELI8W7K8WfbazNpC2YJd3sGMbRLRo/DJ6Vw=","X-Received":"by 10.176.81.68 with SMTP id f4mr3917273uaa.52.1507039121711;\n\tTue, 03 Oct 2017 06:58:41 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<150642407781.3900.3667954520393080307.stgit@Misha-PC.lan02.inno>","References":"<150642384156.3900.3326424823772221077.stgit@Misha-PC.lan02.inno>\n\t<150642407781.3900.3667954520393080307.stgit@Misha-PC.lan02.inno>","From":"Ladi Prosek ","Date":"Tue, 3 Oct 2017 15:58:41 +0200","Message-ID":"","To":"Mihail Abakumov ","Content-Type":"text/plain; charset=\"UTF-8\"","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.85.217.177","Subject":"Re: [Qemu-devel] [PATCH 41/43] windbg: implemented\n\tkd_api_search_memory","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"sw@weilnetz.de, qemu-devel ,\n\tPavel Dovgalyuk ,\n\tRoman Kagan , \n\tPaolo Bonzini , \"Denis V. Lunev\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1793144,"web_url":"http://patchwork.ozlabs.org/comment/1793144/","msgid":"<1bad3fc5b87c1b8913e010ad0d0816cd@ispras.ru>","list_archive_url":null,"date":"2017-10-24T11:59:26","subject":"Re: [Qemu-devel] [PATCH 41/43] windbg: implemented\n\tkd_api_search_memory","submitter":{"id":71645,"url":"http://patchwork.ozlabs.org/api/people/71645/","name":"Mikhail Abakumov","email":"mikhail.abakumov@ispras.ru"},"content":"Ladi Prosek писал 2017-10-03 16:58:\n> On Tue, Sep 26, 2017 at 1:07 PM, Mihail Abakumov\n> wrote:\n>> +\n>> + uint8_t mem[s_len - 1 + p_len];\n> \n> s_len could be very large, people do things like\n> \n> 0:000> s -d 0x80000000 L?0x7fffffff \n> \n> You should not allocate this buffer on the stack and preferably break\n> large searches down to smaller ranges, i.e. don't allocate and read\n> ~s_len bytes all at once.\n\nYes, you're right. I corrected it.\n\n> \n>> + int err = cpu_memory_rw_debug(cpu, addr, mem, sizeof(mem), 0);\n>> + if (!err) {\n>> + int i;\n>> + pd->m64.ReturnStatus = STATUS_NO_MORE_ENTRIES;\n>> + for (i = 0; i < s_len; ++i) {\n>> + if (memcmp(mem + i, pd->extra, p_len) == 0) {\n>> + m64c->FoundAddress = addr + i;\n>> + m64c->FoundAddress = ldq_p(&m64c->FoundAddress);\n>> + pd->m64.ReturnStatus = STATUS_SUCCESS;\n>> + break;\n>> + }\n>> + }\n> \n> Use memmem instead?\n> \n\nFor some reason, I do not have such function.\n\nThanks,\nMihail Abakumov","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yLsJr3nvFz9t2l\n\tfor ;\n\tTue, 24 Oct 2017 22:59:55 +1100 (AEDT)","from localhost ([::1]:43310 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e6xs9-0007dj-2e\n\tfor incoming@patchwork.ozlabs.org; Tue, 24 Oct 2017 07:59:53 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:37445)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e6xro-0007dc-PT\n\tfor qemu-devel@nongnu.org; Tue, 24 Oct 2017 07:59:33 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e6xrk-0006Lf-0b\n\tfor qemu-devel@nongnu.org; Tue, 24 Oct 2017 07:59:32 -0400","from mail.ispras.ru ([83.149.199.45]:49936)\n\tby eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e6xrj-0006Kf-Pc\n\tfor qemu-devel@nongnu.org; Tue, 24 Oct 2017 07:59:27 -0400","from mail.ispras.ru (localhost [127.0.0.1])\n\tby mail.ispras.ru (Postfix) with ESMTPSA id C3D5654006C;\n\tTue, 24 Oct 2017 14:59:26 +0300 (MSK)"],"MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8;\n format=flowed","Date":"Tue, 24 Oct 2017 14:59:26 +0300","From":"Mihail Abakumov ","To":"Ladi Prosek ","In-Reply-To":"","References":"<150642384156.3900.3326424823772221077.stgit@Misha-PC.lan02.inno>\n\t<150642407781.3900.3667954520393080307.stgit@Misha-PC.lan02.inno>\n\t","Message-ID":"<1bad3fc5b87c1b8913e010ad0d0816cd@ispras.ru>","X-Sender":"mikhail.abakumov@ispras.ru","User-Agent":"Roundcube Webmail/1.1.2","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [fuzzy]","X-Received-From":"83.149.199.45","Subject":"Re: [Qemu-devel] [PATCH 41/43] windbg: implemented\n\tkd_api_search_memory","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"sw@weilnetz.de, qemu-devel ,\n\tPavel Dovgalyuk ,\n\tRoman Kagan , \n\tPaolo Bonzini , \"Denis V. Lunev\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]