[{"id":1778991,"web_url":"http://patchwork.ozlabs.org/comment/1778991/","msgid":"","list_archive_url":null,"date":"2017-10-03T13:47:00","subject":"Re: [Qemu-devel] [PATCH 38/43] windbg: implemented\n\tkd_api_read_physical_memory and kd_api_write_physical_memory","submitter":{"id":68164,"url":"http://patchwork.ozlabs.org/api/people/68164/","name":"Ladi Prosek","email":"lprosek@redhat.com"},"content":"On Tue, Sep 26, 2017 at 1:07 PM, Mihail Abakumov\n wrote:\n> Signed-off-by: Mihail Abakumov \n> Signed-off-by: Pavel Dovgalyuk \n> Signed-off-by: Dmitriy Koltunov \n> ---\n> include/exec/windbgstub-utils.h | 2 ++\n> windbgstub-utils.c | 28 ++++++++++++++++++++++++++++\n> windbgstub.c | 8 ++++++++\n> 3 files changed, 38 insertions(+)\n>\n> diff --git a/include/exec/windbgstub-utils.h b/include/exec/windbgstub-utils.h\n> index 07e11c0494..d390bc1dfe 100755\n> --- a/include/exec/windbgstub-utils.h\n> +++ b/include/exec/windbgstub-utils.h\n> @@ -113,6 +113,8 @@ void kd_api_read_control_space(CPUState *cpu, PacketData *pd);\n> void kd_api_write_control_space(CPUState *cpu, PacketData *pd);\n> void kd_api_read_io_space(CPUState *cpu, PacketData *pd);\n> void kd_api_write_io_space(CPUState *cpu, PacketData *pd);\n> +void kd_api_read_physical_memory(CPUState *cpu, PacketData *pd);\n> +void kd_api_write_physical_memory(CPUState *cpu, PacketData *pd);\n> void kd_api_unsupported(CPUState *cpu, PacketData *pd);\n>\n> SizedBuf kd_gen_exception_sc(CPUState *cpu);\n> diff --git a/windbgstub-utils.c b/windbgstub-utils.c\n> index 6bf9868e51..1fba54f9d9 100755\n> --- a/windbgstub-utils.c\n> +++ b/windbgstub-utils.c\n> @@ -1170,6 +1170,34 @@ void kd_api_write_io_space(CPUState *cpu, PacketData *pd)\n> pd->m64.ReturnStatus = STATUS_SUCCESS;\n> }\n>\n> +void kd_api_read_physical_memory(CPUState *cpu, PacketData *pd)\n> +{\n> + DBGKD_READ_MEMORY64 *mem = &pd->m64.u.ReadMemory;\n> + uint32_t len;\n> + target_ulong addr;\n> +\n> + len = MIN(ldl_p(&mem->TransferCount), PACKET_MAX_SIZE - M64_SIZE);\n> + addr = ldtul_p(&mem->TargetBaseAddress);\n> +\n> + cpu_physical_memory_rw(addr, pd->extra, len, 0);\n> + pd->extra_size = len;\n> + mem->ActualBytesRead = ldl_p(&len);\n\nstl_p(&mem->ActualBytesRead, len)\n\nAnd the same pattern is in many other places. Stores to potentially\nunaligned memory locations with the right endianness should be done\nwith st* not ld*.\n\n> +}\n> +\n> +void kd_api_write_physical_memory(CPUState *cpu, PacketData *pd)\n> +{\n> + DBGKD_WRITE_MEMORY64 *mem = &pd->m64.u.WriteMemory;\n> + uint32_t len;\n> + target_ulong addr;\n> +\n> + len = MIN(ldl_p(&mem->TransferCount), pd->extra_size);\n> + addr = ldtul_p(&mem->TargetBaseAddress);\n> +\n> + cpu_physical_memory_rw(addr, pd->extra, len, 1);\n> + pd->extra_size = 0;\n> + mem->ActualBytesWritten = ldl_p(&len);\n> +}\n> +\n> void kd_api_unsupported(CPUState *cpu, PacketData *pd)\n> {\n> WINDBG_ERROR(\"Catched unimplemented api %s\",\n> diff --git a/windbgstub.c b/windbgstub.c\n> index 0363d9a5c8..118e9dd697 100755\n> --- a/windbgstub.c\n> +++ b/windbgstub.c\n> @@ -182,6 +182,14 @@ static void windbg_process_manipulate_packet(ParsingContext *ctx)\n> kd_api_write_control_space(cpu, &ctx->data);\n> break;\n>\n> + case DbgKdReadPhysicalMemoryApi:\n> + kd_api_read_physical_memory(cpu, &ctx->data);\n> + break;\n> +\n> + case DbgKdWritePhysicalMemoryApi:\n> + kd_api_write_physical_memory(cpu, &ctx->data);\n> + break;\n> +\n> case DbgKdClearAllInternalBreakpointsApi:\n> return;\n>\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y60r464sqz9t2Q\n\tfor ;\n\tWed, 4 Oct 2017 00:53:56 +1100 (AEDT)","from localhost ([::1]:58681 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dzNdz-0007uq-0T\n\tfor incoming@patchwork.ozlabs.org; Tue, 03 Oct 2017 09:53:55 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:40428)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dzNXQ-0002iR-Rv\n\tfor qemu-devel@nongnu.org; Tue, 03 Oct 2017 09:47:15 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dzNXK-0004Zd-If\n\tfor qemu-devel@nongnu.org; Tue, 03 Oct 2017 09:47:07 -0400","from mail-ua0-f169.google.com ([209.85.217.169]:52040)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1dzNXK-0004Yq-E4\n\tfor qemu-devel@nongnu.org; Tue, 03 Oct 2017 09:47:02 -0400","by mail-ua0-f169.google.com with SMTP id 47so4899631uas.8\n\tfor ; Tue, 03 Oct 2017 06:47:02 -0700 (PDT)","by 10.103.60.26 with HTTP; Tue, 3 Oct 2017 06:47:00 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=BtDUoap+xhmtbejNe5q1Nej5audF445rsOOKTVt2iak=;\n\tb=MrrlhxnqYLqWfGfKFXcHrETsdzz5+oU3MN8LOSy2P+woxGTs5UGDcqSWzWcZnc+hSQ\n\tKOEYYOrx8wS6Hg8cxxxRDfNonjrUhhzFrZVZ0tyaHl2X7dko+yNpF0AxnYt6rb4MrSRo\n\tUs18AGoP5qIYoGHbrcBVRjzMydP1gm4cRA9chN8JGEwy1DdN4vFV7HHJZpixtp/c7e5X\n\t6enNUZMHER/gFDikemAoMVmUu+WWtJFZQJL68IWBm/4AyCuhf7jh7rMSe8HD/I2ifift\n\tYqH+ZOPkj2KkTmJYJ55jLv/R/20u83M/nRrcaFQjeQrUMXqm34LKGJnfO1UNLoUW+vxV\n\t3RWA==","X-Gm-Message-State":"AMCzsaVX8wMSOIAoaNleEpAFYTy3luXW4Wzm8jHPDhZg7bF08AfOgaTe\n\tvv//BGuXgU2BvkNCAUYkBMf+wLifgCkgJelWaCdMnQ==","X-Google-Smtp-Source":"AOwi7QAtJ5m1ycRAXueXlsxRrpkpV844QoGOfM9mca4QRFbxVby7Ur5WAp31LTzIWnlfWFHfAI0Di2Yh1RAHYtoekWU=","X-Received":"by 10.159.43.206 with SMTP id f14mr8559553uaj.98.1507038421595; \n\tTue, 03 Oct 2017 06:47:01 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<150642406010.3900.1199547239226671745.stgit@Misha-PC.lan02.inno>","References":"<150642384156.3900.3326424823772221077.stgit@Misha-PC.lan02.inno>\n\t<150642406010.3900.1199547239226671745.stgit@Misha-PC.lan02.inno>","From":"Ladi Prosek ","Date":"Tue, 3 Oct 2017 15:47:00 +0200","Message-ID":"","To":"Mihail Abakumov ","Content-Type":"text/plain; charset=\"UTF-8\"","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.85.217.169","Subject":"Re: [Qemu-devel] [PATCH 38/43] windbg: implemented\n\tkd_api_read_physical_memory and kd_api_write_physical_memory","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"sw@weilnetz.de, qemu-devel ,\n\tPavel Dovgalyuk ,\n\tRoman Kagan , \n\tPaolo Bonzini , \"Denis V. Lunev\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]