[{"id":1778995,"web_url":"http://patchwork.ozlabs.org/comment/1778995/","msgid":"","list_archive_url":null,"date":"2017-10-03T14:00:56","subject":"Re: [Qemu-devel] [PATCH 42/43] windbg: implemented\n\tkd_api_fill_memory","submitter":{"id":68164,"url":"http://patchwork.ozlabs.org/api/people/68164/","name":"Ladi Prosek","email":"lprosek@redhat.com"},"content":"On Tue, Sep 26, 2017 at 1:08 PM, Mihail Abakumov\n wrote:\n> Signed-off-by: Mihail Abakumov \n> Signed-off-by: Pavel Dovgalyuk \n> Signed-off-by: Dmitriy Koltunov \n> ---\n> include/exec/windbgstub-utils.h | 1 +\n> windbgstub-utils.c | 36 ++++++++++++++++++++++++++++++++++++\n> windbgstub.c | 4 ++++\n> 3 files changed, 41 insertions(+)\n>\n> diff --git a/include/exec/windbgstub-utils.h b/include/exec/windbgstub-utils.h\n> index ba001ddb42..d1a10c862e 100755\n> --- a/include/exec/windbgstub-utils.h\n> +++ b/include/exec/windbgstub-utils.h\n> @@ -119,6 +119,7 @@ void kd_api_get_version(CPUState *cpu, PacketData *pd);\n> void kd_api_read_msr(CPUState *cpu, PacketData *pd);\n> void kd_api_write_msr(CPUState *cpu, PacketData *pd);\n> void kd_api_search_memory(CPUState *cpu, PacketData *pd);\n> +void kd_api_fill_memory(CPUState *cpu, PacketData *pd);\n> void kd_api_unsupported(CPUState *cpu, PacketData *pd);\n>\n> SizedBuf kd_gen_exception_sc(CPUState *cpu);\n> diff --git a/windbgstub-utils.c b/windbgstub-utils.c\n> index 2d3fbcc41c..3832e0b116 100755\n> --- a/windbgstub-utils.c\n> +++ b/windbgstub-utils.c\n> @@ -1570,6 +1570,42 @@ void kd_api_search_memory(CPUState *cpu, PacketData *pd)\n> pd->extra_size = 0;\n> }\n>\n> +void kd_api_fill_memory(CPUState *cpu, PacketData *pd)\n> +{\n> + DBGKD_FILL_MEMORY *m64c = &pd->m64.u.FillMemory;\n> +\n> + uint32_t len = ldl_p(&m64c->Length);\n> + target_ulong addr = ldq_p(&m64c->Address);\n> + uint16_t pattern = ldl_p(&m64c->PatternLength);\n> + uint16_t flags = ldl_p(&m64c->Flags);\n> +\n> + uint8_t mem[len];\n\nSame as patch 41, break len into, say, page-sized regions and call\ncpu_memory_rw_debug in a loop.\n\n> + int i, err;\n> + for (i = 0; i < len; ++i) {\n> + mem[i] = pd->extra[i % pattern];\n> + }\n> +\n> + switch (flags) {\n> + case DBGKD_FILL_MEMORY_VIRTUAL:\n> + err = cpu_memory_rw_debug(cpu, addr, mem, len, 1);\n> + if (err) {\n> + pd->m64.ReturnStatus = STATUS_UNSUCCESSFUL;\n> + WINDBG_DEBUG(\"fill_memory: No physical page mapped: \" FMT_ADDR,\n> + addr);\n> + }\n> + break;\n> +\n> + case DBGKD_FILL_MEMORY_PHYSICAL:\n> + cpu_physical_memory_rw(addr, mem, len, 1);\n> + break;\n> +\n> + default:\n> + break;\n> + }\n> +\n> + pd->extra_size = 0;\n> +}\n> +\n> void kd_api_unsupported(CPUState *cpu, PacketData *pd)\n> {\n> WINDBG_ERROR(\"Catched unimplemented api %s\",\n> diff --git a/windbgstub.c b/windbgstub.c\n> index 7cff6bc514..b01ddcf009 100755\n> --- a/windbgstub.c\n> +++ b/windbgstub.c\n> @@ -209,6 +209,10 @@ static void windbg_process_manipulate_packet(ParsingContext *ctx)\n> kd_api_search_memory(cpu, &ctx->data);\n> break;\n>\n> + case DbgKdFillMemoryApi:\n> + kd_api_fill_memory(cpu, &ctx->data);\n> + break;\n> +\n> default:\n> kd_api_unsupported(cpu, &ctx->data);\n> break;\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y610p5098z9t2Q\n\tfor ;\n\tWed, 4 Oct 2017 01:01:30 +1100 (AEDT)","from localhost ([::1]:58710 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dzNlI-0003RY-Sb\n\tfor incoming@patchwork.ozlabs.org; Tue, 03 Oct 2017 10:01:28 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:44682)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dzNky-0003Qw-Ln\n\tfor qemu-devel@nongnu.org; Tue, 03 Oct 2017 10:01:09 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dzNkp-0005uR-8h\n\tfor qemu-devel@nongnu.org; Tue, 03 Oct 2017 10:01:08 -0400","from mail-vk0-f41.google.com ([209.85.213.41]:52220)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1dzNkp-0005to-4K\n\tfor qemu-devel@nongnu.org; Tue, 03 Oct 2017 10:00:59 -0400","by mail-vk0-f41.google.com with SMTP id 137so2094862vkk.8\n\tfor ; Tue, 03 Oct 2017 07:00:58 -0700 (PDT)","by 10.103.60.26 with HTTP; Tue, 3 Oct 2017 07:00:56 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=OYCYvTQzat6p8o8Fczxz9JVWjB/l2+hv25sSFd/HQbs=;\n\tb=EbvgBBy0Bmvhzj0/pYZKgFMdIBE+eIZh905yQ2qYbTQ0tbOp0LFgRko3f08aVtYfk4\n\tz0iwDGarQ1q2gdtakGBNhly1oOMzY+8jb2Vegbsi6OA7B0Se7z8lSvE1BRMZ/o7GfI3l\n\t75nMpuqM/4E0PIkOoovHlyHhRAeQ0mhOno61O6JU7V+Wmsau1DJxGQ73Ho5rSY6xm4Tw\n\t3yG2c63I9UohUe4g1mnZq2DpOWvQ76+/nh9IutH6UTAYwlutk61BiiWVa5+3MTvBqm83\n\tfq31bVqnB/o1jfiWl8iHdHEDE+f6sntHg58K6nxZW43FHbtSZOVSWXIMcyW8AdDtfyu4\n\tfXtA==","X-Gm-Message-State":"AMCzsaV+/BzSp9kX6OCumvMZkElrBpKLZmYKLPRbwnbENOMnoxDGmTWI\n\taij8dX4q1+npuCnTFcz/1InmQjw9X9B6tn2KYVUtEg==","X-Google-Smtp-Source":"AOwi7QDs1kWaRSoSGkSfU4IioVT3buphRH0j5Cq10LaQIC2DzADcIb3Xwbnmu1ivgIsDj+9JKoNwhutq63e+KL6Ptpo=","X-Received":"by 10.31.139.68 with SMTP id n65mr1282226vkd.192.1507039256625; \n\tTue, 03 Oct 2017 07:00:56 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<150642408350.3900.16985989168069353852.stgit@Misha-PC.lan02.inno>","References":"<150642384156.3900.3326424823772221077.stgit@Misha-PC.lan02.inno>\n\t<150642408350.3900.16985989168069353852.stgit@Misha-PC.lan02.inno>","From":"Ladi Prosek ","Date":"Tue, 3 Oct 2017 16:00:56 +0200","Message-ID":"","To":"Mihail Abakumov ","Content-Type":"text/plain; charset=\"UTF-8\"","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.85.213.41","Subject":"Re: [Qemu-devel] [PATCH 42/43] windbg: implemented\n\tkd_api_fill_memory","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"sw@weilnetz.de, qemu-devel ,\n\tPavel Dovgalyuk ,\n\tRoman Kagan , \n\tPaolo Bonzini , \"Denis V. Lunev\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]