[{"id":1778905,"web_url":"http://patchwork.ozlabs.org/comment/1778905/","msgid":"","list_archive_url":null,"date":"2017-10-03T12:32:54","subject":"Re: [Qemu-devel] [PATCH 26/43] windbg: implemented\n\twindbg_read_context","submitter":{"id":68164,"url":"http://patchwork.ozlabs.org/api/people/68164/","name":"Ladi Prosek","email":"lprosek@redhat.com"},"content":"On Tue, Sep 26, 2017 at 1:06 PM, Mihail Abakumov\n wrote:\n> Signed-off-by: Mihail Abakumov \n> Signed-off-by: Pavel Dovgalyuk \n> Signed-off-by: Dmitriy Koltunov \n> ---\n> windbgstub-utils.c | 90 +++++++++++++++++++++++++++++++++++++++++++++++++++-\n> 1 file changed, 89 insertions(+), 1 deletion(-)\n>\n> diff --git a/windbgstub-utils.c b/windbgstub-utils.c\n> index c3ae2ddf5b..23bf4be9f0 100755\n> --- a/windbgstub-utils.c\n> +++ b/windbgstub-utils.c\n> @@ -280,7 +280,95 @@ static KDData *kd;\n> static int windbg_read_context(CPUState *cpu, uint8_t *buf, int len,\n> int offset)\n> {\n> - return 0;\n> + const bool new_mem = (len != sizeof(CPU_CONTEXT) || offset != 0);\n> + CPUArchState *env = cpu->env_ptr;\n> + CPU_CONTEXT *cc;\n> + int err = 0;\n> +\n> + if (new_mem) {\n> + cc = g_new(CPU_CONTEXT, 1);\n> + } else {\n> + cc = (CPU_CONTEXT *) buf;\n> + }\n> +\n> + memset(cc, 0, len);\n\nThis overruns the buffer if len > sizeof(CPU_CONTEXT).\n\n> +\n> + cc->ContextFlags = CPU_CONTEXT_ALL;\n> +\n> + if (cc->ContextFlags & CPU_CONTEXT_SEGMENTS) {\n> + cc->SegCs = lduw_p(&env->segs[R_CS].selector);\n> + cc->SegDs = lduw_p(&env->segs[R_DS].selector);\n> + cc->SegEs = lduw_p(&env->segs[R_ES].selector);\n> + cc->SegFs = lduw_p(&env->segs[R_FS].selector);\n> + cc->SegGs = lduw_p(&env->segs[R_GS].selector);\n> + cc->SegSs = lduw_p(&env->segs[R_SS].selector);\n> + }\n> +\n> + if (cc->ContextFlags & CPU_CONTEXT_DEBUG_REGISTERS) {\n> + cc->Dr0 = ldtul_p(&env->dr[0]);\n> + cc->Dr1 = ldtul_p(&env->dr[1]);\n> + cc->Dr2 = ldtul_p(&env->dr[2]);\n> + cc->Dr3 = ldtul_p(&env->dr[3]);\n> + cc->Dr6 = ldtul_p(&env->dr[6]);\n> + cc->Dr7 = ldtul_p(&env->dr[7]);\n> + }\n> +\n> + if (cc->ContextFlags & CPU_CONTEXT_INTEGER) {\n> + cc->Edi = ldl_p(&env->regs[R_EDI]);\n> + cc->Esi = ldl_p(&env->regs[R_ESI]);\n> + cc->Ebx = ldl_p(&env->regs[R_EBX]);\n> + cc->Edx = ldl_p(&env->regs[R_EDX]);\n> + cc->Ecx = ldl_p(&env->regs[R_ECX]);\n> + cc->Eax = ldl_p(&env->regs[R_EAX]);\n> + cc->Ebp = ldl_p(&env->regs[R_EBP]);\n> + cc->Esp = ldl_p(&env->regs[R_ESP]);\n> +\n> + cc->Eip = ldl_p(&env->eip);\n> + cc->EFlags = ldl_p(&env->eflags);\n> + }\n> +\n> + if (cc->ContextFlags & CPU_CONTEXT_FLOATING_POINT) {\n> + uint32_t swd = 0, twd = 0;\n> + swd = env->fpus & ~(7 << 11);\n> + swd |= (env->fpstt & 7) << 11;\n> + int i;\n> + for (i = 0; i < 8; ++i) {\n> + twd |= (!env->fptags[i]) << i;\n> + }\n> +\n> + cc->FloatSave.ControlWord = ldl_p(&env->fpuc);\n> + cc->FloatSave.StatusWord = ldl_p(&swd);\n> + cc->FloatSave.TagWord = ldl_p(&twd);\n> + cc->FloatSave.ErrorOffset = ldl_p(PTR(env->fpip));\n> + cc->FloatSave.ErrorSelector = ldl_p(PTR(env->fpip) + 32);\n> + cc->FloatSave.DataOffset = ldl_p(PTR(env->fpdp));\n> + cc->FloatSave.DataSelector = ldl_p(PTR(env->fpdp) + 32);\n> + cc->FloatSave.Cr0NpxState = ldl_p(&env->xcr0);\n> +\n> + for (i = 0; i < 8; ++i) {\n> + memcpy(PTR(cc->FloatSave.RegisterArea[i * 10]),\n> + PTR(env->fpregs[i]), 10);\n> + }\n> + }\n> +\n> + if (cc->ContextFlags & CPU_CONTEXT_EXTENDED_REGISTERS) {\n> + uint8_t *ptr = cc->ExtendedRegisters + 160;\n> + int i;\n> + for (i = 0; i < 8; ++i, ptr += 16) {\n> + stq_p(ptr, env->xmm_regs[i].ZMM_Q(0));\n> + stq_p(ptr + 8, env->xmm_regs[i].ZMM_Q(1));\n> + }\n> +\n> + stl_p(cc->ExtendedRegisters + 24, env->mxcsr);\n> + }\n> +\n> + cc->ContextFlags = ldl_p(&cc->ContextFlags);\n> +\n> + if (new_mem) {\n> + memcpy(buf, (uint8_t *) cc + offset, len);\n> + g_free(cc);\n> + }\n> + return err;\n> }\n>\n> static int windbg_write_context(CPUState *cpu, uint8_t *buf, int len,\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y5z3D2ygJz9s0Z\n\tfor ;\n\tTue, 3 Oct 2017 23:33:26 +1100 (AEDT)","from localhost ([::1]:58385 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dzMO1-0001x8-Ar\n\tfor incoming@patchwork.ozlabs.org; Tue, 03 Oct 2017 08:33:21 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:47919)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dzMNf-0001wr-RE\n\tfor qemu-devel@nongnu.org; Tue, 03 Oct 2017 08:33:00 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dzMNb-0008Pg-Ow\n\tfor qemu-devel@nongnu.org; Tue, 03 Oct 2017 08:32:59 -0400","from mail-ua0-f169.google.com ([209.85.217.169]:51506)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1dzMNb-0008PV-Jl\n\tfor qemu-devel@nongnu.org; Tue, 03 Oct 2017 08:32:55 -0400","by mail-ua0-f169.google.com with SMTP id 47so4752226uas.8\n\tfor ; Tue, 03 Oct 2017 05:32:55 -0700 (PDT)","by 10.103.60.26 with HTTP; Tue, 3 Oct 2017 05:32:54 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=TslDq/7SIzSGHf45pHv6cHRWPmmUzfl280AqlovJrTc=;\n\tb=KTYnufUV4GjYofZtbx7CNXRva1eKQIfKAMBhHtMCjG+tHywYdNQ9UkIoPO5UHRe2ac\n\taNdKtdykvN2E5NqvTxWFvT6Zvq1a6VPiSL0YCiOqvigWAy/aVxQoEhcNe97I4nk1Cg1M\n\td8R9Z08cJLhzc0K0K4pLiTuPPtuJYDmn5w7tEZssou+VDZkfy55kRRT9Xj9bA5pAaBnQ\n\tFAkuDYytIxHTzxKSmJhjNOPvQyQZp97+Y6+lctS4fPu0EbqZHFQz+V+StRV6F86HuatM\n\tsaxJR8eDAfFlR5MBoFCNIUFoq9q/3maW6mBJNY7yp7keus19AC/qw4o5EIpEjPRIKr/V\n\t+4ag==","X-Gm-Message-State":"AHPjjUj+rkB8ki2sqHL+veX+kTphnjyH/6Vf6hnkLJlSbuuiC2sxMd7f\n\tZ1QXqFoQkhWOE3+Lc+W0r9EjFS+PJVViWXxPRxH0gg==","X-Google-Smtp-Source":"AOwi7QD+dZjn2TeXbafynB0HsNfrng6dUzh/gOaIZrlvPtMNMMQMm6NO4DNiDgQL/+YEEYvLQC5ioWVDOUl+rtCDhcU=","X-Received":"by 10.176.4.199 with SMTP id 65mr10533745uaw.47.1507033974707;\n\tTue, 03 Oct 2017 05:32:54 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<150642399172.3900.299369975046339119.stgit@Misha-PC.lan02.inno>","References":"<150642384156.3900.3326424823772221077.stgit@Misha-PC.lan02.inno>\n\t<150642399172.3900.299369975046339119.stgit@Misha-PC.lan02.inno>","From":"Ladi Prosek ","Date":"Tue, 3 Oct 2017 14:32:54 +0200","Message-ID":"","To":"Mihail Abakumov ","Content-Type":"text/plain; charset=\"UTF-8\"","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.85.217.169","Subject":"Re: [Qemu-devel] [PATCH 26/43] windbg: implemented\n\twindbg_read_context","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"sw@weilnetz.de, qemu-devel ,\n\tPavel Dovgalyuk ,\n\tRoman Kagan , \n\tPaolo Bonzini , \"Denis V. Lunev\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]