[{"id":1778890,"web_url":"http://patchwork.ozlabs.org/comment/1778890/","msgid":"","list_archive_url":null,"date":"2017-10-03T12:20:44","subject":"Re: [Qemu-devel] [PATCH 19/43] windbg: implemented\n\twindbg_process_control_packet","submitter":{"id":68164,"url":"http://patchwork.ozlabs.org/api/people/68164/","name":"Ladi Prosek","email":"lprosek@redhat.com"},"content":"On Tue, Sep 26, 2017 at 1:05 PM, Mihail Abakumov\n wrote:\n> Signed-off-by: Mihail Abakumov \n> Signed-off-by: Pavel Dovgalyuk \n> Signed-off-by: Dmitriy Koltunov \n> ---\n> windbgstub.c | 26 +++++++++++++++++++++++++-\n> 1 file changed, 25 insertions(+), 1 deletion(-)\n>\n> diff --git a/windbgstub.c b/windbgstub.c\n> index 3a13d22349..b8053102dd 100755\n> --- a/windbgstub.c\n> +++ b/windbgstub.c\n> @@ -126,7 +126,31 @@ static void windbg_process_data_packet(ParsingContext *ctx)\n> {}\n>\n> static void windbg_process_control_packet(ParsingContext *ctx)\n> -{}\n> +{\n> + switch (ctx->packet.PacketType) {\n> + case PACKET_TYPE_KD_ACKNOWLEDGE:\n> + break;\n> +\n> + case PACKET_TYPE_KD_RESET:\n> + {\n> + SizedBuf buf = kd_gen_load_symbols_sc(qemu_get_cpu(0));\n> +\n> + windbg_send_data_packet(buf.data, buf.size,\n> + PACKET_TYPE_KD_STATE_CHANGE64);\n> + windbg_send_control_packet(ctx->packet.PacketType);\n> + windbg_state->ctrl_packet_id = INITIAL_PACKET_ID;\n> + SBUF_FREE(buf);\n> + break;\n> + }\n> + default:\n> + WINDBG_ERROR(\"Catched unsupported control packet 0x%x\",\n\n\"caught\" instead of \"catched\", same in patches 20 and 21.\n\n> + ctx->packet.PacketType);\n> +\n> + windbg_state->ctrl_packet_id = 0;\n> + windbg_send_control_packet(PACKET_TYPE_KD_RESEND);\n> + break;\n> + }\n> +}\n>\n> static void windbg_ctx_handler(ParsingContext *ctx)\n> {\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y5ynD1gDSz9t2Z\n\tfor ;\n\tTue, 3 Oct 2017 23:21:17 +1100 (AEDT)","from localhost ([::1]:58337 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dzMCH-0005kh-U1\n\tfor incoming@patchwork.ozlabs.org; Tue, 03 Oct 2017 08:21:13 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:43989)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dzMBt-0005jE-Uz\n\tfor qemu-devel@nongnu.org; Tue, 03 Oct 2017 08:20:55 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dzMBp-0000cj-V2\n\tfor qemu-devel@nongnu.org; Tue, 03 Oct 2017 08:20:49 -0400","from mail-ua0-f179.google.com ([209.85.217.179]:52391)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1dzMBp-0000c0-QF\n\tfor qemu-devel@nongnu.org; Tue, 03 Oct 2017 08:20:45 -0400","by mail-ua0-f179.google.com with SMTP id i35so2408774uah.9\n\tfor ; Tue, 03 Oct 2017 05:20:45 -0700 (PDT)","by 10.103.60.26 with HTTP; Tue, 3 Oct 2017 05:20:44 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=JCWVUZ8iYZ8mAyCiHHN85pIHj1INeVUKB5oNZWcBVl8=;\n\tb=gkrmLPUlopj1oT80WthuIkomoQXlz+jK6Tw0btVQ85jGPUqLS4SX9P4QJc87J3cG+0\n\tFwal2N5GMK1ol+IwVodp+RETW0tgmwgzA+eeHLq3pc7kLdN+oFsWHtzhJGAty/ltFCMk\n\tHW1xi1ru++Q6XeRGgSul3Lfyb/14MFEvtxoYV7VuyC2HoaYgK8C/XkezVIvcXB4t6Ewp\n\tzHnlWCmTIt31Qm52hys1F8J3Ow05r3Rd5knfl7SaUxhiqdJIo6H227uFQp12TISazlpw\n\tkSTQZK3UJvS5He2XV3NVE91dRiA6TVWGX7q5RsSWygVF5m1VN3ca3VhC2p3z7fhz+/P7\n\tTT/Q==","X-Gm-Message-State":"AHPjjUgWxlXuw6vYR2EYHAbIdj1i+TYF17l+NYMnMnQQIvlbUoAdjhhO\n\tEbmlHcuUQnyT1JgqZ6FDNzhIHGkiVWNt/SQs9TUAGw==","X-Google-Smtp-Source":"AOwi7QB0BkOyjYy3Vvx9W7yBR+XfVSDxf63EfLmGr/0TBsZawyCFxf2Y6HpUqF9UhP9N96Ae1+Tx/bgSwryeNHZf9sQ=","X-Received":"by 10.159.54.241 with SMTP id\n\tp104mr10625418uap.143.1507033245155; \n\tTue, 03 Oct 2017 05:20:45 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<150642395256.3900.7797961982959292389.stgit@Misha-PC.lan02.inno>","References":"<150642384156.3900.3326424823772221077.stgit@Misha-PC.lan02.inno>\n\t<150642395256.3900.7797961982959292389.stgit@Misha-PC.lan02.inno>","From":"Ladi Prosek ","Date":"Tue, 3 Oct 2017 14:20:44 +0200","Message-ID":"","To":"Mihail Abakumov ","Content-Type":"text/plain; charset=\"UTF-8\"","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.85.217.179","Subject":"Re: [Qemu-devel] [PATCH 19/43] windbg: implemented\n\twindbg_process_control_packet","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"sw@weilnetz.de, qemu-devel ,\n\tPavel Dovgalyuk ,\n\tRoman Kagan , \n\tPaolo Bonzini , \"Denis V. Lunev\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]