[{"id":1778892,"web_url":"http://patchwork.ozlabs.org/comment/1778892/","msgid":"","list_archive_url":null,"date":"2017-10-03T12:24:07","subject":"Re: [Qemu-devel] [PATCH 22/43] windbg: implemented\n\tkd_api_read_virtual_memory and kd_api_read_virtual_memory","submitter":{"id":68164,"url":"http://patchwork.ozlabs.org/api/people/68164/","name":"Ladi Prosek","email":"lprosek@redhat.com"},"content":"nit: The subject line has \"kd_api_read_virtual_memory\" twice in it.\nWas probably meant to be\n\n[PATCH 22/43] windbg: implemented kd_api_read_virtual_memory and\nkd_api_write_virtual_memory\n\n\nOn Tue, Sep 26, 2017 at 1:06 PM, Mihail Abakumov\n wrote:\n> Signed-off-by: Mihail Abakumov \n> Signed-off-by: Pavel Dovgalyuk \n> Signed-off-by: Dmitriy Koltunov \n> ---\n> include/exec/windbgstub-utils.h | 2 ++\n> windbgstub-utils.c | 47 +++++++++++++++++++++++++++++++++++++++\n> windbgstub.c | 8 +++++++\n> 3 files changed, 57 insertions(+)\n>\n> diff --git a/include/exec/windbgstub-utils.h b/include/exec/windbgstub-utils.h\n> index ca21af7c91..c1ff1cec57 100755\n> --- a/include/exec/windbgstub-utils.h\n> +++ b/include/exec/windbgstub-utils.h\n> @@ -102,6 +102,8 @@ typedef struct SizedBuf {\n> buf.size = 0; \\\n> } while (false)\n>\n> +void kd_api_read_virtual_memory(CPUState *cpu, PacketData *pd);\n> +void kd_api_write_virtual_memory(CPUState *cpu, PacketData *pd);\n> void kd_api_unsupported(CPUState *cpu, PacketData *pd);\n>\n> SizedBuf kd_gen_exception_sc(CPUState *cpu);\n> diff --git a/windbgstub-utils.c b/windbgstub-utils.c\n> index e7b381f829..1bde60a1e9 100755\n> --- a/windbgstub-utils.c\n> +++ b/windbgstub-utils.c\n> @@ -30,6 +30,53 @@ typedef struct KDData {\n>\n> static KDData *kd;\n>\n> +void kd_api_read_virtual_memory(CPUState *cpu, PacketData *pd)\n> +{\n> + DBGKD_READ_MEMORY64 *mem = &pd->m64.u.ReadMemory;\n> + uint32_t len;\n> + target_ulong addr;\n> + int err;\n> +\n> + len = MIN(ldl_p(&mem->TransferCount), PACKET_MAX_SIZE - M64_SIZE);\n> + addr = ldtul_p(&mem->TargetBaseAddress);\n> + err = cpu_memory_rw_debug(cpu, addr, pd->extra, len, 0);\n> +\n> + if (!err) {\n> + pd->extra_size = len;\n> + mem->ActualBytesRead = ldl_p(&len);\n> + } else {\n> + pd->extra_size = 0;\n> + mem->ActualBytesRead = 0;\n> + pd->m64.ReturnStatus = STATUS_UNSUCCESSFUL;\n> +\n> + WINDBG_DEBUG(\"read_virtual_memory: No physical page mapped: \" FMT_ADDR,\n> + (target_ulong) mem->TargetBaseAddress);\n> + }\n> +}\n> +\n> +void kd_api_write_virtual_memory(CPUState *cpu, PacketData *pd)\n> +{\n> + DBGKD_WRITE_MEMORY64 *mem = &pd->m64.u.WriteMemory;\n> + uint32_t len;\n> + target_ulong addr;\n> + int err;\n> +\n> + len = MIN(ldl_p(&mem->TransferCount), pd->extra_size);\n> + addr = ldtul_p(&mem->TargetBaseAddress);\n> + err = cpu_memory_rw_debug(cpu, addr, pd->extra, len, 1);\n> +\n> + pd->extra_size = 0;\n> + if (!err) {\n> + mem->ActualBytesWritten = ldl_p(&len);\n> + } else {\n> + mem->ActualBytesWritten = 0;\n> + pd->m64.ReturnStatus = STATUS_UNSUCCESSFUL;\n> +\n> + WINDBG_DEBUG(\"read_write_memory: No physical page mapped: \" FMT_ADDR,\n> + (target_ulong) mem->TargetBaseAddress);\n> + }\n> +}\n> +\n> void kd_api_unsupported(CPUState *cpu, PacketData *pd)\n> {\n> WINDBG_ERROR(\"Catched unimplemented api %s\",\n> diff --git a/windbgstub.c b/windbgstub.c\n> index 50b4ef0dea..327fe83f70 100755\n> --- a/windbgstub.c\n> +++ b/windbgstub.c\n> @@ -133,6 +133,14 @@ static void windbg_process_manipulate_packet(ParsingContext *ctx)\n>\n> switch (ctx->data.m64.ApiNumber) {\n>\n> + case DbgKdReadVirtualMemoryApi:\n> + kd_api_read_virtual_memory(cpu, &ctx->data);\n> + break;\n> +\n> + case DbgKdWriteVirtualMemoryApi:\n> + kd_api_write_virtual_memory(cpu, &ctx->data);\n> + break;\n> +\n> default:\n> kd_api_unsupported(cpu, &ctx->data);\n> break;\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y5ys660fWz9t2m\n\tfor ;\n\tTue, 3 Oct 2017 23:24:42 +1100 (AEDT)","from localhost ([::1]:58348 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dzMFc-0006fg-UQ\n\tfor incoming@patchwork.ozlabs.org; Tue, 03 Oct 2017 08:24:40 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:44855)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dzMFA-0006fW-6E\n\tfor qemu-devel@nongnu.org; Tue, 03 Oct 2017 08:24:16 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dzMF6-0005Km-UK\n\tfor qemu-devel@nongnu.org; Tue, 03 Oct 2017 08:24:12 -0400","from mail-vk0-f46.google.com ([209.85.213.46]:44380)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1dzMF6-0005KR-Pm\n\tfor qemu-devel@nongnu.org; Tue, 03 Oct 2017 08:24:08 -0400","by mail-vk0-f46.google.com with SMTP id d12so4450344vkf.1\n\tfor ; Tue, 03 Oct 2017 05:24:08 -0700 (PDT)","by 10.103.60.26 with HTTP; Tue, 3 Oct 2017 05:24:07 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=0vewg+u47zSToHb36LNriJXxZQTyIU5Ur+r5VQqZlFM=;\n\tb=ZE3gIZrK09F/hc0aoUqf3p8RYncTVXNRUFPhEnnp9/NQ37E/ww5vUgY9h6dZ5xBNyD\n\tQLejCgJeUrnN2t71Iy2NvKJrPUWxrMAm1VJJ5DW7UHxD71rklezxxDiC+u55NmVySTjw\n\td0U+7BZ66A5OT3xZKcxlc+ygvmQawqREVYVQZPDyO2+7CEoGszoYAfpODnOJArm6jXmG\n\tU9XZAB+tFa+Opc18ZycKHXb0rG2Zr5AkqbkkSQkXej9Dz5IGe+Q6k38FhdYWrZIZguPA\n\tzT9VZ7Yi+CTKr2K7ojYSAssceDtSY0v1dYdpaSwweDMJM1UFZ7ojcoKTKW6KHpKF5aec\n\t+NiA==","X-Gm-Message-State":"AMCzsaUoxdp/bOmXG29+FgglpZ0awCzHmVIZzJts7zklhg3kqHg4kIHK\n\tSpFkhGwPWikSKgxCktW6jPCGk85YEuEiPcVGz0OAYg==","X-Google-Smtp-Source":"AOwi7QB7WqJvenGhXQfMkOyGDM/vz+1etCXQImLuZtIBJvwz3cQMCcoBm3nN6SuY74hwVZgax59SVmr4xtxWRAohdlk=","X-Received":"by 10.31.139.68 with SMTP id n65mr1135435vkd.192.1507033448071; \n\tTue, 03 Oct 2017 05:24:08 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<150642396922.3900.13282234011521338171.stgit@Misha-PC.lan02.inno>","References":"<150642384156.3900.3326424823772221077.stgit@Misha-PC.lan02.inno>\n\t<150642396922.3900.13282234011521338171.stgit@Misha-PC.lan02.inno>","From":"Ladi Prosek ","Date":"Tue, 3 Oct 2017 14:24:07 +0200","Message-ID":"","To":"Mihail Abakumov ","Content-Type":"text/plain; charset=\"UTF-8\"","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.85.213.46","Subject":"Re: [Qemu-devel] [PATCH 22/43] windbg: implemented\n\tkd_api_read_virtual_memory and kd_api_read_virtual_memory","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"sw@weilnetz.de, qemu-devel ,\n\tPavel Dovgalyuk ,\n\tRoman Kagan , \n\tPaolo Bonzini , \"Denis V. Lunev\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]