[{"id":1778864,"web_url":"http://patchwork.ozlabs.org/comment/1778864/","msgid":"","list_archive_url":null,"date":"2017-10-03T11:57:31","subject":"Re: [Qemu-devel] [PATCH 08/43] windbg: hook to wrmsr operation","submitter":{"id":68164,"url":"http://patchwork.ozlabs.org/api/people/68164/","name":"Ladi Prosek","email":"lprosek@redhat.com"},"content":"On Tue, Sep 26, 2017 at 1:04 PM, Mihail Abakumov\n wrote:\n> Inserted hook to wrmsr operation. Windows Kernel put address on KPCR struct to fs/gs (x32/x64) register. Needs catch this moment and allow windbg server handle packets.\n>\n> Signed-off-by: Mihail Abakumov \n> Signed-off-by: Pavel Dovgalyuk \n> Signed-off-by: Dmitriy Koltunov \n> ---\n> include/exec/windbgstub-utils.h | 3 +++\n> include/exec/windbgstub.h | 1 +\n> target/i386/misc_helper.c | 3 +++\n> windbgstub-utils.c | 8 ++++++++\n> windbgstub.c | 8 ++++++++\n> 5 files changed, 23 insertions(+)\n>\n> diff --git a/include/exec/windbgstub-utils.h b/include/exec/windbgstub-utils.h\n> index 65f336e4bf..90fb766839 100755\n> --- a/include/exec/windbgstub-utils.h\n> +++ b/include/exec/windbgstub-utils.h\n> @@ -62,4 +62,7 @@\n> _t; \\\n> })\n>\n> +bool windbg_on_load(void);\n> +void windbg_on_exit(void);\n> +\n> #endif\n> diff --git a/include/exec/windbgstub.h b/include/exec/windbgstub.h\n> index 703fc26b8f..2dbf1b1f13 100755\n> --- a/include/exec/windbgstub.h\n> +++ b/include/exec/windbgstub.h\n> @@ -15,6 +15,7 @@\n> #define WINDBG \"windbg\"\n> #define WINDBG_DEBUG_ON false\n>\n> +void windbg_try_load(void);\n> int windbg_server_start(const char *device);\n>\n> #endif\n> diff --git a/target/i386/misc_helper.c b/target/i386/misc_helper.c\n> index 628f64aad5..ec1fcd2899 100644\n> --- a/target/i386/misc_helper.c\n> +++ b/target/i386/misc_helper.c\n> @@ -24,6 +24,7 @@\n> #include \"exec/exec-all.h\"\n> #include \"exec/cpu_ldst.h\"\n> #include \"exec/address-spaces.h\"\n> +#include \"exec/windbgstub.h\"\n>\n> void helper_outb(CPUX86State *env, uint32_t port, uint32_t data)\n> {\n> @@ -385,6 +386,8 @@ void helper_wrmsr(CPUX86State *env)\n> /* XXX: exception? */\n> break;\n> }\n> +\n> + windbg_try_load();\n\nMost people use QEMU with KVM and won't ever hit this code. Does your\nwork rely on TCG only for FS/GS write interception?\n\nIf KVM is out of scope for you, you should at least make sure that\nusers won't expect -windbg to work with it. So either fall back to TCG\nif -windbg is passed or issue a warning.\n\n> }\n>\n> void helper_rdmsr(CPUX86State *env)\n> diff --git a/windbgstub-utils.c b/windbgstub-utils.c\n> index dc5e505c63..b5fb6db3f2 100755\n> --- a/windbgstub-utils.c\n> +++ b/windbgstub-utils.c\n> @@ -10,3 +10,11 @@\n> */\n>\n> #include \"exec/windbgstub-utils.h\"\n> +\n> +bool windbg_on_load(void)\n> +{\n> + return false;\n> +}\n> +\n> +void windbg_on_exit(void)\n> +{}\n> diff --git a/windbgstub.c b/windbgstub.c\n> index 378d1b911f..99c3ef9b14 100755\n> --- a/windbgstub.c\n> +++ b/windbgstub.c\n> @@ -39,8 +39,16 @@ static void windbg_chr_receive(void *opaque, const uint8_t *buf, int size)\n> }\n> }\n>\n> +void windbg_try_load(void)\n> +{\n> + if (windbg_state && !windbg_state->is_loaded) {\n> + windbg_state->is_loaded = windbg_on_load();\n> + }\n> +}\n> +\n> static void windbg_exit(void)\n> {\n> + windbg_on_exit();\n> g_free(windbg_state);\n> }\n>\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y5yGn1ZTNz9t2Z\n\tfor ;\n\tTue, 3 Oct 2017 22:58:22 +1100 (AEDT)","from localhost ([::1]:57992 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dzLq7-0006JJ-CV\n\tfor incoming@patchwork.ozlabs.org; Tue, 03 Oct 2017 07:58:19 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:37325)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dzLpo-0006JD-1k\n\tfor qemu-devel@nongnu.org; Tue, 03 Oct 2017 07:58:01 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dzLpj-0008JU-70\n\tfor qemu-devel@nongnu.org; Tue, 03 Oct 2017 07:58:00 -0400","from mail-ua0-f172.google.com ([209.85.217.172]:54687)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1dzLpj-0008Iy-2c\n\tfor qemu-devel@nongnu.org; Tue, 03 Oct 2017 07:57:55 -0400","by mail-ua0-f172.google.com with SMTP id l94so5023374ual.11\n\tfor ; Tue, 03 Oct 2017 04:57:54 -0700 (PDT)","by 10.103.60.26 with HTTP; Tue, 3 Oct 2017 04:57:31 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=2L0kl0E5neehD6HLfpkKwjftVX/Huq91l8bcYeddLjM=;\n\tb=UBhVbBw6x1uULg2GOhT3Tco2eUxUup0s9sXJkVyxx3orxr6rhah8E/4KViuU9QTQUy\n\tg0AAx9/fk6mVgez/zKub5CZrDabSxVYclZusYAs9hjzggV3kmn8dmEwqOSz6cU87LNxq\n\tBGy1WV0la0aNsh1VFOq5Hb9U4GI6+EC4q3DFxkEsIZein1dqlSgVcY+F3Obun3SjyFi9\n\t2UedpCnO5Wu0CnibG1/YIWVI2Wc6VkYVYvvDKsrq1riFb7o7pmm//T/vCNIfNTnImeCs\n\t2XNiArvpCvw1isJVhwc2wSxH8BV9zKwMlSY6h+YjLDXQwQmkn3sFi/JG6QdbHsQ9qALw\n\tCTng==","X-Gm-Message-State":"AMCzsaVkw1ncyqMOkPA3FJiGhwjQVyQ2s/5sjlCNAxDDWL68Zb7k71ou\n\ts1wj16egHdJVn2lDkqOL8BVIv2txP35yMM7KCoAfVg==","X-Google-Smtp-Source":"AOwi7QDYKj5B4Vf41E3ATtwdZkHu6js+3ea3auG8RsXie4Mk5kwWDupou5EYOv8YMILcpXEBzWG1+KayiH21eYykqAQ=","X-Received":"by 10.159.43.206 with SMTP id f14mr8388873uaj.98.1507031874249; \n\tTue, 03 Oct 2017 04:57:54 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<150642389121.3900.12320775067244184010.stgit@Misha-PC.lan02.inno>","References":"<150642384156.3900.3326424823772221077.stgit@Misha-PC.lan02.inno>\n\t<150642389121.3900.12320775067244184010.stgit@Misha-PC.lan02.inno>","From":"Ladi Prosek ","Date":"Tue, 3 Oct 2017 13:57:31 +0200","Message-ID":"","To":"Mihail Abakumov ","Content-Type":"text/plain; charset=\"UTF-8\"","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.85.217.172","Subject":"Re: [Qemu-devel] [PATCH 08/43] windbg: hook to wrmsr operation","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"sw@weilnetz.de, qemu-devel ,\n\tPavel Dovgalyuk ,\n\tRoman Kagan , \n\tPaolo Bonzini , \"Denis V. Lunev\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1793143,"web_url":"http://patchwork.ozlabs.org/comment/1793143/","msgid":"<6acc44e581334f8457cefffae88a0262@ispras.ru>","list_archive_url":null,"date":"2017-10-24T11:50:11","subject":"Re: [Qemu-devel] [PATCH 08/43] windbg: hook to wrmsr operation","submitter":{"id":71645,"url":"http://patchwork.ozlabs.org/api/people/71645/","name":"Mikhail Abakumov","email":"mikhail.abakumov@ispras.ru"},"content":"Ladi Prosek писал 2017-10-03 14:57:\n> On Tue, Sep 26, 2017 at 1:04 PM, Mihail Abakumov\n> wrote:\n> \n> Most people use QEMU with KVM and won't ever hit this code. Does your\n> work rely on TCG only for FS/GS write interception?\n> \n> If KVM is out of scope for you, you should at least make sure that\n> users won't expect -windbg to work with it. So either fall back to TCG\n> if -windbg is passed or issue a warning.\n> \n\nKVM is unsupported, at the moment. Therefore, I added additional \nchecking on it in windbg_server_start.\n\nThanks,\nMihail Abakumov","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yLs6D580hz9rxm\n\tfor ;\n\tTue, 24 Oct 2017 22:50:44 +1100 (AEDT)","from localhost ([::1]:43292 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e6xjG-0005TK-SL\n\tfor incoming@patchwork.ozlabs.org; Tue, 24 Oct 2017 07:50:42 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:36047)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e6xir-0005TF-Im\n\tfor qemu-devel@nongnu.org; Tue, 24 Oct 2017 07:50:18 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e6xim-0003fW-Q3\n\tfor qemu-devel@nongnu.org; Tue, 24 Oct 2017 07:50:17 -0400","from mail.ispras.ru ([83.149.199.45]:48776)\n\tby eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e6xim-0003fK-I5\n\tfor qemu-devel@nongnu.org; Tue, 24 Oct 2017 07:50:12 -0400","from mail.ispras.ru (localhost [127.0.0.1])\n\tby mail.ispras.ru (Postfix) with ESMTPSA id BCACC54006C;\n\tTue, 24 Oct 2017 14:50:11 +0300 (MSK)"],"MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8;\n format=flowed","Date":"Tue, 24 Oct 2017 14:50:11 +0300","From":"Mihail Abakumov ","To":"Ladi Prosek ","In-Reply-To":"","References":"<150642384156.3900.3326424823772221077.stgit@Misha-PC.lan02.inno>\n\t<150642389121.3900.12320775067244184010.stgit@Misha-PC.lan02.inno>\n\t","Message-ID":"<6acc44e581334f8457cefffae88a0262@ispras.ru>","X-Sender":"mikhail.abakumov@ispras.ru","User-Agent":"Roundcube Webmail/1.1.2","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [fuzzy]","X-Received-From":"83.149.199.45","Subject":"Re: [Qemu-devel] [PATCH 08/43] windbg: hook to wrmsr operation","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"sw@weilnetz.de, qemu-devel ,\n\tPavel Dovgalyuk ,\n\tRoman Kagan , \n\tPaolo Bonzini , \"Denis V. Lunev\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]