[{"id":1775724,"web_url":"http://patchwork.ozlabs.org/comment/1775724/","msgid":"","list_archive_url":null,"date":"2017-09-26T17:26:19","subject":"Re: [Qemu-devel] [PATCH 07/43] windbg: added chardev","submitter":{"id":64571,"url":"http://patchwork.ozlabs.org/api/people/64571/","name":"Alistair Francis","email":"alistair23@gmail.com"},"content":"On Tue, Sep 26, 2017 at 4:04 AM, Mihail Abakumov\n wrote:\n> Added chardev for listening to windbg. Target device is a parameter in the '-windbg' option.\n>\n> Signed-off-by: Mihail Abakumov \n> Signed-off-by: Pavel Dovgalyuk \n> Signed-off-by: Dmitriy Koltunov \n\nAcked-by: Alistair Francis \n\nThanks,\nAlistair\n\n> ---\n> windbgstub.c | 26 ++++++++++++++++++++++++++\n> 1 file changed, 26 insertions(+)\n>\n> diff --git a/windbgstub.c b/windbgstub.c\n> index 60a380c213..378d1b911f 100755\n> --- a/windbgstub.c\n> +++ b/windbgstub.c\n> @@ -10,6 +10,7 @@\n> */\n>\n> #include \"qemu/osdep.h\"\n> +#include \"qapi/error.h\"\n> #include \"chardev/char.h\"\n> #include \"chardev/char-fe.h\"\n> #include \"exec/windbgstub.h\"\n> @@ -18,12 +19,26 @@\n> typedef struct WindbgState {\n> bool is_loaded;\n>\n> + CharBackend chr;\n> +\n> uint32_t ctrl_packet_id;\n> uint32_t data_packet_id;\n> } WindbgState;\n>\n> static WindbgState *windbg_state;\n>\n> +static int windbg_chr_can_receive(void *opaque)\n> +{\n> + return PACKET_MAX_SIZE;\n> +}\n> +\n> +static void windbg_chr_receive(void *opaque, const uint8_t *buf, int size)\n> +{\n> + if (windbg_state->is_loaded) {\n> + /* T0D0: parse data */\n> + }\n> +}\n> +\n> static void windbg_exit(void)\n> {\n> g_free(windbg_state);\n> @@ -31,6 +46,8 @@ static void windbg_exit(void)\n>\n> int windbg_server_start(const char *device)\n> {\n> + Chardev *chr = NULL;\n> +\n> if (windbg_state) {\n> WINDBG_ERROR(\"Multiple instances are not supported\");\n> exit(1);\n> @@ -40,6 +57,15 @@ int windbg_server_start(const char *device)\n> windbg_state->ctrl_packet_id = RESET_PACKET_ID;\n> windbg_state->data_packet_id = INITIAL_PACKET_ID;\n>\n> + chr = qemu_chr_new_noreplay(WINDBG, device);\n> + if (!chr) {\n> + return -1;\n> + }\n> +\n> + qemu_chr_fe_init(&windbg_state->chr, chr, &error_abort);\n> + qemu_chr_fe_set_handlers(&windbg_state->chr, windbg_chr_can_receive,\n> + windbg_chr_receive, NULL, NULL, NULL, NULL, true);\n> +\n> atexit(windbg_exit);\n> return 0;\n> }\n>\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"sSU9KJun\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1nvl4H1Xz9sCZ\n\tfor ;\n\tWed, 27 Sep 2017 03:27:23 +1000 (AEST)","from localhost ([::1]:50436 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwtdf-0006Kv-BQ\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 13:27:19 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:56036)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwtdD-0006Kq-Ek\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 13:26:52 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwtdC-0003z0-FX\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 13:26:51 -0400","from mail-it0-x242.google.com ([2607:f8b0:4001:c0b::242]:37547)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dwtdC-0003yX-B6\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 13:26:50 -0400","by mail-it0-x242.google.com with SMTP id v140so1369943ita.4\n\tfor ; Tue, 26 Sep 2017 10:26:50 -0700 (PDT)","by 10.79.14.209 with HTTP; Tue, 26 Sep 2017 10:26:19 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=ZyQ1ocghdtNuL0NE7kiDS42Uc+KjETcAWQNppEpIzMM=;\n\tb=sSU9KJunNbnN7ZtKyhVB5e2mcNvKds/betVv0A8TUtFd6gg7mkNIydcysqEEvQq4ca\n\tXsx5qvlq31HEeKhAudvXLmYEne2qk399WuLrGcRmuLloM4RjQiUfyfTi2H5NxySauH37\n\tXnsum3eBY22L0QMpWUYJj22U62bEn6aRDXTlt+ySrXg8fCLZigope20xr52CBwBh1Rql\n\tT6rYUdfSTxFDmWPUqlidc0V7h3briH9gfpQ5hE3Qx8rYuEuto3DL3wDRMPH6aLRMmanP\n\tJWKGjNHbUBGeRYwezyKaxs2uxX9NxDIdkQt/zynDm2C+JwVGwAulceyu0s6QMmNL1VGK\n\tltMg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=ZyQ1ocghdtNuL0NE7kiDS42Uc+KjETcAWQNppEpIzMM=;\n\tb=mWbfVjShoKcvbdBmIyCXFU4kNizQ9SrxnHEQW5jsHADdKP5r9yESxWchceUGIoK0RN\n\tooSkLQqqLlF3w14bCPTRhZQ7rBl/TBIyI0hS6dWHpo1fVwBR7yYyAwRDCHeNAl5Ff4vR\n\t7YCtBuY0eOxDEZTN4zo9i7OtCjiLA03+jJKDXWQsLynf2/z/WloboSpVcKQqc7zvn5GY\n\tj4cZuYw9jnnKRJMdPUSA1OgPvmetDlfbGBY3L/XXF62F4e85oZCmVXgKFnXqc30+fsLA\n\tbxY02KjeChSV6SEW2mEMzrHrJiUq1nh0x2KXEmKcWOuUYkKc4O//lvxcyqlVm0HZrn8y\n\tLP1A==","X-Gm-Message-State":"AHPjjUhLmVhX8fbRSYwGOXfetaV/uBeH4D9qfiy724SQx7GOFW1n2dfh\n\tOGzrAkuTIbeVQskkjErOO925qMpjt5mi6cpFdak=","X-Google-Smtp-Source":"AOwi7QBkbz1iewNjH5ZLWgHyKMK7HQuSKObsXvmwj2GVz1xGkVxfOBjQUMEYUib1iR8G+LlDBv2nLvdM3ZL2zLSPdbg=","X-Received":"by 10.36.29.137 with SMTP id 131mr7219896itj.91.1506446809613;\n\tTue, 26 Sep 2017 10:26:49 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<150642388560.3900.1889412060549174598.stgit@Misha-PC.lan02.inno>","References":"<150642384156.3900.3326424823772221077.stgit@Misha-PC.lan02.inno>\n\t<150642388560.3900.1889412060549174598.stgit@Misha-PC.lan02.inno>","From":"Alistair Francis ","Date":"Tue, 26 Sep 2017 10:26:19 -0700","Message-ID":"","To":"Mihail Abakumov ","Content-Type":"text/plain; charset=\"UTF-8\"","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:4001:c0b::242","Subject":"Re: [Qemu-devel] [PATCH 07/43] windbg: added chardev","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Stefan Weil , lprosek@redhat.com,\n\t\"qemu-devel@nongnu.org Developers\" ,\n\tdovgaluk@ispras.ru, rkagan@virtuozzo.com, den@openvz.org,\n\tPaolo Bonzini ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1778858,"web_url":"http://patchwork.ozlabs.org/comment/1778858/","msgid":"","list_archive_url":null,"date":"2017-10-03T11:49:24","subject":"Re: [Qemu-devel] [PATCH 07/43] windbg: added chardev","submitter":{"id":68164,"url":"http://patchwork.ozlabs.org/api/people/68164/","name":"Ladi Prosek","email":"lprosek@redhat.com"},"content":"On Tue, Sep 26, 2017 at 1:04 PM, Mihail Abakumov\n wrote:\n> Added chardev for listening to windbg. Target device is a parameter in the '-windbg' option.\n>\n> Signed-off-by: Mihail Abakumov \n> Signed-off-by: Pavel Dovgalyuk \n> Signed-off-by: Dmitriy Koltunov \n> ---\n> windbgstub.c | 26 ++++++++++++++++++++++++++\n> 1 file changed, 26 insertions(+)\n>\n> diff --git a/windbgstub.c b/windbgstub.c\n> index 60a380c213..378d1b911f 100755\n> --- a/windbgstub.c\n> +++ b/windbgstub.c\n> @@ -10,6 +10,7 @@\n> */\n>\n> #include \"qemu/osdep.h\"\n> +#include \"qapi/error.h\"\n> #include \"chardev/char.h\"\n> #include \"chardev/char-fe.h\"\n> #include \"exec/windbgstub.h\"\n> @@ -18,12 +19,26 @@\n> typedef struct WindbgState {\n> bool is_loaded;\n>\n> + CharBackend chr;\n> +\n> uint32_t ctrl_packet_id;\n> uint32_t data_packet_id;\n> } WindbgState;\n>\n> static WindbgState *windbg_state;\n>\n> +static int windbg_chr_can_receive(void *opaque)\n> +{\n> + return PACKET_MAX_SIZE;\n> +}\n> +\n> +static void windbg_chr_receive(void *opaque, const uint8_t *buf, int size)\n> +{\n> + if (windbg_state->is_loaded) {\n> + /* T0D0: parse data */\n> + }\n> +}\n> +\n> static void windbg_exit(void)\n> {\n> g_free(windbg_state);\n> @@ -31,6 +46,8 @@ static void windbg_exit(void)\n>\n> int windbg_server_start(const char *device)\n> {\n> + Chardev *chr = NULL;\n> +\n> if (windbg_state) {\n> WINDBG_ERROR(\"Multiple instances are not supported\");\n> exit(1);\n> @@ -40,6 +57,15 @@ int windbg_server_start(const char *device)\n> windbg_state->ctrl_packet_id = RESET_PACKET_ID;\n> windbg_state->data_packet_id = INITIAL_PACKET_ID;\n>\n> + chr = qemu_chr_new_noreplay(WINDBG, device);\n> + if (!chr) {\n\nThis should generate error output. Passing \"-windbg bogus\" makes QEMU\nexit silently.\n-gdb seems to have the same problem.\n\n> + return -1;\n> + }\n> +\n> + qemu_chr_fe_init(&windbg_state->chr, chr, &error_abort);\n> + qemu_chr_fe_set_handlers(&windbg_state->chr, windbg_chr_can_receive,\n> + windbg_chr_receive, NULL, NULL, NULL, NULL, true);\n> +\n> atexit(windbg_exit);\n> return 0;\n> }\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y5y4w1ndXz9t2Z\n\tfor ;\n\tTue, 3 Oct 2017 22:49:52 +1100 (AEDT)","from localhost ([::1]:57972 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dzLhu-0004Rx-Cs\n\tfor incoming@patchwork.ozlabs.org; Tue, 03 Oct 2017 07:49:50 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:35429)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dzLhY-0004RW-Ju\n\tfor qemu-devel@nongnu.org; Tue, 03 Oct 2017 07:49:29 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dzLhV-0000oL-Du\n\tfor qemu-devel@nongnu.org; Tue, 03 Oct 2017 07:49:28 -0400","from mail-ua0-f175.google.com ([209.85.217.175]:55045)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1dzLhV-0000nn-9R\n\tfor qemu-devel@nongnu.org; Tue, 03 Oct 2017 07:49:25 -0400","by mail-ua0-f175.google.com with SMTP id l94so5010944ual.11\n\tfor ; Tue, 03 Oct 2017 04:49:25 -0700 (PDT)","by 10.103.60.26 with HTTP; Tue, 3 Oct 2017 04:49:24 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=MLiCPYRczfm+Wm71ShK6YwoQ5lwdVDyordsHR6qL9aI=;\n\tb=EITDP1R2HKzcIbv7DpAgIUcHlmwMBsugokXRKNdk6qQjf6qIX78O5TRN07z7q2O87f\n\tW6AkzLfRZBxVXXHZBJq+lUZYOhQh0odPbpHqObBpFSXwGn7DiUT50if+NZCr5a2R0T4z\n\tyaCeDgLFpybqndvRpzDSKWuvEY8/EBKKHSYGOcnh/+eU/77Y2L7bWchA19L/UzFx4bpP\n\tfRRvFCR/yr7Cepup9tE1tAZNKCEB7fQTH9/UN7iUkh2T2oj/moFZ7TGr0z3i+tPwcXnK\n\tjFjmYzfvXjZvqXgIPL6bCrqcdnGfWJUXuVzPZIrhbNzoEqRAUos0QN8NoEOy1OV3tpVA\n\tduDg==","X-Gm-Message-State":"AMCzsaX5r6kodMCR6VIS03XHmYinAUtGggHS+Obbwgl17HGxn3P55b96\n\t7EISQmhfsTEpvkXXhhIu9XN7sYaT15czuTP3aX8Dgw==","X-Google-Smtp-Source":"AOwi7QA+maSHC9CN/0G1YTVKQXivB4wgaYwpkm9nLUp8omly4XTNYMxqB8cIQBDo+4jmtdMbT2Z2wZOnR/e18+nSwbI=","X-Received":"by 10.176.3.2 with SMTP id 2mr9175349uat.14.1507031364475;\n\tTue, 03 Oct 2017 04:49:24 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<150642388560.3900.1889412060549174598.stgit@Misha-PC.lan02.inno>","References":"<150642384156.3900.3326424823772221077.stgit@Misha-PC.lan02.inno>\n\t<150642388560.3900.1889412060549174598.stgit@Misha-PC.lan02.inno>","From":"Ladi Prosek ","Date":"Tue, 3 Oct 2017 13:49:24 +0200","Message-ID":"","To":"Mihail Abakumov ","Content-Type":"text/plain; charset=\"UTF-8\"","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.85.217.175","Subject":"Re: [Qemu-devel] [PATCH 07/43] windbg: added chardev","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"sw@weilnetz.de, qemu-devel ,\n\tPavel Dovgalyuk ,\n\tRoman Kagan , \n\tPaolo Bonzini , \"Denis V. Lunev\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1793142,"web_url":"http://patchwork.ozlabs.org/comment/1793142/","msgid":"","list_archive_url":null,"date":"2017-10-24T11:45:38","subject":"Re: [Qemu-devel] [PATCH 07/43] windbg: added chardev","submitter":{"id":71645,"url":"http://patchwork.ozlabs.org/api/people/71645/","name":"Mikhail Abakumov","email":"mikhail.abakumov@ispras.ru"},"content":"Ladi Prosek писал 2017-10-03 14:49:\n>> \n>> + chr = qemu_chr_new_noreplay(WINDBG, device);\n>> + if (!chr) {\n> \n> This should generate error output. Passing \"-windbg bogus\" makes QEMU\n> exit silently.\n> -gdb seems to have the same problem.\n> \n\nI added additional checking on chardev. At the moment, supporting only \npipe.\n\nThanks,\nMihail Abakumov\n\n>> + return -1;\n>> + }\n>> +","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yLs0x5ZDJz9t2l\n\tfor ;\n\tTue, 24 Oct 2017 22:46:08 +1100 (AEDT)","from localhost ([::1]:43283 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e6xen-0004KG-5p\n\tfor incoming@patchwork.ozlabs.org; Tue, 24 Oct 2017 07:46:05 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:35249)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e6xeS-0004Jz-U7\n\tfor qemu-devel@nongnu.org; Tue, 24 Oct 2017 07:45:45 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e6xeN-0001b1-Go\n\tfor qemu-devel@nongnu.org; Tue, 24 Oct 2017 07:45:44 -0400","from mail.ispras.ru ([83.149.199.45]:48202)\n\tby eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e6xeN-0001ac-9V\n\tfor qemu-devel@nongnu.org; Tue, 24 Oct 2017 07:45:39 -0400","from mail.ispras.ru (localhost [127.0.0.1])\n\tby mail.ispras.ru (Postfix) with ESMTPSA id 5C5BC54006C;\n\tTue, 24 Oct 2017 14:45:38 +0300 (MSK)"],"MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8;\n format=flowed","Date":"Tue, 24 Oct 2017 14:45:38 +0300","From":"Mihail Abakumov ","To":"Ladi Prosek ","In-Reply-To":"","References":"<150642384156.3900.3326424823772221077.stgit@Misha-PC.lan02.inno>\n\t<150642388560.3900.1889412060549174598.stgit@Misha-PC.lan02.inno>\n\t","Message-ID":"","X-Sender":"mikhail.abakumov@ispras.ru","User-Agent":"Roundcube Webmail/1.1.2","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [fuzzy]","X-Received-From":"83.149.199.45","Subject":"Re: [Qemu-devel] [PATCH 07/43] windbg: added chardev","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"sw@weilnetz.de, qemu-devel ,\n\tPavel Dovgalyuk ,\n\tRoman Kagan , \n\tPaolo Bonzini , \"Denis V. Lunev\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]