[{"id":1778876,"web_url":"http://patchwork.ozlabs.org/comment/1778876/","msgid":"","list_archive_url":null,"date":"2017-10-03T12:13:26","subject":"Re: [Qemu-devel] [PATCH 09/43] windbg: handler of fs/gs register","submitter":{"id":68164,"url":"http://patchwork.ozlabs.org/api/people/68164/","name":"Ladi Prosek","email":"lprosek@redhat.com"},"content":"On Tue, Sep 26, 2017 at 1:04 PM, Mihail Abakumov\n wrote:\n> Added handler of fs/gs register. It tries to find and check KPCR and version address.\n>\n> Signed-off-by: Mihail Abakumov \n> Signed-off-by: Pavel Dovgalyuk \n> Signed-off-by: Dmitriy Koltunov \n> ---\n> include/exec/windbgstub-utils.h | 5 +++\n> windbgstub-utils.c | 63 ++++++++++++++++++++++++++++++++++++++-\n> 2 files changed, 66 insertions(+), 2 deletions(-)\n>\n> diff --git a/include/exec/windbgstub-utils.h b/include/exec/windbgstub-utils.h\n> index 90fb766839..f2402ebb34 100755\n> --- a/include/exec/windbgstub-utils.h\n> +++ b/include/exec/windbgstub-utils.h\n> @@ -62,6 +62,11 @@\n> _t; \\\n> })\n>\n> +typedef struct InitedAddr {\n> + target_ulong addr;\n> + bool is_init;\n> +} InitedAddr;\n> +\n> bool windbg_on_load(void);\n> void windbg_on_exit(void);\n>\n> diff --git a/windbgstub-utils.c b/windbgstub-utils.c\n> index b5fb6db3f2..662096647e 100755\n> --- a/windbgstub-utils.c\n> +++ b/windbgstub-utils.c\n> @@ -11,10 +11,69 @@\n>\n> #include \"exec/windbgstub-utils.h\"\n>\n> +#ifdef TARGET_X86_64\n> +# define OFFSET_SELF_PCR 0x18\n> +# define OFFSET_VERS 0x108\n> +#else\n> +# define OFFSET_SELF_PCR 0x1C\n> +# define OFFSET_VERS 0x34\n> +#endif\n> +\n> +typedef struct KDData {\n> + InitedAddr KPCR;\n> + InitedAddr version;\n> +} KDData;\n> +\n> +static KDData *kd;\n> +\n> bool windbg_on_load(void)\n> {\n> - return false;\n> + CPUState *cpu = qemu_get_cpu(0);\n> + CPUArchState *env = cpu->env_ptr;\n> +\n> + if (!kd) {\n> + kd = g_new0(KDData, 1);\n> + }\n> +\n> + if (!kd->KPCR.is_init) {\n> +\n> + #ifdef TARGET_X86_64\n> + kd->KPCR.addr = env->segs[R_GS].base;\n> + #else\n> + kd->KPCR.addr = env->segs[R_FS].base;\n> + #endif\n\nWhat if Windows is rebooted and FS/GS changes? Do you need to flip\nKPCR.is_init back to false on system reset?\n\n> + static target_ulong prev_KPCR;\n> + if (!kd->KPCR.addr || prev_KPCR == kd->KPCR.addr) {\n> + return false;\n> + }\n> + prev_KPCR = kd->KPCR.addr;\n> +\n> + if (kd->KPCR.addr != READ_VMEM(cpu, kd->KPCR.addr + OFFSET_SELF_PCR,\n> + target_ulong)) {\n> + return false;\n> + }\n> +\n> + kd->KPCR.is_init = true;\n> + }\n> +\n> + if (!kd->version.is_init && kd->KPCR.is_init) {\n> + kd->version.addr = READ_VMEM(cpu, kd->KPCR.addr + OFFSET_VERS,\n> + target_ulong);\n> + if (!kd->version.addr) {\n> + return false;\n> + }\n> + kd->version.is_init = true;\n> + }\n> +\n> + WINDBG_DEBUG(\"windbg_on_load: KPCR \" FMT_ADDR, kd->KPCR.addr);\n> + WINDBG_DEBUG(\"windbg_on_load: version \" FMT_ADDR, kd->version.addr);\n> +\n> + return true;\n> }\n>\n> void windbg_on_exit(void)\n> -{}\n> +{\n> + g_free(kd);\n> + kd = NULL;\n> +}\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y5yd16CDxz9sRW\n\tfor ;\n\tTue, 3 Oct 2017 23:14:12 +1100 (AEDT)","from localhost ([::1]:58292 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dzM5Q-0001Jh-BJ\n\tfor incoming@patchwork.ozlabs.org; Tue, 03 Oct 2017 08:14:08 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41601)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dzM4p-0001G2-UR\n\tfor qemu-devel@nongnu.org; Tue, 03 Oct 2017 08:13:33 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dzM4l-0002ib-SV\n\tfor qemu-devel@nongnu.org; Tue, 03 Oct 2017 08:13:31 -0400","from mail-vk0-f43.google.com ([209.85.213.43]:55638)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1dzM4l-0002hH-Mw\n\tfor qemu-devel@nongnu.org; Tue, 03 Oct 2017 08:13:27 -0400","by mail-vk0-f43.google.com with SMTP id i1so4419235vke.12\n\tfor ; Tue, 03 Oct 2017 05:13:27 -0700 (PDT)","by 10.103.60.26 with HTTP; Tue, 3 Oct 2017 05:13:26 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=kAGK65/+OkpxnJz8I1I2FXHPZV81VcdBbVTOT5fqd3Y=;\n\tb=NngUYnYh6ABPNdFXLeOQgTTH8KLRvYaA7qqLvFUKn+xrX84VsWr1Roc1RX4R/5JUkY\n\tZ5cT0Wwh5B5DdbVAgzyL37II6gEr+DdR8NdMvIWsG1uvDcoIr7MfaFLzqviv68LCARZg\n\t10MWUt8xJVh35pdd06isAAR8JpNiFuaq1XuK4m6fXuEn7/LnGEu8yimsb4/eZX3/PDWT\n\t4gj1yARZe0vU1x1lgsMlKsOONvcrtoSR2IJYTyEc3AhhYJOUPsA6YcUgBYmTCNGegLPg\n\tFxOBWkga7py1KFGGgukcmOYKuze8E57POadoNj5HeZPPOwu0bkM+xuKy2sBaDYdy0Jq6\n\t7FcQ==","X-Gm-Message-State":"AMCzsaWt7u+f6bZhR2yP91GgtNK3SVne3q1ml7E+EgRNXqfYIXUVR4FU\n\t44FzoJX/0gHEFERV1Pj5WuT4jJunpegPOPUkd0sZvw==","X-Google-Smtp-Source":"AOwi7QC9Fij6uiuA4LVevJBzi6vln4LHC5c+YfG3ULRCXHcselKVA2nhqN1IWzQFNBuahDV36j8PmEsEO+9YPGLLVP4=","X-Received":"by 10.31.95.70 with SMTP id t67mr1319202vkb.168.1507032807063;\n\tTue, 03 Oct 2017 05:13:27 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<150642389679.3900.2803313967054050497.stgit@Misha-PC.lan02.inno>","References":"<150642384156.3900.3326424823772221077.stgit@Misha-PC.lan02.inno>\n\t<150642389679.3900.2803313967054050497.stgit@Misha-PC.lan02.inno>","From":"Ladi Prosek ","Date":"Tue, 3 Oct 2017 14:13:26 +0200","Message-ID":"","To":"Mihail Abakumov ","Content-Type":"text/plain; charset=\"UTF-8\"","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.85.213.43","Subject":"Re: [Qemu-devel] [PATCH 09/43] windbg: handler of fs/gs register","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"sw@weilnetz.de, qemu-devel ,\n\tPavel Dovgalyuk ,\n\tRoman Kagan , \n\tPaolo Bonzini , \"Denis V. Lunev\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]