[{"id":1775705,"web_url":"http://patchwork.ozlabs.org/comment/1775705/","msgid":"","list_archive_url":null,"date":"2017-09-26T17:10:15","subject":"Re: [Qemu-devel] [PATCH 04/43] windbg: added '-windbg' option","submitter":{"id":64571,"url":"http://patchwork.ozlabs.org/api/people/64571/","name":"Alistair Francis","email":"alistair23@gmail.com"},"content":"On Tue, Sep 26, 2017 at 4:04 AM, Mihail Abakumov\n wrote:\n> This option starts windbg server.\n>\n> Signed-off-by: Mihail Abakumov \n> Signed-off-by: Pavel Dovgalyuk \n> Signed-off-by: Dmitriy Koltunov \n\nAcked-by: Alistair Francis \n\nThanks,\nAlistair\n\n> ---\n> qemu-options.hx | 8 ++++++++\n> vl.c | 8 ++++++++\n> 2 files changed, 16 insertions(+)\n>\n> diff --git a/qemu-options.hx b/qemu-options.hx\n> index 9f6e2adfff..1c84eb56d9 100644\n> --- a/qemu-options.hx\n> +++ b/qemu-options.hx\n> @@ -3544,6 +3544,14 @@ Shorthand for -gdb tcp::1234, i.e. open a gdbserver on TCP port 1234\n> (@pxref{gdb_usage}).\n> ETEXI\n>\n> +DEF(\"windbg\", HAS_ARG, QEMU_OPTION_windbg, \\\n> + \"-windbg wait for windbg connection\\n\", QEMU_ARCH_I386)\n> +STEXI\n> +@item -windbg\n> +@findex -windbg\n> +Wait for windbg connection.\n> +ETEXI\n> +\n> DEF(\"d\", HAS_ARG, QEMU_OPTION_d, \\\n> \"-d item1,... enable logging of specified items (use '-d help' for a list of log items)\\n\",\n> QEMU_ARCH_ALL)\n> diff --git a/vl.c b/vl.c\n> index 8e247cc2a2..d6378cf03f 100644\n> --- a/vl.c\n> +++ b/vl.c\n> @@ -80,6 +80,7 @@ int main(int argc, char **argv)\n> #include \"sysemu/sysemu.h\"\n> #include \"sysemu/numa.h\"\n> #include \"exec/gdbstub.h\"\n> +#include \"exec/windbgstub.h\"\n> #include \"qemu/timer.h\"\n> #include \"chardev/char.h\"\n> #include \"qemu/bitmap.h\"\n> @@ -2436,6 +2437,7 @@ struct device_config {\n> DEV_VIRTCON, /* -virtioconsole */\n> DEV_DEBUGCON, /* -debugcon */\n> DEV_GDB, /* -gdb, -s */\n> + DEV_WINDBG, /* -windbg */\n> DEV_SCLP, /* s390 sclp */\n> } type;\n> const char *cmdline;\n> @@ -3445,6 +3447,9 @@ int main(int argc, char **argv, char **envp)\n> case QEMU_OPTION_gdb:\n> add_device_config(DEV_GDB, optarg);\n> break;\n> + case QEMU_OPTION_windbg:\n> + add_device_config(DEV_WINDBG, optarg);\n> + break;\n> case QEMU_OPTION_L:\n> if (is_help_option(optarg)) {\n> list_data_dirs = true;\n> @@ -4586,6 +4591,9 @@ int main(int argc, char **argv, char **envp)\n> exit(1);\n> }\n>\n> + if (foreach_device_config(DEV_WINDBG, windbg_server_start) < 0) {\n> + exit(1);\n> + }\n> if (foreach_device_config(DEV_SERIAL, serial_parse) < 0)\n> exit(1);\n> if (foreach_device_config(DEV_PARALLEL, parallel_parse) < 0)\n>\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"dgTGpEvx\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1nXz5X39z9rxl\n\tfor ;\n\tWed, 27 Sep 2017 03:11:14 +1000 (AEST)","from localhost ([::1]:50386 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwtO3-0001da-SE\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 13:11:11 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:51271)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwtNi-0001dU-My\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 13:10:51 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwtNg-0002r8-7h\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 13:10:50 -0400","from mail-wr0-x242.google.com ([2a00:1450:400c:c0c::242]:35387)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dwtNg-0002qW-0w\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 13:10:48 -0400","by mail-wr0-x242.google.com with SMTP id n64so2866524wrb.2\n\tfor ; Tue, 26 Sep 2017 10:10:47 -0700 (PDT)","by 10.28.135.139 with HTTP; Tue, 26 Sep 2017 10:10:15 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=nKhvq2+R0OZjnA1mNlQPQgO7ycZk75C2sutq91Hb57c=;\n\tb=dgTGpEvxYvyKswIMZ22ntyq7Oz/6hrBtaU+ArGxrL0A0uoeHCOCFTjZxWB3R5jAa0b\n\tc1l1V13XLTSDinsYEYGzfTxnDyvj2n1v4LDI6Y4MOTPxtxKdUdVsKIQIapwlXOjdcrZ9\n\tw/cdECXsgE6wuWnYnlWHvsbWbV/XsPLRUXn2C68oelbToh2f0HCRtPxAqb0gLcM/HioR\n\tJfwt2Rg7inTN5hkf4CO6Jzz23twCnYfRtIFTDMirqFMw32NFXrHl8i6V7ugI4JO9KN1H\n\tbRkg1dQ9mWMrpq7strciZ4CfEievUQLSNyNG/oht9EDJOV9cfHShyyVgiRj7pPw7O/CT\n\turoQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=nKhvq2+R0OZjnA1mNlQPQgO7ycZk75C2sutq91Hb57c=;\n\tb=ogb+Neq82+jPB0XOw8MKpvxBUkCsI6lO25JmMyc3vQXdYokVtAuAqYnsUooiS0+ZRp\n\tt4aRybObBkImWSa/oDWwcfrb/QwVOzCLyOgTzCTAThXddT61hMPptGhh24a0Q9bO6DGx\n\t+USMlCTeZi5AXcYewLjKWQ6S++3XG5d/fxUNNSKOtREjssQJUafOMK0DLxgM9NdF67rT\n\tIvxL/bQskgDuXDQtAnrdNQ7OvESycY2isg4nxPxW5yV77H7kFjLn/dbSWbu69BM7TDW1\n\tjIStnws6Amb3MZIEk3dL7Bfl5Zpd9Dx0ciZi8iBV9riFnbqCKHjSlOjiGH7aR+UX3LsM\n\tm2KQ==","X-Gm-Message-State":"AHPjjUhaBxXO8lH/NtobVWRND0TGksiyQO7LK8xwqUaKjy9zX6UYs5xk\n\tAgwR1i1Vg5sol/WRIHj5o1kPLtft+OieuGOrD0w=","X-Google-Smtp-Source":"AOwi7QDv7NOc0lgInMxGs6HrX/rk3C73+CuVhLZXkaqMAwPOOEQRoJsyQ/Ln+UgSkscXfqiWshLCmS9GDH8lmjLn8Lo=","X-Received":"by 10.223.144.71 with SMTP id h65mr10052218wrh.41.1506445846795; \n\tTue, 26 Sep 2017 10:10:46 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<150642386887.3900.11789274449160294712.stgit@Misha-PC.lan02.inno>","References":"<150642384156.3900.3326424823772221077.stgit@Misha-PC.lan02.inno>\n\t<150642386887.3900.11789274449160294712.stgit@Misha-PC.lan02.inno>","From":"Alistair Francis ","Date":"Tue, 26 Sep 2017 10:10:15 -0700","Message-ID":"","To":"Mihail Abakumov ","Content-Type":"text/plain; charset=\"UTF-8\"","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c0c::242","Subject":"Re: [Qemu-devel] [PATCH 04/43] windbg: added '-windbg' option","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Stefan Weil , lprosek@redhat.com,\n\t\"qemu-devel@nongnu.org Developers\" ,\n\tdovgaluk@ispras.ru, rkagan@virtuozzo.com, den@openvz.org,\n\tPaolo Bonzini ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]