[{"id":1775712,"web_url":"http://patchwork.ozlabs.org/comment/1775712/","msgid":"","list_archive_url":null,"date":"2017-09-26T17:17:46","subject":"Re: [Qemu-devel] [PATCH 06/43] windbg: added WindbgState","submitter":{"id":64571,"url":"http://patchwork.ozlabs.org/api/people/64571/","name":"Alistair Francis","email":"alistair23@gmail.com"},"content":"On Tue, Sep 26, 2017 at 4:04 AM, Mihail Abakumov\n wrote:\n> Added definition of the WindbgState struct and its initialization.\n>\n> Signed-off-by: Mihail Abakumov \n> Signed-off-by: Pavel Dovgalyuk \n> Signed-off-by: Dmitriy Koltunov \n> ---\n> windbgstub.c | 26 ++++++++++++++++++++++++++\n> 1 file changed, 26 insertions(+)\n>\n> diff --git a/windbgstub.c b/windbgstub.c\n> index 3830446988..60a380c213 100755\n> --- a/windbgstub.c\n> +++ b/windbgstub.c\n> @@ -10,10 +10,36 @@\n> */\n>\n> #include \"qemu/osdep.h\"\n> +#include \"chardev/char.h\"\n> +#include \"chardev/char-fe.h\"\n> #include \"exec/windbgstub.h\"\n> #include \"exec/windbgstub-utils.h\"\n>\n> +typedef struct WindbgState {\n> + bool is_loaded;\n> +\n> + uint32_t ctrl_packet_id;\n> + uint32_t data_packet_id;\n> +} WindbgState;\n> +\n> +static WindbgState *windbg_state;\n> +\n> +static void windbg_exit(void)\n> +{\n> + g_free(windbg_state);\n> +}\n> +\n> int windbg_server_start(const char *device)\n> {\n> + if (windbg_state) {\n> + WINDBG_ERROR(\"Multiple instances are not supported\");\n\nUse error_report() to report errors.\n\nThanks,\nAlistair\n\n> + exit(1);\n> + }\n> +\n> + windbg_state = g_new0(WindbgState, 1);\n> + windbg_state->ctrl_packet_id = RESET_PACKET_ID;\n> + windbg_state->data_packet_id = INITIAL_PACKET_ID;\n> +\n> + atexit(windbg_exit);\n\nI don't think you need this.\n\nThanks,\nAlistair\n\n> return 0;\n> }\n>\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"TVqYR8wn\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1njq2tSXz9s7G\n\tfor ;\n\tWed, 27 Sep 2017 03:18:55 +1000 (AEST)","from localhost ([::1]:50411 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwtVV-0003hE-BO\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 13:18:53 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:53288)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwtUw-0003g9-M2\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 13:18:19 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwtUv-0006xp-Lq\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 13:18:18 -0400","from mail-it0-x243.google.com ([2607:f8b0:4001:c0b::243]:34251)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dwtUv-0006xS-HV\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 13:18:17 -0400","by mail-it0-x243.google.com with SMTP id o200so5066172itg.1\n\tfor ; Tue, 26 Sep 2017 10:18:17 -0700 (PDT)","by 10.79.14.209 with HTTP; Tue, 26 Sep 2017 10:17:46 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=91tVOSk1ncfos/HaFcKi0DW6y224dKcNIClpkMolmWE=;\n\tb=TVqYR8wnAUHUhdKOF22Yo8wHnRFza03QVq9wvlJ6EwiMmvdGFXB1BikK4KkQzn9HHX\n\tF43olHi8NsyFJzz10nPT/Szzb6n/51q+xHR2Pl8ahKmDHNCNwpVbJKOg6SA7z+aF7416\n\tHu1jR4nhgXShrAEtRaplozKDgBWyD9itXTn/zSOuiwEhT2OcgFI5M7M8E2SM7OXIu9RC\n\tawfxK59D8itnHWMSewiMtLhVlBvStf3YVyDJy/PbIsmqhzbBFrnHsURLU979digmAo9S\n\tprJwm3TShSr06xCxqsx1gnPnXlIuZk0Jmba4Mc0ajjQTId4iRPqRCRmIwnwGT3txPyDR\n\tFe9w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=91tVOSk1ncfos/HaFcKi0DW6y224dKcNIClpkMolmWE=;\n\tb=lgvfOKfjdLKkw5QpdsI2lk2tJ2doTEeR/4xqAAS2vODLFBqaWVCRKBU5I8unJMbTSr\n\thl05EAyW82tHYi/ZfmdTn+mIzlchOhhZB/jSoXW2Nfu6fe8W4KiaI3n9WryKYgHWj20g\n\tHBoDvil29T5w8K+MInfuGg5FGTHI+q+LBwUthcg7fDVId6ecqVxIaEygB14JCGvgGwfJ\n\tk0pofHE7tc2DNkvc8WFakYMlsm3rTJ9/5jrM2FbXEPzcfdcR0FQTnx+RnR+Oyp8BlTnl\n\tGLV3Q/4S9Tn0kHnAcygUWh+RDrx0hynW2akkcTDrjCSahZTvG0F7Zt2ynUZFEoS7ap+v\n\tYfSA==","X-Gm-Message-State":"AHPjjUiEFnmKsFglmkCeUEtwvvJKuMEF0fPK0wl6W1xkbKyRcSYPiuWu\n\tQeErk2cAblp+oI6s5CISbZd9RHWhPx+cy+K7T4k=","X-Google-Smtp-Source":"AOwi7QDZ8BlyfISFoTLFM5rlHoWRuLv/NRUWygX6sWZmDgt8eoJ6WvxGFtcqtZjRjno5m/5Z8Tnt0J595GnZAcX+c4o=","X-Received":"by 10.36.20.149 with SMTP id 143mr6566501itg.63.1506446296883;\n\tTue, 26 Sep 2017 10:18:16 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<150642388004.3900.5767850617613782105.stgit@Misha-PC.lan02.inno>","References":"<150642384156.3900.3326424823772221077.stgit@Misha-PC.lan02.inno>\n\t<150642388004.3900.5767850617613782105.stgit@Misha-PC.lan02.inno>","From":"Alistair Francis ","Date":"Tue, 26 Sep 2017 10:17:46 -0700","Message-ID":"","To":"Mihail Abakumov ","Content-Type":"text/plain; charset=\"UTF-8\"","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:4001:c0b::243","Subject":"Re: [Qemu-devel] [PATCH 06/43] windbg: added WindbgState","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Stefan Weil , lprosek@redhat.com,\n\t\"qemu-devel@nongnu.org Developers\" ,\n\tdovgaluk@ispras.ru, rkagan@virtuozzo.com, den@openvz.org,\n\tPaolo Bonzini ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]