[{"id":1778450,"web_url":"http://patchwork.ozlabs.org/comment/1778450/","msgid":"<2EF2F5C0CC56984AA024D0B180335FCB525690F5@IRSMSX102.ger.corp.intel.com>","list_archive_url":null,"date":"2017-10-02T16:28:38","subject":"Re: [ovs-dev] [PATCH v3 4/9] netdev-dpdk: implement flow put with\n\trte flow","submitter":{"id":67440,"url":"http://patchwork.ozlabs.org/api/people/67440/","name":"Chandran, Sugesh","email":"sugesh.chandran@intel.com"},"content":"Regards\n_Sugesh\n\n\n> -----Original Message-----\n> From: Yuanhan Liu [mailto:yliu@fridaylinux.org]\n> Sent: Tuesday, September 26, 2017 6:37 AM\n> To: dev@openvswitch.org\n> Cc: Finn Christensen ; Darrell Ball ;\n> Chandran, Sugesh ; Simon Horman\n> ; Yuanhan Liu \n> Subject: [PATCH v3 4/9] netdev-dpdk: implement flow put with rte flow\n> \n> From: Finn Christensen \n> \n> The basic yet the major part of this patch is to translate the \"match\"\n> to rte flow patterns. And then, we create a rte flow with a MARK action.\n> Afterwards, all pkts matches the flow will have the mark id in the mbuf.\n> \n> For any unsupported flows, such as MPLS, -1 is returned, meaning the flow\n> offload is failed and then skipped.\n> \n> Co-authored-by: Yuanhan Liu \n> Signed-off-by: Finn Christensen \n> Signed-off-by: Yuanhan Liu \n> ---\n> \n> v3: - fix duplicate (and wrong) TOS assignment\n> - zero the pattern spec as well\n> - remove macros\n> - add missing unsupported fields\n> \n> v2: - convert some macros to functions\n> - do not hardcode the max number of flow/action\n> - fix L2 patterns for Intel nic\n> - add comments for not implemented offload methods\n> ---\n> lib/netdev-dpdk.c | 441\n> +++++++++++++++++++++++++++++++++++++++++++++++++++++-\n> 1 file changed, 440 insertions(+), 1 deletion(-)\n> \n> diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 1be9131..525536a\n> 100644\n> --- a/lib/netdev-dpdk.c\n> +++ b/lib/netdev-dpdk.c\n> @@ -3404,6 +3404,445 @@ get_rte_flow_by_ufid(const ovs_u128 *ufid) }\n> \n\n[snip] \n> +\n> + /* unsupported L2 */\n> + if (!is_all_zero(&match->wc.masks.mpls_lse,\n> + sizeof(match_zero_wc.flow.mpls_lse))) {\n> + goto err;\n[Sugesh] As we discussed earlier, If we know the capability , we can avoid the whole translation itself.\nAlso it helps to avoid the flow install when the device is full and cannot take any more flow rules.\n\n> + }\n> +\n> + /* unsupported L3 */\n> + if (match->wc.masks.ipv6_label ||\n> --\n> 2.7.4","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y5SMr0YBvz9t6n\n\tfor ;\n\tTue, 3 Oct 2017 03:31:04 +1100 (AEDT)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 0DB64B7C;\n\tMon, 2 Oct 2017 16:28:43 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 9861EB5D\n\tfor ; Mon, 2 Oct 2017 16:28:41 +0000 (UTC)","from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id CB67F151\n\tfor ; Mon, 2 Oct 2017 16:28:40 +0000 (UTC)","from orsmga004.jf.intel.com ([10.7.209.38])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t02 Oct 2017 09:28:39 -0700","from irsmsx104.ger.corp.intel.com ([163.33.3.159])\n\tby orsmga004.jf.intel.com with ESMTP; 02 Oct 2017 09:28:39 -0700","from irsmsx102.ger.corp.intel.com ([169.254.2.180]) by\n\tIRSMSX104.ger.corp.intel.com ([163.33.3.159]) with mapi id\n\t14.03.0319.002; Mon, 2 Oct 2017 17:28:38 +0100"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,470,1500966000\"; d=\"scan'208\";a=\"134375349\"","From":"\"Chandran, Sugesh\" ","To":"Yuanhan Liu , \"dev@openvswitch.org\"\n\t","Thread-Topic":"[PATCH v3 4/9] netdev-dpdk: implement flow put with rte flow","Thread-Index":"AQHTNonn+Y+gvjAqJEGpURWy3HtRuKLQuRpA","Date":"Mon, 2 Oct 2017 16:28:38 +0000","Message-ID":"<2EF2F5C0CC56984AA024D0B180335FCB525690F5@IRSMSX102.ger.corp.intel.com>","References":"<1506404199-23579-1-git-send-email-yliu@fridaylinux.org>\n\t<1506404199-23579-5-git-send-email-yliu@fridaylinux.org>","In-Reply-To":"<1506404199-23579-5-git-send-email-yliu@fridaylinux.org>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","dlp-product":"dlpe-windows","dlp-version":"11.0.0.116","dlp-reaction":"no-action","x-originating-ip":"[163.33.239.182]","MIME-Version":"1.0","X-Spam-Status":"No, score=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI,\n\tRP_MATCHES_RCVD autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"Simon Horman ","Subject":"Re: [ovs-dev] [PATCH v3 4/9] netdev-dpdk: implement flow put with\n\trte flow","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}}]