[{"id":1775245,"web_url":"http://patchwork.ozlabs.org/comment/1775245/","msgid":"<20170926082300.GC14296@kuha.fi.intel.com>","list_archive_url":null,"date":"2017-09-26T08:23:00","subject":"Re: [PATCH 02/12] usb: typec: add basic typec properties","submitter":{"id":23674,"url":"http://patchwork.ozlabs.org/api/people/23674/","name":"Heikki Krogerus","email":"heikki.krogerus@linux.intel.com"},"content":"On Tue, Sep 26, 2017 at 08:45:17AM +0800, Li Jun wrote:\n> port-type is required for any typec port; default-role is only required\n> for drp; power source capable needs src-pdos; power sink capable needs\n> snk-pdos, max-snk-mv, max-snk-ma, op-snk-mw.\n> \n> Signed-off-by: Li Jun \n> ---\n> Documentation/devicetree/bindings/usb/typec.txt | 46 +++++++++++++++++++++++++\n> 1 file changed, 46 insertions(+)\n> \n> diff --git a/Documentation/devicetree/bindings/usb/typec.txt b/Documentation/devicetree/bindings/usb/typec.txt\n> new file mode 100644\n> index 0000000..36d4467\n> --- /dev/null\n> +++ b/Documentation/devicetree/bindings/usb/typec.txt\n> @@ -0,0 +1,46 @@\n> +Generic typec and power delivery properties\n> +-------------------------------------------\n> +\n> +Required properties:\n> +- port-type: should be one of \"source\", \"sink\" or \"dual\".\n> +- default-role: preferred power role if drp, should be \"sink\" or \"source\".\n> +- src-pdos: An array of u32 with each entry providing supported power\n> + source data object(PDO), the detailed bit definitions of\n> + PDO can be found in \"Universal Serial Bus Power Delivery\n> + Specification\" chapter 6.4.1.2 Source_Capabilities Message,\n> + the order of each entry(PDO) should follow the PD spec chapter\n> + 6.4.1. Required only for power source and power dual role with\n> + power delivery support.\n> +- snk-pdos: An array of u32 with each entry providing supported power\n> + sink data object(PDO), the detailed bit definitions of PDO\n> + can be found in \"Universal Serial Bus Power Delivery\n> + Specification\" chapter 6.4.1.3 Sink Capabilities Message,\n> + the order of each entry(PDO) should follow the PD spec chapter\n> + 6.4.1. Required only for power sink and power dual role with\n> + power delivery support.\n\nWouldn't it be better to supply a property per detail and let the\ndrivers construct the pdos as needed?\n\n> +- max-snk-mv: The max voltage the sink can support in millivoltage, required\n> + only for power sink and power dual role with power delivery\n> + support.\n> +- max-snk-ma: The max current the sink can support in milliampere, required\n> + only for power sink and power dual role with power delivery\n> + support.\n> +- op-snk-mw: Sink required operating power in milliwatts, if source offered\n> + power is less then it, Capability Mismatch is set, required\n> + only for power sink and power dual role with power delivery\n> + support.\n\nI'm a little bit concerned about these. Has any OF/DT guys reviewed\nthem?\n\nWe should also keep in mind that the same properties should also be\npossible to use with ACPI. That may not be a problem as such, but we\nshould consult the ACPI guys as well.\n\n\nThanks,","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1Yqc4hvdz9t1t\n\tfor ;\n\tTue, 26 Sep 2017 18:23:08 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S967292AbdIZIXH (ORCPT );\n\tTue, 26 Sep 2017 04:23:07 -0400","from mga03.intel.com ([134.134.136.65]:33224 \"EHLO mga03.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S966216AbdIZIXF (ORCPT );\n\tTue, 26 Sep 2017 04:23:05 -0400","from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t26 Sep 2017 01:23:05 -0700","from kuha.fi.intel.com ([10.237.72.189])\n\tby orsmga002.jf.intel.com with SMTP; 26 Sep 2017 01:23:00 -0700","by kuha.fi.intel.com (sSMTP sendmail emulation);\n\tTue, 26 Sep 2017 11:23:00 +0300"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,440,1500966000\"; d=\"scan'208\";a=\"139485850\"","Date":"Tue, 26 Sep 2017 11:23:00 +0300","From":"Heikki Krogerus ","To":"Li Jun ","Cc":"gregkh@linuxfoundation.org, linux@roeck-us.net, robh+dt@kernel.org,\n\tmark.rutland@arm.com, yueyao@google.com, o_leveque@orange.fr,\n\tpeter.chen@nxp.com, aisheng.dong@nxp.com,\n\tlinux-usb@vger.kernel.org, devicetree@vger.kernel.org","Subject":"Re: [PATCH 02/12] usb: typec: add basic typec properties","Message-ID":"<20170926082300.GC14296@kuha.fi.intel.com>","References":"<1506386727-16370-1-git-send-email-jun.li@nxp.com>\n\t<1506386727-16370-3-git-send-email-jun.li@nxp.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1506386727-16370-3-git-send-email-jun.li@nxp.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1775335,"web_url":"http://patchwork.ozlabs.org/comment/1775335/","msgid":"","list_archive_url":null,"date":"2017-09-26T10:09:03","subject":"RE: [PATCH 02/12] usb: typec: add basic typec properties","submitter":{"id":69265,"url":"http://patchwork.ozlabs.org/api/people/69265/","name":"Jun Li","email":"jun.li@nxp.com"},"content":"Hi,\n\n> -----Original Message-----\n> From: Heikki Krogerus [mailto:heikki.krogerus@linux.intel.com]\n> Sent: Tuesday, September 26, 2017 4:23 PM\n> To: Jun Li \n> Cc: gregkh@linuxfoundation.org; linux@roeck-us.net; robh+dt@kernel.org;\n> mark.rutland@arm.com; yueyao@google.com; o_leveque@orange.fr; Peter\n> Chen ; A.s. Dong ; linux-\n> usb@vger.kernel.org; devicetree@vger.kernel.org\n> Subject: Re: [PATCH 02/12] usb: typec: add basic typec properties\n> \n> On Tue, Sep 26, 2017 at 08:45:17AM +0800, Li Jun wrote:\n> > port-type is required for any typec port; default-role is only\n> > required for drp; power source capable needs src-pdos; power sink\n> > capable needs snk-pdos, max-snk-mv, max-snk-ma, op-snk-mw.\n> >\n> > Signed-off-by: Li Jun \n> > ---\n> > Documentation/devicetree/bindings/usb/typec.txt | 46\n> > +++++++++++++++++++++++++\n> > 1 file changed, 46 insertions(+)\n> >\n> > diff --git a/Documentation/devicetree/bindings/usb/typec.txt\n> > b/Documentation/devicetree/bindings/usb/typec.txt\n> > new file mode 100644\n> > index 0000000..36d4467\n> > --- /dev/null\n> > +++ b/Documentation/devicetree/bindings/usb/typec.txt\n> > @@ -0,0 +1,46 @@\n> > +Generic typec and power delivery properties\n> > +-------------------------------------------\n> > +\n> > +Required properties:\n> > +- port-type: should be one of \"source\", \"sink\" or \"dual\".\n> > +- default-role: preferred power role if drp, should be \"sink\" or \"source\".\n> > +- src-pdos: An array of u32 with each entry providing supported power\n> > + source data object(PDO), the detailed bit definitions of\n> > + PDO can be found in \"Universal Serial Bus Power Delivery\n> > + Specification\" chapter 6.4.1.2 Source_Capabilities Message,\n> > + the order of each entry(PDO) should follow the PD spec chapter\n> > + 6.4.1. Required only for power source and power dual role with\n> > + power delivery support.\n> > +- snk-pdos: An array of u32 with each entry providing supported power\n> > + sink data object(PDO), the detailed bit definitions of PDO\n> > + can be found in \"Universal Serial Bus Power Delivery\n> > + Specification\" chapter 6.4.1.3 Sink Capabilities Message,\n> > + the order of each entry(PDO) should follow the PD spec chapter\n> > + 6.4.1. Required only for power sink and power dual role with\n> > + power delivery support.\n> \n> Wouldn't it be better to supply a property per detail and let the drivers construct\n> the pdos as needed?\n\nThis is my original idea, but different kind of PDOs have so many detail attributes for\ndifferent config, we will have a very long properties list, for simple, maybe it's easier\nfor user to check the standard PD spec and construct it by hand in this case.\n\n> \n> > +- max-snk-mv: The max voltage the sink can support in millivoltage, required\n> > + only for power sink and power dual role with power delivery\n> > + support.\n> > +- max-snk-ma: The max current the sink can support in milliampere, required\n> > + only for power sink and power dual role with power delivery\n> > + support.\n> > +- op-snk-mw: Sink required operating power in milliwatts, if source offered\n> > + power is less then it, Capability Mismatch is set, required\n> > + only for power sink and power dual role with power delivery\n> > + support.\n> \n> I'm a little bit concerned about these. Has any OF/DT guys reviewed them?\n> \n> We should also keep in mind that the same properties should also be possible to\n> use with ACPI. That may not be a problem as such, but we should consult the\n> ACPI guys as well.\n> \n\nOk, let's wait DT guys comments.\n\nLi Jun\n> \n> Thanks,\n> \n> --\n> heikki\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"TbMehK5B\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=jun.li@nxp.com; "],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1c9z3bt0z9s7M\n\tfor ;\n\tTue, 26 Sep 2017 20:09:11 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S965326AbdIZKJK (ORCPT );\n\tTue, 26 Sep 2017 06:09:10 -0400","from mail-ve1eur01on0042.outbound.protection.outlook.com\n\t([104.47.1.42]:38036\n\t\"EHLO EUR01-VE1-obe.outbound.protection.outlook.com\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S965021AbdIZKJI (ORCPT );\n\tTue, 26 Sep 2017 06:09:08 -0400","from DB4PR04MB0768.eurprd04.prod.outlook.com (10.141.45.21) by\n\tDB4PR04MB315.eurprd04.prod.outlook.com (10.141.239.150) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.77.7; Tue, 26 Sep 2017 10:09:04 +0000","from DB4PR04MB0768.eurprd04.prod.outlook.com\n\t([fe80::38a4:9a83:4e70:d431]) by\n\tDB4PR04MB0768.eurprd04.prod.outlook.com\n\t([fe80::38a4:9a83:4e70:d431%16]) with mapi id 15.20.0077.011;\n\tTue, 26 Sep 2017 10:09:03 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=AoRHS3kgunL6udGVxV/NQtvfW5qkplQ6eSOcDXZOIvw=;\n\tb=TbMehK5BZiQKt/NXPr0W/hKUV44P0JTLd59RMcrMC8lrSOj1iDxLra9OIjy7rOfMcdYGA4rgzWWb2gdQN/Bp24lykNh2p34/hZZ1+k16djnFyI9Nn+64TRefrcQW/GBED54Sedfzo2qBaoYFbaynE9RUexE3ivsUplE1y87n53Q=","From":"Jun Li ","To":"Heikki Krogerus ","CC":"\"gregkh@linuxfoundation.org\" ,\n\t\"linux@roeck-us.net\" ,\n\t\"robh+dt@kernel.org\" ,\n\t\"mark.rutland@arm.com\" ,\n\t\"yueyao@google.com\" ,\n\t\"o_leveque@orange.fr\" ,\n\tPeter Chen , \"A.s. Dong\" , \n\t\"linux-usb@vger.kernel.org\" ,\n\t\"devicetree@vger.kernel.org\" ","Subject":"RE: [PATCH 02/12] usb: typec: add basic typec properties","Thread-Topic":"[PATCH 02/12] usb: typec: add basic typec properties","Thread-Index":"AQHTNoKkBFAz8DTeAE6Zjv0Tx1jP4KLG1E4AgAAaAdA=","Date":"Tue, 26 Sep 2017 10:09:03 +0000","Message-ID":"","References":"<1506386727-16370-1-git-send-email-jun.li@nxp.com>\n\t<1506386727-16370-3-git-send-email-jun.li@nxp.com>\n\t<20170926082300.GC14296@kuha.fi.intel.com>","In-Reply-To":"<20170926082300.GC14296@kuha.fi.intel.com>","Accept-Language":"zh-CN, en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"TbMehK5B\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=jun.li@nxp.com; "],"x-originating-ip":"[199.59.231.64]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; DB4PR04MB315;\n\t6:Vz1QYCWgKRM5PsOpXee14i1ChxZGKNEULeiAyd/EO04H8ay8I6qfe31a5faoPrcKV+GxAINsfQ01DbniqJxRdWQw2lcKtGAMeoftwTasvT4dSVB/HklcK9X9jtJPwipuiXMvZx/Wb03iXf98YoNWaA6F/fTafea9XS3GwC+iFm5kGLF9iZZisGweAuzIwqEYwKrMja3268a/9Na4eqEhMzZaZR/axo7qXX7gsAugx5VZS04F35J9aR9Qz4vN+jM9r3akOwgIZYfJC6thBTAXvGp8EsaIs7AX8ScVm2LuQThX11ZX2cCERIfvEhEK36vg85fHCacMAnCjLsShVpOeiQ==;\n\t5:QSOM3uAY6SJznLxwjUejSc4v6fFcPr7Q7DpVVDX0gdeOAwPQU9+4ojH/09dr0cDl3QeeqNXhkmzu1lJjdK7Nk0cQYvNqlSCfwg0WZGkMnrUI+Fiimt5f0hrKAZvDQ6LJFcBW12MHTiPbp0pZcZYiwA==;\n\t24:pUozOsWP14hflm36U37C7p8vAocm0EYy4BsTloCNVrSEvUidU9wH1pn3/Ml3fB5KT38JBBnsaImvzmsCg6rSJ8/OIUTAbK6H05g73pO1+U8=;\n\t7:eW5Hj0c81oru49wwaHXhy8ZKUo62El061IdLUK/D/USWL5CxMoSpBiYFzm22XCgbkw+rFOs5jEtfiXv7h2oghqjAbzxTLtLl7D/8en3xAGVekSRJqKd+aOjZ63SrJzT0/UMBK6RszmSYhjwbp9ir1wkowUAJ5EW0edVi3y9RS5iZYXWHO4JYhTZ/JMBiyUdoTiFleOMxtYsPE1lwFg4Sz/jeCnWHLigVXshcXusW+w0=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;SSOR;","x-forefront-antispam-report":"SFV:SKI; SCL:-1; SFV:NSPM;\n\tSFS:(10009020)(6009001)(376002)(346002)(39860400002)(377454003)(189002)(199003)(24454002)(13464003)(5250100002)(2950100002)(50986999)(54356999)(76176999)(101416001)(2906002)(105586002)(3280700002)(25786009)(7696004)(5660300001)(3846002)(2900100001)(99286003)(4326008)(33656002)(102836003)(6246003)(53936002)(106356001)(55016002)(6436002)(14454004)(478600001)(9686003)(3660700001)(316002)(86362001)(68736007)(6116002)(81166006)(97736004)(6916009)(7736002)(74316002)(6506006)(305945005)(229853002)(8676002)(34040400001)(53546010)(8936002)(81156014)(54906003)(66066001)(189998001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:DB4PR04MB315;\n\tH:DB4PR04MB0768.eurprd04.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; MX:3; A:1; LANG:en; ","x-ms-office365-filtering-correlation-id":"97c4f1cf-718d-49bc-00d2-08d504c69dab","x-ms-office365-filtering-ht":"Tenant","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);\n\tSRVR:DB4PR04MB315; ","x-ms-traffictypediagnostic":"DB4PR04MB315:","x-exchange-antispam-report-test":"UriScan:(249592161093381)(180628864354917)(9452136761055)(185117386973197)(211936372134217)(228905959029699);","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(3002001)(10201501046)(93006095)(93001095)(920507026)(6055026)(6041248)(20161123560025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123555025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:DB4PR04MB315; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:DB4PR04MB315; ","x-forefront-prvs":"0442E569BC","received-spf":"None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-OriginatorOrg":"nxp.com","X-MS-Exchange-CrossTenant-originalarrivaltime":"26 Sep 2017 10:09:03.6808\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"686ea1d3-bc2b-4c6f-a92c-d99c5c301635","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DB4PR04MB315","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]