[{"id":1775130,"web_url":"http://patchwork.ozlabs.org/comment/1775130/","msgid":"<1d317e5b-9de9-9186-1c00-573ca96f3d25@tuxfamily.org>","list_archive_url":null,"date":"2017-09-26T03:51:44","subject":"Re: [Qemu-devel] [PATCH v1 3/8] hw: Replace fprintf(stderr,\n\t\"*\\n\" with error_report()","submitter":{"id":66063,"url":"http://patchwork.ozlabs.org/api/people/66063/","name":"Thomas Huth","email":"huth@tuxfamily.org"},"content":"On 26.09.2017 02:08, Alistair Francis wrote:\n> Replace a large number of the fprintf(stderr, \"*\\n\" calls with\n> error_report(). The functions were renamed with these commands and then\n> compiler issues where manually fixed.\n> \n> find ./* -type f -exec sed -i \\\n> 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, \"\\(.*\\)\\\\n\"\\(.*\\));|error_report(\"\\1\"\\2);|Ig}' \\\n> {} +\n> find ./* -type f -exec sed -i \\\n> 'N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, \"\\(.*\\)\\\\n\"\\(.*\\));|error_report(\"\\1\"\\2);|Ig}' \\\n> {} +\n> find ./* -type f -exec sed -i \\\n> 'N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, \"\\(.*\\)\\\\n\"\\(.*\\));|error_report(\"\\1\"\\2);|Ig}' \\\n> {} +\n> find ./* -type f -exec sed -i \\\n> 'N;N;N;N;N;N;N;N; {s|fprintf(stderr, \"\\(.*\\)\\\\n\"\\(.*\\));|error_report(\"\\1\"\\2);|Ig}' \\\n> {} +\n> find ./* -type f -exec sed -i \\\n> 'N;N;N;N;N;N;N; {s|fprintf(stderr, \"\\(.*\\)\\\\n\"\\(.*\\));|error_report(\"\\1\"\\2);|Ig}' \\\n> {} +\n> find ./* -type f -exec sed -i \\\n> 'N;N;N;N;N;N; {s|fprintf(stderr, \"\\(.*\\)\\\\n\"\\(.*\\));|error_report(\"\\1\"\\2);|Ig}' \\\n> {} +\n> find ./* -type f -exec sed -i \\\n> 'N;N;N;N;N; {s|fprintf(stderr, \"\\(.*\\)\\\\n\"\\(.*\\));|error_report(\"\\1\"\\2);|Ig}' \\\n> {} +\n> find ./* -type f -exec sed -i \\\n> 'N;N;N;N; {s|fprintf(stderr, \"\\(.*\\)\\\\n\"\\(.*\\));|error_report(\"\\1\"\\2);|Ig}' \\\n> {} +\n> find ./* -type f -exec sed -i \\\n> 'N;N;N; {s|fprintf(stderr, \"\\(.*\\)\\\\n\"\\(.*\\));|error_report(\"\\1\"\\2);|Ig}' \\\n> {} +\n> find ./* -type f -exec sed -i \\\n> 'N;N; {s|fprintf(stderr, \"\\(.*\\)\\\\n\"\\(.*\\));|error_report(\"\\1\"\\2);|Ig}' \\\n> {} +\n> find ./* -type f -exec sed -i \\\n> 'N; {s|fprintf(stderr, \"\\(.*\\)\\\\n\"\\(.*\\));|error_report(\"\\1\"\\2);|Ig}' \\\n> {} +\n> \n> Some lines where then manually tweaked to pass checkpatch.\n> \n> Signed-off-by: Alistair Francis \n> Cc: Andrzej Zaborowski \n> Cc: Jan Kiszka \n> Cc: Stefan Hajnoczi \n> Cc: Paolo Bonzini \n> Cc: Thomas Huth \n> Cc: Gerd Hoffmann \n> Cc: \"Michael S. Tsirkin\" \n> Cc: Richard Henderson \n> Cc: Eduardo Habkost \n> Cc: Stefano Stabellini \n> Cc: Anthony Perard \n> Cc: John Snow \n> Cc: Christian Borntraeger \n> Cc: Cornelia Huck \n> Cc: Alexander Graf \n> Cc: Michael Walle \n> Cc: Paul Burton \n> Cc: Aurelien Jarno \n> Cc: Yongbok Kim \n> Cc: \"Hervé Poussineau\" \n> Cc: Anthony Green \n> Cc: Jason Wang \n> Cc: Chris Wulff \n> Cc: Marek Vasut \n> Cc: Jia Liu \n> Cc: Stafford Horne \n> Cc: Marcel Apfelbaum \n> Cc: Magnus Damm \n> Cc: Fabien Chouteau \n> Cc: Mark Cave-Ayland \n> Cc: Artyom Tarasenko \n> Cc: qemu-arm@nongnu.org\n> Cc: qemu-block@nongnu.org\n> Cc: xen-devel@lists.xenproject.org\n> Cc: qemu-ppc@nongnu.org\n> ---\n> \n> hw/arm/armv7m.c | 2 +-\n> hw/arm/boot.c | 34 +++++++++----------\n> hw/arm/gumstix.c | 13 ++++----\n> hw/arm/mainstone.c | 7 ++--\n> hw/arm/musicpal.c | 2 +-\n> hw/arm/omap1.c | 5 +--\n> hw/arm/omap2.c | 21 ++++++------\n> hw/arm/omap_sx1.c | 6 ++--\n> hw/arm/palm.c | 10 +++---\n> hw/arm/pxa2xx.c | 7 ++--\n> hw/arm/stellaris.c | 3 +-\n> hw/arm/tosa.c | 17 +++++-----\n> hw/arm/versatilepb.c | 2 +-\n> hw/arm/vexpress.c | 8 ++---\n> hw/arm/z2.c | 6 ++--\n> hw/block/dataplane/virtio-blk.c | 6 ++--\n> hw/block/onenand.c | 8 ++---\n> hw/block/tc58128.c | 44 ++++++++++++-------------\n> hw/bt/core.c | 15 +++++----\n> hw/bt/hci-csr.c | 17 +++++-----\n> hw/bt/hci.c | 30 ++++++++---------\n> hw/bt/hid.c | 2 +-\n> hw/bt/l2cap.c | 47 ++++++++++++++-------------\n> hw/bt/sdp.c | 7 ++--\n> hw/char/exynos4210_uart.c | 6 ++--\n> hw/char/mcf_uart.c | 5 +--\n> hw/char/sh_serial.c | 9 +++---\n> hw/core/loader.c | 31 +++++++++---------\n> hw/core/ptimer.c | 7 ++--\n> hw/cris/axis_dev88.c | 3 +-\n> hw/cris/boot.c | 5 +--\n> hw/display/blizzard.c | 20 ++++++------\n> hw/display/omap_dss.c | 14 ++++----\n> hw/display/pl110.c | 2 +-\n> hw/display/pxa2xx_lcd.c | 2 +-\n> hw/display/qxl-render.c | 7 ++--\n> hw/display/qxl.c | 10 +++---\n> hw/display/tc6393xb.c | 36 ++++++++++++---------\n> hw/display/virtio-gpu-3d.c | 4 +--\n> hw/display/vmware_vga.c | 22 ++++++-------\n> hw/dma/omap_dma.c | 26 ++++++++-------\n> hw/dma/soc_dma.c | 37 ++++++++++-----------\n> hw/gpio/omap_gpio.c | 2 +-\n> hw/i2c/omap_i2c.c | 10 +++---\n> hw/i386/kvm/apic.c | 9 +++---\n> hw/i386/kvm/clock.c | 7 ++--\n> hw/i386/kvm/i8254.c | 7 ++--\n> hw/i386/kvm/i8259.c | 5 +--\n> hw/i386/kvm/ioapic.c | 5 +--\n> hw/i386/multiboot.c | 21 ++++++------\n> hw/i386/pc.c | 18 +++++------\n> hw/i386/pc_piix.c | 2 +-\n> hw/i386/pc_sysfw.c | 5 +--\n> hw/i386/xen/xen-hvm.c | 32 +++++++++---------\n> hw/i386/xen/xen-mapcache.c | 12 +++----\n> hw/i386/xen/xen_apic.c | 2 +-\n> hw/ide/ahci.c | 6 ++--\n> hw/ide/core.c | 2 +-\n> hw/input/lm832x.c | 6 ++--\n> hw/input/pckbd.c | 3 +-\n> hw/input/pxa2xx_keypad.c | 2 +-\n> hw/input/tsc2005.c | 17 +++++-----\n> hw/input/tsc210x.c | 72 ++++++++++++++++++++---------------------\n> hw/input/virtio-input-hid.c | 14 ++++----\n> hw/input/virtio-input.c | 5 +--\n> hw/intc/arm_gic_kvm.c | 12 +++----\n> hw/intc/omap_intc.c | 4 +--\n> hw/intc/openpic.c | 7 ++--\n> hw/intc/openpic_kvm.c | 8 ++---\n> hw/intc/s390_flic_kvm.c | 4 +--\n> hw/ipmi/ipmi.c | 1 +\n> hw/ipmi/ipmi_bmc_extern.c | 5 +--\n> hw/isa/isa-bus.c | 7 ++--\n> hw/lm32/lm32_boards.c | 5 +--\n> hw/lm32/milkymist.c | 5 +--\n> hw/m68k/an5206.c | 4 +--\n> hw/m68k/mcf5206.c | 3 +-\n> hw/m68k/mcf5208.c | 7 ++--\n> hw/microblaze/boot.c | 2 +-\n> hw/mips/boston.c | 4 +--\n> hw/mips/mips_fulong2e.c | 4 +--\n> hw/mips/mips_jazz.c | 4 +--\n> hw/mips/mips_malta.c | 4 +--\n> hw/mips/mips_mipssim.c | 4 +--\n> hw/mips/mips_r4k.c | 6 ++--\n> hw/misc/a9scu.c | 3 +-\n> hw/misc/omap_gpmc.c | 11 ++++---\n> hw/misc/omap_l4.c | 5 +--\n> hw/misc/omap_sdrc.c | 3 +-\n> hw/misc/vmport.c | 2 +-\n> hw/moxie/moxiesim.c | 7 ++--\n> hw/net/fsl_etsec/etsec.c | 2 +-\n> hw/net/pcnet.c | 2 +-\n> hw/net/smc91c111.c | 5 +--\n> hw/net/vhost_net.c | 16 ++++-----\n> hw/nios2/boot.c | 2 +-\n> hw/nvram/eeprom93xx.c | 5 +--\n> hw/nvram/fw_cfg.c | 4 +--\n> hw/openrisc/openrisc_sim.c | 3 +-\n> hw/pci-host/bonito.c | 6 ++--\n> hw/pci/pci.c | 10 +++---\n> hw/ppc/e500.c | 20 ++++++------\n> hw/ppc/mac_newworld.c | 2 +-\n> hw/ppc/mac_oldworld.c | 2 +-\n> hw/ppc/mpc8544_guts.c | 5 +--\n> hw/ppc/ppc405_boards.c | 8 ++---\n> hw/ppc/ppc440_bamboo.c | 19 +++++------\n> hw/ppc/ppc4xx_pci.c | 3 +-\n> hw/ppc/prep.c | 4 +--\n> hw/ppc/virtex_ml507.c | 4 +--\n> hw/s390x/virtio-ccw.c | 2 +-\n> hw/scsi/lsi53c895a.c | 4 +--\n> hw/scsi/spapr_vscsi.c | 49 ++++++++++++++--------------\n> hw/scsi/virtio-scsi-dataplane.c | 6 ++--\n> hw/sd/pl181.c | 5 +--\n> hw/sd/sd.c | 14 ++++----\n> hw/sh4/r2d.c | 9 +++---\n> hw/sh4/sh7750.c | 64 ++++++++++++++++++------------------\n> hw/sparc/leon3.c | 9 +++---\n> hw/sparc/sun4m.c | 8 ++---\n> hw/sparc64/niagara.c | 2 +-\n> hw/sparc64/sun4u.c | 9 +++---\n> hw/ssi/omap_spi.c | 5 +--\n> hw/timer/omap_gptimer.c | 11 ++++---\n> hw/timer/twl92230.c | 2 +-\n> hw/timer/xilinx_timer.c | 8 ++---\n> hw/usb/core.c | 15 +++++----\n> hw/usb/desc.c | 4 +--\n> hw/usb/dev-audio.c | 29 +++++++++--------\n> hw/usb/dev-bluetooth.c | 4 +--\n> hw/usb/dev-mtp.c | 9 +++---\n> hw/usb/dev-network.c | 20 ++++++------\n> hw/usb/hcd-ehci.c | 32 +++++++++---------\n> hw/usb/hcd-musb.c | 4 +--\n> hw/usb/hcd-xhci.c | 3 +-\n> hw/usb/host-legacy.c | 2 +-\n> hw/watchdog/watchdog.c | 9 +++---\n> hw/watchdog/wdt_i6300esb.c | 8 +++--\n> hw/xen/xen-common.c | 10 +++---\n> hw/xen/xen_pt.c | 4 +--\n> hw/xenpv/xen_domainbuild.c | 24 +++++++-------\n> hw/xenpv/xen_machine_pv.c | 8 ++---\n> 142 files changed, 769 insertions(+), 705 deletions(-)\n\nThis patch is IMHO way to big! Can you please break this down into the\nindividual hw/* subsystems, so that people who are familiar with a\ncertain subsystem have a chance to review just their part? Thanks.\n\n Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1RqT0s2Tz9t3x\n\tfor ;\n\tTue, 26 Sep 2017 13:52:37 +1000 (AEST)","from localhost ([::1]:45468 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwgvD-0003gB-7t\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 23:52:35 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:38483)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwgul-0003dz-GN\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 23:52:09 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwguj-0001ZV-Rl\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 23:52:07 -0400","from mail-wr0-f195.google.com ([209.85.128.195]:33275)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dwguU-0001So-Du; Mon, 25 Sep 2017 23:51:50 -0400","by mail-wr0-f195.google.com with SMTP id b9so1315669wra.0;\n\tMon, 25 Sep 2017 20:51:50 -0700 (PDT)","from [192.168.178.23] (pD9E836CB.dip0.t-ipconnect.de.\n\t[217.232.54.203]) by smtp.gmail.com with ESMTPSA id\n\t137sm1276742wmp.7.2017.09.25.20.51.46\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 25 Sep 2017 20:51:47 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=AibOYXhziTL50phhDTFBkPpw+sO7cs2eBF8Sc1DT4Gg=;\n\tb=p85TI3AkT1t2mKELfyhjnfQfqtJQhep0fZ5wvGhFkVXoJY9I0JwV9bxcYxnttjIuMM\n\tPUh4s5BgiKB32wYGq1cAhzFqLPTwHnkiTRrQzKqj1SH7kT6n35Yy/zzFQpI48nq8YBFl\n\t+byH6axuUHgMpjTjW91GzPLcdNRy0I7rYw7q1dGFURIl/GUBPNfH1zACFWrBnX98IhBE\n\t6D86AUlZg/z55EY7dSbp+HukqkrN1NjBoqAR7tmK1pmQsAjyIRq/I9izoi7IDrzJckNT\n\t/kFbD/L+t0ORS4vYfUiIkiCmy7TfdjrkNjHsuaA9SurHxn1sJ9EKwRFSLVcI6EOmwMiB\n\tMXhA==","X-Gm-Message-State":"AHPjjUhPi/V33rARrZkNA144c33DQMLMUrY+9IEN/eSc6UJyTx5qcfW+\n\tgQoYMOL/tDOQO6qeUm25o6U=","X-Google-Smtp-Source":"AOwi7QAm0C942KMgADNF7Auhh0Vf9lwmG9A8WUrQafMJsW7SyJEoaZpoLGVeSNy9TNVYPagatFx6KQ==","X-Received":"by 10.223.143.14 with SMTP id p14mr6989900wrb.133.1506397908944; \n\tMon, 25 Sep 2017 20:51:48 -0700 (PDT)","To":"Alistair Francis , qemu-devel@nongnu.org","References":"\n\t","From":"Thomas Huth ","Message-ID":"<1d317e5b-9de9-9186-1c00-573ca96f3d25@tuxfamily.org>","Date":"Tue, 26 Sep 2017 05:51:44 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.85.128.195","Subject":"Re: [Qemu-devel] [PATCH v1 3/8] hw: Replace fprintf(stderr,\n\t\"*\\n\" with error_report()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Cornelia Huck , \"Michael S. Tsirkin\" ,\n\tAnthony Green , Mark Cave-Ayland\n\t, \tAlexander Graf ,\n\tGerd Hoffmann , Marek Vasut , \n\tStefano Stabellini , Jia Liu ,\n\tqemu-block@nongnu.org, Magnus Damm ,\n\tarmbru@redhat.com, \tChristian Borntraeger ,\n\t=?utf-8?q?Herv=C3=A9_?= =?utf-8?q?Poussineau?= ,\n\tMarcel Apfelbaum , xen-devel@lists.xenproject.org,\n\tJason Wang , \n\tArtyom Tarasenko , Eduardo Habkost\n\t, \tFabien Chouteau ,\n\tAnthony Perard , qemu-arm@nongnu.org, \n\tJan Kiszka , Stefan Hajnoczi , \n\tYongbok Kim , alistair23@gmail.com, \n\tStafford Horne , John Snow , \n\tRichard Henderson\n\t, Paul Burton , Thomas Huth\n\t, Chris Wulff , Michael Walle\n\t, qemu-ppc@nongnu.org, Paolo Bonzini\n\t, Aurelien Jarno ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1776670,"web_url":"http://patchwork.ozlabs.org/comment/1776670/","msgid":"","list_archive_url":null,"date":"2017-09-27T22:41:26","subject":"Re: [Qemu-devel] [PATCH v1 3/8] hw: Replace fprintf(stderr,\n\t\"*\\n\" with error_report()","submitter":{"id":47878,"url":"http://patchwork.ozlabs.org/api/people/47878/","name":"Alistair Francis","email":"alistair.francis@xilinx.com"},"content":"On Mon, Sep 25, 2017 at 8:51 PM, Thomas Huth wrote:\n> On 26.09.2017 02:08, Alistair Francis wrote:\n>> Replace a large number of the fprintf(stderr, \"*\\n\" calls with\n>> error_report(). The functions were renamed with these commands and then\n>> compiler issues where manually fixed.\n>>\n>> find ./* -type f -exec sed -i \\\n>> 'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, \"\\(.*\\)\\\\n\"\\(.*\\));|error_report(\"\\1\"\\2);|Ig}' \\\n>> {} +\n>> find ./* -type f -exec sed -i \\\n>> 'N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, \"\\(.*\\)\\\\n\"\\(.*\\));|error_report(\"\\1\"\\2);|Ig}' \\\n>> {} +\n>> find ./* -type f -exec sed -i \\\n>> 'N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, \"\\(.*\\)\\\\n\"\\(.*\\));|error_report(\"\\1\"\\2);|Ig}' \\\n>> {} +\n>> find ./* -type f -exec sed -i \\\n>> 'N;N;N;N;N;N;N;N; {s|fprintf(stderr, \"\\(.*\\)\\\\n\"\\(.*\\));|error_report(\"\\1\"\\2);|Ig}' \\\n>> {} +\n>> find ./* -type f -exec sed -i \\\n>> 'N;N;N;N;N;N;N; {s|fprintf(stderr, \"\\(.*\\)\\\\n\"\\(.*\\));|error_report(\"\\1\"\\2);|Ig}' \\\n>> {} +\n>> find ./* -type f -exec sed -i \\\n>> 'N;N;N;N;N;N; {s|fprintf(stderr, \"\\(.*\\)\\\\n\"\\(.*\\));|error_report(\"\\1\"\\2);|Ig}' \\\n>> {} +\n>> find ./* -type f -exec sed -i \\\n>> 'N;N;N;N;N; {s|fprintf(stderr, \"\\(.*\\)\\\\n\"\\(.*\\));|error_report(\"\\1\"\\2);|Ig}' \\\n>> {} +\n>> find ./* -type f -exec sed -i \\\n>> 'N;N;N;N; {s|fprintf(stderr, \"\\(.*\\)\\\\n\"\\(.*\\));|error_report(\"\\1\"\\2);|Ig}' \\\n>> {} +\n>> find ./* -type f -exec sed -i \\\n>> 'N;N;N; {s|fprintf(stderr, \"\\(.*\\)\\\\n\"\\(.*\\));|error_report(\"\\1\"\\2);|Ig}' \\\n>> {} +\n>> find ./* -type f -exec sed -i \\\n>> 'N;N; {s|fprintf(stderr, \"\\(.*\\)\\\\n\"\\(.*\\));|error_report(\"\\1\"\\2);|Ig}' \\\n>> {} +\n>> find ./* -type f -exec sed -i \\\n>> 'N; {s|fprintf(stderr, \"\\(.*\\)\\\\n\"\\(.*\\));|error_report(\"\\1\"\\2);|Ig}' \\\n>> {} +\n>>\n>> Some lines where then manually tweaked to pass checkpatch.\n>>\n>> Signed-off-by: Alistair Francis \n>> Cc: Andrzej Zaborowski \n>> Cc: Jan Kiszka \n>> Cc: Stefan Hajnoczi \n>> Cc: Paolo Bonzini \n>> Cc: Thomas Huth \n>> Cc: Gerd Hoffmann \n>> Cc: \"Michael S. Tsirkin\" \n>> Cc: Richard Henderson \n>> Cc: Eduardo Habkost \n>> Cc: Stefano Stabellini \n>> Cc: Anthony Perard \n>> Cc: John Snow \n>> Cc: Christian Borntraeger \n>> Cc: Cornelia Huck \n>> Cc: Alexander Graf \n>> Cc: Michael Walle \n>> Cc: Paul Burton \n>> Cc: Aurelien Jarno \n>> Cc: Yongbok Kim \n>> Cc: \"Hervé Poussineau\" \n>> Cc: Anthony Green \n>> Cc: Jason Wang \n>> Cc: Chris Wulff \n>> Cc: Marek Vasut \n>> Cc: Jia Liu \n>> Cc: Stafford Horne \n>> Cc: Marcel Apfelbaum \n>> Cc: Magnus Damm \n>> Cc: Fabien Chouteau \n>> Cc: Mark Cave-Ayland \n>> Cc: Artyom Tarasenko \n>> Cc: qemu-arm@nongnu.org\n>> Cc: qemu-block@nongnu.org\n>> Cc: xen-devel@lists.xenproject.org\n>> Cc: qemu-ppc@nongnu.org\n>> ---\n>>\n>> hw/arm/armv7m.c | 2 +-\n>> hw/arm/boot.c | 34 +++++++++----------\n>> hw/arm/gumstix.c | 13 ++++----\n>> hw/arm/mainstone.c | 7 ++--\n>> hw/arm/musicpal.c | 2 +-\n>> hw/arm/omap1.c | 5 +--\n>> hw/arm/omap2.c | 21 ++++++------\n>> hw/arm/omap_sx1.c | 6 ++--\n>> hw/arm/palm.c | 10 +++---\n>> hw/arm/pxa2xx.c | 7 ++--\n>> hw/arm/stellaris.c | 3 +-\n>> hw/arm/tosa.c | 17 +++++-----\n>> hw/arm/versatilepb.c | 2 +-\n>> hw/arm/vexpress.c | 8 ++---\n>> hw/arm/z2.c | 6 ++--\n>> hw/block/dataplane/virtio-blk.c | 6 ++--\n>> hw/block/onenand.c | 8 ++---\n>> hw/block/tc58128.c | 44 ++++++++++++-------------\n>> hw/bt/core.c | 15 +++++----\n>> hw/bt/hci-csr.c | 17 +++++-----\n>> hw/bt/hci.c | 30 ++++++++---------\n>> hw/bt/hid.c | 2 +-\n>> hw/bt/l2cap.c | 47 ++++++++++++++-------------\n>> hw/bt/sdp.c | 7 ++--\n>> hw/char/exynos4210_uart.c | 6 ++--\n>> hw/char/mcf_uart.c | 5 +--\n>> hw/char/sh_serial.c | 9 +++---\n>> hw/core/loader.c | 31 +++++++++---------\n>> hw/core/ptimer.c | 7 ++--\n>> hw/cris/axis_dev88.c | 3 +-\n>> hw/cris/boot.c | 5 +--\n>> hw/display/blizzard.c | 20 ++++++------\n>> hw/display/omap_dss.c | 14 ++++----\n>> hw/display/pl110.c | 2 +-\n>> hw/display/pxa2xx_lcd.c | 2 +-\n>> hw/display/qxl-render.c | 7 ++--\n>> hw/display/qxl.c | 10 +++---\n>> hw/display/tc6393xb.c | 36 ++++++++++++---------\n>> hw/display/virtio-gpu-3d.c | 4 +--\n>> hw/display/vmware_vga.c | 22 ++++++-------\n>> hw/dma/omap_dma.c | 26 ++++++++-------\n>> hw/dma/soc_dma.c | 37 ++++++++++-----------\n>> hw/gpio/omap_gpio.c | 2 +-\n>> hw/i2c/omap_i2c.c | 10 +++---\n>> hw/i386/kvm/apic.c | 9 +++---\n>> hw/i386/kvm/clock.c | 7 ++--\n>> hw/i386/kvm/i8254.c | 7 ++--\n>> hw/i386/kvm/i8259.c | 5 +--\n>> hw/i386/kvm/ioapic.c | 5 +--\n>> hw/i386/multiboot.c | 21 ++++++------\n>> hw/i386/pc.c | 18 +++++------\n>> hw/i386/pc_piix.c | 2 +-\n>> hw/i386/pc_sysfw.c | 5 +--\n>> hw/i386/xen/xen-hvm.c | 32 +++++++++---------\n>> hw/i386/xen/xen-mapcache.c | 12 +++----\n>> hw/i386/xen/xen_apic.c | 2 +-\n>> hw/ide/ahci.c | 6 ++--\n>> hw/ide/core.c | 2 +-\n>> hw/input/lm832x.c | 6 ++--\n>> hw/input/pckbd.c | 3 +-\n>> hw/input/pxa2xx_keypad.c | 2 +-\n>> hw/input/tsc2005.c | 17 +++++-----\n>> hw/input/tsc210x.c | 72 ++++++++++++++++++++---------------------\n>> hw/input/virtio-input-hid.c | 14 ++++----\n>> hw/input/virtio-input.c | 5 +--\n>> hw/intc/arm_gic_kvm.c | 12 +++----\n>> hw/intc/omap_intc.c | 4 +--\n>> hw/intc/openpic.c | 7 ++--\n>> hw/intc/openpic_kvm.c | 8 ++---\n>> hw/intc/s390_flic_kvm.c | 4 +--\n>> hw/ipmi/ipmi.c | 1 +\n>> hw/ipmi/ipmi_bmc_extern.c | 5 +--\n>> hw/isa/isa-bus.c | 7 ++--\n>> hw/lm32/lm32_boards.c | 5 +--\n>> hw/lm32/milkymist.c | 5 +--\n>> hw/m68k/an5206.c | 4 +--\n>> hw/m68k/mcf5206.c | 3 +-\n>> hw/m68k/mcf5208.c | 7 ++--\n>> hw/microblaze/boot.c | 2 +-\n>> hw/mips/boston.c | 4 +--\n>> hw/mips/mips_fulong2e.c | 4 +--\n>> hw/mips/mips_jazz.c | 4 +--\n>> hw/mips/mips_malta.c | 4 +--\n>> hw/mips/mips_mipssim.c | 4 +--\n>> hw/mips/mips_r4k.c | 6 ++--\n>> hw/misc/a9scu.c | 3 +-\n>> hw/misc/omap_gpmc.c | 11 ++++---\n>> hw/misc/omap_l4.c | 5 +--\n>> hw/misc/omap_sdrc.c | 3 +-\n>> hw/misc/vmport.c | 2 +-\n>> hw/moxie/moxiesim.c | 7 ++--\n>> hw/net/fsl_etsec/etsec.c | 2 +-\n>> hw/net/pcnet.c | 2 +-\n>> hw/net/smc91c111.c | 5 +--\n>> hw/net/vhost_net.c | 16 ++++-----\n>> hw/nios2/boot.c | 2 +-\n>> hw/nvram/eeprom93xx.c | 5 +--\n>> hw/nvram/fw_cfg.c | 4 +--\n>> hw/openrisc/openrisc_sim.c | 3 +-\n>> hw/pci-host/bonito.c | 6 ++--\n>> hw/pci/pci.c | 10 +++---\n>> hw/ppc/e500.c | 20 ++++++------\n>> hw/ppc/mac_newworld.c | 2 +-\n>> hw/ppc/mac_oldworld.c | 2 +-\n>> hw/ppc/mpc8544_guts.c | 5 +--\n>> hw/ppc/ppc405_boards.c | 8 ++---\n>> hw/ppc/ppc440_bamboo.c | 19 +++++------\n>> hw/ppc/ppc4xx_pci.c | 3 +-\n>> hw/ppc/prep.c | 4 +--\n>> hw/ppc/virtex_ml507.c | 4 +--\n>> hw/s390x/virtio-ccw.c | 2 +-\n>> hw/scsi/lsi53c895a.c | 4 +--\n>> hw/scsi/spapr_vscsi.c | 49 ++++++++++++++--------------\n>> hw/scsi/virtio-scsi-dataplane.c | 6 ++--\n>> hw/sd/pl181.c | 5 +--\n>> hw/sd/sd.c | 14 ++++----\n>> hw/sh4/r2d.c | 9 +++---\n>> hw/sh4/sh7750.c | 64 ++++++++++++++++++------------------\n>> hw/sparc/leon3.c | 9 +++---\n>> hw/sparc/sun4m.c | 8 ++---\n>> hw/sparc64/niagara.c | 2 +-\n>> hw/sparc64/sun4u.c | 9 +++---\n>> hw/ssi/omap_spi.c | 5 +--\n>> hw/timer/omap_gptimer.c | 11 ++++---\n>> hw/timer/twl92230.c | 2 +-\n>> hw/timer/xilinx_timer.c | 8 ++---\n>> hw/usb/core.c | 15 +++++----\n>> hw/usb/desc.c | 4 +--\n>> hw/usb/dev-audio.c | 29 +++++++++--------\n>> hw/usb/dev-bluetooth.c | 4 +--\n>> hw/usb/dev-mtp.c | 9 +++---\n>> hw/usb/dev-network.c | 20 ++++++------\n>> hw/usb/hcd-ehci.c | 32 +++++++++---------\n>> hw/usb/hcd-musb.c | 4 +--\n>> hw/usb/hcd-xhci.c | 3 +-\n>> hw/usb/host-legacy.c | 2 +-\n>> hw/watchdog/watchdog.c | 9 +++---\n>> hw/watchdog/wdt_i6300esb.c | 8 +++--\n>> hw/xen/xen-common.c | 10 +++---\n>> hw/xen/xen_pt.c | 4 +--\n>> hw/xenpv/xen_domainbuild.c | 24 +++++++-------\n>> hw/xenpv/xen_machine_pv.c | 8 ++---\n>> 142 files changed, 769 insertions(+), 705 deletions(-)\n>\n> This patch is IMHO way to big! Can you please break this down into the\n> individual hw/* subsystems, so that people who are familiar with a\n> certain subsystem have a chance to review just their part? Thanks.\n\nOk, will do in v2.\n\nThanks,\nAlistair\n\n>\n> Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"UOWfAFvK\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2Xrs6SSZz9t6W\n\tfor ;\n\tThu, 28 Sep 2017 08:42:37 +1000 (AEST)","from localhost ([::1]:56601 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxL2J-0004pA-Uz\n\tfor incoming@patchwork.ozlabs.org; Wed, 27 Sep 2017 18:42:35 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:60609)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxL1k-0004oF-Cw\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 18:42:02 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxL1i-0007MR-KT\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 18:42:00 -0400","from mail-wr0-x244.google.com ([2a00:1450:400c:c0c::244]:35523)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dxL1i-0007LH-Ag; Wed, 27 Sep 2017 18:41:58 -0400","by mail-wr0-x244.google.com with SMTP id n64so6758859wrb.2;\n\tWed, 27 Sep 2017 15:41:58 -0700 (PDT)","by 10.28.135.139 with HTTP; Wed, 27 Sep 2017 15:41:26 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc:content-transfer-encoding;\n\tbh=sdYUbeVZhZCzUw83teV/dkoe49F5oXI3kI/7kQ3DTCs=;\n\tb=UOWfAFvKgU4ObkVwUE+Ukl3L9jK+OKyUxSWrz517I2Wf0ASf3r32dPZPotd9flnkco\n\tVaERC9Q9Ua935wPZRnnRoOdliKU44sYZiFQP1V9oOPn60PwYfnezqnah4cfmWNoJsyAc\n\t6pGs/7Dh9/3aZVJKR2x5l42ltSebMRjh2vU7hbtZOdUHoglIHlaaucuKjcGylYrAIIxs\n\t3D4xbbG4t/seTWlyR/0wp32LcFIqMJYNCdyDuwzGNa3BACLsp8FTGSvL6SQjQavGN1rg\n\t9RJM884fVW1L0BQDYywFm6vHXIqn1Uwm1qmfaGul6tn+9x5hItwODU0Vo4RXg/RHQUHn\n\twqUg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=sdYUbeVZhZCzUw83teV/dkoe49F5oXI3kI/7kQ3DTCs=;\n\tb=XKbAIyqoiHGsDnjoTpesJA+rHJQ/pgpbbQn+Ul/eFa0pxjD4YyqFKu1AzmTJ2NuIU9\n\t+m4GUaN2RBRLsHrLDW1ya4Q3KJ6eijKhsq6e+p6pt9Fo+kivNLbvUslKUs1YX3IyB4FB\n\t6aKB9UQXz4DwMm+7WpPPfO56AIuQbjj9XHDyOR1IdAQ5jZ3kmNG+UHnOgCunc42kNrGV\n\tZmAupd/962a7mIEOwk/FYqF+rlhDVDZao7lSUcdGvPdzEI08rhq/RjGbHv63tBV8wAzV\n\t6EAShl3JvAGr7vn3PmmWq1SmWnQQmIacAd06JyXNyeTRx4XZgfCjjW51m2ubMzDucjIO\n\tAlOA==","X-Gm-Message-State":"AHPjjUj2mDYUD5u4sZe7G9uE+slVW6+stkbafkSgb6t5fOY1k0Oku7o4\n\ttouhgO41PBOVwg/sXnvLlFWGHgXfqEdl6M4I2jA=","X-Google-Smtp-Source":"AOwi7QAp0LILoqKtaPluU/r7ELsiQeueETWZ/0IyV94YdUN1HcCo6UDYqPgvIh6QlO/X4kivcUCYpIAn2qAZHxf272M=","X-Received":"by 10.223.169.143 with SMTP id b15mr3002426wrd.127.1506552117045;\n\tWed, 27 Sep 2017 15:41:57 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1d317e5b-9de9-9186-1c00-573ca96f3d25@tuxfamily.org>","References":"\n\t\n\t<1d317e5b-9de9-9186-1c00-573ca96f3d25@tuxfamily.org>","From":"Alistair Francis ","Date":"Wed, 27 Sep 2017 15:41:26 -0700","X-Google-Sender-Auth":"4CpEOc9u8p_tS483Wm4BKbYrhnM","Message-ID":"","To":"Thomas Huth ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c0c::244","Subject":"Re: [Qemu-devel] [PATCH v1 3/8] hw: Replace fprintf(stderr,\n\t\"*\\n\" with error_report()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Cornelia Huck , \"Michael S. Tsirkin\" ,\n\tAnthony Green , Mark Cave-Ayland\n\t, \"qemu-devel@nongnu.org Developers\"\n\t, \tMarkus Armbruster ,\n\tGerd Hoffmann , Marek Vasut ,\n\tStefano Stabellini , Jia Liu ,\n\tqemu-block@nongnu.org, Magnus Damm ,\n\tAlexander Graf , Christian Borntraeger\n\t, =?utf-8?q?Herv=C3=A9_Poussineau?=\n\t, \tAnthony Perard ,\n\t\"open list:X86\" , \n\tJason Wang ,\n\tArtyom Tarasenko , Eduardo Habkost\n\t, \tFabien Chouteau ,\n\tAlistair Francis , \n\tMarcel Apfelbaum , qemu-arm ,\n\tJan Kiszka , \tStefan Hajnoczi ,\n\tYongbok Kim , Stafford Horne ,\n\tJohn Snow , Richard Henderson ,\n\tPaul Burton , Chris Wulff ,\n\tMichael Walle , \"open list:New World\"\n\t, Paolo Bonzini ,\n\tAurelien Jarno ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]