[{"id":1775071,"web_url":"http://patchwork.ozlabs.org/comment/1775071/","msgid":"<20170926005520.GA7906@flamenco>","list_archive_url":null,"date":"2017-09-26T00:55:20","subject":"Re: [Qemu-devel] [PATCH v1 2/8] tests: Replace fprintf(stderr,\n\t\"*\\n\" with error_report()","submitter":{"id":65690,"url":"http://patchwork.ozlabs.org/api/people/65690/","name":"Emilio Cota","email":"cota@braap.org"},"content":"On Mon, Sep 25, 2017 at 17:08:48 -0700, Alistair Francis wrote:\n> diff --git a/tests/atomic_add-bench.c b/tests/atomic_add-bench.c\n> index caa1e8e689..41ba1600c0 100644\n> --- a/tests/atomic_add-bench.c\n> +++ b/tests/atomic_add-bench.c\n> @@ -29,7 +29,7 @@ static const char commands_string[] =\n> static void usage_complete(char *argv[])\n> {\n> fprintf(stderr, \"Usage: %s [options]\\n\", argv[0]);\n> - fprintf(stderr, \"options:\\n%s\\n\", commands_string);\n> + fprintf(stderr, \"options:\\n%s\", commands_string);\n> }\n\nWe do want that trailing \\n, unless we move it to commands_string.\n\nAlso, I think using error_report here would be confusing -- this is a standalone\ntest program with as little QEMU-specific knowledge as possible (QemuThreads\nare used for portability); using error_report here is confusing (this is not\nan error).\n\n> diff --git a/tests/check-qlit b/tests/check-qlit\n> new file mode 100755\n> index 0000000000000000000000000000000000000000..950429524e3eb07e6daed1fe01caad0f5d554809\n> GIT binary patch\n> literal 272776\n> zcmeEvdwf*Ywf~vPB$){zGeCghJ;($So{10*LNEgfoIs*MKvBRDLV(l&F`3b5QKOS6\n\n? I don't know what this is, I don't seem to have this binary in my\nchecked out tree.\n\n(snips thousands of lines)\n\n> diff --git a/tests/qht-bench.c b/tests/qht-bench.c\n> index 11c1cec766..2637d601a9 100644\n> --- a/tests/qht-bench.c\n> +++ b/tests/qht-bench.c\n> @@ -5,6 +5,7 @@\n> * See the COPYING file in the top-level directory.\n> */\n> #include \"qemu/osdep.h\"\n> +#include \"qemu/error-report.h\"\n> #include \"qemu/processor.h\"\n> #include \"qemu/atomic.h\"\n> #include \"qemu/qht.h\"\n> @@ -89,7 +90,7 @@ static const char commands_string[] =\n> static void usage_complete(int argc, char *argv[])\n> {\n> fprintf(stderr, \"Usage: %s [options]\\n\", argv[0]);\n> - fprintf(stderr, \"options:\\n%s\\n\", commands_string);\n> + fprintf(stderr, \"options:\\n%s\", commands_string);\n\nSame as above: this removes the necessary trailing \\n.\n\n> exit(-1);\n> }\n> \n> @@ -328,7 +329,7 @@ static void htable_init(void)\n> retries++;\n> }\n> }\n> - fprintf(stderr, \" populated after %zu retries\\n\", retries);\n> + error_report(\" populated after %zu retries\", retries);\n> }\n\nditto -- I'd rather keep fprintf(stderr) here, it's less confusing.\n\nThanks,\n\n\t\tEmilio","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=braap.org header.i=@braap.org\n\theader.b=\"LxC03kVN\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"bIVv1NBh\"; \n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1Mvq1fYQz9t3R\n\tfor ;\n\tTue, 26 Sep 2017 10:56:00 +1000 (AEST)","from localhost ([::1]:45052 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dweAG-0007RZ-8u\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 20:55:56 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:35250)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwe9s-0007P8-1s\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 20:55:33 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwe9r-0005P9-5g\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 20:55:32 -0400","from out2-smtp.messagingengine.com ([66.111.4.26]:49449)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dwe9k-00055A-3u; Mon, 25 Sep 2017 20:55:24 -0400","from compute4.internal (compute4.nyi.internal [10.202.2.44])\n\tby mailout.nyi.internal (Postfix) with ESMTP id DF41520C10;\n\tMon, 25 Sep 2017 20:55:20 -0400 (EDT)","from frontend1 ([10.202.2.160])\n\tby compute4.internal (MEProxy); Mon, 25 Sep 2017 20:55:20 -0400","from localhost (flamenco.cs.columbia.edu [128.59.20.216])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id A8B297E8EC;\n\tMon, 25 Sep 2017 20:55:20 -0400 (EDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=braap.org; h=cc\n\t:content-type:date:from:in-reply-to:message-id:mime-version\n\t:references:subject:to:x-me-sender:x-me-sender:x-sasl-enc\n\t:x-sasl-enc; s=mesmtp; bh=67ZgjRGTftjQHX49CrQ8+BS4F1+Usd+GLmCAGC\n\tVK1HE=; b=LxC03kVN4JaGm7GNEeSyoHjwkODmTUBSQs5uiATxEXNnlm3/OksNYY\n\tQi3XZM64wcLqbpLhOfOw/VFK3vYD7Ki6o96M4qM3FJow9XMGr43C5mu2KEhtVwrf\n\ttXs00o2Vo5nZ17M56EtsbZVk5M4vhZwemxYiJQfODoigypwQBdwXw=","v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to:x-me-sender\n\t:x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=67ZgjRGTftjQHX49Cr\n\tQ8+BS4F1+Usd+GLmCAGCVK1HE=; b=bIVv1NBhD4WTw1Rtp/B7Vll2qsAhuM050f\n\tgozbdcJn59U2Xp5tUDzq7EeiCkEphVhGwevv8IFI59mJaccikn7h/zWbRT6RxVd/\n\t9W7aIvpz57SGjPlqTLSaWKT+jYbas8RWxBAq7dDBsYxgm3oOafwF4d/fYpMPyvGy\n\tfCzB7HgzoOJkXlK2amEVPRRCZWw45kTnCwlc0qQjKBuboTdjrnuUExGjQ4ynvNmx\n\tL3yY+vJkO4zBhO8pM+QHHT4+iQgrFOnz793FnNmuv12wB4uVMB60pJISwCfUE8vd\n\tcxy6JKANswJ79vG8Zsc8AimmNQORej0Gitx47E7VIZ3MGa+9GrOg=="],"X-ME-Sender":"","X-Sasl-enc":"Htjks+qWsv8Nzq4mQvfKzGQHI/uDeEwcvTId+C7x3qFD 1506387320","Date":"Mon, 25 Sep 2017 20:55:20 -0400","From":"\"Emilio G. Cota\" ","To":"Alistair Francis ","Message-ID":"<20170926005520.GA7906@flamenco>","References":"\n\t<50c325943b1547813567efe6a11fb44644494d70.1506384414.git.alistair.francis@xilinx.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<50c325943b1547813567efe6a11fb44644494d70.1506384414.git.alistair.francis@xilinx.com>","User-Agent":"Mutt/1.5.24 (2015-08-30)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"66.111.4.26","Subject":"Re: [Qemu-devel] [PATCH v1 2/8] tests: Replace fprintf(stderr,\n\t\"*\\n\" with error_report()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-block@nongnu.org, \"Michael S. Tsirkin\" ,\n\tqemu-devel@nongnu.org, armbru@redhat.com,\n\t\"Dr. David Alan Gilbert\" ,\n\tGerd Hoffmann , alistair23@gmail.com,\n\tIgor Mammedov ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1775551,"web_url":"http://patchwork.ozlabs.org/comment/1775551/","msgid":"<7e8efa9f-a6ad-742d-b20e-467af90da68a@redhat.com>","list_archive_url":null,"date":"2017-09-26T14:03:14","subject":"Re: [Qemu-devel] [PATCH v1 2/8] tests: Replace fprintf(stderr,\n\t\"*\\n\" with error_report()","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/25/2017 07:55 PM, Emilio G. Cota wrote:\n\n>> diff --git a/tests/check-qlit b/tests/check-qlit\n>> new file mode 100755\n>> index 0000000000000000000000000000000000000000..950429524e3eb07e6daed1fe01caad0f5d554809\n>> GIT binary patch\n>> literal 272776\n>> zcmeEvdwf*Ywf~vPB$){zGeCghJ;($So{10*LNEgfoIs*MKvBRDLV(l&F`3b5QKOS6\n> \n> ? I don't know what this is, I don't seem to have this binary in my\n> checked out tree.\n\nOuch. We have a missing entry in .gitignore for a recent test addition,\nwhich hits if you do an in-tree build and then an indiscriminate 'git\nadd tests/' (I've already mentioned it on-list). It's a built\nexecutable during 'make check', and doesn't belong in git.\n\nhttps://lists.gnu.org/archive/html/qemu-devel/2017-09/msg01067.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1jP11PTXz9t43\n\tfor ;\n\tWed, 27 Sep 2017 00:04:04 +1000 (AEST)","from localhost ([::1]:47702 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwqSv-00056u-UI\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 10:04:01 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:56855)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwqST-00055w-2R\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 10:03:42 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwqSP-0004tA-1p\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 10:03:33 -0400","from mx1.redhat.com ([209.132.183.28]:35856)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dwqSJ-0004rA-Jr; Tue, 26 Sep 2017 10:03:23 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 31CACE182D;\n\tTue, 26 Sep 2017 14:03:22 +0000 (UTC)","from [10.10.124.97] (ovpn-124-97.rdu2.redhat.com [10.10.124.97])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 5991B76124;\n\tTue, 26 Sep 2017 14:03:15 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 31CACE182D","To":"\"Emilio G. Cota\" ,\n\tAlistair Francis ","References":"\n\t<50c325943b1547813567efe6a11fb44644494d70.1506384414.git.alistair.francis@xilinx.com>\n\t<20170926005520.GA7906@flamenco>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"<7e8efa9f-a6ad-742d-b20e-467af90da68a@redhat.com>","Date":"Tue, 26 Sep 2017 09:03:14 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170926005520.GA7906@flamenco>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"NXpfQ8SVG8eP9e2p5wR90eM9wxwjpqGQE\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tTue, 26 Sep 2017 14:03:22 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v1 2/8] tests: Replace fprintf(stderr,\n\t\"*\\n\" with error_report()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-block@nongnu.org, \"Michael S. Tsirkin\" ,\n\tqemu-devel@nongnu.org, armbru@redhat.com,\n\t\"Dr. David Alan Gilbert\" ,\n\tGerd Hoffmann ,\n\tIgor Mammedov , alistair23@gmail.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1776684,"web_url":"http://patchwork.ozlabs.org/comment/1776684/","msgid":"","list_archive_url":null,"date":"2017-09-27T23:08:50","subject":"Re: [Qemu-devel] [PATCH v1 2/8] tests: Replace fprintf(stderr,\n\t\"*\\n\" with error_report()","submitter":{"id":47878,"url":"http://patchwork.ozlabs.org/api/people/47878/","name":"Alistair Francis","email":"alistair.francis@xilinx.com"},"content":"On Mon, Sep 25, 2017 at 5:55 PM, Emilio G. Cota wrote:\n> On Mon, Sep 25, 2017 at 17:08:48 -0700, Alistair Francis wrote:\n>> diff --git a/tests/atomic_add-bench.c b/tests/atomic_add-bench.c\n>> index caa1e8e689..41ba1600c0 100644\n>> --- a/tests/atomic_add-bench.c\n>> +++ b/tests/atomic_add-bench.c\n>> @@ -29,7 +29,7 @@ static const char commands_string[] =\n>> static void usage_complete(char *argv[])\n>> {\n>> fprintf(stderr, \"Usage: %s [options]\\n\", argv[0]);\n>> - fprintf(stderr, \"options:\\n%s\\n\", commands_string);\n>> + fprintf(stderr, \"options:\\n%s\", commands_string);\n>> }\n>\n> We do want that trailing \\n, unless we move it to commands_string.\n\nYeah, this was a mistake. It should have swapped to error_report().\n\n>\n> Also, I think using error_report here would be confusing -- this is a standalone\n> test program with as little QEMU-specific knowledge as possible (QemuThreads\n> are used for portability); using error_report here is confusing (this is not\n> an error).\n\nDo you mean in all tests/ sub directory or just a few certain cases?\n\n>\n>> diff --git a/tests/check-qlit b/tests/check-qlit\n>> new file mode 100755\n>> index 0000000000000000000000000000000000000000..950429524e3eb07e6daed1fe01caad0f5d554809\n>> GIT binary patch\n>> literal 272776\n>> zcmeEvdwf*Ywf~vPB$){zGeCghJ;($So{10*LNEgfoIs*MKvBRDLV(l&F`3b5QKOS6\n>\n> ? I don't know what this is, I don't seem to have this binary in my\n> checked out tree.\n\nYeah, this shouldn't be here.\n\nThanks,\nAlistair\n\n>\n> (snips thousands of lines)\n>\n>> diff --git a/tests/qht-bench.c b/tests/qht-bench.c\n>> index 11c1cec766..2637d601a9 100644\n>> --- a/tests/qht-bench.c\n>> +++ b/tests/qht-bench.c\n>> @@ -5,6 +5,7 @@\n>> * See the COPYING file in the top-level directory.\n>> */\n>> #include \"qemu/osdep.h\"\n>> +#include \"qemu/error-report.h\"\n>> #include \"qemu/processor.h\"\n>> #include \"qemu/atomic.h\"\n>> #include \"qemu/qht.h\"\n>> @@ -89,7 +90,7 @@ static const char commands_string[] =\n>> static void usage_complete(int argc, char *argv[])\n>> {\n>> fprintf(stderr, \"Usage: %s [options]\\n\", argv[0]);\n>> - fprintf(stderr, \"options:\\n%s\\n\", commands_string);\n>> + fprintf(stderr, \"options:\\n%s\", commands_string);\n>\n> Same as above: this removes the necessary trailing \\n.\n>\n>> exit(-1);\n>> }\n>>\n>> @@ -328,7 +329,7 @@ static void htable_init(void)\n>> retries++;\n>> }\n>> }\n>> - fprintf(stderr, \" populated after %zu retries\\n\", retries);\n>> + error_report(\" populated after %zu retries\", retries);\n>> }\n>\n> ditto -- I'd rather keep fprintf(stderr) here, it's less confusing.\n>\n> Thanks,\n>\n> Emilio","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"E8fUkrMB\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2YSH5Fynz9t66\n\tfor ;\n\tThu, 28 Sep 2017 09:09:51 +1000 (AEST)","from localhost ([::1]:56655 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dxLSf-0001SJ-Rg\n\tfor incoming@patchwork.ozlabs.org; Wed, 27 Sep 2017 19:09:49 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:36651)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dxLSF-0001Qj-KS\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 19:09:26 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dxLSE-0004pU-Ht\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 19:09:23 -0400","from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:51972)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dxLSE-0004pE-Ao; Wed, 27 Sep 2017 19:09:22 -0400","by mail-wm0-x244.google.com with SMTP id i131so173805wma.0;\n\tWed, 27 Sep 2017 16:09:22 -0700 (PDT)","by 10.28.135.139 with HTTP; Wed, 27 Sep 2017 16:08:50 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=rp2UqV/jWXRP6V2unol2bkIJSdKUp4rpJFqyAufle4k=;\n\tb=E8fUkrMB3RGnUqBRsqzEjtRlVB968fA8f6xxQh8cXfGHOzS0nXjcKaZiA0WMeYTbfy\n\tvQgHZzpvB0nl3wfs1rl1ILxeXVg/KJ1Zl/z+BO0qOO9bbiluFWJF9Iurr1fNLEsyUko3\n\tAb5h7kIpBg8B1EO34TsDFIeNDMV/iMs0sn0elMYt47+BcJgRvflHE+QjVawzRGkvK3W9\n\tCFKwz1WqnUnynogqGYZZ20U8xZn/Zt4mNn9O/kiX5XAffJQlyJnwFa+1/eIJxvKeDjyP\n\t3VWYAlUajK1nUQ9Bc8jiVi1RnpJ5K1oH0lFP56/sqFsOIUhJ6V3xLCpIkB0dPnolkJQM\n\tslqA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=rp2UqV/jWXRP6V2unol2bkIJSdKUp4rpJFqyAufle4k=;\n\tb=tE2RVn3Sl+450gGpwF1/YHdHkjzGWrP+DHqX74Enx2YAKg01r8GXunAfT0c+gO1mIb\n\tMU3z4xF5YuSxijZ4O0FcHWcLCiHqLvn4Whz/xciSJqQ2VexzxgzfaGyBINkWGcKTEcmg\n\tUujMLYxPFvVsW8Dd6l1KUZ/Z3dP+QJxTHhX6SwJtguohNNjgXa+TxnDbme89wH5iWl6B\n\tfXel5/pfgUNEp1SFt/IjTdrsUrTJ5DETsSn/8yFRSXk5Y1oauh+2SSxuG5u5FZQhp+Lg\n\tDoOhAh65Qjec4spt/HgpwXuI4yRlSiAxIULkzCsJ1VRsdNS0XPt//03gYFvYfPuoazWy\n\tdPAA==","X-Gm-Message-State":"AHPjjUhu+NLAidZYh4w1Phu0xK6BQiujO1kBXiogg1CFi4C1bPwM47Vm\n\tBuTAK9NDMaaPkudOCPuesYUCDhjFO8bMgF4WBOE=","X-Google-Smtp-Source":"AOwi7QBq2arUWQeL3FbmbpUx/3zvaQHmv+9Ov6gtyjzNyLndORUUwFDT/ceK/moi2lGOSHXwmzDDBxQijYTsY1+lKMI=","X-Received":"by 10.28.125.205 with SMTP id y196mr1703531wmc.128.1506553761271;\n\tWed, 27 Sep 2017 16:09:21 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170926005520.GA7906@flamenco>","References":"\n\t<50c325943b1547813567efe6a11fb44644494d70.1506384414.git.alistair.francis@xilinx.com>\n\t<20170926005520.GA7906@flamenco>","From":"Alistair Francis ","Date":"Wed, 27 Sep 2017 16:08:50 -0700","X-Google-Sender-Auth":"83D2Lg9THH4ZhA23rMGmWfTWji4","Message-ID":"","To":"\"Emilio G. Cota\" ","Content-Type":"text/plain; charset=\"UTF-8\"","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::244","Subject":"Re: [Qemu-devel] [PATCH v1 2/8] tests: Replace fprintf(stderr,\n\t\"*\\n\" with error_report()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-block@nongnu.org, \"Michael S. Tsirkin\" ,\n\t\"qemu-devel@nongnu.org Developers\" ,\n\tMarkus Armbruster ,\n\t\"Dr. David Alan Gilbert\" ,\n\tGerd Hoffmann , Igor Mammedov ,\n\tAlistair Francis ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]