[{"id":1775613,"web_url":"http://patchwork.ozlabs.org/comment/1775613/","msgid":"<8095513c-6344-f456-2c79-5a9b97ab691a@linaro.org>","list_archive_url":null,"date":"2017-09-26T15:05:52","subject":"Re: [Qemu-devel] [PATCH v1 7/8] tcg: Replace fprintf(stderr,\n\t\"*\\n\" with error_report()","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 09/25/2017 05:09 PM, Alistair Francis wrote:\n> Replace a large number of the fprintf(stderr, \"*\\n\" calls with\n> error_report(). The functions were renamed with these commands and then\n> compiler issues where manually fixed.\n> \n> find ./* -type f -exec sed -i \\\n>     'N;N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, \"\\(.*\\)\\\\n\"\\(.*\\));|error_report(\"\\1\"\\2);|Ig}' \\\n>     {} +\n> find ./* -type f -exec sed -i \\\n>     'N;N;N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, \"\\(.*\\)\\\\n\"\\(.*\\));|error_report(\"\\1\"\\2);|Ig}' \\\n>     {} +\n> find ./* -type f -exec sed -i \\\n>     'N;N;N;N;N;N;N;N;N; {s|fprintf(stderr, \"\\(.*\\)\\\\n\"\\(.*\\));|error_report(\"\\1\"\\2);|Ig}' \\\n>     {} +\n> find ./* -type f -exec sed -i \\\n>     'N;N;N;N;N;N;N;N; {s|fprintf(stderr, \"\\(.*\\)\\\\n\"\\(.*\\));|error_report(\"\\1\"\\2);|Ig}' \\\n>     {} +\n> find ./* -type f -exec sed -i \\\n>     'N;N;N;N;N;N;N; {s|fprintf(stderr, \"\\(.*\\)\\\\n\"\\(.*\\));|error_report(\"\\1\"\\2);|Ig}' \\\n>     {} +\n> find ./* -type f -exec sed -i \\\n>     'N;N;N;N;N;N; {s|fprintf(stderr, \"\\(.*\\)\\\\n\"\\(.*\\));|error_report(\"\\1\"\\2);|Ig}' \\\n>     {} +\n> find ./* -type f -exec sed -i \\\n>     'N;N;N;N;N; {s|fprintf(stderr, \"\\(.*\\)\\\\n\"\\(.*\\));|error_report(\"\\1\"\\2);|Ig}' \\\n>     {} +\n> find ./* -type f -exec sed -i \\\n>     'N;N;N;N; {s|fprintf(stderr, \"\\(.*\\)\\\\n\"\\(.*\\));|error_report(\"\\1\"\\2);|Ig}' \\\n>     {} +\n> find ./* -type f -exec sed -i \\\n>     'N;N;N; {s|fprintf(stderr, \"\\(.*\\)\\\\n\"\\(.*\\));|error_report(\"\\1\"\\2);|Ig}' \\\n>     {} +\n> find ./* -type f -exec sed -i \\\n>     'N;N; {s|fprintf(stderr, \"\\(.*\\)\\\\n\"\\(.*\\));|error_report(\"\\1\"\\2);|Ig}' \\\n>     {} +\n> find ./* -type f -exec sed -i \\\n>     'N; {s|fprintf(stderr, \"\\(.*\\)\\\\n\"\\(.*\\));|error_report(\"\\1\"\\2);|Ig}' \\\n>     {} +\n> \n> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>\n> Cc: Paolo Bonzini <pbonzini@redhat.com>\n> Cc: Peter Crosthwaite <crosthwaite.peter@gmail.com>\n> Cc: Richard Henderson <rth@twiddle.net>\n> Cc: Stefan Weil <sw@weilnetz.de>\n> ---\n> \n>  cpus.c                   |  8 ++++----\n>  exec.c                   | 14 +++++++-------\n>  tcg/optimize.c           |  8 ++++----\n>  tcg/tcg.c                |  2 +-\n>  tcg/tcg.h                |  3 ++-\n>  tcg/tci.c                |  2 +-\n>  tcg/tci/tcg-target.inc.c |  4 ++--\n>  vl.c                     |  2 +-\n>  8 files changed, 22 insertions(+), 21 deletions(-)\n\nAcked-by: Richard Henderson <richard.henderson@linaro.org>\n\n\nr~","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"UylWxBB1\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1knK6dRCz9t6C\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 27 Sep 2017 01:06:45 +1000 (AEST)","from localhost ([::1]:48023 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dwrRa-0003sd-Gz\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 11:06:42 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:47275)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <richard.henderson@linaro.org>) id 1dwrQx-0003s0-Hq\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 11:06:09 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <richard.henderson@linaro.org>) id 1dwrQr-0002ym-MY\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 11:06:03 -0400","from mail-pf0-x236.google.com ([2607:f8b0:400e:c00::236]:48298)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <richard.henderson@linaro.org>)\n\tid 1dwrQr-0002y7-F8\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 11:05:57 -0400","by mail-pf0-x236.google.com with SMTP id n24so5673468pfk.5\n\tfor <qemu-devel@nongnu.org>; Tue, 26 Sep 2017 08:05:57 -0700 (PDT)","from bigtime.twiddle.net ([70.35.39.2])\n\tby smtp.gmail.com with ESMTPSA id\n\ts4sm15682611pgr.32.2017.09.26.08.05.54\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 26 Sep 2017 08:05:55 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=kXwFdL7MvH2pCWyq9dewneaXqFS+oUvdDJZTOc8Bmro=;\n\tb=UylWxBB1x4alxwfyX88mz6wsG2RcOWbyir5hOtZVBWh8nkQzr117DI/YU2KWMG5+oZ\n\tYXtOrPBws69JwLl8AMhMMPQeeA0D+69VVs0y5KmL9Eudg20J9auE6olwiMFaSRenOyOR\n\tNdDxHXn3pBkowwFbrjWprG1fERrQgSdKJRbIA=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=kXwFdL7MvH2pCWyq9dewneaXqFS+oUvdDJZTOc8Bmro=;\n\tb=Le3P2aooQE4MdYIvY3zxiotjnq6HqUBL8CYLqjSJWvx8xnKBsFpA0rBv5dsMcU23KF\n\thfgVAbS95zIzHNvLYFrPCuBOE0ph+TkVXJcKzxKa5rVzN8BYAsyZSMwhA0QO2SqaJ4kx\n\tw6aLTGUWna51eavHmZtdopfV6hJdMn+crWWvjifp+9xkkFvvuQEGAE2n0OzE3Jr7JSvv\n\tJy9BtHbkgfbFepeyzRfWloWQ0TOajjDfSoNF/gtblzM0hU4nSd3KsZcAQWHXVxIvLplN\n\twyfuwDKDwf2Y+YFhNeczWDYuXr0DsvWLdfzefeXsAl54GsjOzdbhcnWKLgVthUdbq0wE\n\tr3fg==","X-Gm-Message-State":"AHPjjUh6nG+Z5t1WrjD+SwFW5H+HvwdfI1BK66PwW67NBLHxTH9F799U\n\tYD9eF6BoFHIhP+q9GPVEokXjkw==","X-Google-Smtp-Source":"AOwi7QBrN9WOqqeE6yoZZzE2z/v1yjqORNbboNQ80wGJcwSe09UK7vxMMmNH3sNe0zPyt3Nt19aN7g==","X-Received":"by 10.98.17.216 with SMTP id 85mr11123894pfr.206.1506438356365; \n\tTue, 26 Sep 2017 08:05:56 -0700 (PDT)","To":"Alistair Francis <alistair.francis@xilinx.com>, qemu-devel@nongnu.org","References":"<cover.1506384414.git.alistair.francis@xilinx.com>\n\t<c52d7f4dac2d3d209968019d389baa64243d2966.1506384415.git.alistair.francis@xilinx.com>","From":"Richard Henderson <richard.henderson@linaro.org>","Message-ID":"<8095513c-6344-f456-2c79-5a9b97ab691a@linaro.org>","Date":"Tue, 26 Sep 2017 08:05:52 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<c52d7f4dac2d3d209968019d389baa64243d2966.1506384415.git.alistair.francis@xilinx.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400e:c00::236","Subject":"Re: [Qemu-devel] [PATCH v1 7/8] tcg: Replace fprintf(stderr,\n\t\"*\\n\" with error_report()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"alistair23@gmail.com, Stefan Weil <sw@weilnetz.de>,\n\tPeter Crosthwaite <crosthwaite.peter@gmail.com>,\n\tarmbru@redhat.com, Paolo Bonzini <pbonzini@redhat.com>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}}]