[{"id":1788687,"web_url":"http://patchwork.ozlabs.org/comment/1788687/","msgid":"<20171017152646.7e884e4a@plex.home>","list_archive_url":null,"date":"2017-10-17T17:26:46","subject":"Re: [ovs-dev] [PATCH v2 1/3] ovs-save: Use --bundle to restore\n\tflows (on OpenFlow 1.4+)","submitter":{"id":3387,"url":"http://patchwork.ozlabs.org/api/people/3387/","name":"Flavio Leitner","email":"fbl@sysclose.org"},"content":"On Mon, 25 Sep 2017 16:44:04 +0200\nTimothy Redaelli wrote:\n\n> If possible, use OpenFlow 1.4 atomic bundle transaction to restore flows.\n> The patch uses also the highest enabled OpenFlow version to do the queries.\n> \n> With the actual implementation, if you have the default OpenFlow version\n> disabled then ovs-save fails. This patch also fixes that problem.\n> \n> Signed-off-by: Timothy Redaelli \n> ---\n> utilities/ovs-save | 22 +++++++++++++++++++---\n> 1 file changed, 19 insertions(+), 3 deletions(-)\n> \n\nAcked-by: Flavio Leitner \nThanks!\nfbl","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=sysclose.org header.i=fbl@sysclose.org\n\theader.b=\"NrtyIURb\"; dkim-atps=neutral"],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yGhwv4rfFz9t2h\n\tfor ;\n\tWed, 18 Oct 2017 04:28:15 +1100 (AEDT)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 348ACBB3;\n\tTue, 17 Oct 2017 17:28:14 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 08128B92\n\tfor ; Tue, 17 Oct 2017 17:28:13 +0000 (UTC)","from sender-of-o52.zoho.com (sender-of-o52.zoho.com\n\t[135.84.80.217])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 3CEA8F8\n\tfor ; Tue, 17 Oct 2017 17:28:12 +0000 (UTC)","from plex.home (187.95.127.252 [187.95.127.252]) by mx.zohomail.com\n\twith SMTPS id 1508261289432499.05459528150936;\n\tTue, 17 Oct 2017 10:28:09 -0700 (PDT)"],"X-Greylist":"from auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1508261289;\n\ts=zoho; d=sysclose.org; i=fbl@sysclose.org;\n\th=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding;\n\tl=624; bh=IgDloAc0Ep0ffTJkmB8fbcg1GAQoF4KbDq1CP7Csrj0=;\n\tb=NrtyIURbR4A355myGDQb1XqLXhFVuIfVYqjkSu246Sj4OavZb+Z5sNI5QcgNuk/A\n\tquiR+Isj9GA+zxymw+KrR1Kp3Ud5mYsUDNcbzG3gqUG7Y0nMiD17+w9Vqtgcnf5FRwG\n\teRXpsDClelt6MmoicKubRcmYU2aXF1DmrIU6DsuU=","Date":"Tue, 17 Oct 2017 15:26:46 -0200","From":"Flavio Leitner ","To":"Timothy Redaelli ","Message-ID":"<20171017152646.7e884e4a@plex.home>","In-Reply-To":"","References":"\n\t","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)","MIME-Version":"1.0","X-ZohoMailClient":"External","X-Spam-Status":"No, score=-0.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,RCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"dev@openvswitch.org","Subject":"Re: [ovs-dev] [PATCH v2 1/3] ovs-save: Use --bundle to restore\n\tflows (on OpenFlow 1.4+)","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1795034,"web_url":"http://patchwork.ozlabs.org/comment/1795034/","msgid":"<20171027165540.GL27530@ovn.org>","list_archive_url":null,"date":"2017-10-27T16:55:40","subject":"Re: [ovs-dev] [PATCH v2 1/3] ovs-save: Use --bundle to restore\n\tflows (on OpenFlow 1.4+)","submitter":{"id":67603,"url":"http://patchwork.ozlabs.org/api/people/67603/","name":"Ben Pfaff","email":"blp@ovn.org"},"content":"On Mon, Sep 25, 2017 at 04:44:04PM +0200, Timothy Redaelli wrote:\n> If possible, use OpenFlow 1.4 atomic bundle transaction to restore flows.\n> The patch uses also the highest enabled OpenFlow version to do the queries.\n> \n> With the actual implementation, if you have the default OpenFlow version\n> disabled then ovs-save fails. This patch also fixes that problem.\n> \n> Signed-off-by: Timothy Redaelli \n\nThanks for working on this.\n\nThe get_highest_ofp_version might have surprising semantics. The\novs-vsctl command will print protocols in alphabetical order, and\nget_highest_ofp_version assumes that the alphabetically last OpenFlow\nprotocol name is the \"best\". That's currently true, but I am not sure\nthat it will be true forever. What if, instead of taking the last, we\ntook all of them? I believe that ovs-ofctl, given multiple protocols on\n-O, will select the \"best\" or latest itself\n\nSomething like this would do the trick, I guess:\n ovs-vsctl get bridge br0 protocols | tr -d '[]\" '\n\nThis is pretty petty, though. It makes no difference for now. I\napplied this to master.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yNqks3lY8z9t39\n\tfor ;\n\tSat, 28 Oct 2017 03:55:49 +1100 (AEDT)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id B52DDC9D;\n\tFri, 27 Oct 2017 16:55:47 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 18032C9B\n\tfor ; Fri, 27 Oct 2017 16:55:47 +0000 (UTC)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 8B75F4DE\n\tfor ; Fri, 27 Oct 2017 16:55:46 +0000 (UTC)","from ovn.org (unknown [208.91.3.26])\n\t(Authenticated sender: blp@ovn.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 04FE1FB8BF;\n\tFri, 27 Oct 2017 18:55:43 +0200 (CEST)"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-Originating-IP":"208.91.3.26","Date":"Fri, 27 Oct 2017 09:55:40 -0700","From":"Ben Pfaff ","To":"Timothy Redaelli ","Message-ID":"<20171027165540.GL27530@ovn.org>","References":"\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"dev@openvswitch.org","Subject":"Re: [ovs-dev] [PATCH v2 1/3] ovs-save: Use --bundle to restore\n\tflows (on OpenFlow 1.4+)","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}}]