[{"id":1774961,"web_url":"http://patchwork.ozlabs.org/comment/1774961/","msgid":"","list_archive_url":null,"date":"2017-09-25T20:19:52","subject":"Re: [Qemu-devel] [PATCH 4/5] qemu-iotests: Test commit block job\n\twhere top has two parents","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/25/2017 07:28 AM, Kevin Wolf wrote:\n> Signed-off-by: Kevin Wolf \n> ---\n> tests/qemu-iotests/191 | 152 +++++++++\n> tests/qemu-iotests/191.out | 827 +++++++++++++++++++++++++++++++++++++++++++++\n> tests/qemu-iotests/group | 1 +\n> 3 files changed, 980 insertions(+)\n> create mode 100755 tests/qemu-iotests/191\n> create mode 100644 tests/qemu-iotests/191.out\n> \n\n> +\n> +_cleanup()\n> +{\n> + rm -f \"${TEST_IMG}.mid\"\n> + rm -f \"${TEST_IMG}.ovl2\"\n> + rm -f \"${TEST_IMG}.ovl3\"\n> + _cleanup_test_img\n> + _cleanup_qemu\n> +}\n> +trap \"_cleanup; exit \\$status\" 0 1 2 3 15\n\nSemantic conflict with Jeff's work to allow preservation of intermediate\nfiles via './check -s'.\n\n> +++ b/tests/qemu-iotests/191.out\n\n> +{\n> + \"timestamp\": {\n> + \"seconds\": TIMESTAMP,\n> + \"microseconds\": TIMESTAMP\n> + },\n> + \"event\": \"BLOCK_JOB_COMPLETED\",\n> + \"data\": {\n> + \"device\": \"commit0\",\n> + \"len\": 67108864,\n> + \"offset\": 67108864,\n> + \"speed\": 0,\n> + \"type\": \"commit\"\n> + }\n> +}\n\nThis may be sensitive to ordering if I ever finish my patches that allow\nfor QAPI->JSON conversion without having to first go through QObject (as\nit is, it's dependent on QDict's hash being stable, whereas my code\nswitches things to be stable according to QAPI ordering). But that's\nnot a problem for your patch.\n\n\n> + \"data\": {\n> + \"compat\": \"1.1\",\n\nYou should make the test specifically exclude compat=0.10 images, or\nelse have further filtering in place if we can still support this on old\nimages.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1Fnr1QFnz9t2Q\n\tfor ;\n\tTue, 26 Sep 2017 06:20:32 +1000 (AEST)","from localhost ([::1]:44124 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwZri-0007vW-BU\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 16:20:30 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:56204)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwZrF-0007ti-8O\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 16:20:02 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwZrE-00066T-A3\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 16:20:01 -0400","from mx1.redhat.com ([209.132.183.28]:65532)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dwZr9-00063b-Jg; Mon, 25 Sep 2017 16:19:55 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 8B0798048C;\n\tMon, 25 Sep 2017 20:19:54 +0000 (UTC)","from [10.10.124.97] (ovpn-124-97.rdu2.redhat.com [10.10.124.97])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id C030360184;\n\tMon, 25 Sep 2017 20:19:53 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 8B0798048C","To":"Kevin Wolf , qemu-block@nongnu.org","References":"<20170925122808.14561-1-kwolf@redhat.com>\n\t<20170925122808.14561-5-kwolf@redhat.com>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"","Date":"Mon, 25 Sep 2017 15:19:52 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170925122808.14561-5-kwolf@redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"liDnoqm1mJL1Plssi60drtKjWCKa6I4IO\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tMon, 25 Sep 2017 20:19:54 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH 4/5] qemu-iotests: Test commit block job\n\twhere top has two parents","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, mreitz@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1780804,"web_url":"http://patchwork.ozlabs.org/comment/1780804/","msgid":"<20171005162833.GC4416@localhost.localdomain>","list_archive_url":null,"date":"2017-10-05T16:28:33","subject":"Re: [Qemu-devel] [PATCH 4/5] qemu-iotests: Test commit block job\n\twhere top has two parents","submitter":{"id":2714,"url":"http://patchwork.ozlabs.org/api/people/2714/","name":"Kevin Wolf","email":"kwolf@redhat.com"},"content":"Am 25.09.2017 um 22:19 hat Eric Blake geschrieben:\n> On 09/25/2017 07:28 AM, Kevin Wolf wrote:\n> > + \"data\": {\n> > + \"compat\": \"1.1\",\n> \n> You should make the test specifically exclude compat=0.10 images, or\n> else have further filtering in place if we can still support this on old\n> images.\n\nSquashed in a line to this effect:\n\n _unsupported_imgopts compat=0.10\n\nAnd applied the series to the block branch.\n\nKevin","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=kwolf@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y7JdJ0W1yz9t16\n\tfor ;\n\tFri, 6 Oct 2017 03:49:08 +1100 (AEDT)","from localhost ([::1]:40907 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e09Kb-0006K5-RC\n\tfor incoming@patchwork.ozlabs.org; Thu, 05 Oct 2017 12:49:05 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:46777)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e090r-00066y-VF\n\tfor qemu-devel@nongnu.org; Thu, 05 Oct 2017 12:28:42 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e090r-0006Xm-6c\n\tfor qemu-devel@nongnu.org; Thu, 05 Oct 2017 12:28:41 -0400","from mx1.redhat.com ([209.132.183.28]:51776)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1e090m-0006Vp-QV; Thu, 05 Oct 2017 12:28:36 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id E4C09267F5;\n\tThu, 5 Oct 2017 16:28:35 +0000 (UTC)","from localhost.localdomain (ovpn-117-207.ams2.redhat.com\n\t[10.36.117.207])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id C99D66292B;\n\tThu, 5 Oct 2017 16:28:34 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com E4C09267F5","Date":"Thu, 5 Oct 2017 18:28:33 +0200","From":"Kevin Wolf ","To":"Eric Blake ","Message-ID":"<20171005162833.GC4416@localhost.localdomain>","References":"<20170925122808.14561-1-kwolf@redhat.com>\n\t<20170925122808.14561-5-kwolf@redhat.com>\n\t","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"/9DWx/yDrRhgMJTb\"","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.9.0 (2017-09-02)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tThu, 05 Oct 2017 16:28:36 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 4/5] qemu-iotests: Test commit block job\n\twhere top has two parents","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, qemu-block@nongnu.org, mreitz@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]