[{"id":1774970,"web_url":"http://patchwork.ozlabs.org/comment/1774970/","msgid":"<3ab20de4-7111-34cc-5f21-05e68682f097@redhat.com>","list_archive_url":null,"date":"2017-09-25T20:47:37","subject":"Re: [Qemu-devel] [PATCH 5/5] commit: Remove overlay_bs","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/25/2017 07:28 AM, Kevin Wolf wrote:\n> We don't need to make any assumptions about the graph layout above the\n> top node of the commit operation any more. Remove the use of\n> bdrv_find_overlay() and related variables from the commit job code.\n> \n> bdrv_drop_intermediate() doesn't use the 'active' parameter any more, so\n> we can just drop it.\n> \n> The overlay node was previously added to the block job to get a\n> BLK_PERM_GRAPH_MOD. We really need to respect those permissions in\n> bdrv_drop_intermediate() now, but as long as we haven't figured out yet\n> how BLK_PERM_GRAPH_MOD is actually supposed to work, just leave a TODO\n> comment there.\n> \n> With this change, it is now possible to perform another block job on an\n> overlay node without conflicts. qemu-iotests 030 is changed accordingly.\n> \n> Signed-off-by: Kevin Wolf \n> ---\n> include/block/block.h | 3 +--\n> block.c | 6 +++--\n> block/commit.c | 62 ++++++++++++--------------------------------------\n> tests/qemu-iotests/030 | 4 ----\n> 4 files changed, 20 insertions(+), 55 deletions(-)\n> \n\nReviewed-by: Eric Blake ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1GPs0st4z9sRq\n\tfor ;\n\tTue, 26 Sep 2017 06:48:15 +1000 (AEST)","from localhost ([::1]:44218 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwaIV-0000PR-11\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 16:48:11 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:33218)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwaI7-0000Gr-EY\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 16:47:48 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwaI6-00015F-HV\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 16:47:47 -0400","from mx1.redhat.com ([209.132.183.28]:34160)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dwaI1-00013O-3R; Mon, 25 Sep 2017 16:47:41 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 0070B793FB;\n\tMon, 25 Sep 2017 20:47:40 +0000 (UTC)","from [10.10.124.97] (ovpn-124-97.rdu2.redhat.com [10.10.124.97])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id D805360483;\n\tMon, 25 Sep 2017 20:47:38 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 0070B793FB","To":"Kevin Wolf , qemu-block@nongnu.org","References":"<20170925122808.14561-1-kwolf@redhat.com>\n\t<20170925122808.14561-6-kwolf@redhat.com>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"<3ab20de4-7111-34cc-5f21-05e68682f097@redhat.com>","Date":"Mon, 25 Sep 2017 15:47:37 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170925122808.14561-6-kwolf@redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"VOfqbgenhLGAfIVUB0C9sMJobQqQLar6U\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tMon, 25 Sep 2017 20:47:40 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH 5/5] commit: Remove overlay_bs","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, mreitz@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]