[{"id":1774894,"web_url":"http://patchwork.ozlabs.org/comment/1774894/","msgid":"","list_archive_url":null,"date":"2017-09-25T17:58:08","subject":"Re: [Qemu-devel] [PATCH 1/5] block: Introduce\n\tBdrvChildRole.update_filename","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/25/2017 07:28 AM, Kevin Wolf wrote:\n> There is no good reason for bdrv_drop_intermediate() to know the active\n> layer above the subchain it is operating on - even more so, because\n> the assumption that there is a single active layer above it is not\n> generally true.\n> \n> In order to prepare removal of the active parameter, use a BdrvChildRole\n> callback to update the backing file string in the overlay image instead\n> of directly calling bdrv_change_backing_file().\n> \n> Signed-off-by: Kevin Wolf \n> ---\n> include/block/block_int.h | 6 ++++++\n> block.c | 33 ++++++++++++++++++++++++++++-----\n> 2 files changed, 34 insertions(+), 5 deletions(-)\n> \n\nReviewed-by: Eric Blake ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1Bf74XD1z9sRq\n\tfor ;\n\tTue, 26 Sep 2017 03:58:39 +1000 (AEST)","from localhost ([::1]:43667 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwXeP-0003Ce-Qv\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 13:58:37 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:45238)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwXe4-0003BI-L0\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 13:58:17 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwXe3-0008BP-CR\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 13:58:16 -0400","from mx1.redhat.com ([209.132.183.28]:48060)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dwXdy-00087P-PC; Mon, 25 Sep 2017 13:58:11 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id B5C5F81E0D;\n\tMon, 25 Sep 2017 17:58:09 +0000 (UTC)","from [10.10.124.97] (ovpn-124-97.rdu2.redhat.com [10.10.124.97])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 1FD235D9C1;\n\tMon, 25 Sep 2017 17:58:09 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com B5C5F81E0D","To":"Kevin Wolf , qemu-block@nongnu.org","References":"<20170925122808.14561-1-kwolf@redhat.com>\n\t<20170925122808.14561-2-kwolf@redhat.com>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"","Date":"Mon, 25 Sep 2017 12:58:08 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170925122808.14561-2-kwolf@redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"6q3ssT0e5rrCui7egvsFE93fuDcoJRWMD\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tMon, 25 Sep 2017 17:58:09 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH 1/5] block: Introduce\n\tBdrvChildRole.update_filename","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, mreitz@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]