[{"id":1774728,"web_url":"http://patchwork.ozlabs.org/comment/1774728/","msgid":"","list_archive_url":null,"date":"2017-09-25T13:19:28","subject":"Re: [Qemu-devel] [PATCH v2 1/6] migration: pre_save return int","submitter":{"id":2222,"url":"http://patchwork.ozlabs.org/api/people/2222/","name":"Richard Henderson","email":"rth@twiddle.net"},"content":"On 09/25/2017 06:29 AM, Dr. David Alan Gilbert (git) wrote:\n> Modify the pre_save method on VMStateDescription to return an int\n> rather than void so that it potentially can fail.\n\nWhat does the int value signify? Why not a bool?\n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"JlQj4cbq\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y14Sm6PRvz9t3F\n\tfor ;\n\tMon, 25 Sep 2017 23:20:08 +1000 (AEST)","from localhost ([::1]:42423 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwTIt-0005of-0r\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 09:20:07 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:58465)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwTIR-0005oY-NV\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 09:19:45 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwTIL-0007V7-QZ\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 09:19:39 -0400","from mail-pf0-x235.google.com ([2607:f8b0:400e:c00::235]:44419)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1dwTIL-0007N9-LG\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 09:19:33 -0400","by mail-pf0-x235.google.com with SMTP id e1so3777333pfk.1\n\tfor ; Mon, 25 Sep 2017 06:19:32 -0700 (PDT)","from bigtime.twiddle.net ([70.35.39.2])\n\tby smtp.googlemail.com with ESMTPSA id\n\tx8sm11850879pff.104.2017.09.25.06.19.30\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 25 Sep 2017 06:19:30 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=oyb9/HaM9K9r+MxICaYrx3yztOwn0R0Kpmo2BNKluyo=;\n\tb=JlQj4cbqMNn8t03DAOaJA3TlAhQ+PiE8nq/5+l4nMid/QMrmCYg5CiElxI5LxhxRkf\n\tDJo4a3D352p38Edzaz/YPVxCfvmIrSp9eCWyfjlizUx7zmNsUIYN9O7IRcPUJJ0BkiIz\n\tYF/j3H22vYw56ttCfyLNftM/E2rzE7A1QZ/1seHzWoOd6kWxJBO1UJgvUO07qA3tobe+\n\tm4v9AROjVZ1zzLs9GLCVIrZ/n5Et0j+vm5j4JR2aWm9XtZ8FqsLKHY6QVEipxuIsbR22\n\tk5wgUw6gtDBDvgn7pPTYjq+6Zh9LaFOnDoObT5o+y5fHRk5d90yZW/JIw5xVXO62X8CZ\n\tJXpA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=oyb9/HaM9K9r+MxICaYrx3yztOwn0R0Kpmo2BNKluyo=;\n\tb=DebzvI2qhAOy/HSXZmmI3sBl7shc4McQug8B3jdI9WCdw54X23/jovsek6h8ppjlW0\n\tr1FQnF41QYTGonuNdCb1G7KK5d5844ehFXOIUuyk1w7PjI0IyZg9kJ0UYI036DSPuVmv\n\t5LTt1d4XhOwv+SeqTkgFgGsOv1WMNw677CZ5G4majq1zGEdf4K3ZdJZ2BLhH/OAuwrqp\n\t2PPSEMPcRVga40XoXmH1jUB1op1D/i2it217ZIdv0Ko+qSAQwJDV/NqiVw9f8j4lcvKr\n\tVfuwO/fXh7m97/HzvXM8n9N04G17sGoZDTotY6JqTiXhgpnCkAvuccs5fmx8GSBr1mqP\n\takXQ==","X-Gm-Message-State":"AHPjjUheS0la6wd2e2lZ9wLOsev/nk8i80/iKweeOEINRrBjBHPj2F8Q\n\tJALbqU54bPU8dZIVG3fdkX8=","X-Google-Smtp-Source":"AOwi7QAy+Nnw+HsCguwGep8DWUDNNUoeLNrP1uwY+oJW3Zy3THhEAu8tNk6qwmip5dOjyNW4Qv9PUA==","X-Received":"by 10.99.173.67 with SMTP id y3mr7689886pgo.69.1506345571037;\n\tMon, 25 Sep 2017 06:19:31 -0700 (PDT)","To":"\"Dr. David Alan Gilbert (git)\" ,\n\tqemu-devel@nongnu.org, quintela@redhat.com, peterx@redhat.com,\n\tfamz@redhat.com","References":"<20170925112917.21340-1-dgilbert@redhat.com>\n\t<20170925112917.21340-2-dgilbert@redhat.com>","From":"Richard Henderson ","Message-ID":"","Date":"Mon, 25 Sep 2017 08:19:28 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170925112917.21340-2-dgilbert@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400e:c00::235","Subject":"Re: [Qemu-devel] [PATCH v2 1/6] migration: pre_save return int","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"peter.maydell@linaro.org, cohuck@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1774732,"web_url":"http://patchwork.ozlabs.org/comment/1774732/","msgid":"<20170925132514.GF2656@work-vm>","list_archive_url":null,"date":"2017-09-25T13:25:15","subject":"Re: [Qemu-devel] [PATCH v2 1/6] migration: pre_save return int","submitter":{"id":48102,"url":"http://patchwork.ozlabs.org/api/people/48102/","name":"Dr. David Alan Gilbert","email":"dgilbert@redhat.com"},"content":"* Richard Henderson (rth@twiddle.net) wrote:\n> On 09/25/2017 06:29 AM, Dr. David Alan Gilbert (git) wrote:\n> > Modify the pre_save method on VMStateDescription to return an int\n> > rather than void so that it potentially can fail.\n> \n> What does the int value signify?\n\n0 is success, anything else is a failure; typically -errno.\n\n> Why not a bool?\n\nConsistency with pre_load, post_load, put and get methods\nthat are already int.\n\nDave\n\n> \n> r~\n--\nDr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=dgilbert@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y14bK6HV9z9tX8\n\tfor ;\n\tMon, 25 Sep 2017 23:25:49 +1000 (AEST)","from localhost ([::1]:42445 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwTOO-0008UR-16\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 09:25:48 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:59614)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwTO5-0008UL-U4\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 09:25:30 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwTO0-0002Ir-S2\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 09:25:29 -0400","from mx1.redhat.com ([209.132.183.28]:49674)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dwTO0-0002FW-Lw\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 09:25:24 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id B500B4E4C6;\n\tMon, 25 Sep 2017 13:25:23 +0000 (UTC)","from work-vm (ovpn-116-100.ams2.redhat.com [10.36.116.100])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id DFCD96C94A;\n\tMon, 25 Sep 2017 13:25:17 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com B500B4E4C6","Date":"Mon, 25 Sep 2017 14:25:15 +0100","From":"\"Dr. David Alan Gilbert\" ","To":"Richard Henderson ","Message-ID":"<20170925132514.GF2656@work-vm>","References":"<20170925112917.21340-1-dgilbert@redhat.com>\n\t<20170925112917.21340-2-dgilbert@redhat.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tMon, 25 Sep 2017 13:25:23 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 1/6] migration: pre_save return int","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"peter.maydell@linaro.org, famz@redhat.com, quintela@redhat.com,\n\tcohuck@redhat.com, qemu-devel@nongnu.org, peterx@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1774734,"web_url":"http://patchwork.ozlabs.org/comment/1774734/","msgid":"","list_archive_url":null,"date":"2017-09-25T13:29:43","subject":"Re: [Qemu-devel] [PATCH v2 1/6] migration: pre_save return int","submitter":{"id":2222,"url":"http://patchwork.ozlabs.org/api/people/2222/","name":"Richard Henderson","email":"rth@twiddle.net"},"content":"On 09/25/2017 06:25 AM, Dr. David Alan Gilbert wrote:\n>> Why not a bool?\n> \n> Consistency with pre_load, post_load, put and get methods\n> that are already int.\n\nFair enough, thanks.\n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"XCeUz9fM\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y14hZ18D8z9t5c\n\tfor ;\n\tMon, 25 Sep 2017 23:30:20 +1000 (AEST)","from localhost ([::1]:42448 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwTSj-0000rZ-H5\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 09:30:17 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:60210)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwTSI-0000rH-Jq\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 09:29:54 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwTSF-000535-Gs\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 09:29:50 -0400","from mail-pg0-x241.google.com ([2607:f8b0:400e:c05::241]:38414)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1dwTSF-00050x-Ac\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 09:29:47 -0400","by mail-pg0-x241.google.com with SMTP id m30so4869371pgn.5\n\tfor ; Mon, 25 Sep 2017 06:29:47 -0700 (PDT)","from bigtime.twiddle.net ([70.35.39.2])\n\tby smtp.googlemail.com with ESMTPSA id\n\tm190sm12592371pga.2.2017.09.25.06.29.45\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 25 Sep 2017 06:29:45 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=rbRTBSNZ7r3GU4hK+rKq7sEf1UBdZUWCYMNSH00lD8c=;\n\tb=XCeUz9fMhXq47Mg9p7h/myxkLq8uj3xw0p3n3680Js9pTUaa72gM0KX2vNsfC+RYxV\n\tvo5Hi9dN8Lo7wMXbuv0QfKD9fp6pzW7HIGr4wY1m0kef8xupHrfH0KBh2mY4laCvO3iu\n\tkvpDy+NMpg5yDwI2/CPHP5U7yyFZ/QUTSypQuz/uTKp0fqLeBSw/evrHtHg8WmFAxf9C\n\tMCeJa632EzLqvMfN6NWRJLSuWaW7vXRyRdERfT0qFBQdPAkK6bljeRPUrqtd9ebFrV3J\n\t72giCF2VMeA6rqlRW6tIeFW0/NaeKYN+CGFsIp9eeqNmO7L3Sb72sH7Nqn8/yW+Iajl4\n\tlZ8g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=rbRTBSNZ7r3GU4hK+rKq7sEf1UBdZUWCYMNSH00lD8c=;\n\tb=QwQUGjKu4eHZK2ing4XojSKWkXyCQKYAiKXQBP420C7/b/ZzofcgOe57Ha1wboqV+h\n\tSdOGllUFYrSEUtesaYAAQ1ZbyijEoEDcP4nb3K67KSyBC24mn9HEnJ9XqK+FRmMLn3lH\n\tQQz+bAsjYxTqQgsq3yj70ZjIBAA7+mGMelW0UycsHiUUVB/6pz5jZA10HjR+l2U5V2CG\n\trLvs//giGnhSen58Xn/pqoHbz2zzzY3RIvdqi35NOP3nET4hLRNPuYneGueBZ+/bpNQu\n\t2fSf7B6MNC/ho0AuHIE7JjwzBxQQT6XxV32E+WAFZZ+p2DGSyibPjlvyUccCTF9kXQG1\n\tClZg==","X-Gm-Message-State":"AHPjjUgeanWZIatOjI8nujrz5DOG/qy1wuqQXcYzVqNVNL9rw4juqxU1\n\teVjBpGKDbe3CsDsNQpCjUlA=","X-Google-Smtp-Source":"AOwi7QCoI3i69xDgEIhmUvtQJEFncJVPc0GqeFaspF7ojiG8PutOw3eIBQDN/9u7KjWGunJuS8xqgQ==","X-Received":"by 10.98.75.193 with SMTP id d62mr7671834pfj.281.1506346186350; \n\tMon, 25 Sep 2017 06:29:46 -0700 (PDT)","To":"\"Dr. David Alan Gilbert\" ","References":"<20170925112917.21340-1-dgilbert@redhat.com>\n\t<20170925112917.21340-2-dgilbert@redhat.com>\n\t\n\t<20170925132514.GF2656@work-vm>","From":"Richard Henderson ","Message-ID":"","Date":"Mon, 25 Sep 2017 06:29:43 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170925132514.GF2656@work-vm>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400e:c05::241","Subject":"Re: [Qemu-devel] [PATCH v2 1/6] migration: pre_save return int","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"peter.maydell@linaro.org, famz@redhat.com, quintela@redhat.com,\n\tcohuck@redhat.com, qemu-devel@nongnu.org, peterx@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1775098,"web_url":"http://patchwork.ozlabs.org/comment/1775098/","msgid":"<20170926023115.GF19505@pxdev.xzpeter.org>","list_archive_url":null,"date":"2017-09-26T02:31:15","subject":"Re: [Qemu-devel] [PATCH v2 1/6] migration: pre_save return int","submitter":{"id":67717,"url":"http://patchwork.ozlabs.org/api/people/67717/","name":"Peter Xu","email":"peterx@redhat.com"},"content":"On Mon, Sep 25, 2017 at 12:29:12PM +0100, Dr. David Alan Gilbert (git) wrote:\n> From: \"Dr. David Alan Gilbert\" \n> \n> Modify the pre_save method on VMStateDescription to return an int\n> rather than void so that it potentially can fail.\n> \n> Changed zillions of devices to make them return 0; the only\n> case I've made it return non-0 is hw/intc/s390_flic_kvm.c that already\n> had an error_report/return case.\n> \n> Note: If you add an error exit in your pre_save you must emit\n> an error_report to say why.\n> \n> Signed-off-by: Dr. David Alan Gilbert \n\nReviewed-by: Peter Xu ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=peterx@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1Q2G35cTz9sPk\n\tfor ;\n\tTue, 26 Sep 2017 12:31:48 +1000 (AEST)","from localhost ([::1]:45265 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwfez-0006uh-HI\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 22:31:45 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:50577)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwfeh-0006uX-QD\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 22:31:28 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwfec-0003b3-Ts\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 22:31:27 -0400","from mx1.redhat.com ([209.132.183.28]:56190)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dwfec-0003a0-OL\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 22:31:22 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 90612C0587F5;\n\tTue, 26 Sep 2017 02:31:21 +0000 (UTC)","from pxdev.xzpeter.org (dhcp-15-224.nay.redhat.com [10.66.15.224])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 7261B77D7E;\n\tTue, 26 Sep 2017 02:31:17 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 90612C0587F5","Date":"Tue, 26 Sep 2017 10:31:15 +0800","From":"Peter Xu ","To":"\"Dr. David Alan Gilbert (git)\" ","Message-ID":"<20170926023115.GF19505@pxdev.xzpeter.org>","References":"<20170925112917.21340-1-dgilbert@redhat.com>\n\t<20170925112917.21340-2-dgilbert@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20170925112917.21340-2-dgilbert@redhat.com>","User-Agent":"Mutt/1.5.24 (2015-08-30)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tTue, 26 Sep 2017 02:31:21 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 1/6] migration: pre_save return int","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"peter.maydell@linaro.org, famz@redhat.com, quintela@redhat.com,\n\tcohuck@redhat.com, qemu-devel@nongnu.org, rth@twiddle.net","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1775496,"web_url":"http://patchwork.ozlabs.org/comment/1775496/","msgid":"<20170926152746.1bd31900.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-26T13:27:46","subject":"Re: [Qemu-devel] [PATCH v2 1/6] migration: pre_save return int","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Mon, 25 Sep 2017 12:29:12 +0100\n\"Dr. David Alan Gilbert (git)\" wrote:\n\n> From: \"Dr. David Alan Gilbert\" \n> \n> Modify the pre_save method on VMStateDescription to return an int\n> rather than void so that it potentially can fail.\n> \n> Changed zillions of devices to make them return 0; the only\n> case I've made it return non-0 is hw/intc/s390_flic_kvm.c that already\n> had an error_report/return case.\n> \n> Note: If you add an error exit in your pre_save you must emit\n> an error_report to say why.\n> \n> Signed-off-by: Dr. David Alan Gilbert \n> ---\n> docs/devel/migration.txt | 2 +-\n> hw/arm/pxa2xx.c | 4 +++-\n> hw/arm/strongarm.c | 4 +++-\n> hw/audio/wm8750.c | 4 +++-\n> hw/block/fdc.c | 4 +++-\n> hw/block/m25p80.c | 4 +++-\n> hw/block/nand.c | 4 +++-\n> hw/block/onenand.c | 4 +++-\n> hw/char/serial.c | 4 +++-\n> hw/display/qxl.c | 4 +++-\n> hw/i2c/core.c | 4 +++-\n> hw/i386/kvm/clock.c | 4 +++-\n> hw/ide/core.c | 4 +++-\n> hw/ide/pci.c | 4 +++-\n> hw/input/ps2.c | 8 ++++++--\n> hw/input/tsc210x.c | 4 +++-\n> hw/intc/apic_common.c | 4 +++-\n> hw/intc/arm_gic_common.c | 4 +++-\n> hw/intc/arm_gicv3_common.c | 4 +++-\n> hw/intc/arm_gicv3_its_common.c | 4 +++-\n> hw/intc/i8259_common.c | 4 +++-\n> hw/intc/ioapic_common.c | 4 +++-\n> hw/intc/s390_flic_kvm.c | 6 ++++--\n> hw/intc/xics.c | 8 ++++++--\n> hw/net/e1000.c | 4 +++-\n> hw/net/e1000e.c | 4 +++-\n> hw/net/rtl8139.c | 4 +++-\n> hw/net/virtio-net.c | 16 ++++++++++++----\n> hw/net/vmxnet3.c | 4 +++-\n> hw/pci-host/piix.c | 4 +++-\n> hw/ppc/ppc.c | 4 +++-\n> hw/ppc/spapr_iommu.c | 4 +++-\n> hw/ppc/spapr_pci.c | 6 ++++--\n> hw/s390x/css.c | 10 +++++++---\n> hw/s390x/virtio-ccw.c | 4 +++-\n> hw/scsi/lsi53c895a.c | 4 +++-\n> hw/scsi/vmw_pvscsi.c | 4 +++-\n> hw/timer/cadence_ttc.c | 4 +++-\n> hw/timer/hpet.c | 4 +++-\n> hw/timer/i8254_common.c | 4 +++-\n> hw/timer/mc146818rtc.c | 4 +++-\n> hw/timer/pl031.c | 4 +++-\n> hw/timer/twl92230.c | 4 +++-\n> hw/usb/dev-smartcard-reader.c | 4 +++-\n> hw/usb/hcd-ehci.c | 4 +++-\n> hw/usb/redirect.c | 4 +++-\n> hw/virtio/vhost-vsock.c | 4 +++-\n> include/migration/vmstate.h | 2 +-\n> migration/colo-comm.c | 4 +++-\n> migration/global_state.c | 4 +++-\n> migration/savevm.c | 4 +++-\n> replay/replay-snapshot.c | 4 +++-\n> slirp/slirp.c | 8 ++++++--\n> target/arm/machine.c | 4 +++-\n> target/i386/machine.c | 7 +++++--\n> target/ppc/machine.c | 4 +++-\n> target/s390x/machine.c | 4 +++-\n> target/sparc/machine.c | 4 +++-\n> tests/test-vmstate.c | 4 +++-\n> 59 files changed, 199 insertions(+), 70 deletions(-)\n\nReviewed-by: Cornelia Huck ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1hc10PjJz9tXq\n\tfor ;\n\tTue, 26 Sep 2017 23:28:31 +1000 (AEST)","from localhost ([::1]:47559 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwpuX-0001HB-3v\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 09:28:29 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:46635)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwpu3-0001GR-N3\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 09:28:05 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwptz-0001Te-NN\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 09:27:59 -0400","from mx1.redhat.com ([209.132.183.28]:41502)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dwptz-0001SF-EZ\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 09:27:55 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 3FE0786647;\n\tTue, 26 Sep 2017 13:27:54 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 785CF183C4;\n\tTue, 26 Sep 2017 13:27:48 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 3FE0786647","Date":"Tue, 26 Sep 2017 15:27:46 +0200","From":"Cornelia Huck ","To":"\"Dr. David Alan Gilbert (git)\" ","Message-ID":"<20170926152746.1bd31900.cohuck@redhat.com>","In-Reply-To":"<20170925112917.21340-2-dgilbert@redhat.com>","References":"<20170925112917.21340-1-dgilbert@redhat.com>\n\t<20170925112917.21340-2-dgilbert@redhat.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tTue, 26 Sep 2017 13:27:54 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 1/6] migration: pre_save return int","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"peter.maydell@linaro.org, famz@redhat.com, quintela@redhat.com,\n\tqemu-devel@nongnu.org, peterx@redhat.com, rth@twiddle.net","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1776142,"web_url":"http://patchwork.ozlabs.org/comment/1776142/","msgid":"<8760c4cydj.fsf@secure.laptop>","list_archive_url":null,"date":"2017-09-27T08:57:28","subject":"Re: [Qemu-devel] [PATCH v2 1/6] migration: pre_save return int","submitter":{"id":2643,"url":"http://patchwork.ozlabs.org/api/people/2643/","name":"Juan Quintela","email":"quintela@redhat.com"},"content":"\"Dr. David Alan Gilbert (git)\" wrote:\n> From: \"Dr. David Alan Gilbert\" \n>\n> Modify the pre_save method on VMStateDescription to return an int\n> rather than void so that it potentially can fail.\n>\n> Changed zillions of devices to make them return 0; the only\n> case I've made it return non-0 is hw/intc/s390_flic_kvm.c that already\n> had an error_report/return case.\n>\n> Note: If you add an error exit in your pre_save you must emit\n> an error_report to say why.\n>\n> Signed-off-by: Dr. David Alan Gilbert \n\nReviewed-by: Juan Quintela ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=quintela@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2BYT30Mmz9tXC\n\tfor ;\n\tWed, 27 Sep 2017 18:58:05 +1000 (AEST)","from localhost ([::1]:53467 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dx8AN-0002Jd-HZ\n\tfor incoming@patchwork.ozlabs.org; Wed, 27 Sep 2017 04:58:03 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:47238)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dx89t-0002Hc-8a\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 04:57:34 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dx89o-0002hV-EV\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 04:57:33 -0400","from mx1.redhat.com ([209.132.183.28]:40136)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dx89o-0002gy-9Q\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 04:57:28 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id A82857E430;\n\tWed, 27 Sep 2017 08:57:26 +0000 (UTC)","from localhost (ovpn-117-142.ams2.redhat.com [10.36.117.142])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 9516577E86;\n\tWed, 27 Sep 2017 08:57:22 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com A82857E430","From":"Juan Quintela ","To":"\"Dr. David Alan Gilbert \\(git\\)\" ","In-Reply-To":"<20170925112917.21340-2-dgilbert@redhat.com> (David Alan\n\tGilbert's message of \"Mon, 25 Sep 2017 12:29:12 +0100\")","References":"<20170925112917.21340-1-dgilbert@redhat.com>\n\t<20170925112917.21340-2-dgilbert@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)","Date":"Wed, 27 Sep 2017 10:57:28 +0200","Message-ID":"<8760c4cydj.fsf@secure.laptop>","MIME-Version":"1.0","Content-Type":"text/plain","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tWed, 27 Sep 2017 08:57:26 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 1/6] migration: pre_save return int","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"quintela@redhat.com","Cc":"peter.maydell@linaro.org, famz@redhat.com, cohuck@redhat.com,\n\tqemu-devel@nongnu.org, peterx@redhat.com, rth@twiddle.net","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]