[{"id":1775102,"web_url":"http://patchwork.ozlabs.org/comment/1775102/","msgid":"<20170926025655.GJ19505@pxdev.xzpeter.org>","list_archive_url":null,"date":"2017-09-26T02:56:55","subject":"Re: [Qemu-devel] [PATCH v2 5/6] migration: Route errors up through\n\tvmstate_save","submitter":{"id":67717,"url":"http://patchwork.ozlabs.org/api/people/67717/","name":"Peter Xu","email":"peterx@redhat.com"},"content":"On Mon, Sep 25, 2017 at 12:29:16PM +0100, Dr. David Alan Gilbert (git) wrote:\n> From: \"Dr. David Alan Gilbert\" <dgilbert@redhat.com>\n> \n> Route the errors from vsmtate_save_state back up through\n> vmstate_save and out to the normal device state path.\n> That's the normal error path done.\n> \n> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>\n\nReviewed-by: Peter Xu <peterx@redhat.com>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=peterx@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1Qbs4vtPz9t3F\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 26 Sep 2017 12:57:28 +1000 (AEST)","from localhost ([::1]:45314 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dwg3p-0003m6-T6\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 22:57:25 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:54825)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <peterx@redhat.com>) id 1dwg3X-0003ln-C6\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 22:57:08 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <peterx@redhat.com>) id 1dwg3T-00071R-GR\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 22:57:07 -0400","from mx1.redhat.com ([209.132.183.28]:35830)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <peterx@redhat.com>) id 1dwg3T-000711-9R\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 22:57:03 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id D26D281E06;\n\tTue, 26 Sep 2017 02:57:01 +0000 (UTC)","from pxdev.xzpeter.org (dhcp-15-224.nay.redhat.com [10.66.15.224])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id AE9F16294C;\n\tTue, 26 Sep 2017 02:56:57 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com D26D281E06","Date":"Tue, 26 Sep 2017 10:56:55 +0800","From":"Peter Xu <peterx@redhat.com>","To":"\"Dr. David Alan Gilbert (git)\" <dgilbert@redhat.com>","Message-ID":"<20170926025655.GJ19505@pxdev.xzpeter.org>","References":"<20170925112917.21340-1-dgilbert@redhat.com>\n\t<20170925112917.21340-6-dgilbert@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20170925112917.21340-6-dgilbert@redhat.com>","User-Agent":"Mutt/1.5.24 (2015-08-30)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tTue, 26 Sep 2017 02:57:01 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 5/6] migration: Route errors up through\n\tvmstate_save","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"peter.maydell@linaro.org, famz@redhat.com, quintela@redhat.com,\n\tcohuck@redhat.com, qemu-devel@nongnu.org, rth@twiddle.net","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1775512,"web_url":"http://patchwork.ozlabs.org/comment/1775512/","msgid":"<20170926153656.4b715383.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-26T13:36:56","subject":"Re: [Qemu-devel] [PATCH v2 5/6] migration: Route errors up through\n\tvmstate_save","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Mon, 25 Sep 2017 12:29:16 +0100\n\"Dr. David Alan Gilbert (git)\" <dgilbert@redhat.com> wrote:\n\n> From: \"Dr. David Alan Gilbert\" <dgilbert@redhat.com>\n> \n> Route the errors from vsmtate_save_state back up through\n> vmstate_save and out to the normal device state path.\n> That's the normal error path done.\n> \n> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>\n> ---\n>  migration/savevm.c | 19 ++++++++++++++-----\n>  1 file changed, 14 insertions(+), 5 deletions(-)\n\nReviewed-by: Cornelia Huck <cohuck@redhat.com>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1hry5b1Vz9s7M\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 26 Sep 2017 23:39:46 +1000 (AEST)","from localhost ([::1]:47599 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dwq5Q-0007gK-PX\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 09:39:44 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:49165)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <cohuck@redhat.com>) id 1dwq32-0006EH-B7\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 09:37:17 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <cohuck@redhat.com>) id 1dwq2z-0007q0-4o\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 09:37:16 -0400","from mx1.redhat.com ([209.132.183.28]:26092)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <cohuck@redhat.com>) id 1dwq2y-0007pT-UB\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 09:37:13 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 018957E44A;\n\tTue, 26 Sep 2017 13:37:12 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 7A67977A04;\n\tTue, 26 Sep 2017 13:36:58 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 018957E44A","Date":"Tue, 26 Sep 2017 15:36:56 +0200","From":"Cornelia Huck <cohuck@redhat.com>","To":"\"Dr. David Alan Gilbert (git)\" <dgilbert@redhat.com>","Message-ID":"<20170926153656.4b715383.cohuck@redhat.com>","In-Reply-To":"<20170925112917.21340-6-dgilbert@redhat.com>","References":"<20170925112917.21340-1-dgilbert@redhat.com>\n\t<20170925112917.21340-6-dgilbert@redhat.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tTue, 26 Sep 2017 13:37:12 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 5/6] migration: Route errors up through\n\tvmstate_save","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"peter.maydell@linaro.org, famz@redhat.com, quintela@redhat.com,\n\tqemu-devel@nongnu.org, peterx@redhat.com, rth@twiddle.net","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1776152,"web_url":"http://patchwork.ozlabs.org/comment/1776152/","msgid":"<87o9pwbjnl.fsf@secure.laptop>","list_archive_url":null,"date":"2017-09-27T09:00:46","subject":"Re: [Qemu-devel] [PATCH v2 5/6] migration: Route errors up through\n\tvmstate_save","submitter":{"id":2643,"url":"http://patchwork.ozlabs.org/api/people/2643/","name":"Juan Quintela","email":"quintela@redhat.com"},"content":"\"Dr. David Alan Gilbert (git)\" <dgilbert@redhat.com> wrote:\n> From: \"Dr. David Alan Gilbert\" <dgilbert@redhat.com>\n>\n> Route the errors from vsmtate_save_state back up through\n> vmstate_save and out to the normal device state path.\n> That's the normal error path done.\n>\n> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>\n\nReviewed-by: Juan Quintela <quintela@redhat.com>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=quintela@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2Bhm3Zwzz9tXT\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 27 Sep 2017 19:04:24 +1000 (AEST)","from localhost ([::1]:53511 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dx8GU-00079w-KG\n\tfor incoming@patchwork.ozlabs.org; Wed, 27 Sep 2017 05:04:22 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:48437)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <quintela@redhat.com>) id 1dx8D8-0004vX-AC\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 05:00:55 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <quintela@redhat.com>) id 1dx8Cy-00050j-TS\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 05:00:54 -0400","from mx1.redhat.com ([209.132.183.28]:59918)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <quintela@redhat.com>) id 1dx8Cy-000503-Ns\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 05:00:44 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 9FA05C0828D9;\n\tWed, 27 Sep 2017 09:00:43 +0000 (UTC)","from localhost (ovpn-117-142.ams2.redhat.com [10.36.117.142])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 81D0F7ED83;\n\tWed, 27 Sep 2017 09:00:39 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 9FA05C0828D9","From":"Juan Quintela <quintela@redhat.com>","To":"\"Dr. David Alan Gilbert \\(git\\)\" <dgilbert@redhat.com>","In-Reply-To":"<20170925112917.21340-6-dgilbert@redhat.com> (David Alan\n\tGilbert's message of \"Mon, 25 Sep 2017 12:29:16 +0100\")","References":"<20170925112917.21340-1-dgilbert@redhat.com>\n\t<20170925112917.21340-6-dgilbert@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)","Date":"Wed, 27 Sep 2017 11:00:46 +0200","Message-ID":"<87o9pwbjnl.fsf@secure.laptop>","MIME-Version":"1.0","Content-Type":"text/plain","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tWed, 27 Sep 2017 09:00:43 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 5/6] migration: Route errors up through\n\tvmstate_save","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Reply-To":"quintela@redhat.com","Cc":"peter.maydell@linaro.org, famz@redhat.com, cohuck@redhat.com,\n\tqemu-devel@nongnu.org, peterx@redhat.com, rth@twiddle.net","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}}]