[{"id":1775099,"web_url":"http://patchwork.ozlabs.org/comment/1775099/","msgid":"<20170926023658.GG19505@pxdev.xzpeter.org>","list_archive_url":null,"date":"2017-09-26T02:36:58","subject":"Re: [Qemu-devel] [PATCH v2 2/6] migration: check pre_save return in\n\tvmstate_save_state","submitter":{"id":67717,"url":"http://patchwork.ozlabs.org/api/people/67717/","name":"Peter Xu","email":"peterx@redhat.com"},"content":"On Mon, Sep 25, 2017 at 12:29:13PM +0100, Dr. David Alan Gilbert (git) wrote:\n> From: \"Dr. David Alan Gilbert\" \n> \n> Check the return value of pre_save state and fail vmstate_save_state\n> if the pre_save failed.\n> \n> Signed-off-by: Dr. David Alan Gilbert \n\nReviewed-by: Peter Xu ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=peterx@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1Q8r6tc6z9sPk\n\tfor ;\n\tTue, 26 Sep 2017 12:37:31 +1000 (AEST)","from localhost ([::1]:45275 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwfkX-00009g-5d\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 22:37:29 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:51551)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwfkF-00009I-OO\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 22:37:12 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwfkA-0005uc-SI\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 22:37:11 -0400","from mx1.redhat.com ([209.132.183.28]:33608)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dwfkA-0005uO-MB\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 22:37:06 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 91921C058EA9;\n\tTue, 26 Sep 2017 02:37:05 +0000 (UTC)","from pxdev.xzpeter.org (dhcp-15-224.nay.redhat.com [10.66.15.224])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id DAAA969A56;\n\tTue, 26 Sep 2017 02:37:00 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 91921C058EA9","Date":"Tue, 26 Sep 2017 10:36:58 +0800","From":"Peter Xu ","To":"\"Dr. David Alan Gilbert (git)\" ","Message-ID":"<20170926023658.GG19505@pxdev.xzpeter.org>","References":"<20170925112917.21340-1-dgilbert@redhat.com>\n\t<20170925112917.21340-3-dgilbert@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20170925112917.21340-3-dgilbert@redhat.com>","User-Agent":"Mutt/1.5.24 (2015-08-30)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tTue, 26 Sep 2017 02:37:05 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 2/6] migration: check pre_save return in\n\tvmstate_save_state","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"peter.maydell@linaro.org, famz@redhat.com, quintela@redhat.com,\n\tcohuck@redhat.com, qemu-devel@nongnu.org, rth@twiddle.net","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1775499,"web_url":"http://patchwork.ozlabs.org/comment/1775499/","msgid":"<20170926152924.65d377d2.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-26T13:29:24","subject":"Re: [Qemu-devel] [PATCH v2 2/6] migration: check pre_save return in\n\tvmstate_save_state","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Mon, 25 Sep 2017 12:29:13 +0100\n\"Dr. David Alan Gilbert (git)\" wrote:\n\n> From: \"Dr. David Alan Gilbert\" \n> \n> Check the return value of pre_save state and fail vmstate_save_state\n> if the pre_save failed.\n> \n> Signed-off-by: Dr. David Alan Gilbert \n> ---\n> include/migration/vmstate.h | 4 ++--\n> migration/trace-events | 1 +\n> migration/vmstate.c | 12 ++++++++++--\n> 3 files changed, 13 insertions(+), 4 deletions(-)\n\nReviewed-by: Cornelia Huck ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1hfD03HVz9tXH\n\tfor ;\n\tTue, 26 Sep 2017 23:30:28 +1000 (AEST)","from localhost ([::1]:47563 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwpwQ-0002Il-4T\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 09:30:26 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:47057)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwpvq-0002FF-Qx\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 09:29:56 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwpvn-0002YW-MC\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 09:29:50 -0400","from mx1.redhat.com ([209.132.183.28]:46830)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dwpvn-0002XN-GD\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 09:29:47 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 88AF17E443;\n\tTue, 26 Sep 2017 13:29:46 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 1D3807812B;\n\tTue, 26 Sep 2017 13:29:27 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 88AF17E443","Date":"Tue, 26 Sep 2017 15:29:24 +0200","From":"Cornelia Huck ","To":"\"Dr. David Alan Gilbert (git)\" ","Message-ID":"<20170926152924.65d377d2.cohuck@redhat.com>","In-Reply-To":"<20170925112917.21340-3-dgilbert@redhat.com>","References":"<20170925112917.21340-1-dgilbert@redhat.com>\n\t<20170925112917.21340-3-dgilbert@redhat.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tTue, 26 Sep 2017 13:29:46 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 2/6] migration: check pre_save return in\n\tvmstate_save_state","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"peter.maydell@linaro.org, famz@redhat.com, quintela@redhat.com,\n\tqemu-devel@nongnu.org, peterx@redhat.com, rth@twiddle.net","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1776146,"web_url":"http://patchwork.ozlabs.org/comment/1776146/","msgid":"<871smscybn.fsf@secure.laptop>","list_archive_url":null,"date":"2017-09-27T08:58:36","subject":"Re: [Qemu-devel] [PATCH v2 2/6] migration: check pre_save return in\n\tvmstate_save_state","submitter":{"id":2643,"url":"http://patchwork.ozlabs.org/api/people/2643/","name":"Juan Quintela","email":"quintela@redhat.com"},"content":"\"Dr. David Alan Gilbert (git)\" wrote:\n> From: \"Dr. David Alan Gilbert\" \n>\n> Check the return value of pre_save state and fail vmstate_save_state\n> if the pre_save failed.\n>\n> Signed-off-by: Dr. David Alan Gilbert \n\nReviewed-by: Juan Quintela ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=quintela@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y2Bbf1Dy3z9tXQ\n\tfor ;\n\tWed, 27 Sep 2017 18:59:58 +1000 (AEST)","from localhost ([::1]:53473 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dx8CB-0003PZ-MO\n\tfor incoming@patchwork.ozlabs.org; Wed, 27 Sep 2017 04:59:55 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:47744)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dx8B2-00031i-JL\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 04:58:45 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dx8Ax-0003Iy-P8\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 04:58:44 -0400","from mx1.redhat.com ([209.132.183.28]:55680)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dx8Ax-0003Ik-JI\n\tfor qemu-devel@nongnu.org; Wed, 27 Sep 2017 04:58:39 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 8E0E5C047B66;\n\tWed, 27 Sep 2017 08:58:38 +0000 (UTC)","from localhost (ovpn-117-142.ams2.redhat.com [10.36.117.142])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id B9B9B7A2E0;\n\tWed, 27 Sep 2017 08:58:29 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 8E0E5C047B66","From":"Juan Quintela ","To":"\"Dr. David Alan Gilbert \\(git\\)\" ","In-Reply-To":"<20170925112917.21340-3-dgilbert@redhat.com> (David Alan\n\tGilbert's message of \"Mon, 25 Sep 2017 12:29:13 +0100\")","References":"<20170925112917.21340-1-dgilbert@redhat.com>\n\t<20170925112917.21340-3-dgilbert@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)","Date":"Wed, 27 Sep 2017 10:58:36 +0200","Message-ID":"<871smscybn.fsf@secure.laptop>","MIME-Version":"1.0","Content-Type":"text/plain","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tWed, 27 Sep 2017 08:58:38 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 2/6] migration: check pre_save return in\n\tvmstate_save_state","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"quintela@redhat.com","Cc":"peter.maydell@linaro.org, famz@redhat.com, cohuck@redhat.com,\n\tqemu-devel@nongnu.org, peterx@redhat.com, rth@twiddle.net","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]