[{"id":1776028,"web_url":"http://patchwork.ozlabs.org/comment/1776028/","msgid":"<20170926.213517.1467163782062660869.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-27T04:35:17","subject":"Re: [PATCH v2 06/16] thunderbolt: Add support for XDomain\n\tdiscovery protocol","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Mika Westerberg \nDate: Mon, 25 Sep 2017 14:07:28 +0300\n\n> +struct icm_fr_event_xdomain_connected {\n> +\tstruct icm_pkg_header hdr;\n> +\tu16 reserved;\n> +\tu16 link_info;\n> +\tuuid_t remote_uuid;\n> +\tuuid_t local_uuid;\n> +\tu32 local_route_hi;\n> +\tu32 local_route_lo;\n> +\tu32 remote_route_hi;\n> +\tu32 remote_route_lo;\n> +} __packed;\n> +\n> +struct icm_fr_event_xdomain_disconnected {\n> +\tstruct icm_pkg_header hdr;\n> +\tu16 reserved;\n> +\tu16 link_info;\n> +\tuuid_t remote_uuid;\n> +} __packed;\n> +\n> struct icm_fr_pkg_add_device_key {\n> \tstruct icm_pkg_header hdr;\n> \tuuid_t ep_uuid;\n\nAgain, __packed should be avoided unless absolutely necessary.\n\nThank you.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y24kV44GBz9t30\n\tfor ;\n\tWed, 27 Sep 2017 14:35:30 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1033392AbdI0EfT (ORCPT );\n\tWed, 27 Sep 2017 00:35:19 -0400","from shards.monkeyblade.net ([184.105.139.130]:48474 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1031535AbdI0EfS (ORCPT\n\t); Wed, 27 Sep 2017 00:35:18 -0400","from localhost (74-93-104-102-Washington.hfc.comcastbusiness.net\n\t[74.93.104.102])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id E592B1340112A;\n\tTue, 26 Sep 2017 21:35:17 -0700 (PDT)"],"Date":"Tue, 26 Sep 2017 21:35:17 -0700 (PDT)","Message-Id":"<20170926.213517.1467163782062660869.davem@davemloft.net>","To":"mika.westerberg@linux.intel.com","Cc":"gregkh@linuxfoundation.org, andreas.noever@gmail.com,\n\tmichael.jamet@intel.com, yehezkel.bernat@intel.com,\n\tamir.jer.levy@intel.com, Mario.Limonciello@dell.com,\n\tlukas@wunner.de, andriy.shevchenko@linux.intel.com, andrew@lunn.ch,\n\tlinux-kernel@vger.kernel.org, netdev@vger.kernel.org","Subject":"Re: [PATCH v2 06/16] thunderbolt: Add support for XDomain\n\tdiscovery protocol","From":"David Miller ","In-Reply-To":"<20170925110738.68382-7-mika.westerberg@linux.intel.com>","References":"<20170925110738.68382-1-mika.westerberg@linux.intel.com>\n\t<20170925110738.68382-7-mika.westerberg@linux.intel.com>","X-Mailer":"Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Tue, 26 Sep 2017 21:35:18 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]