[{"id":1774916,"web_url":"http://patchwork.ozlabs.org/comment/1774916/","msgid":"","list_archive_url":null,"date":"2017-09-25T18:32:12","subject":"Re: [PATCH net-next 7/7] nfp: flower vxlan neighbour keep-alive","submitter":{"id":64793,"url":"http://patchwork.ozlabs.org/api/people/64793/","name":"Or Gerlitz","email":"gerlitz.or@gmail.com"},"content":"On Mon, Sep 25, 2017 at 1:23 PM, Simon Horman\n wrote:\n> From: John Hurley \n>\n> Periodically receive messages containing the destination IPs of tunnels\n> that have recently forwarded traffic. Update the neighbour entries 'used'\n> value for these IPs next hop.\n\nAre you proactively sending keep alive messages from the driver or the\nfw? what's wrong with the probes sent by the kernel NUD subsystem?\n\nIn our driver we also update the used value for neighs of offloaded\ntunnels, we do it based on flow counters for the offloaded tunnels\nwhich is an evidence for activity. Any reason for you not to apply a\nsimilar practice?\n\nOr.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"tI1N3LID\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1CNx0mRqz9t3F\n\tfor ;\n\tTue, 26 Sep 2017 04:32:17 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S965524AbdIYScO (ORCPT );\n\tMon, 25 Sep 2017 14:32:14 -0400","from mail-oi0-f52.google.com ([209.85.218.52]:54114 \"EHLO\n\tmail-oi0-f52.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S965518AbdIYScN (ORCPT\n\t); Mon, 25 Sep 2017 14:32:13 -0400","by mail-oi0-f52.google.com with SMTP id j126so8313759oia.10\n\tfor ; Mon, 25 Sep 2017 11:32:13 -0700 (PDT)","by 10.202.168.151 with HTTP; Mon, 25 Sep 2017 11:32:12 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=+Ho50Fp+uG8eMoGljNGrh3hg7ArwwCPqMvokiyCeG2g=;\n\tb=tI1N3LIDbPpbYNC6+8tQhFobwGlKVS8tlSrw9x5roGmcd5ZjuZbMfsizqIxIWjU+V4\n\tqxtVjzUPuaBgBgKIWmrHXnXAex/kE68sKoh2l6iTxupxx0g9fZf/dBnyHoUpcmXZKw/o\n\t4W5LwO0I+cOaawAlnh/SXHApWuVh7ckVhzM+lAPteIzaCE/5dwjHr8e0V/bhvAFdyBfE\n\tNur+cqvHaooyfBlAO1AFDgDx1XU52HsJzH01LaaAm4GV5uCeGO0yQpjt22l6OF+w9aWj\n\tjYZXK/SLt2pAP0v3GmRKn+xzuiTy/zKCjbY14Z+lFO5bHdsPpc60/qaN2PAsjFkH5NHC\n\t9HuQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=+Ho50Fp+uG8eMoGljNGrh3hg7ArwwCPqMvokiyCeG2g=;\n\tb=Yu3eSW5MZfFuIf9cgMGqa7bPoPrWRrQdyzsObYUp7Comy/SnQYccBAASC5R0bOFvV1\n\tvmCZB3s+1oleDR1mlJ3zEMppb7ObHw9lotRDfFRn6f52725/suLfyqInZWImumymvU1E\n\tWDjaiK0j0z5aY8iNnuVsbMqz84NTDku7frRbzZoVgDcvLWrdQp/SYzZrcfbsxONaludM\n\tfO129bGQItKvQs4aIESe6XbmQcgKOuvxKV1NjAtq0AeJi8yM/U0kEkcKKj/JInS8Peeb\n\tT2K3PMrNdBN2tWmYfvjXhm3OmPK3v0tS2hplH0gykg9W9naYM4+jjSM38OrhURXpW8bu\n\tIQZg==","X-Gm-Message-State":"AHPjjUiPigZOd1STmPpVAIbTyBB8Kka+zquJgo9IX2Tpf0s/DLjUDH5o\n\tNvKib2Xg5y4Fylugo0sNCiALi2AEfBj2+OcD45o=","X-Google-Smtp-Source":"AOwi7QCL5okJiMkAlGbLBeb9bwlEwAfA/cI/6PJ/UnPp9z6q7SQLDBfHQnwifL4pvyLUhL8tdaDcen08DFRW+5R+Ljo=","X-Received":"by 10.157.82.1 with SMTP id e1mr726182oth.40.1506364332687; Mon,\n\t25 Sep 2017 11:32:12 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1506335021-32024-8-git-send-email-simon.horman@netronome.com>","References":"<1506335021-32024-1-git-send-email-simon.horman@netronome.com>\n\t<1506335021-32024-8-git-send-email-simon.horman@netronome.com>","From":"Or Gerlitz ","Date":"Mon, 25 Sep 2017 21:32:12 +0300","Message-ID":"","Subject":"Re: [PATCH net-next 7/7] nfp: flower vxlan neighbour keep-alive","To":"Simon Horman ","Cc":"David Miller ,\n\tJakub Kicinski ,\n\tLinux Netdev List ,\n\toss-drivers@netronome.com, John Hurley ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1775301,"web_url":"http://patchwork.ozlabs.org/comment/1775301/","msgid":"","list_archive_url":null,"date":"2017-09-26T09:37:53","subject":"Re: [PATCH net-next 7/7] nfp: flower vxlan neighbour keep-alive","submitter":{"id":70683,"url":"http://patchwork.ozlabs.org/api/people/70683/","name":"John Hurley","email":"john.hurley@netronome.com"},"content":"[ Reposting in plantext only]\n\n\n\nOn Mon, Sep 25, 2017 at 7:32 PM, Or Gerlitz wrote:\n>\n> On Mon, Sep 25, 2017 at 1:23 PM, Simon Horman\n> wrote:\n> > From: John Hurley \n> >\n> > Periodically receive messages containing the destination IPs of tunnels\n> > that have recently forwarded traffic. Update the neighbour entries 'used'\n> > value for these IPs next hop.\n>\n> Are you proactively sending keep alive messages from the driver or the\n> fw? what's wrong with the probes sent by the kernel NUD subsystem?\n>\n\nHi Or,\n\nThe messages are sent from the FW to the driver. They indicate which\noffloaded tunnels are currently active.\n\n>\n> In our driver we also update the used value for neighs of offloaded\n> tunnels, we do it based on flow counters for the offloaded tunnels\n> which is an evidence for activity. Any reason for you not to apply a\n> similar practice?\n\n\nYes, this would provide the same outcome. Because our firmware already\noffered these messages, we chose to support this approach.\n\n>\n>\n> Or.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=netronome-com.20150623.gappssmtp.com\n\theader.i=@netronome-com.20150623.gappssmtp.com\n\theader.b=\"veF6jP/r\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1bTy3NcPz9tX8\n\tfor ;\n\tTue, 26 Sep 2017 19:37:58 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S967833AbdIZJh4 (ORCPT );\n\tTue, 26 Sep 2017 05:37:56 -0400","from mail-wm0-f43.google.com ([74.125.82.43]:44986 \"EHLO\n\tmail-wm0-f43.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S965142AbdIZJhz (ORCPT\n\t); Tue, 26 Sep 2017 05:37:55 -0400","by mail-wm0-f43.google.com with SMTP id m127so14764573wmm.1\n\tfor ; Tue, 26 Sep 2017 02:37:54 -0700 (PDT)","by 10.223.128.97 with HTTP; Tue, 26 Sep 2017 02:37:53 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=netronome-com.20150623.gappssmtp.com; s=20150623;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=frZHmGDXFLdnuw1+F13FW27KFAq20MDPRP8N01Ymf/w=;\n\tb=veF6jP/readT+PYXRSqukbj9bY2dcP/T9AOwkTgC1T674+IvUAipN7hTcfIHRzLvfe\n\t75XOmOO3mzIn+TdXvPjhSS+S2eBwBC5ALki0DfX6oupMVZuiOMA5SsN0Z7+Ckv78Vybz\n\tmU1Khg4AQ5V/Dz2kuoi04YVOS0O3EQEJUFgQweqfvqT2wn8eec7tiNoPGi64UZnEnE1r\n\tfTxDE4ohAssIC2mhyJIiQYleELimRXc7E6R0RcBGL3dx2vhLrrzY9tspE/Nyh3+Dunau\n\tzIcjwAz32/BulALAAs0aNWw7W5YRWdwFhJj/GoROvlmZZlVZiSBY9fTXPovGSlMkdNFr\n\tZ87Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=frZHmGDXFLdnuw1+F13FW27KFAq20MDPRP8N01Ymf/w=;\n\tb=aOiPHLj4uLUfyux0NPidMF5RNpGviiKxfyq8W7kUdL/loU+bU5yHGWTqFjcTvcIuHv\n\tG3b7VOtFF+UhURDKn/6sG55iKjPqN7TAUSwaxhEY1ztUU/wYE6zp23QnMMTT+OUffGpK\n\tsE0g+zyfk3Rbn3Vw4Bv/Vx2BtvtnB1MFzAw4/P2v9+HKEV45PqH7zSIZR2yt9EWCVJkC\n\tYgLRMkrBYOXBGxfS15xEJhOCbKZq7jOY46tpTRasXUj01leRcTaZr4TXzgE3m435pAT+\n\t5e9aPw5tnU7GiWQEq+4zZ3CE93wD4WMoHJQuxGmiQIdrNZOF7yaFqxpui5/CIATLdiQg\n\tM/8g==","X-Gm-Message-State":"AHPjjUjEc5G5rOUt+nntw/rv9kIEz2LwA5TMNE8lKG+orqh1hSnFAb1M\n\tRPU2r9tUil0jDUMLIZdVCqyBulfcWo7iVp4fow86NQ==","X-Google-Smtp-Source":"AOwi7QCQe851jQKSHQadn7ZumdoAUaNpuFZP9bAcu1NOsjFKoaoPiHDnzNeVHXgR0haissBhUisaJ9jYFZID3M9YXMM=","X-Received":"by 10.28.105.200 with SMTP id z69mr2265933wmh.20.1506418674063; \n\tTue, 26 Sep 2017 02:37:54 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<1506335021-32024-1-git-send-email-simon.horman@netronome.com>\n\t<1506335021-32024-8-git-send-email-simon.horman@netronome.com>\n\t\n\t","From":"John Hurley ","Date":"Tue, 26 Sep 2017 10:37:53 +0100","Message-ID":"","Subject":"Re: [PATCH net-next 7/7] nfp: flower vxlan neighbour keep-alive","To":"Or Gerlitz ","Cc":"Simon Horman ,\n\tDavid Miller ,\n\tJakub Kicinski ,\n\tLinux Netdev List , oss-drivers@netronome.com","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1775437,"web_url":"http://patchwork.ozlabs.org/comment/1775437/","msgid":"","list_archive_url":null,"date":"2017-09-26T12:44:44","subject":"Re: [PATCH net-next 7/7] nfp: flower vxlan neighbour keep-alive","submitter":{"id":64793,"url":"http://patchwork.ozlabs.org/api/people/64793/","name":"Or Gerlitz","email":"gerlitz.or@gmail.com"},"content":"On Tue, Sep 26, 2017 at 12:37 PM, John Hurley wrote:\n> [ Reposting in plantext only]\n> On Mon, Sep 25, 2017 at 7:32 PM, Or Gerlitz wrote:\n>>\n>> On Mon, Sep 25, 2017 at 1:23 PM, Simon Horman\n>> wrote:\n>> > From: John Hurley \n>> >\n>> > Periodically receive messages containing the destination IPs of tunnels\n>> > that have recently forwarded traffic. Update the neighbour entries 'used'\n>> > value for these IPs next hop.\n>>\n>> Are you proactively sending keep alive messages from the driver or the\n>> fw? what's wrong with the probes sent by the kernel NUD subsystem?\n\n> The messages are sent from the FW to the driver. They indicate which\n> offloaded tunnels are currently active.\n\nDo you support flow counters for offloaded TC rules? do you support last-use?\n\nIf Y && Y and you cache someone the prev counter value, you can use\nthis for the \"used\" feedback. I don't see why add keep-alive and not piggy back\non the flow counters logic.\n\n>> In our driver we also update the used value for neighs of offloaded\n>> tunnels, we do it based on flow counters for the offloaded tunnels\n>> which is an evidence for activity. Any reason for you not to apply a\n>> similar practice?\n\n> Yes, this would provide the same outcome. Because our firmware already\n> offered these messages, we chose to support this approach.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Tnvv6LPX\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1gdY4dxrz9tXj\n\tfor ;\n\tTue, 26 Sep 2017 22:44:49 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S968770AbdIZMor (ORCPT );\n\tTue, 26 Sep 2017 08:44:47 -0400","from mail-oi0-f48.google.com ([209.85.218.48]:45782 \"EHLO\n\tmail-oi0-f48.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S936444AbdIZMop (ORCPT\n\t); Tue, 26 Sep 2017 08:44:45 -0400","by mail-oi0-f48.google.com with SMTP id z73so11656902oia.2\n\tfor ; Tue, 26 Sep 2017 05:44:45 -0700 (PDT)","by 10.202.168.151 with HTTP; Tue, 26 Sep 2017 05:44:44 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=0UYZ7Ms+rlQDh9Nm8lmT5sMfBTy8o4CtPav3L52j5ts=;\n\tb=Tnvv6LPXsLrdPHjkgBX8nLZhOGoOAjI3x5YqfZwRVAuKM/3c3cPfbwfC3jQgk63k7/\n\tKxdRRXXVEHTWkXn+LGD4xS7zLiXoj6Hdvk63M+aHYlvnVr12Axofiaq5wJFXaGZMyWCs\n\t0C/Dg+fROqqr7PD+oR6f00su3zwhlm8popuqk1LoW8hAnbKqo960Gv4oTY9L76UIa7Uu\n\tb4fSEauBxD3B/LvV6+36wvd2nYqbLXohl1WhvCW0Eiros08iui6wn1ZP2cBfTlecwhqS\n\t8H3Tzk8nke16TaM5dWi1uEgvRpMmCLpB0UAv4Zm7jiShplpguJlvkkIQKbWsosYqetAN\n\tjvkw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=0UYZ7Ms+rlQDh9Nm8lmT5sMfBTy8o4CtPav3L52j5ts=;\n\tb=Vwo4v+DicmMhyGrFKAouJPMuGTNuwFii1UIGe17/+WUjjlGlvMMqEoBuct0jlEuA87\n\tuRJ7T4Bk2S5hPStyuK5Kj+cj8phzFyZ2mhshiK9Tl7vRnE9Rdkb3v5huICATyY3Ay2Nk\n\trk9VaPSzUWpbME01gCiRT3cMub7ques5LSnzEjOIP9EyGfMKjgT8z3lTAV+aB9/5eZIZ\n\tWqO3BGTwxBnUDqZcw+10nHAf+B3jph/jOgtCNgiti4drqArv4pp1HQhzehnX/64+1+Ap\n\tSSZK1s++JheHAnFdMAl0d+QMGHsBIBPb/L0QwXeANMoPuloZQdXPC1Zmh2+mQYilN7I0\n\tONfQ==","X-Gm-Message-State":"AHPjjUg5qpmvF8ZVZpS6l15ULuQasQzHaBU82DxF5KPEusCHrdlKuM09\n\tSboKELOGAA9XzW1+xE8XmofDoAHNiL3sHvQKosY=","X-Google-Smtp-Source":"AOwi7QAhlVIJD29WXT2CBspgBTb/w9FQM8y6rVdKGSJ0SI1nNwMq9ik277qqroxSkHsgLFZnsrleipEeAuBlVlv1Ca4=","X-Received":"by 10.157.0.207 with SMTP id 15mr1896692otk.301.1506429885033;\n\tTue, 26 Sep 2017 05:44:45 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<1506335021-32024-1-git-send-email-simon.horman@netronome.com>\n\t<1506335021-32024-8-git-send-email-simon.horman@netronome.com>\n\t\n\t\n\t","From":"Or Gerlitz ","Date":"Tue, 26 Sep 2017 15:44:44 +0300","Message-ID":"","Subject":"Re: [PATCH net-next 7/7] nfp: flower vxlan neighbour keep-alive","To":"John Hurley ","Cc":"Simon Horman ,\n\tDavid Miller ,\n\tJakub Kicinski ,\n\tLinux Netdev List , oss-drivers@netronome.com","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]