[{"id":1774613,"web_url":"http://patchwork.ozlabs.org/comment/1774613/","msgid":"<3cf601ed-cc96-dfe5-a217-fe13f5d4b721@denx.de>","list_archive_url":null,"date":"2017-09-25T09:09:22","subject":"Re: [U-Boot] [PATCH v2 08/19] fs: Enable generic filesystems\n\tinterface support in SPL.","submitter":{"id":12009,"url":"http://patchwork.ozlabs.org/api/people/12009/","name":"Marek Vasut","email":"marex@denx.de"},"content":"On 09/25/2017 10:40 AM, tien.fong.chee@intel.com wrote:\n> From: Tien Fong Chee \n> \n> Enable generic filesystem interface drivers(fs.c and fat/) build\n> for SPL. This would allow generic filesystem being used in SPL.\n> \n> Signed-off-by: Tien Fong Chee \n\n+CC Simon, I'd like a RB on this one.\n\n> ---\n> common/spl/Kconfig | 8 ++++++++\n> doc/README.SPL | 1 +\n> fs/Makefile | 1 +\n> 3 files changed, 10 insertions(+)\n> \n> diff --git a/common/spl/Kconfig b/common/spl/Kconfig\n> index 9446cd9..5f4bd92 100644\n> --- a/common/spl/Kconfig\n> +++ b/common/spl/Kconfig\n> @@ -304,6 +304,14 @@ config SPL_ETH_SUPPORT\n> \t is required since the network stack uses a number of environment\n> \t variables. See also SPL_NET_SUPPORT.\n> \n> +config SPL_FS_GENERIC\n> +\tbool \"Support Generic filesystems interface driver\"\n> +\thelp\n> +\t Enable support for generic filesystems interface with SPL. This\n> +\t permits U-Boot (or Linux in Falcon mode) to be loaded from a generic\n> +\t filesystem from within SPL. Support for the underlying block\n> +\t device (e.g. MMC or USB) must be enabled separately.\n> +\n> config SPL_EXT_SUPPORT\n> \tbool \"Support EXT filesystems\"\n> \thelp\n> diff --git a/doc/README.SPL b/doc/README.SPL\n> index 3ba313c..32628a4 100644\n> --- a/doc/README.SPL\n> +++ b/doc/README.SPL\n> @@ -55,6 +55,7 @@ CONFIG_SPL_SPI_FLASH_SUPPORT (drivers/mtd/spi/libspi_flash.o)\n> CONFIG_SPL_SPI_SUPPORT (drivers/spi/libspi.o)\n> CONFIG_SPL_FAT_SUPPORT (fs/fat/libfat.o)\n> CONFIG_SPL_EXT_SUPPORT\n> +CONFIG_SPL_FS_GENERIC (fs/fs.o fat/)\n> CONFIG_SPL_LIBGENERIC_SUPPORT (lib/libgeneric.o)\n> CONFIG_SPL_POWER_SUPPORT (drivers/power/libpower.o)\n> CONFIG_SPL_NAND_SUPPORT (drivers/mtd/nand/libnand.o)\n> diff --git a/fs/Makefile b/fs/Makefile\n> index 5770f41..fdacac8 100644\n> --- a/fs/Makefile\n> +++ b/fs/Makefile\n> @@ -7,6 +7,7 @@\n> #\n> \n> ifdef CONFIG_SPL_BUILD\n> +obj-$(CONFIG_SPL_FS_GENERIC) += fs.o fat/\n> obj-$(CONFIG_SPL_FAT_SUPPORT) += fat/\n> obj-$(CONFIG_SPL_EXT_SUPPORT) += ext4/\n> else\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y10GG3DHgz9tX3\n\tfor ;\n\tMon, 25 Sep 2017 20:10:46 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 2D945C221DF; Mon, 25 Sep 2017 10:04:26 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 6603CC221A9;\n\tMon, 25 Sep 2017 09:58:59 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 91439C221A8; Mon, 25 Sep 2017 09:58:33 +0000 (UTC)","from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9])\n\tby lists.denx.de (Postfix) with ESMTPS id 1F666C220EA\n\tfor ; Mon, 25 Sep 2017 09:58:30 +0000 (UTC)","from frontend01.mail.m-online.net (unknown [192.168.8.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3y10056L8zz1qskc;\n\tMon, 25 Sep 2017 11:58:29 +0200 (CEST)","from localhost (dynscan1.mnet-online.de [192.168.6.70])\n\tby mail.m-online.net (Postfix) with ESMTP id 3y10055KcLz1qql2;\n\tMon, 25 Sep 2017 11:58:29 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id psUyg4yJGWxW; Mon, 25 Sep 2017 11:58:28 +0200 (CEST)","from [IPv6:::1] (unknown [195.140.253.167])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPSA;\n\tMon, 25 Sep 2017 11:58:28 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Virus-Scanned":"amavisd-new at mnet-online.de","X-Auth-Info":"j0crE8s4PeYOSqe3CmDmbpa1PV4wV8jcH0Q6b2PnZyg=","To":"tien.fong.chee@intel.com, u-boot@lists.denx.de","References":"<1506328815-23733-1-git-send-email-tien.fong.chee@intel.com>\n\t<1506328815-23733-9-git-send-email-tien.fong.chee@intel.com>","From":"Marek Vasut ","Message-ID":"<3cf601ed-cc96-dfe5-a217-fe13f5d4b721@denx.de>","Date":"Mon, 25 Sep 2017 11:09:22 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1506328815-23733-9-git-send-email-tien.fong.chee@intel.com>","Content-Language":"en-US","Cc":"Ching Liang See ,\n\tTien Fong ,\n\tWestergteen Dalon ","Subject":"Re: [U-Boot] [PATCH v2 08/19] fs: Enable generic filesystems\n\tinterface support in SPL.","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1782487,"web_url":"http://patchwork.ozlabs.org/comment/1782487/","msgid":"","list_archive_url":null,"date":"2017-10-09T04:47:27","subject":"Re: [U-Boot] [PATCH v2 08/19] fs: Enable generic filesystems\n\tinterface support in SPL.","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 25 September 2017 at 02:40, wrote:\n> From: Tien Fong Chee \n>\n> Enable generic filesystem interface drivers(fs.c and fat/) build\n> for SPL. This would allow generic filesystem being used in SPL.\n>\n> Signed-off-by: Tien Fong Chee \n> ---\n> common/spl/Kconfig | 8 ++++++++\n> doc/README.SPL | 1 +\n> fs/Makefile | 1 +\n> 3 files changed, 10 insertions(+)\n\nReviewed-by: Simon Glass ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"lcp8RMAk\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"a9RD3Gy0\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y9T7444Smz9tY0\n\tfor ;\n\tMon, 9 Oct 2017 16:18:56 +1100 (AEDT)","by lists.denx.de (Postfix, from userid 105)\n\tid 3E280C21DF1; Mon, 9 Oct 2017 05:07:15 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 47C3AC21D64;\n\tMon, 9 Oct 2017 05:07:04 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 8345FC21D56; Mon, 9 Oct 2017 04:47:52 +0000 (UTC)","from mail-qk0-f175.google.com (mail-qk0-f175.google.com\n\t[209.85.220.175])\n\tby lists.denx.de (Postfix) with ESMTPS id D4A3CC21D57\n\tfor ; Mon, 9 Oct 2017 04:47:48 +0000 (UTC)","by mail-qk0-f175.google.com with SMTP id b15so20423154qkg.9\n\tfor ; Sun, 08 Oct 2017 21:47:48 -0700 (PDT)","by 10.200.63.170 with HTTP; Sun, 8 Oct 2017 21:47:27 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=RCVD_IN_MSPIKE_H2,\n\tT_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=8TYY2xTY53mmFIgy6uq5gbZNXpVL/4ptQHw/u9S1sV0=;\n\tb=lcp8RMAk2B134ExvCoDvVHEPjhNvP/r7T8fP0n4GAVsHcu8TGb68zSC1U+IYO+nm29\n\tVlZJml45e8wPILdGxaoIVqWQUwt7x+8rqOPxx8AfJKHuhZxd7e1hx8dwfW04dhf0oI8B\n\tbuZuiEVB0iYO2S+A/daHn68CPJjBvNkaylXeb1X/eVYKlOWu79Ih1kFgC0V1U9DVH06M\n\tbND3g5uHQ/kLLK3TX1GA3J9TUr+BGmEXzdXjD0N4ROHBBnCZVs/3oF+/0b2iyDdOMuyj\n\theNw8L7ukzmG2xlvf5sd1NKp9HUJjYddQAMMFmx3+++GFoVTa90nfNv6mZeL85EYbEHR\n\t7Fpg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=8TYY2xTY53mmFIgy6uq5gbZNXpVL/4ptQHw/u9S1sV0=;\n\tb=a9RD3Gy03vdyKC8E7ka1/GLjV+KELhlTOXAP0BpL3Mm776Mhn3IdYQjkAC65xzmmsP\n\t+XM9QaPGYTsdBjYa1USPq8IKqwVVHw3iKiBW0SmTGbzMkKlsOxN1GOTl3tdq2/o/DdT/\n\tbgMtgUk0irYUz74MU8e3pxEshVPpmQjSvXwEY="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=8TYY2xTY53mmFIgy6uq5gbZNXpVL/4ptQHw/u9S1sV0=;\n\tb=g8vzQ/4SCxItCcy4pALfooY2Md8/N3AvEyKhpc9odKxYdQu14advtgrc1yb/J3R/2K\n\tAMn4oPuo4vgE0DTx7BCv5mZzMTQGRD7GraAl8ecWbBuZLDvBfPsqC45gykF6rCjkBZPm\n\tUCDgGiiRrHny/4Xe4fST2pud6XX71KNWztmUwJ7r6QyWgh2Qtc6ij+KgU2M8wbvIiT3r\n\t2l596APBy2mQ4RYNx6F8QTDtP0A3Tn2GmKktNOaTTX2BctQcpx92g7WZDacasmsJ3Y0+\n\tyr9Q8ZJmMomveUy3eDzVIqZjpMHKXLNPzjz+y+tOFehgGY+dAGJMSmawlCULkLgJSjLC\n\tJbLA==","X-Gm-Message-State":"AMCzsaWQJzs/5O3hKLfToR3M29bhJqJYA6A7/IJWOtSArCfeEfYVcLNs\n\tOPXMVzcRzdPNjgCBdC189caZVVXPMKQHvIhZ9lifaA==","X-Google-Smtp-Source":"AOwi7QBT1mmK0+LX0fFrfvUuUQzxVO7i3Gm4Jd3qdoc6q0HRNyBa0TV9fxzTzwiSkrux48+7e1hIzyurIV34FI+kfgE=","X-Received":"by 10.233.216.135 with SMTP id\n\tu129mr8060396qkf.302.1507524467608; \n\tSun, 08 Oct 2017 21:47:47 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1506328815-23733-9-git-send-email-tien.fong.chee@intel.com>","References":"<1506328815-23733-1-git-send-email-tien.fong.chee@intel.com>\n\t<1506328815-23733-9-git-send-email-tien.fong.chee@intel.com>","From":"Simon Glass ","Date":"Sun, 8 Oct 2017 22:47:27 -0600","X-Google-Sender-Auth":"XeRRZnX2BB5h_d6PEZlZqA2Wg-M","Message-ID":"","To":"Tien Fong Chee ","Cc":"Marek Vasut , U-Boot Mailing List , \n\tChing Liang See ,\n\tWestergteen Dalon ,\n\tTien Fong ","Subject":"Re: [U-Boot] [PATCH v2 08/19] fs: Enable generic filesystems\n\tinterface support in SPL.","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]