[{"id":1774602,"web_url":"http://patchwork.ozlabs.org/comment/1774602/","msgid":"<800f086c-9879-3d13-d0f3-f478ac98446e@denx.de>","list_archive_url":null,"date":"2017-09-25T09:15:06","subject":"Re: [U-Boot] [PATCH v2 10/19] arm: socfpga: Rename the gen5 sdram\n\tdriver to more specific name","submitter":{"id":12009,"url":"http://patchwork.ozlabs.org/api/people/12009/","name":"Marek Vasut","email":"marex@denx.de"},"content":"On 09/25/2017 10:40 AM, tien.fong.chee@intel.com wrote:\n> From: Tien Fong Chee \n> \n> Current sdram driver is only applied to gen5 device, hence it is better\n> to rename sdram driver to more specific name which is related to gen5\n> device.\n> \n> Signed-off-by: Tien Fong Chee \n> ---\n> arch/arm/mach-socfpga/include/mach/sdram.h | 434 +--------------------\n> .../include/mach/{sdram.h => sdram_gen5.h} | 6 +-\n> drivers/ddr/altera/Makefile | 2 +-\n> drivers/ddr/altera/{sdram.c => sdram_gen5.c} | 0\n> 4 files changed, 8 insertions(+), 434 deletions(-)\n> copy arch/arm/mach-socfpga/include/mach/{sdram.h => sdram_gen5.h} (99%)\n> rename drivers/ddr/altera/{sdram.c => sdram_gen5.c} (100%)\n> \n> diff --git a/arch/arm/mach-socfpga/include/mach/sdram.h b/arch/arm/mach-socfpga/include/mach/sdram.h\n> index b11228f..4a9754e 100644\n> --- a/arch/arm/mach-socfpga/include/mach/sdram.h\n> +++ b/arch/arm/mach-socfpga/include/mach/sdram.h\n> @@ -1,5 +1,5 @@\n> /*\n> - * Copyright Altera Corporation (C) 2014-2015\n> + * Copyright (C) 2017 Intel Corporation \n\nRetain the old copyright ?\n\n> *\n> * SPDX-License-Identifier:\tGPL-2.0+\n> */\n> @@ -8,435 +8,9 @@\n> \n> #ifndef __ASSEMBLY__\n\nWhat's with this massive deletion here ?\n\n> -unsigned long sdram_calculate_size(void);\n> -int sdram_mmr_init_full(unsigned int sdr_phy_reg);\n> -int sdram_calibration_full(void);\n> -\n> -const struct socfpga_sdram_config *socfpga_get_sdram_config(void);\n> -\n> -void socfpga_get_seq_ac_init(const u32 **init, unsigned int *nelem);\n> -void socfpga_get_seq_inst_init(const u32 **init, unsigned int *nelem);\n> -const struct socfpga_sdram_rw_mgr_config *socfpga_get_sdram_rwmgr_config(void);\n[...]","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y10825zTGz9tX3\n\tfor ;\n\tMon, 25 Sep 2017 20:05:22 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 9CD08C21FEA; Mon, 25 Sep 2017 10:03:52 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 99BFFC22174;\n\tMon, 25 Sep 2017 09:58:52 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 84A4FC2211A; Mon, 25 Sep 2017 09:58:36 +0000 (UTC)","from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10])\n\tby lists.denx.de (Postfix) with ESMTPS id 6645DC22028\n\tfor ; Mon, 25 Sep 2017 09:58:33 +0000 (UTC)","from frontend01.mail.m-online.net (unknown [192.168.8.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3y10091Przz1qsVm;\n\tMon, 25 Sep 2017 11:58:33 +0200 (CEST)","from localhost (dynscan1.mnet-online.de [192.168.6.70])\n\tby mail.m-online.net (Postfix) with ESMTP id 3y10090XTyz1qqkh;\n\tMon, 25 Sep 2017 11:58:33 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id LpeHrsVuOviG; Mon, 25 Sep 2017 11:58:31 +0200 (CEST)","from [IPv6:::1] (unknown [195.140.253.167])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPSA;\n\tMon, 25 Sep 2017 11:58:31 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Virus-Scanned":"amavisd-new at mnet-online.de","X-Auth-Info":"7HLRBT+ee0RcEkeLWI8/Wjrmd9fogsK52tahc0bm7g0=","To":"tien.fong.chee@intel.com, u-boot@lists.denx.de","References":"<1506328815-23733-1-git-send-email-tien.fong.chee@intel.com>\n\t<1506328815-23733-11-git-send-email-tien.fong.chee@intel.com>","From":"Marek Vasut ","Message-ID":"<800f086c-9879-3d13-d0f3-f478ac98446e@denx.de>","Date":"Mon, 25 Sep 2017 11:15:06 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1506328815-23733-11-git-send-email-tien.fong.chee@intel.com>","Content-Language":"en-US","Cc":"Ching Liang See ,\n\tWestergteen Dalon ,\n\tTien Fong ","Subject":"Re: [U-Boot] [PATCH v2 10/19] arm: socfpga: Rename the gen5 sdram\n\tdriver to more specific name","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1775247,"web_url":"http://patchwork.ozlabs.org/comment/1775247/","msgid":"<1506414197.27760.23.camel@intel.com>","list_archive_url":null,"date":"2017-09-26T08:23:18","subject":"Re: [U-Boot] [PATCH v2 10/19] arm: socfpga: Rename the gen5 sdram\n\tdriver to more specific name","submitter":{"id":70549,"url":"http://patchwork.ozlabs.org/api/people/70549/","name":"Chee, Tien Fong","email":"tien.fong.chee@intel.com"},"content":"On Isn, 2017-09-25 at 11:15 +0200, Marek Vasut wrote:\r\n> On 09/25/2017 10:40 AM, tien.fong.chee@intel.com wrote:\r\n> > \r\n> > From: Tien Fong Chee \r\n> > \r\n> > Current sdram driver is only applied to gen5 device, hence it is\r\n> > better\r\n> > to rename sdram driver to more specific name which is related to\r\n> > gen5\r\n> > device.\r\n> > \r\n> > Signed-off-by: Tien Fong Chee \r\n> > ---\r\n> >  arch/arm/mach-socfpga/include/mach/sdram.h         | 434 +------\r\n> > --------------\r\n> >  .../include/mach/{sdram.h => sdram_gen5.h}         |   6 +-\r\n> >  drivers/ddr/altera/Makefile                        |   2 +-\r\n> >  drivers/ddr/altera/{sdram.c => sdram_gen5.c}       |   0\r\n> >  4 files changed, 8 insertions(+), 434 deletions(-)\r\n> >  copy arch/arm/mach-socfpga/include/mach/{sdram.h => sdram_gen5.h}\r\n> > (99%)\r\n> >  rename drivers/ddr/altera/{sdram.c => sdram_gen5.c} (100%)\r\n> > \r\n> > diff --git a/arch/arm/mach-socfpga/include/mach/sdram.h\r\n> > b/arch/arm/mach-socfpga/include/mach/sdram.h\r\n> > index b11228f..4a9754e 100644\r\n> > --- a/arch/arm/mach-socfpga/include/mach/sdram.h\r\n> > +++ b/arch/arm/mach-socfpga/include/mach/sdram.h\r\n> > @@ -1,5 +1,5 @@\r\n> >  /*\r\n> > - * Copyright Altera Corporation (C) 2014-2015\r\n> > + * Copyright (C) 2017 Intel Corporation \r\n> Retain the old copyright ?\r\n> \r\nOkay.\r\n> > \r\n> >   *\r\n> >   * SPDX-License-Identifier:\tGPL-2.0+\r\n> >   */\r\n> > @@ -8,435 +8,9 @@\r\n> >  \r\n> >  #ifndef __ASSEMBLY__\r\n> What's with this massive deletion here ?\r\n> \r\nMove to sdram_gen5.h . This header should contain common stuff.\r\n> > \r\n> > -unsigned long sdram_calculate_size(void);\r\n> > -int sdram_mmr_init_full(unsigned int sdr_phy_reg);\r\n> > -int sdram_calibration_full(void);\r\n> > -\r\n> > -const struct socfpga_sdram_config *socfpga_get_sdram_config(void);\r\n> > -\r\n> > -void socfpga_get_seq_ac_init(const u32 **init, unsigned int\r\n> > *nelem);\r\n> > -void socfpga_get_seq_inst_init(const u32 **init, unsigned int\r\n> > *nelem);\r\n> > -const struct socfpga_sdram_rw_mgr_config\r\n> > *socfpga_get_sdram_rwmgr_config(void);\r\n> [...]\r\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1Yr30Y7Bz9tXc\n\tfor ;\n\tTue, 26 Sep 2017 18:23:31 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid CDFC5C21CA5; Tue, 26 Sep 2017 08:23:29 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 014CFC21CA5;\n\tTue, 26 Sep 2017 08:23:26 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 7A886C21CA5; Tue, 26 Sep 2017 08:23:24 +0000 (UTC)","from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby lists.denx.de (Postfix) with ESMTPS id AD159C21C93\n\tfor ; Tue, 26 Sep 2017 08:23:23 +0000 (UTC)","from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby orsmga105.jf.intel.com with ESMTP; 26 Sep 2017 01:23:21 -0700","from pgsmsx108.gar.corp.intel.com ([10.221.44.103])\n\tby fmsmga006.fm.intel.com with ESMTP; 26 Sep 2017 01:23:20 -0700","from kmsmsx156.gar.corp.intel.com (172.21.138.133) by\n\tPGSMSX108.gar.corp.intel.com (10.221.44.103) with Microsoft SMTP\n\tServer (TLS) id 14.3.319.2; Tue, 26 Sep 2017 16:23:19 +0800","from pgsmsx109.gar.corp.intel.com ([169.254.14.159]) by\n\tKMSMSX156.gar.corp.intel.com ([172.21.138.133]) with mapi id\n\t14.03.0248.002; Tue, 26 Sep 2017 16:23:19 +0800"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED\n\tautolearn=unavailable autolearn_force=no version=3.4.0","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,440,1500966000\"; d=\"scan'208\";a=\"156044158\"","From":"\"Chee, Tien Fong\" ","To":"\"marex@denx.de\" , \"u-boot@lists.denx.de\"\n\t","Thread-Topic":"[PATCH v2 10/19] arm: socfpga: Rename the gen5 sdram driver to\n\tmore specific name","Thread-Index":"AQHTNdoC443zSHRqQ0qa7ZIZ4TtsSaLEy70AgAGD24A=","Date":"Tue, 26 Sep 2017 08:23:18 +0000","Message-ID":"<1506414197.27760.23.camel@intel.com>","References":"<1506328815-23733-1-git-send-email-tien.fong.chee@intel.com>\n\t<1506328815-23733-11-git-send-email-tien.fong.chee@intel.com>\n\t<800f086c-9879-3d13-d0f3-f478ac98446e@denx.de>","In-Reply-To":"<800f086c-9879-3d13-d0f3-f478ac98446e@denx.de>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-originating-ip":"[10.226.242.102]","Content-ID":"<939E15779DB29A40B4F82589FDA80DD8@intel.com>","MIME-Version":"1.0","Cc":"\"See, Chin Liang\" , \"Westergreen,\n\tDalon\" ,\n\t\"skywindctf@gmail.com\" ","Subject":"Re: [U-Boot] [PATCH v2 10/19] arm: socfpga: Rename the gen5 sdram\n\tdriver to more specific name","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1775377,"web_url":"http://patchwork.ozlabs.org/comment/1775377/","msgid":"<902a4d12-9c8e-3cb5-0101-e7d7f05bcbb1@denx.de>","list_archive_url":null,"date":"2017-09-26T10:33:06","subject":"Re: [U-Boot] [PATCH v2 10/19] arm: socfpga: Rename the gen5 sdram\n\tdriver to more specific name","submitter":{"id":12009,"url":"http://patchwork.ozlabs.org/api/people/12009/","name":"Marek Vasut","email":"marex@denx.de"},"content":"On 09/26/2017 10:23 AM, Chee, Tien Fong wrote:\n> On Isn, 2017-09-25 at 11:15 +0200, Marek Vasut wrote:\n>> On 09/25/2017 10:40 AM, tien.fong.chee@intel.com wrote:\n>>>\n>>> From: Tien Fong Chee \n>>>\n>>> Current sdram driver is only applied to gen5 device, hence it is\n>>> better\n>>> to rename sdram driver to more specific name which is related to\n>>> gen5\n>>> device.\n>>>\n>>> Signed-off-by: Tien Fong Chee \n>>> ---\n>>>  arch/arm/mach-socfpga/include/mach/sdram.h         | 434 +------\n>>> --------------\n>>>  .../include/mach/{sdram.h => sdram_gen5.h}         |   6 +-\n>>>  drivers/ddr/altera/Makefile                        |   2 +-\n>>>  drivers/ddr/altera/{sdram.c => sdram_gen5.c}       |   0\n>>>  4 files changed, 8 insertions(+), 434 deletions(-)\n>>>  copy arch/arm/mach-socfpga/include/mach/{sdram.h => sdram_gen5.h}\n>>> (99%)\n>>>  rename drivers/ddr/altera/{sdram.c => sdram_gen5.c} (100%)\n>>>\n>>> diff --git a/arch/arm/mach-socfpga/include/mach/sdram.h\n>>> b/arch/arm/mach-socfpga/include/mach/sdram.h\n>>> index b11228f..4a9754e 100644\n>>> --- a/arch/arm/mach-socfpga/include/mach/sdram.h\n>>> +++ b/arch/arm/mach-socfpga/include/mach/sdram.h\n>>> @@ -1,5 +1,5 @@\n>>>  /*\n>>> - * Copyright Altera Corporation (C) 2014-2015\n>>> + * Copyright (C) 2017 Intel Corporation \n>> Retain the old copyright ?\n>>\n> Okay.\n>>>\n>>>   *\n>>>   * SPDX-License-Identifier:\tGPL-2.0+\n>>>   */\n>>> @@ -8,435 +8,9 @@\n>>>  \n>>>  #ifndef __ASSEMBLY__\n>> What's with this massive deletion here ?\n>>\n> Move to sdram_gen5.h . This header should contain common stuff.\n\nThen where did the + part go ?\n\n>>>\n>>> -unsigned long sdram_calculate_size(void);\n>>> -int sdram_mmr_init_full(unsigned int sdr_phy_reg);\n>>> -int sdram_calibration_full(void);\n>>> -\n>>> -const struct socfpga_sdram_config *socfpga_get_sdram_config(void);\n>>> -\n>>> -void socfpga_get_seq_ac_init(const u32 **init, unsigned int\n>>> *nelem);\n>>> -void socfpga_get_seq_inst_init(const u32 **init, unsigned int\n>>> *nelem);\n>>> -const struct socfpga_sdram_rw_mgr_config\n>>> *socfpga_get_sdram_rwmgr_config(void);\n>> [...]","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1dYt08TNz9tXP\n\tfor ;\n\tTue, 26 Sep 2017 21:11:29 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid BD9C1C21F5B; Tue, 26 Sep 2017 11:09:15 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 648F9C21DA6;\n\tTue, 26 Sep 2017 11:08:01 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 517BBC21E43; Tue, 26 Sep 2017 11:07:38 +0000 (UTC)","from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9])\n\tby lists.denx.de (Postfix) with ESMTPS id C35F4C21EC9\n\tfor ; Tue, 26 Sep 2017 11:07:32 +0000 (UTC)","from frontend01.mail.m-online.net (unknown [192.168.8.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3y1dTJ43dxz1qsjl;\n\tTue, 26 Sep 2017 13:07:32 +0200 (CEST)","from localhost (dynscan1.mnet-online.de [192.168.6.70])\n\tby mail.m-online.net (Postfix) with ESMTP id 3y1dTJ3p5Wz1r0wd;\n\tTue, 26 Sep 2017 13:07:32 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id OkR2y9DUQ2Z8; Tue, 26 Sep 2017 13:07:29 +0200 (CEST)","from [IPv6:::1] (unknown [195.140.253.167])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPSA;\n\tTue, 26 Sep 2017 13:07:29 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Virus-Scanned":"amavisd-new at mnet-online.de","X-Auth-Info":"+BGcnRsJeXgH4RdL1bdaNRA5cVchpK3js1u/uevatVo=","To":"\"Chee, Tien Fong\" ,\n\t\"u-boot@lists.denx.de\" ","References":"<1506328815-23733-1-git-send-email-tien.fong.chee@intel.com>\n\t<1506328815-23733-11-git-send-email-tien.fong.chee@intel.com>\n\t<800f086c-9879-3d13-d0f3-f478ac98446e@denx.de>\n\t<1506414197.27760.23.camel@intel.com>","From":"Marek Vasut ","Message-ID":"<902a4d12-9c8e-3cb5-0101-e7d7f05bcbb1@denx.de>","Date":"Tue, 26 Sep 2017 12:33:06 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1506414197.27760.23.camel@intel.com>","Content-Language":"en-US","Cc":"\"See, Chin Liang\" , \"Westergreen,\n\tDalon\" ,\n\t\"skywindctf@gmail.com\" ","Subject":"Re: [U-Boot] [PATCH v2 10/19] arm: socfpga: Rename the gen5 sdram\n\tdriver to more specific name","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1776034,"web_url":"http://patchwork.ozlabs.org/comment/1776034/","msgid":"<1506488793.3589.15.camel@intel.com>","list_archive_url":null,"date":"2017-09-27T05:06:33","subject":"Re: [U-Boot] [PATCH v2 10/19] arm: socfpga: Rename the gen5 sdram\n\tdriver to more specific name","submitter":{"id":70549,"url":"http://patchwork.ozlabs.org/api/people/70549/","name":"Chee, Tien Fong","email":"tien.fong.chee@intel.com"},"content":"On Sel, 2017-09-26 at 12:33 +0200, Marek Vasut wrote:\r\n> On 09/26/2017 10:23 AM, Chee, Tien Fong wrote:\r\n> > \r\n> > On Isn, 2017-09-25 at 11:15 +0200, Marek Vasut wrote:\r\n> > > \r\n> > > On 09/25/2017 10:40 AM, tien.fong.chee@intel.com wrote:\r\n> > > > \r\n> > > > \r\n> > > > From: Tien Fong Chee \r\n> > > > \r\n> > > > Current sdram driver is only applied to gen5 device, hence it\r\n> > > > is\r\n> > > > better\r\n> > > > to rename sdram driver to more specific name which is related\r\n> > > > to\r\n> > > > gen5\r\n> > > > device.\r\n> > > > \r\n> > > > Signed-off-by: Tien Fong Chee \r\n> > > > ---\r\n> > > >  arch/arm/mach-socfpga/include/mach/sdram.h         | 434 +--\r\n> > > > ----\r\n> > > > --------------\r\n> > > >  .../include/mach/{sdram.h => sdram_gen5.h}         |   6 +-\r\n> > > >  drivers/ddr/altera/Makefile                        |   2 +-\r\n> > > >  drivers/ddr/altera/{sdram.c => sdram_gen5.c}       |   0\r\n> > > >  4 files changed, 8 insertions(+), 434 deletions(-)\r\n> > > >  copy arch/arm/mach-socfpga/include/mach/{sdram.h =>\r\n> > > > sdram_gen5.h}\r\n> > > > (99%)\r\n> > > >  rename drivers/ddr/altera/{sdram.c => sdram_gen5.c} (100%)\r\n> > > > \r\n> > > > diff --git a/arch/arm/mach-socfpga/include/mach/sdram.h\r\n> > > > b/arch/arm/mach-socfpga/include/mach/sdram.h\r\n> > > > index b11228f..4a9754e 100644\r\n> > > > --- a/arch/arm/mach-socfpga/include/mach/sdram.h\r\n> > > > +++ b/arch/arm/mach-socfpga/include/mach/sdram.h\r\n> > > > @@ -1,5 +1,5 @@\r\n> > > >  /*\r\n> > > > - * Copyright Altera Corporation (C) 2014-2015\r\n> > > > + * Copyright (C) 2017 Intel Corporation \r\n> > > Retain the old copyright ?\r\n> > > \r\n> > Okay.\r\n> > > \r\n> > > > \r\n> > > > \r\n> > > >   *\r\n> > > >   * SPDX-License-Identifier:\tGPL-2.0+\r\n> > > >   */\r\n> > > > @@ -8,435 +8,9 @@\r\n> > > >  \r\n> > > >  #ifndef __ASSEMBLY__\r\n> > > What's with this massive deletion here ?\r\n> > > \r\n> > Move to sdram_gen5.h . This header should contain common stuff.\r\n> Then where did the + part go ?\r\n> \r\nI'm not sure why the patch didn't showing \"+\" portion, i suspect the\r\npatch use below instead of \"+\".\r\n copy arch/arm/mach-socfpga/include/mach/{sdram.h =>\r\n> > > > sdram_gen5.h}> > > > (99%)> > > >  rename\r\ndrivers/ddr/altera/{sdram.c => sdram_gen5.c} (100%)\r\n> > \r\n> > > \r\n> > > > \r\n> > > > \r\n> > > > -unsigned long sdram_calculate_size(void);\r\n> > > > -int sdram_mmr_init_full(unsigned int sdr_phy_reg);\r\n> > > > -int sdram_calibration_full(void);\r\n> > > > -\r\n> > > > -const struct socfpga_sdram_config\r\n> > > > *socfpga_get_sdram_config(void);\r\n> > > > -\r\n> > > > -void socfpga_get_seq_ac_init(const u32 **init, unsigned int\r\n> > > > *nelem);\r\n> > > > -void socfpga_get_seq_inst_init(const u32 **init, unsigned int\r\n> > > > *nelem);\r\n> > > > -const struct socfpga_sdram_rw_mgr_config\r\n> > > > *socfpga_get_sdram_rwmgr_config(void);\r\n> > > [...]\r\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y25Qd6h7Xz9sPt\n\tfor ;\n\tWed, 27 Sep 2017 15:06:49 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 8F983C21D99; Wed, 27 Sep 2017 05:06:45 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 797EDC21C45;\n\tWed, 27 Sep 2017 05:06:42 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 7F27EC21C45; Wed, 27 Sep 2017 05:06:40 +0000 (UTC)","from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby lists.denx.de (Postfix) with ESMTPS id 6EAC8C21C40\n\tfor ; Wed, 27 Sep 2017 05:06:39 +0000 (UTC)","from orsmga005.jf.intel.com ([10.7.209.41])\n\tby orsmga105.jf.intel.com with ESMTP; 26 Sep 2017 22:06:37 -0700","from kmsmsx155.gar.corp.intel.com ([172.21.73.106])\n\tby orsmga005.jf.intel.com with ESMTP; 26 Sep 2017 22:06:35 -0700","from pgsmsx109.gar.corp.intel.com ([169.254.14.159]) by\n\tKMSMSX155.gar.corp.intel.com ([169.254.15.167]) with mapi id\n\t14.03.0319.002; Wed, 27 Sep 2017 13:06:34 +0800"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED\n\tautolearn=unavailable autolearn_force=no version=3.4.0","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,443,1500966000\"; d=\"scan'208\";a=\"153801235\"","From":"\"Chee, Tien Fong\" ","To":"\"marex@denx.de\" , \"u-boot@lists.denx.de\"\n\t","Thread-Topic":"[PATCH v2 10/19] arm: socfpga: Rename the gen5 sdram driver to\n\tmore specific name","Thread-Index":"AQHTNdoC443zSHRqQ0qa7ZIZ4TtsSaLEy70AgAGD24CAACRFAIABNxiA","Date":"Wed, 27 Sep 2017 05:06:33 +0000","Message-ID":"<1506488793.3589.15.camel@intel.com>","References":"<1506328815-23733-1-git-send-email-tien.fong.chee@intel.com>\n\t<1506328815-23733-11-git-send-email-tien.fong.chee@intel.com>\n\t<800f086c-9879-3d13-d0f3-f478ac98446e@denx.de>\n\t<1506414197.27760.23.camel@intel.com>\n\t<902a4d12-9c8e-3cb5-0101-e7d7f05bcbb1@denx.de>","In-Reply-To":"<902a4d12-9c8e-3cb5-0101-e7d7f05bcbb1@denx.de>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-originating-ip":"[10.226.242.102]","Content-ID":"<4079AAC3EC9096448EB72D8F22D28914@intel.com>","MIME-Version":"1.0","Cc":"\"See, Chin Liang\" , \"Westergreen,\n\tDalon\" ,\n\t\"skywindctf@gmail.com\" ","Subject":"Re: [U-Boot] [PATCH v2 10/19] arm: socfpga: Rename the gen5 sdram\n\tdriver to more specific name","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]