[{"id":1774599,"web_url":"http://patchwork.ozlabs.org/comment/1774599/","msgid":"","list_archive_url":null,"date":"2017-09-25T09:08:45","subject":"Re: [U-Boot] [PATCH v2 07/19] fdt: Add compatible strings for Arria\n\t10","submitter":{"id":12009,"url":"http://patchwork.ozlabs.org/api/people/12009/","name":"Marek Vasut","email":"marex@denx.de"},"content":"On 09/25/2017 10:40 AM, tien.fong.chee@intel.com wrote:\n> From: Tien Fong Chee \n> \n> Add compatible strings for Intel Arria 10 SoCFPGA device.\n> \n> Signed-off-by: Tien Fong Chee \n\nApplied, thanks\n\n> ---\n> include/fdtdec.h | 2 ++\n> lib/fdtdec.c | 2 ++\n> 2 files changed, 4 insertions(+)\n> \n> diff --git a/include/fdtdec.h b/include/fdtdec.h\n> index 4a0947c..095ff36 100644\n> --- a/include/fdtdec.h\n> +++ b/include/fdtdec.h\n> @@ -157,6 +157,8 @@ enum fdt_compat_id {\n> \tCOMPAT_ALTERA_SOCFPGA_F2SDR0, /* SoCFPGA fpga2SDRAM0 bridge */\n> \tCOMPAT_ALTERA_SOCFPGA_F2SDR1, /* SoCFPGA fpga2SDRAM1 bridge */\n> \tCOMPAT_ALTERA_SOCFPGA_F2SDR2, /* SoCFPGA fpga2SDRAM2 bridge */\n> +\tCOMPAT_ALTERA_SOCFPGA_FPGA0,\t\t/* SOCFPGA FPGA manager */\n> +\tCOMPAT_ALTERA_SOCFPGA_NOC,\t\t/* SOCFPGA Arria 10 NOC */\n> \n> \tCOMPAT_COUNT,\n> };\n> diff --git a/lib/fdtdec.c b/lib/fdtdec.c\n> index 107a892..03ff75e 100644\n> --- a/lib/fdtdec.c\n> +++ b/lib/fdtdec.c\n> @@ -70,6 +70,8 @@ static const char * const compat_names[COMPAT_COUNT] = {\n> \tCOMPAT(ALTERA_SOCFPGA_F2SDR0, \"altr,socfpga-fpga2sdram0-bridge\"),\n> \tCOMPAT(ALTERA_SOCFPGA_F2SDR1, \"altr,socfpga-fpga2sdram1-bridge\"),\n> \tCOMPAT(ALTERA_SOCFPGA_F2SDR2, \"altr,socfpga-fpga2sdram2-bridge\"),\n> +\tCOMPAT(ALTERA_SOCFPGA_FPGA0, \"altr,socfpga-a10-fpga-mgr\"),\n> +\tCOMPAT(ALTERA_SOCFPGA_NOC, \"altr,socfpga-a10-noc\"),\n> };\n> \n> const char *fdtdec_get_compatible(enum fdt_compat_id id)\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y105m4qL7z9tX3\n\tfor ;\n\tMon, 25 Sep 2017 20:03:24 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 7C172C2205F; Mon, 25 Sep 2017 10:03:02 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id ECC1AC2213C;\n\tMon, 25 Sep 2017 09:58:42 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid B32DDC22126; Mon, 25 Sep 2017 09:58:33 +0000 (UTC)","from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9])\n\tby lists.denx.de (Postfix) with ESMTPS id 7DD3CC22094\n\tfor ; Mon, 25 Sep 2017 09:58:28 +0000 (UTC)","from frontend01.mail.m-online.net (unknown [192.168.8.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3y100426Snz1qsSg;\n\tMon, 25 Sep 2017 11:58:28 +0200 (CEST)","from localhost (dynscan1.mnet-online.de [192.168.6.70])\n\tby mail.m-online.net (Postfix) with ESMTP id 3y100419z0z1qqkh;\n\tMon, 25 Sep 2017 11:58:28 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id 3Yr3FVFLr8mz; Mon, 25 Sep 2017 11:58:27 +0200 (CEST)","from [IPv6:::1] (unknown [195.140.253.167])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPSA;\n\tMon, 25 Sep 2017 11:58:27 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Virus-Scanned":"amavisd-new at mnet-online.de","X-Auth-Info":"edRvHdSkMwSqQAxoUIhDon8CyOpBlSPuV3WLtPA2cXk=","To":"tien.fong.chee@intel.com, u-boot@lists.denx.de","References":"<1506328815-23733-1-git-send-email-tien.fong.chee@intel.com>\n\t<1506328815-23733-8-git-send-email-tien.fong.chee@intel.com>","From":"Marek Vasut ","Message-ID":"","Date":"Mon, 25 Sep 2017 11:08:45 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1506328815-23733-8-git-send-email-tien.fong.chee@intel.com>","Content-Language":"en-US","Cc":"Ching Liang See ,\n\tWestergteen Dalon ,\n\tTien Fong ","Subject":"Re: [U-Boot] [PATCH v2 07/19] fdt: Add compatible strings for Arria\n\t10","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1819425,"web_url":"http://patchwork.ozlabs.org/comment/1819425/","msgid":"","list_archive_url":null,"date":"2017-12-10T19:34:16","subject":"Re: [U-Boot] [PATCH v2 07/19] fdt: Add compatible strings for Arria\n\t10","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi,\n\nOn 25 September 2017 at 03:08, Marek Vasut wrote:\n> On 09/25/2017 10:40 AM, tien.fong.chee@intel.com wrote:\n>> From: Tien Fong Chee \n>>\n>> Add compatible strings for Intel Arria 10 SoCFPGA device.\n>>\n>> Signed-off-by: Tien Fong Chee \n>\n> Applied, thanks\n>\n>> ---\n>> include/fdtdec.h | 2 ++\n>> lib/fdtdec.c | 2 ++\n>> 2 files changed, 4 insertions(+)\n>>\n>> diff --git a/include/fdtdec.h b/include/fdtdec.h\n>> index 4a0947c..095ff36 100644\n>> --- a/include/fdtdec.h\n>> +++ b/include/fdtdec.h\n>> @@ -157,6 +157,8 @@ enum fdt_compat_id {\n>> COMPAT_ALTERA_SOCFPGA_F2SDR0, /* SoCFPGA fpga2SDRAM0 bridge */\n>> COMPAT_ALTERA_SOCFPGA_F2SDR1, /* SoCFPGA fpga2SDRAM1 bridge */\n>> COMPAT_ALTERA_SOCFPGA_F2SDR2, /* SoCFPGA fpga2SDRAM2 bridge */\n>> + COMPAT_ALTERA_SOCFPGA_FPGA0, /* SOCFPGA FPGA manager */\n>> + COMPAT_ALTERA_SOCFPGA_NOC, /* SOCFPGA Arria 10 NOC */\n\nWe should not be adding new things here. There is a clear message at the top:\n\n * NOTE: This list is basically a TODO list for things that need to be\n * converted to driver model. So don't add new things here unless there is a\n * good reason why driver-model conversion is infeasible. Examples include\n * things which are used before driver model is available.\n\nCan this be converted to driver model please? I'll see if I can remove\nthis array.\n\n>>\n>> COMPAT_COUNT,\n>> };\n>> diff --git a/lib/fdtdec.c b/lib/fdtdec.c\n>> index 107a892..03ff75e 100644\n>> --- a/lib/fdtdec.c\n>> +++ b/lib/fdtdec.c\n>> @@ -70,6 +70,8 @@ static const char * const compat_names[COMPAT_COUNT] = {\n>> COMPAT(ALTERA_SOCFPGA_F2SDR0, \"altr,socfpga-fpga2sdram0-bridge\"),\n>> COMPAT(ALTERA_SOCFPGA_F2SDR1, \"altr,socfpga-fpga2sdram1-bridge\"),\n>> COMPAT(ALTERA_SOCFPGA_F2SDR2, \"altr,socfpga-fpga2sdram2-bridge\"),\n>> + COMPAT(ALTERA_SOCFPGA_FPGA0, \"altr,socfpga-a10-fpga-mgr\"),\n>> + COMPAT(ALTERA_SOCFPGA_NOC, \"altr,socfpga-a10-noc\"),\n>> };\n>>\n>> const char *fdtdec_get_compatible(enum fdt_compat_id id)\n>>\n>\n>\n> --\n> Best regards,\n> Marek Vasut\n\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"Qghg/81t\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"H3RHGeVj\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3yvxB712lJz9s72\n\tfor ;\n\tMon, 11 Dec 2017 06:34:55 +1100 (AEDT)","by lists.denx.de (Postfix, from userid 105)\n\tid BA313C21DB0; Sun, 10 Dec 2017 19:34:43 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 99E25C21C4F;\n\tSun, 10 Dec 2017 19:34:40 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 63FD8C21C4C; Sun, 10 Dec 2017 19:34:39 +0000 (UTC)","from mail-qt0-f196.google.com (mail-qt0-f196.google.com\n\t[209.85.216.196])\n\tby lists.denx.de (Postfix) with ESMTPS id D237FC21C4A\n\tfor ; Sun, 10 Dec 2017 19:34:38 +0000 (UTC)","by mail-qt0-f196.google.com with SMTP id g9so33132012qth.9\n\tfor ; Sun, 10 Dec 2017 11:34:38 -0800 (PST)","by 10.140.100.167 with HTTP; Sun, 10 Dec 2017 11:34:16 -0800 (PST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=V9r/kdfekxVvookKP0yGWH4IjzCnwy3dUUWE211Q+Vc=;\n\tb=Qghg/81ta8KNQSuPt2xx8iY4g5Zcjaq1/Z/WF4byh04yofmUP31owScrw4AellAeK8\n\tHdVz0fptyi3WSuLvgSJCeFOkI07Kzx5mT6xLpNJQ4C2oMeYd6lamIc2drxcx4Arukk9A\n\t58tXu03H9bDojSOIGV/rRMU6ptScKoNNT0duZ0ZHzBdd28Qw6OzwkPGv+CQgHjBSlAI4\n\tatJxUEaguG5uIxFql+hT/KAtUBWuzJA/D2Zt6+JVGC1NMHQl3PWHi/I6s8utiR2ACdIU\n\t0ZVbHCDTdCmj7hhzjmzgREaPBNQuSksJQwhqjTIV3HgQPoPnBBCI6vu26goDJA1KDGJ+\n\t2ifg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=V9r/kdfekxVvookKP0yGWH4IjzCnwy3dUUWE211Q+Vc=;\n\tb=H3RHGeVjH69KuU3+jOtb7dJEmG5xdpqDbf/bSNeST4vzwmOeBptOcQthQOK9J+Vd+O\n\tSRK5a7SYB9f+AfJWJcAgAUOYKARQcIDNONffsy8byorzHMJnIcMofu3YeGBrHyElSXQ5\n\tYVV0Ev0unx4/kLSirgbe7F3lVP2ZYOi1nZWOk="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=V9r/kdfekxVvookKP0yGWH4IjzCnwy3dUUWE211Q+Vc=;\n\tb=JPi+KwJ/CxyFmd1AOkeJmHirrvU+flhRHjt4VOiJm93gMVuZ6vtZdCGnmNlMYNBra2\n\tsFIT32FC11uROr5BAwFwvbth0iGGGAZlKTRfFj1bhG8IHXaZIaYMoghbkM4okPhCseMy\n\tfyy+2eU/4U3vnuhsv5lKxCu1NqokcRmsseT8qb4Dx6FCPW2aZ8Edbgm24IfqOlrb9Qhg\n\tPpcs1rWqG58zWVJLKZlCeo157r3Fmv+wsIwK8MC1Dcj2x81hO0Hur3Ys4nQ6H0Ex5Eue\n\tRZ0UnT0zKCgfJV8pVz+QFMEJkg5HKeS1cwkMAx8Rg29xDAgEKhEcWs7IOWAqZZjK9wjt\n\tatJw==","X-Gm-Message-State":"AKGB3mKi2shlhOgPjJ9om3NJ7rlJOjxpsy1K6MJpn3/DMYkBiLaFoL8Y\n\td+VS3w1UT6BjSxai7Ocs3HNfQQN2HSyowJfKTLOP0w==","X-Google-Smtp-Source":"AGs4zMZ6Dw+xMau5EJQI7FNryE4Bv1Bs4NYiI1ALWDY1BpS2VYUI6FBHz2kfljyuaWA7oq1C9TWt1ctlLnAza3wj07k=","X-Received":"by 10.200.4.154 with SMTP id s26mr25451778qtg.156.1512934477148; \n\tSun, 10 Dec 2017 11:34:37 -0800 (PST)","MIME-Version":"1.0","In-Reply-To":"","References":"<1506328815-23733-1-git-send-email-tien.fong.chee@intel.com>\n\t<1506328815-23733-8-git-send-email-tien.fong.chee@intel.com>\n\t","From":"Simon Glass ","Date":"Sun, 10 Dec 2017 12:34:16 -0700","X-Google-Sender-Auth":"cxRRzZfuYeJlMf0-5LM3hWUqpAs","Message-ID":"","To":"Marek Vasut ","Cc":"U-Boot Mailing List ,\n\tTien Fong Chee ,\n\tChing Liang See ,\n\tWestergteen Dalon ,\n\tTien Fong ","Subject":"Re: [U-Boot] [PATCH v2 07/19] fdt: Add compatible strings for Arria\n\t10","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]