[{"id":1776072,"web_url":"http://patchwork.ozlabs.org/comment/1776072/","msgid":"<20170927090315.22070171@brouer.com>","list_archive_url":null,"date":"2017-09-27T07:03:34","subject":"Re: [PATCH net-next 3/6] bpf: update bpf.h uapi header for tools","submitter":{"id":13625,"url":"http://patchwork.ozlabs.org/api/people/13625/","name":"Jesper Dangaard Brouer","email":"brouer@redhat.com"},"content":"On Mon, 25 Sep 2017 02:25:52 +0200\nDaniel Borkmann wrote:\n\n> Looks like a couple of updates missed to get carried into tools/include/uapi/,\n> so copy the bpf.h header as usual to pull in latest updates.\n> \n> Signed-off-by: Daniel Borkmann \n> Acked-by: Alexei Starovoitov \n> Acked-by: John Fastabend \n> ---\n> tools/include/uapi/linux/bpf.h | 45 ++++++++++++++++++++++++++++++------------\n> 1 file changed, 32 insertions(+), 13 deletions(-)\n> \n> diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h\n> index 461811e..e43491a 100644\n> --- a/tools/include/uapi/linux/bpf.h\n> +++ b/tools/include/uapi/linux/bpf.h\n> @@ -143,12 +143,6 @@ enum bpf_attach_type {\n> \n> #define MAX_BPF_ATTACH_TYPE __MAX_BPF_ATTACH_TYPE\n> \n> -enum bpf_sockmap_flags {\n> -\tBPF_SOCKMAP_UNSPEC,\n> -\tBPF_SOCKMAP_STRPARSER,\n> -\t__MAX_BPF_SOCKMAP_FLAG\n> -};\n> -\n\nWhy does \"bpf_sockmap_flags\" gets removed?\n\nIt got added in: commit 69e8cc134bcb (\"bpf: sockmap sample program\").\nBut I cannot find any users of these flags, so I guess it is okay.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=brouer@redhat.com"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y281b5n2Xz9t4Z\n\tfor ;\n\tWed, 27 Sep 2017 17:03:47 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752058AbdI0HDo (ORCPT );\n\tWed, 27 Sep 2017 03:03:44 -0400","from mx1.redhat.com ([209.132.183.28]:48274 \"EHLO mx1.redhat.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751396AbdI0HDl (ORCPT );\n\tWed, 27 Sep 2017 03:03:41 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 4987B12987F;\n\tWed, 27 Sep 2017 07:03:41 +0000 (UTC)","from localhost (ovpn-200-30.brq.redhat.com [10.40.200.30])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 57F7B80B2E;\n\tWed, 27 Sep 2017 07:03:36 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 4987B12987F","Date":"Wed, 27 Sep 2017 09:03:34 +0200","From":"Jesper Dangaard Brouer ","To":"Daniel Borkmann ","Cc":"brouer@redhat.com, davem@davemloft.net,\n\talexei.starovoitov@gmail.com, john.fastabend@gmail.com,\n\tpeter.waskiewicz.jr@intel.com, jakub.kicinski@netronome.com,\n\tnetdev@vger.kernel.org","Subject":"Re: [PATCH net-next 3/6] bpf: update bpf.h uapi header for tools","Message-ID":"<20170927090315.22070171@brouer.com>","In-Reply-To":"<4bdb49b4387d698443e32b8a6a85414e57ef4de0.1506297988.git.daniel@iogearbox.net>","References":"\n\t<4bdb49b4387d698443e32b8a6a85414e57ef4de0.1506297988.git.daniel@iogearbox.net>","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tWed, 27 Sep 2017 07:03:41 +0000 (UTC)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1776074,"web_url":"http://patchwork.ozlabs.org/comment/1776074/","msgid":"<20170927091050.469a3e08@redhat.com>","list_archive_url":null,"date":"2017-09-27T07:10:50","subject":"Re: [PATCH net-next 3/6] bpf: update bpf.h uapi header for tools","submitter":{"id":13625,"url":"http://patchwork.ozlabs.org/api/people/13625/","name":"Jesper Dangaard Brouer","email":"brouer@redhat.com"},"content":"On Wed, 27 Sep 2017 09:03:34 +0200\nJesper Dangaard Brouer wrote:\n\n> On Mon, 25 Sep 2017 02:25:52 +0200\n> Daniel Borkmann wrote:\n> \n> > Looks like a couple of updates missed to get carried into tools/include/uapi/,\n> > so copy the bpf.h header as usual to pull in latest updates.\n> > \n> > Signed-off-by: Daniel Borkmann \n> > Acked-by: Alexei Starovoitov \n> > Acked-by: John Fastabend \n> > ---\n> > tools/include/uapi/linux/bpf.h | 45 ++++++++++++++++++++++++++++++------------\n> > 1 file changed, 32 insertions(+), 13 deletions(-)\n> > \n> > diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h\n> > index 461811e..e43491a 100644\n> > --- a/tools/include/uapi/linux/bpf.h\n> > +++ b/tools/include/uapi/linux/bpf.h\n> > @@ -143,12 +143,6 @@ enum bpf_attach_type {\n> > \n> > #define MAX_BPF_ATTACH_TYPE __MAX_BPF_ATTACH_TYPE\n> > \n> > -enum bpf_sockmap_flags {\n> > -\tBPF_SOCKMAP_UNSPEC,\n> > -\tBPF_SOCKMAP_STRPARSER,\n> > -\t__MAX_BPF_SOCKMAP_FLAG\n> > -};\n> > - \n> \n> Why does \"bpf_sockmap_flags\" gets removed?\n> \n> It got added in: commit 69e8cc134bcb (\"bpf: sockmap sample program\").\n> But I cannot find any users of these flags, so I guess it is okay.\n\nFound the explanation in commit 2f857d04601 (\"bpf: sockmap, remove\nSTRPARSER map_flags and add multi-map support\").\n https://git.kernel.org/torvalds/c/2f857d04601\n\nAcked-by: Jesper Dangaard Brouer ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=brouer@redhat.com"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y289w425kz9t4Z\n\tfor ;\n\tWed, 27 Sep 2017 17:11:00 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752080AbdI0HK5 (ORCPT );\n\tWed, 27 Sep 2017 03:10:57 -0400","from mx1.redhat.com ([209.132.183.28]:59050 \"EHLO mx1.redhat.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751866AbdI0HK4 (ORCPT );\n\tWed, 27 Sep 2017 03:10:56 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id B41062027C;\n\tWed, 27 Sep 2017 07:10:56 +0000 (UTC)","from localhost (ovpn-200-30.brq.redhat.com [10.40.200.30])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id EB19977E56;\n\tWed, 27 Sep 2017 07:10:51 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com B41062027C","Date":"Wed, 27 Sep 2017 09:10:50 +0200","From":"Jesper Dangaard Brouer ","To":"Daniel Borkmann ","Cc":"davem@davemloft.net, alexei.starovoitov@gmail.com,\n\tjohn.fastabend@gmail.com, peter.waskiewicz.jr@intel.com,\n\tjakub.kicinski@netronome.com, netdev@vger.kernel.org, brouer@redhat.com","Subject":"Re: [PATCH net-next 3/6] bpf: update bpf.h uapi header for tools","Message-ID":"<20170927091050.469a3e08@redhat.com>","In-Reply-To":"<20170927090315.22070171@brouer.com>","References":"\n\t<4bdb49b4387d698443e32b8a6a85414e57ef4de0.1506297988.git.daniel@iogearbox.net>\n\t<20170927090315.22070171@brouer.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tWed, 27 Sep 2017 07:10:56 +0000 (UTC)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]