[{"id":1774981,"web_url":"http://patchwork.ozlabs.org/comment/1774981/","msgid":"<8132918e-ebf8-dbf6-72e9-c10ed675d962@gmail.com>","list_archive_url":null,"date":"2017-09-25T21:02:21","subject":"Re: [Buildroot] [PATCH 1/1] [RFC] mvebu_espressobin-88f3720 : Add\n\tsupport for espressobin","submitter":{"id":67942,"url":"http://patchwork.ozlabs.org/api/people/67942/","name":"Romain Naour","email":"romain.naour@gmail.com"},"content":"Hi Maxime,\n\nLe 25/09/2017 à 00:05, Maxime Chevallier a écrit :\n> Add support for the Globalscale 'Espressobin' board based\n> on Marvell Armada 3720.\n> \n> This board has a dual Cortex-A53, 1GB DDR3, USBs, ethernets,\n> and some GPIO ports. More informations on the vendor site :\n> http://espressobin.net/tech-spec/\n> \n> This config uses the mainline linux support for the board and\n> the buildroot toolchain using glibc, since uclibc does not\n> support aarch64.\n> \n> Mainline device-tree does not include SDCard support yet, so USB\n> is the preferred way to boot the image, using the default pre-flashed\n> u-boot on SPI NOR.\n\nUsually we use configs or board in the commit title.\n\n\"board: Add support for espressobin 88f3720\" should be enough.\n\nOtherwise, looks good for me as is.\n\nLinux 4.14-rc2 is out, do you know if the SDCard support has been added in this\nrelease?\n\nMaybe you can also add a new entry in .gitlab-ci.yml file for CI testing in gitlab.\n(see .gitlab-ci.yml.in to regenerate this file). But this can be done in a\nfollow up patch.\n\nBest regards,\nRomain\n\n> \n> Signed-off-by: Maxime Chevallier \n> ---\n> DEVELOPERS | 4 ++\n> board/globalscale/espressobin/genimage.cfg | 11 +++++\n> board/globalscale/espressobin/readme.txt | 76 +++++++++++++++++++++++++++++\n> configs/mvebu_espressobin-88f3720_defconfig | 29 +++++++++++\n> 4 files changed, 120 insertions(+)\n> create mode 100644 board/globalscale/espressobin/genimage.cfg\n> create mode 100644 board/globalscale/espressobin/readme.txt\n> create mode 100644 configs/mvebu_espressobin-88f3720_defconfig\n> \n> diff --git a/DEVELOPERS b/DEVELOPERS\n> index e34802f..5036ac2 100644\n> --- a/DEVELOPERS\n> +++ b/DEVELOPERS\n> @@ -1208,6 +1208,10 @@ F:\tpackage/python-wsaccel/\n> N:\tMax Filippov \n> F:\tarch/Config.in.xtensa\n> \n> +N:\tMaxime Chevallier \n> +F:\tconfigs/mvebu_espressobin-88f3720_defconfig\n> +F:\tboard/globalscale/espressobin/\n> +\n> N:\tMaxime Hadjinlian \n> F:\tpackage/babeld/\n> F:\tpackage/dante/\n> diff --git a/board/globalscale/espressobin/genimage.cfg b/board/globalscale/espressobin/genimage.cfg\n> new file mode 100644\n> index 0000000..664f81b\n> --- /dev/null\n> +++ b/board/globalscale/espressobin/genimage.cfg\n> @@ -0,0 +1,11 @@\n> +# Minimal image\n> +\n> +image sdcard.img {\n> + hdimage {\n> + }\n> +\n> + partition rootfs {\n> + partition-type = 0x83\n> + image = \"rootfs.ext4\"\n> + }\n> +}\n> diff --git a/board/globalscale/espressobin/readme.txt b/board/globalscale/espressobin/readme.txt\n> new file mode 100644\n> index 0000000..fc9140e\n> --- /dev/null\n> +++ b/board/globalscale/espressobin/readme.txt\n> @@ -0,0 +1,76 @@\n> +Espressobin\n> +===========\n> +\n> +This is the basic support for the Espressobin by globalscale technologies,\n> +based on the Marvell Armada 3720.\n> +\n> +This support is based on the mainline linux kernel.\n> +\n> +\n> +How to build\n> +============\n> +\n> +1 - Use default configuration for espressobin :\n> +\n> +make mvebu_espressobin-88f3720_defconfig\n> +\n> +2 - Build the system\n> +\n> +make\n> +\n> +This generates the kernel image, the devicetree binary, the rootfs as a\n> +tar.gz, and a filesystem image containing everything : sdcard.img (this name\n> +is misleading though, see Limitations).\n> +\n> +Build artifacts are located in output/images.\n> +\n> +How to boot\n> +===========\n> +\n> +To boot, you need an UART connection, using the on-board micro-usb port\n> +at 115200 bauds.\n> +\n> +NOTE : As of today, booting from SDCard is not fully supported (rootfs cannot\n> +be located on SCard).\n> +\n> +## From USB Stick ############################################################\n> +\n> +As of right now, this is the easiest way to boot the system, since the SDCard\n> +support is not fully mainlined. It uses the pre-flashed u-boot on the SPI NOR\n> +to load the kernel, device-tree and rootfs from a USB stick.\n> +\n> +The on-board jumpers must be configured to select the SPI NOR as a boot source.\n> +\n> +1 - Flash rootfs image on usb drive (Be careful to select the correct drive)\n> +\n> +sudo dd if=sdcard.img of=/dev/sdX bs=1M\n> +sync\n> +\n> +2 - Boot from SPI NOR, interrupt boot by pressing Enter\n> +\n> +3 - Setup the bootusb u-boot script :\n> +\n> +setenv fdt_addr 0x1800000\n> +setenv fdt_name boot/armada-3720-espressobin.dtb\n> +setenv bootusb 'usb start; ext4load usb 0:1 $kernel_addr $image_name; ext4load usb 0:1 $fdt_addr $fdt_name; setenv bootargs $console root=/dev/sda1 rw rootwait; booti $kernel_addr - $fdt_addr'\n> +run bootusb\n> +\n> +Limitations\n> +===========\n> +\n> +Since the buildroot support for the espressobin is based on mainline\n> +linux, especially regarding device-tree, the current functionnalities\n> +for espressobin are limited.\n> +\n> +Namely, the mainline device-tree does not include support for sdcards yet, which\n> +means the kernel is not able to load a rootfs located on a SDCard.\n> +\n> +Todo\n> +====\n> +\n> +- Add bootloader generation\n> +\n> +- Use a custom devicetree to have SDcard support (or wait for support in mainline linux tree)\n> +\n> +- When SDcard support is working, add generation of sdcard image including bootloader, and\n> + document the on-board jumper configuration needed for sdcard boot.\n> diff --git a/configs/mvebu_espressobin-88f3720_defconfig b/configs/mvebu_espressobin-88f3720_defconfig\n> new file mode 100644\n> index 0000000..394c881\n> --- /dev/null\n> +++ b/configs/mvebu_espressobin-88f3720_defconfig\n> @@ -0,0 +1,29 @@\n> +# Architecture\n> +BR2_aarch64=y\n> +BR2_cortex_a53=y\n> +\n> +# Linux headers same as kernel, a 4.13 series\n> +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_13=y\n> +\n> +# Filesystem\n> +BR2_TARGET_ROOTFS_EXT2=y\n> +BR2_TARGET_ROOTFS_EXT2_4=y\n> +BR2_TARGET_ROOTFS_EXT2_GEN=4\n> +BR2_TARGET_ROOTFS_TAR_GZIP=y\n> +\n> +# Kernel\n> +BR2_LINUX_KERNEL=y\n> +BR2_LINUX_KERNEL_CUSTOM_VERSION=y\n> +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE=\"4.13\"\n> +BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y\n> +BR2_LINUX_KERNEL_DTS_SUPPORT=y\n> +BR2_LINUX_KERNEL_INTREE_DTS_NAME=\"marvell/armada-3720-espressobin\"\n> +BR2_LINUX_KERNEL_INSTALL_TARGET=y\n> +\n> +# uClibc does not support aarch64 yet.\n> +BR2_TOOLCHAIN_BUILDROOT_GLIBC=y\n> +\n> +# Image generation\n> +BR2_PACKAGE_HOST_GENIMAGE=y\n> +BR2_ROOTFS_POST_IMAGE_SCRIPT=\"support/scripts/genimage.sh\"\n> +BR2_ROOTFS_POST_SCRIPT_ARGS=\"-c board/globalscale/espressobin/genimage.cfg\"\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"tBnoFaxO\"; dkim-atps=neutral"],"Received":["from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1GkK3snmz9t30\n\tfor ;\n\tTue, 26 Sep 2017 07:02:33 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 2066D8795B;\n\tMon, 25 Sep 2017 21:02:30 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 5iJfo49vSE8k; Mon, 25 Sep 2017 21:02:27 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id C703A876FC;\n\tMon, 25 Sep 2017 21:02:27 +0000 (UTC)","from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id DA6DB1C1627\n\tfor ;\n\tMon, 25 Sep 2017 21:02:26 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id C93D488585\n\tfor ;\n\tMon, 25 Sep 2017 21:02:26 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id mWHPKzcPC--A for ;\n\tMon, 25 Sep 2017 21:02:26 +0000 (UTC)","from mail-wr0-f196.google.com (mail-wr0-f196.google.com\n\t[209.85.128.196])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id A55E88857A\n\tfor ; Mon, 25 Sep 2017 21:02:25 +0000 (UTC)","by mail-wr0-f196.google.com with SMTP id k20so653124wre.1\n\tfor ; Mon, 25 Sep 2017 14:02:25 -0700 (PDT)","from ?IPv6:2a01:e35:1391:67d0:e6f9:2d2f:1a1e:79bf?\n\t([2a01:e35:1391:67d0:e6f9:2d2f:1a1e:79bf])\n\tby smtp.gmail.com with ESMTPSA id\n\t6sm8296512wru.33.2017.09.25.14.02.22\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 25 Sep 2017 14:02:23 -0700 (PDT)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:references:from:message-id:date:user-agent:mime-version\n\t:in-reply-to:content-language:content-transfer-encoding;\n\tbh=zrZkDA3mK8zkqFGlUpa3SHjEGDG/ISKm6icTcnYKxwk=;\n\tb=tBnoFaxOetS+5lSIjjMvtRDD3ic2hj61sz3ErqmAP0INQCug0gOHzkn/jlZs3UAp7v\n\t+buW8O7HdciJKYD5Jy1xzXwt+/Nh767OntgNyObxVySGAc+EnZwqbj8bhr7vFU6s/T5t\n\tUUmFZlCbON4fDYltF47wbas0sMzIDaUG7N95M9vACtQM5cOX/kX1qYYMjjtkxp0bKlb/\n\trHfNf3B17PvxYiYic//6GO0PhNhE69WGQNPUD5skrwB3NqFMv0CUssVj5SAKC/Z7wzpN\n\t3D5PKbtsT7gkAX1iqpfmFGAwXSiRDIjcEQ4zmgeoCJcwbrpvxVr4xvxri3uIhcJbZyRz\n\tiF/w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=zrZkDA3mK8zkqFGlUpa3SHjEGDG/ISKm6icTcnYKxwk=;\n\tb=kzVXISV56GOyvzjwrXQIt5gvNDbwpJ2TKUT4unmpv5EKHpC0/Wo5ekglTXLwfgTb/e\n\twvU3FB4yCFQ5LycFciZsV211mgCsGtWKhP1qgFg462ydtEZcYs/sZ2TT1y4iO9Y3VPOn\n\tNFHuXnWTlsFT0kyI1w7Cc/SSKZ2L+PTi0Xlhy5H90NhfxYZ95J4Kr4bnYhXB/OSdVN+I\n\tKzfYy5tMcq6DAnjSPXkB6Bqlf81QbNymvGlMYmKSyDqeeJkAfyvqumBHZbFreDpz/ytM\n\tVpypeDj4gfO28SicX5EFp6KpbIeJfupX6Vt+EWxNTmiZzDByzMSiI/8LfNTZpCbRsO5U\n\tGRgg==","X-Gm-Message-State":"AHPjjUjd0hkktGl6c7Yz6EAhwDTRx1m4g9r9WCpwtdhkLXSkVDoY+VXq\n\tH3gK0FohzVLNin98cDa0Ts/FMMSX","X-Google-Smtp-Source":"AOwi7QA329hIjonOs67/AGpSJeXlWLj+QjD47yc0XvOPyJJRBtZ8xUQqELM33j7HoVxBXnM7pDHR2A==","X-Received":"by 10.223.177.134 with SMTP id q6mr8396162wra.3.1506373343563;\n\tMon, 25 Sep 2017 14:02:23 -0700 (PDT)","To":"Maxime Chevallier , buildroot@buildroot.org","References":"<1506290733-6042-1-git-send-email-chevalliersebmax@gmail.com>\n\t<1506290733-6042-2-git-send-email-chevalliersebmax@gmail.com>","From":"Romain Naour ","Message-ID":"<8132918e-ebf8-dbf6-72e9-c10ed675d962@gmail.com>","Date":"Mon, 25 Sep 2017 23:02:21 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1506290733-6042-2-git-send-email-chevalliersebmax@gmail.com>","Content-Language":"en-US","Subject":"Re: [Buildroot] [PATCH 1/1] [RFC] mvebu_espressobin-88f3720 : Add\n\tsupport for espressobin","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}},{"id":1774991,"web_url":"http://patchwork.ozlabs.org/comment/1774991/","msgid":"<5c6b0144-03fd-93e1-bea8-e10c0de4f196@mind.be>","list_archive_url":null,"date":"2017-09-25T21:41:26","subject":"Re: [Buildroot] [PATCH 1/1] [RFC] mvebu_espressobin-88f3720 : Add\n\tsupport for espressobin","submitter":{"id":11809,"url":"http://patchwork.ozlabs.org/api/people/11809/","name":"Arnout Vandecappelle","email":"arnout@mind.be"},"content":"On 25-09-17 23:02, Romain Naour wrote:\n> Hi Maxime,\n> \n> Le 25/09/2017 à 00:05, Maxime Chevallier a écrit :\n>> Add support for the Globalscale 'Espressobin' board based\n>> on Marvell Armada 3720.\n>>\n>> This board has a dual Cortex-A53, 1GB DDR3, USBs, ethernets,\n>> and some GPIO ports. More informations on the vendor site :\n>> http://espressobin.net/tech-spec/\n>>\n>> This config uses the mainline linux support for the board and\n>> the buildroot toolchain using glibc, since uclibc does not\n>> support aarch64.\n>>\n>> Mainline device-tree does not include SDCard support yet, so USB\n>> is the preferred way to boot the image, using the default pre-flashed\n>> u-boot on SPI NOR.\n> Usually we use configs or board in the commit title.\n> \n> \"board: Add support for espressobin 88f3720\" should be enough.\n> \n> Otherwise, looks good for me as is.\n\n Indeed, looks good to me as well.\n\n I don't like the name much, though. Isn't globalscale_espressobin_defconfig\nmore appropriate?\n\n> \n> Linux 4.14-rc2 is out, do you know if the SDCard support has been added in this\n> release?\n> \n> Maybe you can also add a new entry in .gitlab-ci.yml file for CI testing in gitlab.\n> (see .gitlab-ci.yml.in to regenerate this file). But this can be done in a\n> follow up patch.\n\n No, this is not optional, it *must* be added otherwise we get errors from CI\n(well, except that the gitlab sync is currently broken). Just run\n'make .gitlab-ci.yml'.\n\n\n Regards,\n Arnout\n\n[snip]","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","Received":["from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1Hbq5bLcz9t2S\n\tfor ;\n\tTue, 26 Sep 2017 07:41:59 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id BD9A42F6F2;\n\tMon, 25 Sep 2017 21:41:54 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id wPlNZNVodnXn; Mon, 25 Sep 2017 21:41:51 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id CBECB2F68C;\n\tMon, 25 Sep 2017 21:41:51 +0000 (UTC)","from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 4D9C41BFF95\n\tfor ;\n\tMon, 25 Sep 2017 21:41:50 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 4873987857\n\tfor ;\n\tMon, 25 Sep 2017 21:41:50 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id iml2xIOXgpmS for ;\n\tMon, 25 Sep 2017 21:41:48 +0000 (UTC)","from exchange.essensium.com (220.77.144.195.ipv4.evonet.be\n\t[195.144.77.220])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 7C4F7877D1\n\tfor ; Mon, 25 Sep 2017 21:41:48 +0000 (UTC)","from [10.8.0.14] (10.3.7.11) by beleexch01.local.ess-mail.com\n\t(10.3.7.8) with Microsoft SMTP Server (TLS) id 15.0.847.32;\n\tMon, 25 Sep 2017 23:41:29 +0200"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","To":"Romain Naour , Maxime Chevallier\n\t, ","References":"<1506290733-6042-1-git-send-email-chevalliersebmax@gmail.com>\n\t<1506290733-6042-2-git-send-email-chevalliersebmax@gmail.com>\n\t<8132918e-ebf8-dbf6-72e9-c10ed675d962@gmail.com>","From":"Arnout Vandecappelle ","Organization":"Essensium/Mind","Message-ID":"<5c6b0144-03fd-93e1-bea8-e10c0de4f196@mind.be>","Date":"Mon, 25 Sep 2017 23:41:26 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<8132918e-ebf8-dbf6-72e9-c10ed675d962@gmail.com>","Content-Language":"en-GB","X-Originating-IP":"[10.3.7.11]","X-ClientProxiedBy":"beleexch01.local.ess-mail.com (10.3.7.8) To\n\tbeleexch01.local.ess-mail.com (10.3.7.8)","Subject":"Re: [Buildroot] [PATCH 1/1] [RFC] mvebu_espressobin-88f3720 : Add\n\tsupport for espressobin","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}},{"id":1775332,"web_url":"http://patchwork.ozlabs.org/comment/1775332/","msgid":"","list_archive_url":null,"date":"2017-09-26T10:05:13","subject":"Re: [Buildroot] [PATCH 1/1] [RFC] mvebu_espressobin-88f3720 : Add\n\tsupport for espressobin","submitter":{"id":72430,"url":"http://patchwork.ozlabs.org/api/people/72430/","name":"Maxime Chevallier","email":"chevalliersebmax@gmail.com"},"content":"Hi,\n\n2017-09-25 23:41 GMT+02:00 Arnout Vandecappelle :\n>\n>\n> On 25-09-17 23:02, Romain Naour wrote:\n>> Hi Maxime,\n>>\n>> Le 25/09/2017 à 00:05, Maxime Chevallier a écrit :\n>>> Add support for the Globalscale 'Espressobin' board based\n>>> on Marvell Armada 3720.\n>>>\n>>> This board has a dual Cortex-A53, 1GB DDR3, USBs, ethernets,\n>>> and some GPIO ports. More informations on the vendor site :\n>>> http://espressobin.net/tech-spec/\n>>>\n>>> This config uses the mainline linux support for the board and\n>>> the buildroot toolchain using glibc, since uclibc does not\n>>> support aarch64.\n>>>\n>>> Mainline device-tree does not include SDCard support yet, so USB\n>>> is the preferred way to boot the image, using the default pre-flashed\n>>> u-boot on SPI NOR.\n>> Usually we use configs or board in the commit title.\n>>\n>> \"board: Add support for espressobin 88f3720\" should be enough.\n\nOk\n\n>>\n>> Otherwise, looks good for me as is.\n>\n> Indeed, looks good to me as well.\n>\n> I don't like the name much, though. Isn't globalscale_espressobin_defconfig\n> more appropriate?\n\nYes it makes more sense to me, but all support for this board in\nu-boot and linux\ninclude 'mvebu' somewhere in the name, so I thought I would do that to.\n\nglobalscale_espressobin_defconfig seems less confusing, I will update it in V2.\n\n>>\n>> Linux 4.14-rc2 is out, do you know if the SDCard support has been added in this\n>> release?\n\nYes SDCard support has been added in linux 4.14-rc1. When 4.14 comes\nout, we will be\nable to generate bootable sdcards including the bootloader using\nin-tree device-tree.\n\n>> Maybe you can also add a new entry in .gitlab-ci.yml file for CI testing in gitlab.\n>> (see .gitlab-ci.yml.in to regenerate this file). But this can be done in a\n>> follow up patch.\n>\n> No, this is not optional, it *must* be added otherwise we get errors from CI\n> (well, except that the gitlab sync is currently broken). Just run\n> 'make .gitlab-ci.yml'.\n\nOk I'll add that in V2.\n\nThanks for the feedback,\n\nRegards,\n\nMaxime","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"bQ7eEmM2\"; dkim-atps=neutral"],"Received":["from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1c5d2XkNz9tXc\n\tfor ;\n\tTue, 26 Sep 2017 20:05:25 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id C71122FD59;\n\tTue, 26 Sep 2017 10:05:20 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Db3TqG3pvzQW; Tue, 26 Sep 2017 10:05:18 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 9966C2E3BB;\n\tTue, 26 Sep 2017 10:05:18 +0000 (UTC)","from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 1E9421C23EE\n\tfor ;\n\tTue, 26 Sep 2017 10:05:17 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 18EE68815F\n\tfor ;\n\tTue, 26 Sep 2017 10:05:17 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id zXWJK0Po4c-I for ;\n\tTue, 26 Sep 2017 10:05:15 +0000 (UTC)","from mail-it0-f68.google.com (mail-it0-f68.google.com\n\t[209.85.214.68])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id A88BD874AE\n\tfor ; Tue, 26 Sep 2017 10:05:15 +0000 (UTC)","by mail-it0-f68.google.com with SMTP id c195so2279433itb.1\n\tfor ; Tue, 26 Sep 2017 03:05:15 -0700 (PDT)","by 10.79.195.85 with HTTP; Tue, 26 Sep 2017 03:05:13 -0700 (PDT)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=m8O27DHKGAnPcf3pP/tTuQjblg6n7zA+dn7j0Z0iowo=;\n\tb=bQ7eEmM2aXzrIwhbdU/PiMyX5Oxus1h3Q81r0Iza5O82NF+vkw8nD0GwpXbUMacx4a\n\tshyJ4eod8OYHiye4aoxqvHJzrtKssiYPaexG9EHREQ3MYxHRPKDMG3ug5KAsSyF4Y8F7\n\t8k7URyd0fEWJZ3ypCVuARKKBLP8r1Y2ofQQ3ve3Oqgdq+i1Z6mqJzx0QnmTrXbZMfd6/\n\t8y3o6L1S6/PY05tOKdxKxA46S8dq46/bakuBtra1z+zEA5chNl6aoOfi6BgvvY9kUWcd\n\tBTLrbebV2dPerWbt9hRjg47Gmwn32J67/VbPqpeXT3cCu4an4Pfv8tVw1ggH5e3nto5R\n\tK1OQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=m8O27DHKGAnPcf3pP/tTuQjblg6n7zA+dn7j0Z0iowo=;\n\tb=lKcr9b4HIJaXZmzTckRt2Kfgh9L12sIbO2vQMglKakf5ap4uxDFrEItwTNiwztgGY1\n\tKbci37dkl7tfsVyJHOxpj2feQys9JAPSWrFbMen4qsITwC1JyKaF1bgPD9S4pafzrg7w\n\ttq2igxLk8520jhn6ehL59X60srojE8tfwB1IsJU+fh5djiJ12zpCikALwWkWtfEmhfVd\n\toAK3lxKm/GTyLEvfNH0gKSzi18zp48gGsAYkk59+ncR/BrJhsF08qDdhRBzr0hyCaU4t\n\t9tEFFkm43hbpjlFQkXMZui+6GuqpbjUfRFSQO68cJhw3fnRRIYa7StC6ZFVS1mAlkOsw\n\tORyw==","X-Gm-Message-State":"AHPjjUhPf4917LoSDvGNnnpwVZq9ENvIPfx2ohDvFFuvNZhkDvHW8CBq\n\t6i0cYXU2PzXKaMW/xlqsrrykA/SolSNFFrjMaFY=","X-Google-Smtp-Source":"AOwi7QCKZ/UcxxEq7/RTpVKx5FgJIvmPir53MEKTvVOhT8m+3c9Fr2GJ8iKS6m1LbL4ZvqGCjxRo2iow3TnMKJtGCUc=","X-Received":"by 10.36.139.195 with SMTP id g186mr4537497ite.128.1506420314642;\n\tTue, 26 Sep 2017 03:05:14 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<5c6b0144-03fd-93e1-bea8-e10c0de4f196@mind.be>","References":"<1506290733-6042-1-git-send-email-chevalliersebmax@gmail.com>\n\t<1506290733-6042-2-git-send-email-chevalliersebmax@gmail.com>\n\t<8132918e-ebf8-dbf6-72e9-c10ed675d962@gmail.com>\n\t<5c6b0144-03fd-93e1-bea8-e10c0de4f196@mind.be>","From":"Maxime Chevallier ","Date":"Tue, 26 Sep 2017 12:05:13 +0200","Message-ID":"","To":"Arnout Vandecappelle ","Cc":"Romain Naour , buildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH 1/1] [RFC] mvebu_espressobin-88f3720 : Add\n\tsupport for espressobin","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}}]