[{"id":1774563,"web_url":"http://patchwork.ozlabs.org/comment/1774563/","msgid":"<01cc3964-6968-df38-a3ea-376a26677243@cumulusnetworks.com>","list_archive_url":null,"date":"2017-09-25T09:20:54","subject":"Re: [patch net-next v2 01/12] fib: notifier: Add VIF add and delete\n\tevent types","submitter":{"id":66448,"url":"http://patchwork.ozlabs.org/api/people/66448/","name":"Nikolay Aleksandrov","email":"nikolay@cumulusnetworks.com"},"content":"On 24/09/17 20:22, Jiri Pirko wrote:\n> From: Yotam Gigi \n> \n> In order for an interface to forward packets according to the kernel\n> multicast routing table, it must be configured with a VIF index according\n> to the mroute user API. The VIF index is then used to refer to that\n> interface in the mroute user API, for example, to set the iif and oifs of\n> an MFC entry.\n> \n> In order to allow drivers to be aware and offload multicast routes, they\n> have to be aware of the VIF add and delete notifications.\n> \n> Due to the fact that a specific VIF can be deleted and re-added pointing to\n> another netdevice, and the MFC routes that point to it will forward the\n> matching packets to the new netdevice, a driver willing to offload MFC\n> cache entries must be aware of the VIF add and delete events in addition to\n> MFC routes notifications.\n> \n> Signed-off-by: Yotam Gigi \n> Reviewed-by: Ido Schimmel \n> Signed-off-by: Jiri Pirko \n> ---\n> include/net/fib_notifier.h | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/include/net/fib_notifier.h b/include/net/fib_notifier.h\n> index 669b971..54cd6b8 100644\n> --- a/include/net/fib_notifier.h\n> +++ b/include/net/fib_notifier.h\n> @@ -20,6 +20,8 @@ enum fib_event_type {\n> \tFIB_EVENT_RULE_DEL,\n> \tFIB_EVENT_NH_ADD,\n> \tFIB_EVENT_NH_DEL,\n> +\tFIB_EVENT_VIF_ADD,\n> +\tFIB_EVENT_VIF_DEL,\n> };\n> \n> struct fib_notifier_ops {\n> \n\nReviewed-by: Nikolay Aleksandrov ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=cumulusnetworks.com\n\theader.i=@cumulusnetworks.com header.b=\"dycYvfSD\"; \n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y0z8s6PMMz9s7F\n\tfor ;\n\tMon, 25 Sep 2017 19:21:01 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S934279AbdIYJVA (ORCPT );\n\tMon, 25 Sep 2017 05:21:00 -0400","from mail-wm0-f49.google.com ([74.125.82.49]:49870 \"EHLO\n\tmail-wm0-f49.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S933236AbdIYJU6 (ORCPT\n\t); Mon, 25 Sep 2017 05:20:58 -0400","by mail-wm0-f49.google.com with SMTP id r74so17440041wme.4\n\tfor ; Mon, 25 Sep 2017 02:20:58 -0700 (PDT)","from [192.168.0.103] (46-10-142-144.ip.btc-net.bg. [46.10.142.144])\n\tby smtp.googlemail.com with ESMTPSA id\n\tj52sm3969057eda.20.2017.09.25.02.20.55\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 25 Sep 2017 02:20:56 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=cumulusnetworks.com; s=google;\n\th=subject:to:references:cc:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=OSnsWHIgOAq2fT4526j2zrS1A7FMR521JbJKeqjsevM=;\n\tb=dycYvfSDlPTjBupz7vX/UrrbERRxA2GEiMXj/thLtv7iMTuLOE6FpOKrFY+BzQ40hB\n\t8I1Z5xsmJZjNLwJHCOvH2Vy8kZHXabFXB4HnSA08HP84GfoI0WKbkvqVPm5fWYwSC4PO\n\tAlxpJg7nWf6u9bNTVwv1eiEdHfqG2kMHAes44=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:cc:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=OSnsWHIgOAq2fT4526j2zrS1A7FMR521JbJKeqjsevM=;\n\tb=Gnr8XFMhVRpA4F3uUFvUWPMP+kzvmQwgYIu1tl3++5shnipWNYpHcMZk618BPUaG1J\n\tv494N2U5qz7MrbwCcC9nIrrlUpno7nkqlVvxQXBU5HTh6MNqKDioo6mEvPdmQuAZ5aHK\n\tTRlWywpFBMdfb7B79sOmg4K3siduZjmYp94YCmG3jUC55XSx/cdatny3tyRH34BMorUL\n\t6FNdkAhHHfjKjyfvH3DbL9Mw+bG7IuTXcjBHPqxT/i0g7HqEj7dzB+JRaUObewewpudS\n\tSxgkRBp2McfDpdyKYATb5J6E3DXSBhknU/csybxHddnwutuGIBJSM4HQwO18XFrWoCbm\n\t5fSg==","X-Gm-Message-State":"AHPjjUjV0k1RNqxx4UNaBmsMXm9o6vKQJv7IuARAP2SoK22bg3bpS1kf\n\t5NymcUfmTg96bIcQJVIRVVD2xQ==","X-Google-Smtp-Source":"AOwi7QDyz+KPUm8sp0IZB77CGtlLD3PqjbnApsBhIeVm440TpXHkLF8x5OLR9TowwuFLCHtDppjplA==","X-Received":"by 10.80.137.173 with SMTP id g42mr13268026edg.80.1506331257372; \n\tMon, 25 Sep 2017 02:20:57 -0700 (PDT)","Subject":"Re: [patch net-next v2 01/12] fib: notifier: Add VIF add and delete\n\tevent types","To":"Jiri Pirko , netdev@vger.kernel.org","References":"<20170924172212.10096-1-jiri@resnulli.us>\n\t<20170924172212.10096-2-jiri@resnulli.us>","Cc":"davem@davemloft.net, yotamg@mellanox.com, idosch@mellanox.com,\n\tmlxsw@mellanox.com, andrew@lunn.ch","From":"Nikolay Aleksandrov ","Message-ID":"<01cc3964-6968-df38-a3ea-376a26677243@cumulusnetworks.com>","Date":"Mon, 25 Sep 2017 12:20:54 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tIcedove/45.6.0","MIME-Version":"1.0","In-Reply-To":"<20170924172212.10096-2-jiri@resnulli.us>","Content-Type":"text/plain; charset=windows-1252","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]