[{"id":1774571,"web_url":"http://patchwork.ozlabs.org/comment/1774571/","msgid":"<32395cd4-f6f4-47ea-8337-0f642f2b9355@cumulusnetworks.com>","list_archive_url":null,"date":"2017-09-25T09:27:27","subject":"Re: [patch net-next v2 02/12] ipmr: Add reference count to MFC\n\tentries","submitter":{"id":66448,"url":"http://patchwork.ozlabs.org/api/people/66448/","name":"Nikolay Aleksandrov","email":"nikolay@cumulusnetworks.com"},"content":"On 24/09/17 20:22, Jiri Pirko wrote:\n> From: Yotam Gigi <yotamg@mellanox.com>\n> \n> Next commits will introduce MFC notifications through the atomic\n> fib_notification chain, thus allowing modules to be aware of MFC entries.\n> \n> Due to the fact that modules may need to hold a reference to an MFC entry,\n> add reference count to MFC entries to prevent them from being freed while\n> these modules use them.\n> \n> The reference counting is done only on resolved MFC entries currently.\n> \n> Signed-off-by: Yotam Gigi <yotamg@mellanox.com>\n> Reviewed-by: Ido Schimmel <idosch@mellanox.com>\n> Signed-off-by: Jiri Pirko <jiri@mellanox.com>\n> ---\n> v1->v2:\n>  - Add comment for the mfc_cache.mfc_un.res.refcount field, similarly to\n>    all other fields in the struct\n> ---\n>  include/linux/mroute.h | 21 +++++++++++++++++++++\n>  net/ipv4/ipmr.c        |  8 +++++---\n>  2 files changed, 26 insertions(+), 3 deletions(-)\n> \n\nReviewed-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=cumulusnetworks.com\n\theader.i=@cumulusnetworks.com header.b=\"Cj+QOT0B\"; \n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y0zJP4Qz7z9sNr\n\tfor <patchwork-incoming@ozlabs.org>;\n\tMon, 25 Sep 2017 19:27:33 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S934353AbdIYJ1b (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tMon, 25 Sep 2017 05:27:31 -0400","from mail-wm0-f47.google.com ([74.125.82.47]:51010 \"EHLO\n\tmail-wm0-f47.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S932404AbdIYJ1a (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Mon, 25 Sep 2017 05:27:30 -0400","by mail-wm0-f47.google.com with SMTP id b195so17469321wmb.5\n\tfor <netdev@vger.kernel.org>; Mon, 25 Sep 2017 02:27:30 -0700 (PDT)","from [192.168.0.103] (46-10-142-144.ip.btc-net.bg. [46.10.142.144])\n\tby smtp.googlemail.com with ESMTPSA id\n\tw10sm3986569eda.73.2017.09.25.02.27.28\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 25 Sep 2017 02:27:28 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=cumulusnetworks.com; s=google;\n\th=subject:to:references:cc:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=eQQDtkuPCYnIO+JdLz3sRw9RV++ASBBlFca2FVyGAhM=;\n\tb=Cj+QOT0BLYIKk7dOM95cKzqaJpuHleEHEqK+leSTpq0yu/kXvdPomxvWsMJgo1u8vh\n\tzRemzVeASBjIBYrDcTpvnvhk5mNP6vT3IzNQG3bckuIJ7f4P4eTp+g1uXJ4M1iEPnm38\n\tUf+kqs6LaGFlNv5Et8n1Saa2B9+NnlolTy0Kg=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:cc:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=eQQDtkuPCYnIO+JdLz3sRw9RV++ASBBlFca2FVyGAhM=;\n\tb=mmvz/YElXCFps9zpOQnreJQZWKFkzQotPxHfnAU5r4L596T+bSlJaGRQM1uJgAOSTj\n\tXH1uA6zGjlcyh1qjASsTL2Cnb5tGa8mDqew1DB87Gh3D6JsmiD4DPTMBXoUcZs2b2PUV\n\t+ob6LxrcYvqnkv6ptV5brpGqel/2qFpZzhqYXV1+1/eAt22M8+R1qK7PWbu7lM+lZKSl\n\tUcbzIvRfFJ4BFjGjO2K5WOLAmyPtmAc93MaSu5zQtlQRfBsQbg1JGAUXptywnLmJtab/\n\tVhcY6lLvtCP4jOhTp0SCVn6Aea+gdPBzIEHy44SNCqrkJT67Z4B8QdMNEfJzJ5JYNUof\n\ty+Ig==","X-Gm-Message-State":"AHPjjUhY9woHhzZEEwBoSeyEoHM23VDMR04CR8KA58iB262uyg9BMsuh\n\td49zuw/1MXHxwrF8lPd0StZ1LA==","X-Google-Smtp-Source":"AOwi7QDSW7awfUSUXUaUAKpH2YGa5xqf8iaHQXRdbgvHPAuUz7xNtkV6xOFbjXVD/fDJcJ+HXMQEYw==","X-Received":"by 10.80.173.227 with SMTP id b32mr14114981edd.65.1506331649648; \n\tMon, 25 Sep 2017 02:27:29 -0700 (PDT)","Subject":"Re: [patch net-next v2 02/12] ipmr: Add reference count to MFC\n\tentries","To":"Jiri Pirko <jiri@resnulli.us>, netdev@vger.kernel.org","References":"<20170924172212.10096-1-jiri@resnulli.us>\n\t<20170924172212.10096-3-jiri@resnulli.us>","Cc":"davem@davemloft.net, yotamg@mellanox.com, idosch@mellanox.com,\n\tmlxsw@mellanox.com, andrew@lunn.ch","From":"Nikolay Aleksandrov <nikolay@cumulusnetworks.com>","X-Enigmail-Draft-Status":"N1110","Message-ID":"<32395cd4-f6f4-47ea-8337-0f642f2b9355@cumulusnetworks.com>","Date":"Mon, 25 Sep 2017 12:27:27 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tIcedove/45.6.0","MIME-Version":"1.0","In-Reply-To":"<20170924172212.10096-3-jiri@resnulli.us>","Content-Type":"text/plain; charset=windows-1252","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}}]